test/message/read: Use googletest and mocks

Similar to the append test, this test case relied on an ad-hoc system
using a separate daemon thread for echoing the messages back to each of
the unit tes

test/message/read: Use googletest and mocks

Similar to the append test, this test case relied on an ad-hoc system
using a separate daemon thread for echoing the messages back to each of
the unit tests. We don't want to depend on a system dbus instance if we
can avoid it. Instead, use the mocking system to make sure the correct
dbus calls are made when reading messages and ensure the resulting
output is built as expected.

Tested:
Build still works and all test cases pass. Ensured that the coverage
of the tests is the same as the old test cases.

Change-Id: I8d71c031391b962f1de6684d927b81e132c0886d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/message/append: Use googletest and mocks

The current test case depends on the system running a dbus daemon that
our test case can register and run a service with. It runs in multiple
threads an

test/message/append: Use googletest and mocks

The current test case depends on the system running a dbus daemon that
our test case can register and run a service with. It runs in multiple
threads and requires using raw sd_bus_message calls to determine if the
appends worked correctly. When systemd 237 becomes the minimum version
we could rely on message sealing and other new public members to deal
with the daemon issues. However, it will be a while before we can make
that the default version.

Lets mock out the expectations for the underlying sd_bus_message calls
to validate that we will build correct objects when using our
message.append() calls.

Tested:
Converted the tests from the old test cases to this new format
keeping very similar test functionality. Tests still pass.

Change-Id: Iafc8662389fe60ca2d519abfe472c61292f3239a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/type_traits: Convert to gtest

This is a fairly minimal and non-invasive change. This test doesn't
really require the googletest framework since it is just using
static_asserts. However, this mo

test/type_traits: Convert to gtest

This is a fairly minimal and non-invasive change. This test doesn't
really require the googletest framework since it is just using
static_asserts. However, this moves us toward uniform testing.

Change-Id: I35d507cf6c97384146120d4f8f1b5a2e52834a6d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

bootstrap: Error out on failures

If we introduce any issues into our autotools scripts the ./bootstrap.sh
script doesn't error out. This allows our build scripts to continue on
potentially out of da

bootstrap: Error out on failures

If we introduce any issues into our autotools scripts the ./bootstrap.sh
script doesn't error out. This allows our build scripts to continue on
potentially out of date copies of the Makefile.in and configure script
since the autoreconf didn't actually get to rewrite them successfully.

Tested:
bootstrapping works as expected and introducing an error into
configure.ac returns the correct error code.

Change-Id: I9f0976bbe88c89e7c436896703558c86cee19a9f
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

SdBusError: Add test cases

This adds basic unit testing to the SdBusError class so we have full
coverage of all the functionality.

Tested:
Ran through the unit test suite including the changes

SdBusError: Add test cases

This adds basic unit testing to the SdBusError class so we have full
coverage of all the functionality.

Tested:
Ran through the unit test suite including the changes that build
valgrind runs and code coverage suppport.

Change-Id: I6d3bdbd2e0332ae5372796cb2a380ccddbee10ec
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

SdBusError: Fix missing move

Our move operator and constructor currently forgets that it needs to
also move the value of the system_error. It also needs to initialize the
error member since the move

SdBusError: Fix missing move

Our move operator and constructor currently forgets that it needs to
also move the value of the system_error. It also needs to initialize the
error member since the move function will first free the current error.

Tested:
Builds still work and existing tests pass.

Change-Id: I72fcd2d10eeedf6edf6f83c10ddaf15bb42c8b0d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

SdBusError: Fix initialization checks

sd_bus_error_set_errno() is semantically useful in C for returning the
errno and constructing the error in a single call. However, since
successful population o

SdBusError: Fix initialization checks

sd_bus_error_set_errno() is semantically useful in C for returning the
errno and constructing the error in a single call. However, since
successful population of the error can not be distinguished due to the
collapsed return value, we need another way to ensure the error was
built correctly. Don't check for the return of sd_bus_error_set_errno()
and instead use sd_bus_error_is_set().

Tested:
Builds still work and tests still pass.

Change-Id: Ib7546d7bb19eb2ebbaf6e2cab79a8ecd8960f280
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

SdBusError: Really own the sd_bus_error

The sd_bus_error constructor claims to own the sd_bus_error pointer but
it doesn't prevent the user from trivially re-using it in a broken way.
Instead of acc

SdBusError: Really own the sd_bus_error

The sd_bus_error constructor claims to own the sd_bus_error pointer but
it doesn't prevent the user from trivially re-using it in a broken way.
Instead of accepting the argument by value, take the old value and
overwrite the caller's copy to NULL it out. This way future calls to
sd_bus_error_free() by the caller will do the right thing.

Tested:
Builds still work and tests are passing.

Change-Id: I0afd856f0a2a08a08f25fd43c051aae4b2a645f4
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

SdBusError: Add Dependency Injection for the SdBusInterface

We want to be able to mock some of the sd_bus_error* calls for testing
the SdBusError class. This work makes that possible in the future w

SdBusError: Add Dependency Injection for the SdBusInterface

We want to be able to mock some of the sd_bus_error* calls for testing
the SdBusError class. This work makes that possible in the future while
retaining the same behavior.

Tested:
Errors still work fine and are backward compatible. New test cases
are now able to build against this class.

Change-Id: Ib125dc48eed60ac2bbdfadc4f1a81c52ab047cd4
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

sdbus: Add some sd_bus_error_* functions for mocking

This is needed for a future commit which implements dependency injection
on the SdBusError class.

Tested:
Functions can be used and mocked a

sdbus: Add some sd_bus_error_* functions for mocking

This is needed for a future commit which implements dependency injection
on the SdBusError class.

Tested:
Functions can be used and mocked as expected.

Change-Id: I15ae9643b2e1fad0abb1fa08483032502d0f623f
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

sdbus_mock: Fix missing bus include

The SdBusMock header uses the bus object but doesn't include the header
with it. Fix this so we can compile in files that don't include the bus.

Tested:
File

sdbus_mock: Fix missing bus include

The SdBusMock header uses the bus object but doesn't include the header
with it. Fix this so we can compile in files that don't include the bus.

Tested:
Files not previously including the bus can now build against this
header.

Change-Id: I2cb7f2b9758d82570e95bb3187f5aef639ac96bf
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test: Support mocking with googletest

We should include gmock in our gtest dependencies so that we can use it
in future test cases. There is no harm in adding this depdency as we
should always build

test: Support mocking with googletest

We should include gmock in our gtest dependencies so that we can use it
in future test cases. There is no harm in adding this depdency as we
should always build it with googletest and doesnt interfere with current
gtests.

Tested:
All of the tests still pass and newer tests using gmock will now
work.

Change-Id: Ie53f63f4926b88178c384cc1150b98555dafd7ec
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

tests: Add code coverage

We want to be able to measure code coverage for our test cases. This
patch adds initial support for measuring the coverage of all of the
files in the repo when running the t

tests: Add code coverage

We want to be able to measure code coverage for our test cases. This
patch adds initial support for measuring the coverage of all of the
files in the repo when running the test cases.

Simply run:
`make check-code-coverage`
and an lcov report will be generated

NOTE: This doesn't yet add any filtering to throw out the results for
system headers and tests cases, but the list of results isn't long so it
is easy to see the relevant coverage results and we don't want to add
any false negatives.

Tested:
Sdbuplus plus still builds fine without the code coverage utilities
by default. sdbusplus now builds with `./configure
--enable-code-coverage` and corrects the libs and cflags accordingly
to enable coverage. Make then succeeds to generate a report when run
with `make check-code-coverage`

Change-Id: I7f640b82e771bc9043abf381d14393be54c3e672
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

SdBusInterface: Add missing methods

The methods sd_bus_get_fd() and sd_bus_message_get_errno() were added to
their respective wrapped functions but are not mockable. This was due to
an older commit

SdBusInterface: Add missing methods

The methods sd_bus_get_fd() and sd_bus_message_get_errno() were added to
their respective wrapped functions but are not mockable. This was due to
an older commit that got merged prior to building mock interface. Clean
this up.

Tested:
Builds and passes all unit tests.

Change-Id: I5929c25c70b025a972fe8e9011b6bc9ce810efb6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

SdBusImpl: Expose the global sdbus_impl

Ultimately we want to use this throughout the sdbusplus headers for
dependency injection in the default case. We are already defining
it manually in <sdbusplu

SdBusImpl: Expose the global sdbus_impl

Ultimately we want to use this throughout the sdbusplus headers for
dependency injection in the default case. We are already defining
it manually in <sdbusplus/bus.hpp> and <sdbusplus/message.hpp>. It would
make more sense to export it from <sdbusplus/sdbus.hpp> so do that.

Tested:
Test suite still builds and passes.

Change-Id: I126864c6ff0c35e37f2e002247f94fea0688d918
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Allow public access to raw message object

There are certain cases where one would like to access the raw message
object under certain contexts. In general, these are contexts where
you need runtime

Allow public access to raw message object

There are certain cases where one would like to access the raw message
object under certain contexts. In general, these are contexts where
you need runtime access to the message type information, rather than
compile time template typing that the existing message object gives
you. It is still desirable to use the message object itself for
exception safety and RAII usage semantics.

Specifically, this came up when attempting to replicate the actions
interface in phosphor-rest, where types and conversions are determined
at runtime via introspect, and the type hierarchies are not known at
compile time.

Change-Id: I1e93af30992ffedbf470c1024eefe10cc5e21031
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

configure: Fix googletest depedence

b4b3247afc020843ebea278bf3c4e1cbebc54968 accidentally added a hard
dependency on googletest. The behavior of PKG_CHECK_MODULES is to fail
if the package is not fo

configure: Fix googletest depedence

b4b3247afc020843ebea278bf3c4e1cbebc54968 accidentally added a hard
dependency on googletest. The behavior of PKG_CHECK_MODULES is to fail
if the package is not found if no [action-if-not-found] is provided.
This change provides a no-op [action-if-not-found] so that autodetection
does not fail if not required.

Tested:
Ran through the unit test suite. Ran through the openbmc build
process without the googletest dependency to make sure it builds
now.

Change-Id: I81492833cc88b269a6d9ac1cb55b95da1975d40b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Add sbusplus properties server

Add properties server similar to boost-dbus that allows
for creating dbus interfaces during runtime. This adds
support for creating methods and get / set properties.

Add sbusplus properties server

Add properties server similar to boost-dbus that allows
for creating dbus interfaces during runtime. This adds
support for creating methods and get / set properties.

Get / set property callbacks are stored in flat_maps of
std::function allowing custom get / set functions. Methods
are also stored in this way allowing for creating of interfaces
without using any yaml. There is one C level callback for properties
get, properties set, and method calls that lookup the correct
std::function in the flat_map to call.

Tested: Ran asio-example on bmc, and updated fru-device.
Change-Id: I19881049f4307fe9c68f78df8854f14afdd6c362
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add boost asio async connection

Add an async connection and example of usage. This
connection inherits the bus object and allows async
method calls using boost asio. Most of these concepts
are from

Add boost asio async connection

Add an async connection and example of usage. This
connection inherits the bus object and allows async
method calls using boost asio. Most of these concepts
are from boost-dbus.

Change-Id: I33b5349d543c9ff4b6ee1ce15346c709c052e1ae
Tested: Compiled and ran asio-example on bmc.
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

tests: Write our own assert()

The cassert `assert()` function is only provided when NDEBUG is not
defined. Otherwise `assert()` becomes a no-op breaking our test cases.
Since we rely on the behavior

tests: Write our own assert()

The cassert `assert()` function is only provided when NDEBUG is not
defined. Otherwise `assert()` becomes a no-op breaking our test cases.
Since we rely on the behavior of assert to validate the tests, we always
want to provide one for the test implementation. This functionality will
be useful once code coverage is added since that forces NDEBUG to be
passed to the preprocessor.

Tested:
Test cases still work correctly if unmodified, and any changes that
should cause the asserts to fail still fail as expected.

Change-Id: I8d4132058308566310c58b7ae3e121eae55d37f5
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

tests: Makefile flags cleanup

This makes sure the correct flags are passed for each stage of
compilation and simplifies the logic for each different test case by
providing uniform flags for all of t

tests: Makefile flags cleanup

This makes sure the correct flags are passed for each stage of
compilation and simplifies the logic for each different test case by
providing uniform flags for all of them. This also makes us link against
libsdbusplus instead of the individual object files so that we don't
need to track object implementation details from the source base of the
project.

Tested:
Test cases still build and pass.

Change-Id: I8474d93d2c3f72a4b500c93016f3b7d7afe07b3c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

configure: Make gtest detection more flexible

This modifies the configure script to pull the googletest information
from pkgconfig. Now we don't have to manually configure GTEST specific
flags, we g

configure: Make gtest detection more flexible

This modifies the configure script to pull the googletest information
from pkgconfig. Now we don't have to manually configure GTEST specific
flags, we gain the correct library and header paths automatically. It
still understands how to detect googletest without pkgconfig if needed.

Change-Id: I7add3ee3073252adac7199415154c6805221e362
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

tests: Fix memory leak from sd_bus calls

Some of the calls into sd_bus leak memory because they never unreference
the bus or messages. Fix this so we can eventually enable leak checking
from valgrin

tests: Fix memory leak from sd_bus calls

Some of the calls into sd_bus leak memory because they never unreference
the bus or messages. Fix this so we can eventually enable leak checking
from valgrind.

Tested:
Ran through valgrind and the errors went away.

Change-Id: Icc3d5d0860b3852401219c1ca511a1bc26aa1c48
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

autotools: Simple changes for uniformity

Add build-aux and m4 directories so libtool can be vendored correctly
when doing a dist. Also reference the m4 directory from the automake
script to silence

autotools: Simple changes for uniformity

Add build-aux and m4 directories so libtool can be vendored correctly
when doing a dist. Also reference the m4 directory from the automake
script to silence any warnings by autoreconf. Add verbose and force
flags to autoreconf to make sure it regenerates everything and gives us
useful feedback about where it is in the process.

Change-Id: I8ea5184d1ae4098c2122d3e4043128b6731f7e87
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test: Makefile.am: add missing exception dependency

The read header includes references to the SdBusError object
but doesn't link against anything providing it.

Change-Id: Id3e9f88557c1b4eeaedd095c

test: Makefile.am: add missing exception dependency

The read header includes references to the SdBusError object
but doesn't link against anything providing it.

Change-Id: Id3e9f88557c1b4eeaedd095cb50515f08055e685
Signed-off-by: Patrick Venture <venture@google.com>

show more ...