Add common sd_event timer class

timer.hpp and timer.cpp are used throughout the project by copying them
into whatever git repo they are needed. This puts a header-only
implementation into sdbusplus,

Add common sd_event timer class

timer.hpp and timer.cpp are used throughout the project by copying them
into whatever git repo they are needed. This puts a header-only
implementation into sdbusplus, which is also used by every project.
Then, if you want a timer, you include sdbusplus/timer.hpp and you are
good to go.

Change-Id: Ica7543ecb66128b645f609e790fa7183eeb34ac1
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Handle invalid enum value in convertForMessage()

The function convertForMessage() takes an enum class as input, and it
assume the enum value is valid and does not check the return value of
std::find

Handle invalid enum value in convertForMessage()

The function convertForMessage() takes an enum class as input, and it
assume the enum value is valid and does not check the return value of
std::find_if().

If user deliberately passes an invalid enum value, it causes undefined
behavior.

Handle this case by checking the return value and throw
std::invalid_argument if the input argument is invalid.

Tested: Verify the unit test in phosphor-time-manager passed; without
the fix, the test fails when -flto is enabled.

Change-Id: I3874eaeb44b8e89469690a21090005d299d0f4b1
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

sdbusplus::asio: fix callback with void args specialization

Callbacks with no arguments failed to build due to an error in the
utility::get_first_arg template. It failed to provide a type member for

sdbusplus::asio: fix callback with void args specialization

Callbacks with no arguments failed to build due to an error in the
utility::get_first_arg template. It failed to provide a type member for
the void specialization. With this fix, it is possible to have a handler
that has no arguments.

Tested by: Added a new callback to the asio-example.cpp. Without the
template change, this caused the build to fail as expected.
After adding the template change, the build succeeds and the
example runs as expected.

Change-Id: Ib09b58c76df8cba57dc093ab37a4c1b68ea11ad3
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

clang-format: Fix pointer alignment

Oenbmc documentation specifies a left alignment for pointers. Our
current format tries to left align if neither alignment is strictly
followed, but will allow rig

clang-format: Fix pointer alignment

Oenbmc documentation specifies a left alignment for pointers. Our
current format tries to left align if neither alignment is strictly
followed, but will allow right aligned files to exist. Lets make this
more strict so that all of our files are consistent.

Change-Id: I3a50043d28a9c25d0cf1ffb752800d05eb7615e1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clang-format: Sort using statements

Make using order consistent where used. There aren't any in this
project, but this should be used more widely by openbmc projects.

Change-Id: I22b16c9d57415e3df7

clang-format: Sort using statements

Make using order consistent where used. There aren't any in this
project, but this should be used more widely by openbmc projects.

Change-Id: I22b16c9d57415e3df7e36a5be66aec1fa86b6a53
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clang-format: always break template declarations

To better match the defined openbmc style.

Change-Id: I68cda43857768bae4c904c367942cb1f0efa3e0c
Signed-off-by: Patrick Venture <venture@google.com>

update .clang-format header inclusion order

Added the header inclusion order to the .clang-format file generated
these changes.

Change-Id: Ia31b21d7ea451cac0309828006bc17c27cbd5bd5
Signed-off-by: P

update .clang-format header inclusion order

Added the header inclusion order to the .clang-format file generated
these changes.

Change-Id: Ia31b21d7ea451cac0309828006bc17c27cbd5bd5
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

clang-format-6.0 bump fixes

The bump to use clang-format-6.0 now reports these issues.

Change-Id: Ice27766e161356f08c98923a256a98af787ac8a2
Signed-off-by: Patrick Venture <venture@google.com>

Allow callback raw access to message

In some cases, the callback may care where the message came from. Allow
the callback to receive the raw sdbusplus::message along with the
automatically extracted

Allow callback raw access to message

In some cases, the callback may care where the message came from. Allow
the callback to receive the raw sdbusplus::message along with the
automatically extracted arguments.

This means that the registration mechanism as well as the callback
mechanism need to be aware of a 'message as a first parameter' situation
and behave accordingly. The registration needs to strip the message
parameter off in order to expose a correct DBus signature. The callback
mechanism needs to strip of the message parameter in order to properly
unpack the message, but add it back in before calling apply to execute
the function.

Tested: Added an example to example/asio-example.cpp and checked to see
that it builds. Was able to extract sender from message passed
into the IPMI handler.

Change-Id: I520e494d3baad34271e748465f30274353554728
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

configure: Fix --disable-tests

Currently, we encounter errors when passing `--disable-tests` because
variables used for automake never get defined when you wrap
AX_CODE_COVERAGE and AX_VALGRIND in A

configure: Fix --disable-tests

Currently, we encounter errors when passing `--disable-tests` because
variables used for automake never get defined when you wrap
AX_CODE_COVERAGE and AX_VALGRIND in AS_IF statements. We can fix this by
ensuring that valgrind and code coverage are disabled when tests are
disabled but the autoconf macros are still present.

Tested:
Unit testing still works as expected and builds with --disable-tests
now succeed.

Change-Id: Iddf2db4625d6760455982f1a6fc136f57becd162
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

property: Add support for const (read-only) values

There is already support for setting a property as const
(see vtable.hpp and corresponding test cases).
Implement this in the generated code by add

property: Add support for const (read-only) values

There is already support for setting a property as const
(see vtable.hpp and corresponding test cases).
Implement this in the generated code by adding support
for a new yaml flag.

Closes openbmc/openbmc#2028

Tested: Added the const flag to the Software Priority property,
and changing the value via REST and busctl would fail with
"org.freedesktop.DBus.Error.PropertyReadOnly", but the code
update app was able to set its value.

Change-Id: I8534753233080366503fd4f1a0c224c2946e8764
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I99921

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I99921bb9541fb37cb8999337a72d540494fbb4d7
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove multiple inheritance from SdBusError

SdBusError now has a direct line of inheritance down to std::exception
and will behave better when trying to catch it as a std::exception.

Add test cases

Remove multiple inheritance from SdBusError

SdBusError now has a direct line of inheritance down to std::exception
and will behave better when trying to catch it as a std::exception.

Add test cases to check that SdBusError is actually caught by
std::exception and all its other base classes.

Change-Id: I83e614219a1c47ec874ee0b4f14096a5e69ac17d
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Add return code checking for process discard

From the docs, sd_bus_process should be called until no progress
can be made. When progress is made, a positive integer is returned.
Add read_immediate t

Add return code checking for process discard

From the docs, sd_bus_process should be called until no progress
can be made. When progress is made, a positive integer is returned.
Add read_immediate to bypass setting up the fd watch when process_discard
returns a positive value.

Tested-by: Had C++ Mapper and Entity-Manager call each-other at the same
time and noticed no longer timed out.

Change-Id: Icab11743c6c5e1486b353fce1d5e3898f2d3f533
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

configure: Don't check for valgrind or coverage without tests

If we don't have test cases enabled we can't possibly need code coverage
or valgrind support since that is only used by our test cases.

configure: Don't check for valgrind or coverage without tests

If we don't have test cases enabled we can't possibly need code coverage
or valgrind support since that is only used by our test cases.

Tested:
Builds still work as expected and the autodetection of tests still
enables valgrind if it is available. Code coverage is only available
if `--disable-tests` is not passed and `--enable-code-coverage` is
passed.

Change-Id: I8bc786f2d64944ff8939b66055b3f850f6be7f6f
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

sdbus_mock: Make get_mocked_new() inline

Make get_mocked_new() inline so different tests can be linked together.
Otherwise, the build gets multiple definition of this function, if
different cases ar

sdbus_mock: Make get_mocked_new() inline

Make get_mocked_new() inline so different tests can be linked together.
Otherwise, the build gets multiple definition of this function, if
different cases are linked together.

Tested: Link test cases using this function OK.

Change-Id: Ifa1c62f9615ba0847b49eb73e9b977a865909bb2
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Correctly trigger interfaces added and removed

Asio was missing these signals, this was discovered while writing
the CPP mapper.

Tested: Restarted the fru device and watched using dbus-mointor.

Correctly trigger interfaces added and removed

Asio was missing these signals, this was discovered while writing
the CPP mapper.

Tested: Restarted the fru device and watched using dbus-mointor.
Also devices were able to be found by the mapper after boot.
Change-Id: I9d6e9c6087e36a3b79853432f46cc3942d317340
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

tests: Add valgrind memcheck support

This adds the ability to build sdbusplus test cases and run them through
valgrind using the build system.

Simply run:
`make check-valgrind`
and the test cas

tests: Add valgrind memcheck support

This adds the ability to build sdbusplus test cases and run them through
valgrind using the build system.

Simply run:
`make check-valgrind`
and the test cases will be run through valgrind

NOTE: This leaves out drd, helgrind, and sgcheck support as they would
requires extensive test refactoring. We don't really use threading in
the library code anyway so they are really only useful for proving the
test cases don't have any races.

Tested:
sdbusplus can still be built without valgrind and tests will still
execute normally. If `./configure --enable-valgrind` is passed the
configure script fails if valgrind is not present. Even with
valgrind, tests are only run through valgrind with `make
check-valgrind`. This succeeds as expected.

Change-Id: I08972feef2f32cf3ef912da4658e2d8920fb0275
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

configure: Remove manual pthread configuration

The PTHREAD_{CFLAGS,LIBS} are no longer directly required by our test
files so we don't need to explicitly depend on it. Instead, pull in the
macro so

configure: Remove manual pthread configuration

The PTHREAD_{CFLAGS,LIBS} are no longer directly required by our test
files so we don't need to explicitly depend on it. Instead, pull in the
macro so that googletest is configured correctly.

Tested:
Builds and run through the unit-test scripts. Pthread support is
still detected when it is needed.

Change-Id: I4c24177f930ea6c104c69a06ac3fdf0b5ae1535a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

exception: Remove unused sdbus_impl declaration

Change 9ff25f7365d4d590fcb5349328a46a8cd2093f34 exposed the sdbus_impl
globally from the sdbus.hpp file. Remove this leftover declaration
since it is

exception: Remove unused sdbus_impl declaration

Change 9ff25f7365d4d590fcb5349328a46a8cd2093f34 exposed the sdbus_impl
globally from the sdbus.hpp file. Remove this leftover declaration
since it is no longer needed.

Tested:
Built and run through the unit test suite.

Change-Id: I39484959978b07dd27aa3b3f3c0f046c5aa9b515
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

sdbusplus/ sort headers

Change-Id: Ica77cc28ad21b06f00f15d2aecca400ead13a5f1
Signed-off-by: Patrick Venture <venture@google.com>

Support to skip property changed signal

PropertyChanged signals are sent out, even before
InterfacesAdded signals (if deferSignal is set to true in
Object) are sent. This patch provides an option, t

Support to skip property changed signal

PropertyChanged signals are sent out, even before
InterfacesAdded signals (if deferSignal is set to true in
Object) are sent. This patch provides an option, to skip sending out
PropertiesChanged signal for proper initialization sequence.

Change-Id: I1678d80cc382fce420dda9f0dd9413d43c1c711d
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

test/message/read: Test that our error handling cases work

This improves our test coverage of sd_bus_message read functionality to
100%.

Tested:
Ran through the usual unit test scripts includin

test/message/read: Test that our error handling cases work

This improves our test coverage of sd_bus_message read functionality to
100%.

Tested:
Ran through the usual unit test scripts including valgrind and code
coverage.

Change-Id: Ifa849d05364349e27e39c6dda5e4cab4efa35476
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/message/read: Add missing variant skip

We were missing a test of the variant code which is used when the type
of the variant provided by the caller does not contain the type needed
at runtime t

test/message/read: Add missing variant skip

We were missing a test of the variant code which is used when the type
of the variant provided by the caller does not contain the type needed
at runtime to store the data in the message. This tests to make sure
that the skip is issued correctly when we can't read out the member.

Tested:
Unit tests still build and pass

Change-Id: I41fdc3e40589f1feedfadc3ab33fe808ff3a6d16
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

gitignore: Add all autogenerated files

Our gitignore is lacking definitions for most of the autogenerated files
by the project. This patch aims to clean up the gitignore by adding all
of the current

gitignore: Add all autogenerated files

Our gitignore is lacking definitions for most of the autogenerated files
by the project. This patch aims to clean up the gitignore by adding all
of the currently generated files / types to the list.

Tested:
Ran through a full unit test suite and none of the files are picked
up anymore.

Change-Id: I015776222f1750d200cc4beac13e1ac4329dd519
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...