message: Add constructor with an int parameter for unix_fd

This allows implicit conversions from int to unix_fd. This is for
instance useful in functions where one wants to return an unix_fd by
just

message: Add constructor with an int parameter for unix_fd

This allows implicit conversions from int to unix_fd. This is for
instance useful in functions where one wants to return an unix_fd by
just supplying the actual int file descriptor.

Change-Id: I118b8ec6b5a3d1533f5b05177127c28ad2539f3d
Signed-off-by: Waqar Hameed <waqarh@axis.com>

show more ...

Add method to check if an interface has been initialized

Different capabilities are supported depending on if an interface
has been initialized (e.g. register_property is only available before
initi

Add method to check if an interface has been initialized

Different capabilities are supported depending on if an interface
has been initialized (e.g. register_property is only available before
initialization and set_property is only available after).

This change adds a method to check if an interface has been initialized
to help determine which capabilities are currently supported.

Tested: Ran a module that uses register_property and set_property based
on this return value and confirmed that the properties are set
accordingly.

Change-Id: Iac39887f5d92981a316d1046f2f3d3ab71d15878
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Support default string values

For properties of type string, allow a default value to be set for the
property on the interface. This provides the ability to have a default
value to an intended free-

Support default string values

For properties of type string, allow a default value to be set for the
property on the interface. This provides the ability to have a default
value to an intended free-form string instead of using enumerated
values.

Tested:
Verified generated interface object initializes a string property
to a default value
Only properties of type string with a default defined are initialized
with the given default value as a string

Change-Id: I1e75dff1c26a4a872e9e3e7959106470c32c9be7
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Fix: ObjectManager path for asio

For asio based registration, ObjectManager's are created
under "/" folder. This makes dynamic detection difficult based
on the service root object path. Updated libr

Fix: ObjectManager path for asio

For asio based registration, ObjectManager's are created
under "/" folder. This makes dynamic detection difficult based
on the service root object path. Updated library to skip
ObjectManager creation, which can be created separately
by the needed daemon under the root object base path
This is needed, as dynamic detection of service name
can be performed on org.freedeskop.DBus.ObjectManager interface
when the root object doesn't have any interfaces.

Unit-test:
1. Verified it is compiling, and compatibile with existing code
2. Verified that ObjectManager is under the needed base path
when argument passed from service daemon.
3. Able to find service name using GetObject under objectMapper,
when service daemon, doens't have any other interface in root
base path other than org.freedesktop.DBus.Manager

Change-Id: Ie1ddf62df0df3849fc761995813c97872d96eb33
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Revert "Revert "Fix incorrect defaultValue in generated server.hpp""

This reverts commit 8192be92b9bf50450eb309a8798b3895bfdae471.

The commit "Fix incorrect defaultValue in generated server.hpp" re

Revert "Revert "Fix incorrect defaultValue in generated server.hpp""

This reverts commit 8192be92b9bf50450eb309a8798b3895bfdae471.

The commit "Fix incorrect defaultValue in generated server.hpp" revealed
an issue in phosphor-dbus-interfaces that causes the build error, and it
was reverted temporarily.

The issue is fixed in phosphor-dbus-interface, so we could add it back.

Change-Id: I1700ff1ede5f0eedc11fc324f649ea4f2e76edf5
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

bus: Only close connections we own

If we have multiple code segments in the same thread acquiring the
default bus, we end up with the potential for one of those handles to be
destroyed, calling sd_e

bus: Only close connections we own

If we have multiple code segments in the same thread acquiring the
default bus, we end up with the potential for one of those handles to be
destroyed, calling sd_event_flush_close_unref(). This terminates the bus
for all users of the same reference. Any of the reference which still
exist after the first destroy will then return ENOTCONN for all bus
operations since it is now closed. This behavior is undesirable as we
expect to be able to have transient bus references.

However, we do want to make sure we clean up any buses created by
sd_bus_open().

See openbmc/phosphor-time-manager@4e84539349dac086ce2a58e5b9900ed4e40a2eaf
for a specific example of this behavior being unwanted.

Change-Id: I8aad7e282e9d66993b63e85532dce37c179ad5dc
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

bus: Add missing sd_bus_open() equivalent

Change-Id: I8181dc8932353e8f37da9fab168f34f214d222c0
Signed-off-by: William A. Kennington III <wak@google.com>

Move asio interfaces away from deprecated names

The intent of this commit is to allow building asio based event loops in
applications with BOOST_ASIO_NO_DEPRECATED flag set. This change is
largely

Move asio interfaces away from deprecated names

The intent of this commit is to allow building asio based event loops in
applications with BOOST_ASIO_NO_DEPRECATED flag set. This change is
largely a sed replace of io_service with io_context.

This will allow us to move to the networking TS at such time that it is
mature. Details on depreated interfaces are available here for
reference:

https://www.boost.org/doc/libs/1_69_0/doc/html/boost_asio/net_ts.html

Change-Id: Ie3cc699effcf855a649dee5bfce2f6616109429b
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Add support for Unix file descriptors

Change-Id: I2d1402c38b7b8b39cee42f959a0421b24a80e45d
Signed-off-by: Waqar Hameed <waqarh@axis.com>

Revert "Fix incorrect defaultValue in generated server.hpp"

This reverts commit 14269fbcc15fd0e764f672de144d44e8ee26dd78.

This caused the following compile failure in phosphor-dbus-interfaces:
16:5

Revert "Fix incorrect defaultValue in generated server.hpp"

This reverts commit 14269fbcc15fd0e764f672de144d44e8ee26dd78.

This caused the following compile failure in phosphor-dbus-interfaces:
16:52:02 make[1]: Entering directory '/phosphor-dbus-interfaces-99b5aaa499c2f1a71a031051136744ad1e7df869'
16:52:02 CXX libphosphor_dbus_la-libphosphor_dbus.lo
16:52:05 In file included from libphosphor_dbus.cpp:16151:0:
16:52:05 ./xyz/openbmc_project/User/Ldap/Config/server.hpp:195:53: error: expected unqualified-id before numeric constant
16:52:05 SearchScope _lDAPSearchScope = SearchScope::0;
16:52:05 ^
16:52:05 make[1]: *** [libphosphor_dbus_la-libphosphor_dbus.lo] Error 1
16:52:08 make: *** [all] Error 2

Change-Id: Ie4c2f99d08b96845da86634ad73b9c8af56b656c
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Fix incorrect defaultValue in generated server.hpp

In property.py, the defaultValue is got from yaml and it could be
string, bool, or numeric.

In case of bool, the value becomes True/False, and whe

Fix incorrect defaultValue in generated server.hpp

In property.py, the defaultValue is got from yaml and it could be
string, bool, or numeric.

In case of bool, the value becomes True/False, and when it is rendered
in C++ code, the code will not compile due to C++ expects true/false
instead.

And in server.hpp template, it checks "if p.defaultValue", and if the
default value is "false" or 0, p.defaultValue becomes False, so the
generated C++ code will not have default value.

For example, a var defined in yaml has below default value:

default: true
default: false
default: 0

will be rendered in C++ code as:

var = True;
var{};
var{};

This commit fixes the issue by converting defaultValue from True/False
to true/false string, and check if by "if p.defaultValue is not None".

Tested: Verify the above exmaple will generate valid C++ code as below:
var = true;
var = false;
var = 0;

Change-Id: I65c9f5222aa2d7b53299a53ff63d33bd6d073b95
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

bus: Add explicit flush and close operations

This change exposes explicit flush and close operations on the bus for
users who require bus termination at a specific checkpoint instead of
program term

bus: Add explicit flush and close operations

This change exposes explicit flush and close operations on the bus for
users who require bus termination at a specific checkpoint instead of
program termination.

Change-Id: I0e2edce8586956ab286d75d1eb13eeca4309e370
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

update asio set property to signal properly

Set property has to send out signal only when there is
change in the property and skipped when there is no change
but still must return true for the set m

update asio set property to signal properly

Set property has to send out signal only when there is
change in the property and skipped when there is no change
but still must return true for the set method accordingly

Unit test:
Using busctl monitor match rule, monitored the properties changed
of sensors (which uses asio logic) and verified by updating
the value with same & different one, and observed both the return
(success) and the properties changed signal generated only when
there is changed in the property value as expected.

Change-Id: I79be5b29f496109c19e415cdcfff89af76693de5
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

asio: Update variant usage

After the below change in sdbusplus,
the variant usage needs to be switched to std::variant
https://github.com/openbmc/sdbusplus/commit/90778b430290c9ec8c33fb77b03e2552d9d

asio: Update variant usage

After the below change in sdbusplus,
the variant usage needs to be switched to std::variant
https://github.com/openbmc/sdbusplus/commit/90778b430290c9ec8c33fb77b03e2552d9dd6905

Tested:
./configure --enable-boost
make

Change-Id: Ic1d156ad379eb56822f75e8046f83fa45f4ad56d
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>

show more ...

bus: route bus deleter to implementation

Allow the bus deleter to be routed to a real or mock implementation.

Also prevents link errors such as:
sysroots/i586-openbmc-linux/usr/include/sdbusplus/

bus: route bus deleter to implementation

Allow the bus deleter to be routed to a real or mock implementation.

Also prevents link errors such as:
sysroots/i586-openbmc-linux/usr/include/sdbusplus/bus.hpp:68: undefined reference to `sd_bus_unref'
when libsystemd is not linked in.

Unit tests still pass and a Witherspoon system QEMU instance still
boots to a shell.

Change-Id: If498076ddc28acf166c9dab0502f7e209d6e1f2d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

bus: Add mock and interface for flush_close_unref

There are currently direct calls to this - add an interface, impl and
mock - so calls can be routed accordingly.

Unit tests still pass with this pa

bus: Add mock and interface for flush_close_unref

There are currently direct calls to this - add an interface, impl and
mock - so calls can be routed accordingly.

Unit tests still pass with this patch applied.

Change-Id: I881fedf62d957f6a87b11ab1e35cacbb9402ffa4
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

style: run clang-format on bus/server.hpp.in

Change-Id: Iadd0601a9d621fcf27c12112af7d38f5e35e593b
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

sdbusplus::asio: Use the default bus

The documentation says that the default bus calls are the ones to use
instead of the open bus calls to reduce resources.

Change-Id: I719494adf2e97e94bb5a9925064

sdbusplus::asio: Use the default bus

The documentation says that the default bus calls are the ones to use
instead of the open bus calls to reduce resources.

Change-Id: I719494adf2e97e94bb5a9925064cda6cfdd28047
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

sdbusplus: better mirror bus aquisition methods

This adds new functions:
* new_default_user() -> return default user bus connection
* new_default_system() -> returns default system connection

And

sdbusplus: better mirror bus aquisition methods

This adds new functions:
* new_default_user() -> return default user bus connection
* new_default_system() -> returns default system connection

And changes new_default() to return the default type of connection for
the user as per the man page:
https://www.freedesktop.org/software/systemd/man/sd_bus_default.html

Also, update the example and the README to use the default bus calls.

Change-Id: I13cd77dda847c4f6018da38e0019816da07710d1
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

asio: Don't allow signaling uninitialized properties

Signaling a property in an non-initialized interface
causes a segfault.

Testedy-by: Verified segfault went away.

Change-Id: Ib48510e761fb696670

asio: Don't allow signaling uninitialized properties

Signaling a property in an non-initialized interface
causes a segfault.

Testedy-by: Verified segfault went away.

Change-Id: Ib48510e761fb69667040351056853a470c5a9a9f
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

message: mapbox::util::variant -> std::variant

Now that we are utilizing c++17, we can move to using the standard
variant type instead of a custom third-party one.

Tested:
Ran through a unit te

message: mapbox::util::variant -> std::variant

Now that we are utilizing c++17, we can move to using the standard
variant type instead of a custom third-party one.

Tested:
Ran through a unit test run.

Change-Id: Idd9854a6d958ea5a191e9a72d6116fd767dff4d3
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

build: set language to C++

Set the language in the build to C++.

Change-Id: I997d6a697bc6c98ab208518a81e66ac2aa7945c1
Signed-off-by: Patrick Venture <venture@google.com>

Add sdbusplus::asio coroutine method handling

Adding the server-side of the coroutine path allows yielding
asynchronous method handling via coroutines. This means that a method
handler can call a yi

Add sdbusplus::asio coroutine method handling

Adding the server-side of the coroutine path allows yielding
asynchronous method handling via coroutines. This means that a method
handler can call a yielding dbus call (or other asio-based asynchronous
call) without blocking the rest of the process.

The call path might look something like this:

service.thing/object/path/interface.my-method()
- do something
- yield_method_call(other.service, /other/path,
other.interface, other-method)
<yields to other coroutine>

execute other code in another context

<returns some time later with dbus call's response>
- use response from other method
<- return my-method response

This also changes the asio-example, pulling it apart into a
client/server model so it is more clear about how to use the yielding
async method handling and yielding async method calls.

Change-Id: I23ccf7a9a8dff787be78929959c1f018280a0392
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

bus: check if D-Bus service name request was successful

Solves issue #21 on github.

Change-Id: I71ef2be8b2a2fc8ff82410b6aed12c76140b5606
Signed-off-by: Waqar Hameed <waqarh@axis.com>

asio: don't allow setting the same value

Setting the same value causes egregious properties changed
events. Return 0 if the user attempts to do this.

Tested-by: used dbus-monitor and noticed reduce

asio: don't allow setting the same value

Setting the same value causes egregious properties changed
events. Return 0 if the user attempts to do this.

Tested-by: used dbus-monitor and noticed reduced traffic
when using set_property

Change-Id: I2643a01fd0e1cc1e0c0ed407056f0e3cd898865b
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...