Fix variable shadow warnings in sdbusplus

-Wshadow is useful for subprojects to enable, because it can find bugs
in common variable names (err, r, i, etc). With these changes, projects
can now buil

Fix variable shadow warnings in sdbusplus

-Wshadow is useful for subprojects to enable, because it can find bugs
in common variable names (err, r, i, etc). With these changes, projects
can now build sdbusplus with -Wshadow enabled.

The changes fall into a couple buckets. The first is for constructor
variables that match the member variable name. In these cases, "_in" is
appended to the end of the constructor variable name.

The second is a case where the variable "r" was used for return codes
twice. One instance is changed to "ret".

With these changes, projects can compile with -Wshadow enabled without
warnings.

Change-Id: Ia33a6f8306473c616f6278bb848460167e5463ef
Signed-off-by: Ed Tanous <edtanous@google.com>

show more ...

stdexec: update to later commit

The upstream code has done some namespace changes. Point to a commit
in that timeframe and fix up the local usages in order to compile
successfully.

Signed-off-by:

stdexec: update to later commit

The upstream code has done some namespace changes. Point to a commit
in that timeframe and fix up the local usages in order to compile
successfully.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5a21ccd0774ee5cd22d45c9a425e43560734a571

show more ...

Add static to method

This function isn't used outside of this compile unit, and has no
definition in a header. Declare it static.

Change-Id: Ibebbaec1926cf03380fb5dff063eccef061ad809
Signed-off-by

Add static to method

This function isn't used outside of this compile unit, and has no
definition in a header. Declare it static.

Change-Id: Ibebbaec1926cf03380fb5dff063eccef061ad809
Signed-off-by: Ed Tanous <edtanous@google.com>

show more ...

Remove extra semi-colons

A couple functions had extra semi-colons, which clang -Weverything
flags. Remove them.

Change-Id: I2b44444c3184817dd0035c62b5ae114254457398
Signed-off-by: Ed Tanous <edtan

Remove extra semi-colons

A couple functions had extra semi-colons, which clang -Weverything
flags. Remove them.

Change-Id: I2b44444c3184817dd0035c62b5ae114254457398
Signed-off-by: Ed Tanous <edtanous@google.com>

show more ...

Revert "black: re-format"

It seems like some order of operations introduced this. Will need to
monitor and see if there is something we need to better handle with
the tools.

This reverts commit 79

Revert "black: re-format"

It seems like some order of operations introduced this. Will need to
monitor and see if there is something we need to better handle with
the tools.

This reverts commit 798efc347ebf381250f8f5d59bc31d6aae622c5b.

Change-Id: I418039ba2a0dba749438cfd7b9e83a21ba56e0f9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I92bbd158a38b4b9

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I92bbd158a38b4b91020390f12c5aba81b4c1415f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbus++: simplify namespace generation

Use nested namespaces in the server interface definitions to
simplify the mako template.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6f17d

sdbus++: simplify namespace generation

Use nested namespaces in the server interface definitions to
simplify the mako template.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6f17dd4069c818f9836cd47eb56926adeaa41b6e

show more ...

clang-ignore: remove unneeded file

The code formatting tools have been updated so that this clang-ignore
is no longer necessary. Meson will use 'git ls-files' by default and
the org-wide tools do a

clang-ignore: remove unneeded file

The code formatting tools have been updated so that this clang-ignore
is no longer necessary. Meson will use 'git ls-files' by default and
the org-wide tools do as well now.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie337eb60d3f87ffab8dcbf4ef33990c432bf82ce

show more ...

shell: reformat with beautysh

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2717d31983fd17fab557bb92fc55e08e248f1159

black: reformat python scripts

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idf22526cce52cae58acacd7970cfe7efa1f564cd

prettierrc: update config

Copy org-wide config from openbmc-build-scripts and reformat
accordingly.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie142989f03f7d702b48f33bbf1c50b3b2

prettierrc: update config

Copy org-wide config from openbmc-build-scripts and reformat
accordingly.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie142989f03f7d702b48f33bbf1c50b3b2f1f47c4

show more ...

sdbus++: remove old 'NEW_CAMELCASE' define

All code is moved over to the new camelcase format, so remove
the #define.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I99bf1276acce70e

sdbus++: remove old 'NEW_CAMELCASE' define

All code is moved over to the new camelcase format, so remove
the #define.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I99bf1276acce70e60529b55be757bd2dcbb8784a

show more ...

Clean up ASIO set-property callback code

This reverts commit ce62764d6c0a72ec88eb433e1afd05b751225971, which
introduced inconsistent semantics for the underlying ASIO set handler
functions. The "ext

Clean up ASIO set-property callback code

This reverts commit ce62764d6c0a72ec88eb433e1afd05b751225971, which
introduced inconsistent semantics for the underlying ASIO set handler
functions. The "external" `call` case expected the handler to return an
integer error code, while the "internal" `set` case expected the handler
to return a boolean status.

This also does a small refactor on the two similar `call` and `set`
functions to deduplicate, and adds ASIO.md to document the expected
semantics of the ASIO handlers.

The vast majority of user code in OpenBMC is still returning integers
from the callbacks (0/1/-1), but in most cases 0 was used to mean
failure, and 1 was used to mean success, so formalizing that the
callback should return a boolean value will not break things.

Tested: With accompanying dbus-sensors change
I05c41318954d5d1549752c5ef2c227f3f22a45d3, using steps in that commit
msg.

Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: Ic3a36027fa95a77469439b296a1497634cfe030f

show more ...

bus: Add function for checking open status

We have a workaround in sdevent for dealing with match expressions
that leak memory. If we keep trying to process bus events after
sd_bus_close(), we will

bus: Add function for checking open status

We have a workaround in sdevent for dealing with match expressions
that leak memory. If we keep trying to process bus events after
sd_bus_close(), we will encounter errors. This allows us to stop
processing when the bus should be closed.

Change-Id: I0bda95e76db8e81b56527cd1d5687a5d0b14f259
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

bus: Return the value of wait

Knowing the number of events being >0 is important if a timeout is set,
otherwise you can't know if processing is safe to perform.

Change-Id: Ifc3b8a01666422b4f2e057f0

bus: Return the value of wait

Knowing the number of events being >0 is important if a timeout is set,
otherwise you can't know if processing is safe to perform.

Change-Id: Ifc3b8a01666422b4f2e057f0b162d7588c0ab446
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

sdbus++: remove 'path' type

The type 'path' is ambiguous because it really isn't file-system
paths but dbus object paths. A while ago 'object_path' was added
for more clarity and 'path' has been de

sdbus++: remove 'path' type

The type 'path' is ambiguous because it really isn't file-system
paths but dbus object paths. A while ago 'object_path' was added
for more clarity and 'path' has been deprecated. All uses of 'path'
in phosphor-dbus-interfaces has been updated and it is a trivial fix
for any other downstream users. Removing 'path' so that the older
typename is no longer used.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icbbbe59538ca3f910a401dced51c239278b76194

show more ...

remove potential memory leak with getAllProperties

Wrap handler in a lambda to remove the trigger potential memory
leak with clang-tidy. Only getAllProperties have this std::move to
async_method_cal

remove potential memory leak with getAllProperties

Wrap handler in a lambda to remove the trigger potential memory
leak with clang-tidy. Only getAllProperties have this std::move to
async_method_call and is hitting the issue.

The issue only happens if the handler captures some variabls

Example code that hit the issue.
```

void handler(const std::string& /*unused*/,
const boost::system::error_code /*unused*/,
const std::vector<
std::pair<std::string, std::variant<std::string>>>& /*unused*/)
{}

void test(sdbusplus::asio::connection* conn)
{
std::string test = "test";
sdbusplus::asio::getAllProperties<std::variant<std::string>>(
*conn, "xyz.openbmc_project.EntityManager", "path",
"xyz.openbmc_project.Inventory.Decorator.Asset",
std::bind_front(handler, test));
}
```
Tested:
clang-tidy is happy now

Signed-off-by: Willy Tu <wltu@google.com>
Change-Id: I0a3a5ed016aed664c650d811e253d54a4eb2b0b1

show more ...

docs: move yaml documentation to a subdir

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6ee7c15e1d7c65a11f27c5a8d3b64675ec03e69c

test: async: tweak time multiplier

When running under valgrind, the timing is a lot slower. Give a
longer time interval for test cases to give some cushion.

Signed-off-by: Patrick Williams <patric

test: async: tweak time multiplier

When running under valgrind, the timing is a lot slower. Give a
longer time interval for test cases to give some cushion.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie3e3a0d1960de2df1cea60763de8f57a3bcaa801

show more ...

async: context: allow many exceptions

Allow many spawned tasks to throw exceptions and queue them up,
re-throwing them one-by-one from `context::run` calls. Similarly
enhance `context::scope` so th

async: context: allow many exceptions

Allow many spawned tasks to throw exceptions and queue them up,
re-throwing them one-by-one from `context::run` calls. Similarly
enhance `context::scope` so that many `context::empty` completions
can complete with error.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8744e0a3b8b0663ebd5ca26db0f5943688afe62a

show more ...

async: context: allow run re-entrance

Switch the context call so that it can be re-entrant. A single call
to `run` will either:

1. Process until the context is successfully stopped.
2. An

async: context: allow run re-entrance

Switch the context call so that it can be re-entrant. A single call
to `run` will either:

1. Process until the context is successfully stopped.
2. An exception is raised from a spawned task.

If an exception is raised, it could be caught outside the run call
and then run called again.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icd05df421a1f0592bd2390fbe8e21a16252eafed

show more ...

async: context: simplify run function

Since we already have a `spawn` function to add async tasks,
get rid of the special "startup" task send to run. Instead
users should pass the start up work to

async: context: simplify run function

Since we already have a `spawn` function to add async tasks,
get rid of the special "startup" task send to run. Instead
users should pass the start up work to spawn and call run with
no parameters.

Eventually this will allow us to exit the run-loop for any and all
exceptions from the async context and potentially allow a caller
to re-enter the `run` loop after handling the child exception.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia0e09a2493f0554538315d1d0c238aa11cb44e39

show more ...

async: context: spawn on worker thread

We always want to do async work on the worker thread. Use
the `execution::on` sender to ensure that tasks are done on that
thread no matter which thread they

async: context: spawn on worker thread

We always want to do async work on the worker thread. Use
the `execution::on` sender to ensure that tasks are done on that
thread no matter which thread they were spawned from.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2b4e3a69bbd64786c2480df9396d65f12dd46cc3

show more ...

test: async: add a few recursive task tests

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I37b231e75b55c851c37600367da7ce1bc75e60af

async: scope: allow blocks before started

In some cases it may be helpful to be able to block on a scope
before work has begun on that scope. Add state tracking to know
when the scope has first sta

async: scope: allow blocks before started

In some cases it may be helpful to be able to block on a scope
before work has begun on that scope. Add state tracking to know
when the scope has first started.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9ee48aa19344b80124aa9409a4a7e368eb025882

show more ...