| 14a6b614 | 17-Mar-2023 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: interface: simplify client.hpp
Use C++17 nested-namespace definition to simplify the header file.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I285f0d0b939b9b448b9117eb18
sdbus++: interface: simplify client.hpp
Use C++17 nested-namespace definition to simplify the header file.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I285f0d0b939b9b448b9117eb185ea6dd3f6eff49
show more ...
|
| 759e7222 | 17-Mar-2023 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: interface: reduce mako embedded python
Reduce the amount of Python embedded in Mako for simplicity and faster
execution.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iff8
sdbus++: interface: reduce mako embedded python
Reduce the amount of Python embedded in Mako for simplicity and faster
execution.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iff8cac1b80bfce6b823b2e90464c788b79e67301
show more ...
|
| 0fc4abad | 17-Mar-2023 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: method: reduce mako embedded python
Embedded Python in the Mako templates is slower than native Python.
Promote some of the functions in the Mako templates to real member
functions in the `
sdbus++: method: reduce mako embedded python
Embedded Python in the Mako templates is slower than native Python.
Promote some of the functions in the Mako templates to real member
functions in the `Method` class.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I06e16e840cfdbe7a87889269d2de8602b9a9bfc4
show more ...
|
| a3610550 | 25-Feb-2023 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: interface: reduce excess whitespace
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If820ee4114c1222e11dded672062dc0a10eb7d27 |
| bde01ad2 | 25-Feb-2023 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: interface: move variant constructor inline
This saves approximately 250K in the libphosphor_dbus.so on x86.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie0786cdbe2cac865
sdbus++: interface: move variant constructor inline
This saves approximately 250K in the libphosphor_dbus.so on x86.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie0786cdbe2cac865f53c0874e5b1218c2208c09c
show more ...
|
| 39a2e3c6 | 25-Feb-2023 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: interface: move basic constructor inline
This saves 100k out of the libphosphor_dbus.so on x86.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iadd57bdb6517ac3dcb92c2165d99
sdbus++: interface: move basic constructor inline
This saves 100k out of the libphosphor_dbus.so on x86.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iadd57bdb6517ac3dcb92c2165d9913f622511c6e
show more ...
|
| df6133b4 | 08-Mar-2023 |
Ed Tanous <edtanous@google.com> |
Remove size_t from SetPropertyReturnValue
This enum is only ever used as an enum. Let the compiler decide what
underlying type to use.
Change-Id: Ieda7835ab346c46d8a1153a8e8eb65e45ae1648c
Signed-o
Remove size_t from SetPropertyReturnValue
This enum is only ever used as an enum. Let the compiler decide what
underlying type to use.
Change-Id: Ieda7835ab346c46d8a1153a8e8eb65e45ae1648c
Signed-off-by: Ed Tanous <edtanous@google.com>
show more ...
|
| 3448edea | 08-Mar-2023 |
Ed Tanous <edtanous@google.com> |
Remove initialized_ member
the std::optional on interface represents the same information about
whether or not this interface have been initialized.
Change-Id: I365ac35a76f3fd710bddac3d55b514f3fde2
Remove initialized_ member
the std::optional on interface represents the same information about
whether or not this interface have been initialized.
Change-Id: I365ac35a76f3fd710bddac3d55b514f3fde2f255
Signed-off-by: Ed Tanous <edtanous@google.com>
show more ...
|
| b65dc1c6 | 07-Mar-2023 |
Ed Tanous <edtanous@google.com> |
Use more specific includes
We shouldn't be including all of asio, just the parts we need.
Change-Id: I15f5ffa40311644df98fcb9164cac529a423d232
Signed-off-by: Ed Tanous <edtanous@google.com> |
| 936cb89e | 01-Mar-2023 |
Ed Tanous <edtanous@google.com> |
Change deprecated asio function
The io_context.post method has been deprecated for some time. Move to
the new model, using boost::asio::post.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-
Change deprecated asio function
The io_context.post method has been deprecated for some time. Move to
the new model, using boost::asio::post.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I946a32e0404809b85c72767aafd783053bf8ee5f
show more ...
|
| 3edbe5c0 | 28-Feb-2023 |
Ed Tanous <edtanous@google.com> |
Change io_service to io_context
This was renamed a while back in boost to be compliant with the
std::executors proposal.
Change-Id: Ibb55df2b7c1e133621e354728115b89953d9e1bc
Signed-off-by: Ed Tanou
Change io_service to io_context
This was renamed a while back in boost to be compliant with the
std::executors proposal.
Change-Id: Ibb55df2b7c1e133621e354728115b89953d9e1bc
Signed-off-by: Ed Tanous <edtanous@google.com>
show more ...
|
| 56252bbe | 13-Feb-2023 |
Patrick Williams <patrick@stwcx.xyz> |
stdexec: update to latest commit
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idaa873100bd02f06455b0eb5a00ca62f93b08acc |
| 29c4d435 | 01-Feb-2023 |
Patrick Williams <patrick@stwcx.xyz> |
event: add unistd header
The file uses `write` which is defined in `unistd.h`. Add it to give
more coverage to various compiler and stdlib versions.
Signed-off-by: Patrick Williams <patrick@stwcx.
event: add unistd header
The file uses `write` which is defined in `unistd.h`. Add it to give
more coverage to various compiler and stdlib versions.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icbef43f3b6b89f0ff3cdfb84ad5fa1c695562dbb
show more ...
|
| abbdd6aa | 20-Jan-2023 |
Patrick Williams <patrick@stwcx.xyz> |
stdexec: update to latest commit
The result of execution::when_all seems to have changed, so I needed
to make a slight change to `sleep_for` to return a task instead of a
Sender.
Signed-off-by: Pat
stdexec: update to latest commit
The result of execution::when_all seems to have changed, so I needed
to make a slight change to `sleep_for` to return a task instead of a
Sender.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib47c631f8e970838a79ffb44e2a1db4c86a831c4
show more ...
|
| 9688ed68 | 06-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Add override keyword everywhere it's required
Clang catches some of these. Add override keywords where we override
functions, per cpp core guidelines.
Change-Id: I66f9e6dff53e07f0057d86a806701593b
Add override keyword everywhere it's required
Clang catches some of these. Add override keywords where we override
functions, per cpp core guidelines.
Change-Id: I66f9e6dff53e07f0057d86a806701593be16b188
Signed-off-by: Ed Tanous <edtanous@google.com>
show more ...
|
| 60a94305 | 06-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Fix meson warning
Meson warns on the calls to run_command.
WARNING: You should add the boolean check kwarg to the run_command call.
It currently defaults to false, but it will default to true in fu
Fix meson warning
Meson warns on the calls to run_command.
WARNING: You should add the boolean check kwarg to the run_command call.
It currently defaults to false, but it will default to true in future
releases of meson. See also:
https://github.com/mesonbuild/meson/issues/9300
This commit does as meson recommends, and adds check: true to all
run_command calls, which will be the default.
Change-Id: I281df6ed32c935ce7d3664a0ad628cc81dbac3a8
Signed-off-by: Ed Tanous <edtanous@google.com>
show more ...
|
| d375eba5 | 06-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Remove static from inline variables
These do not need to be static in this context. They are used to
construct a message and that's it, constexpr is better.
At the same time, change the auto on de
Remove static from inline variables
These do not need to be static in this context. They are used to
construct a message and that's it, constexpr is better.
At the same time, change the auto on depth to int32_t, because that is
the correct API.
Change-Id: Ie2fc84eb2fee13af4c898854b822d8dbd190f5a4
Signed-off-by: Ed Tanous <edtanous@google.com>
show more ...
|
| 1837cd59 | 06-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Remove dead code paths
There's a few places where we call return after another return
statement, or after a method that doesn't return. These are not
required, and can be removed.
Change-Id: I0917
Remove dead code paths
There's a few places where we call return after another return
statement, or after a method that doesn't return. These are not
required, and can be removed.
Change-Id: I091716bd0eb8ad6aec7a54b66d175b348cbe00e0
Signed-off-by: Ed Tanous <edtanous@google.com>
show more ...
|
| cb2fbeb9 | 06-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Remove some extra semi-colons in tests
These snuck in here and cause clang warnings. Fix them.
Change-Id: I526cfee1ebc799eae48b92e790273f31462c655f
Signed-off-by: Ed Tanous <edtanous@google.com> |
| 640a7d56 | 04-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Add support for appending std::string_view
std::string_view is used more in the project now that c++17 is
available. It should be allowed as a base type in serialization of dbus
interfaces.
To avo
Add support for appending std::string_view
std::string_view is used more in the project now that c++17 is
available. It should be allowed as a base type in serialization of dbus
interfaces.
To avoid an extra string copy, this function makes use of
sd_bus_message_append_string_iovec, which allows appending in string
pieces that might not be null terminated. This function is piped
through the test framework, and interfaces to match.
Change-Id: Iee3e2cea9759fa9759cec98ab30c12c822aa3b73
Signed-off-by: Ed Tanous <edtanous@google.com>
show more ...
|
| 2e3f79b3 | 05-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Add missing override keyword on mock
This mock method is missing an override keyword. Looks like an
unintentional omission. Add it.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ia1c2
Add missing override keyword on mock
This mock method is missing an override keyword. Looks like an
unintentional omission. Add it.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ia1c2ee09ddbb5add0485b2e3f66347823bf959af
show more ...
|
| 87ce9630 | 04-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Remove static keyword from template
Clang warns on these templates not being used, each of which use a
static modifier in a header file. Given we're in a header, this likely
means that this static
Remove static keyword from template
Clang warns on these templates not being used, each of which use a
static modifier in a header file. Given we're in a header, this likely
means that this static modifier isn't really doing anything, given that
every compile unit will include the header.
Remove static to shut clang up.
Change-Id: I50c33738e4567150eeddf9e6ded0dc24db14c78d
Signed-off-by: Ed Tanous <edtanous@google.com>
show more ...
|
| ddc57bdf | 05-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Fix a bunch of docstrings
Clang correctly notes that a bunch of our docstrings are wrong. We
don't really use doxygen, but it's useful to be able to run a compiler
without warnings. The failures f
Fix a bunch of docstrings
Clang correctly notes that a bunch of our docstrings are wrong. We
don't really use doxygen, but it's useful to be able to run a compiler
without warnings. The failures fall into a couple categories.
First, when using variadic templates, the type is the variable name (ie
T), not including variadic expansion. (ie T...). In these cases, the
... is removed from the definition.
Templatized structs should not use the @struct keyword. They are a
template as far as doxygen is concerned, so remove the keyword.
A number of functions docstrings are just wrong in terms of argument
names, or whether or not they have return types.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Iab6f76b422a9568b7ad19d3f725a9c1b870784d9
show more ...
|
| 760e66a8 | 05-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Remove unused variable
Clang correctly notes that ioc is private and unused. Remove it.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I1aa16b3f3c4e08d8c48205c9e060f6e1087956d4 |
| 571a2140 | 05-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Silence sign-conversion warning
In this case, we're loading an int into a char. Given that we're
building a hex string, this is intended, and can never overflow, but
this conversion causes a warnin
Silence sign-conversion warning
In this case, we're loading an int into a char. Given that we're
building a hex string, this is intended, and can never overflow, but
this conversion causes a warning about implicit conversions.
Make the conversion explicit by wrapping in a static_cast.
Change-Id: I4c103afcaad2943f339413e1ecdd934677805dad
Signed-off-by: Ed Tanous <edtanous@google.com>
show more ...
|