| bde01ad2 | 25-Feb-2023 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: interface: move variant constructor inline
This saves approximately 250K in the libphosphor_dbus.so on x86.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie0786cdbe2cac865
sdbus++: interface: move variant constructor inline
This saves approximately 250K in the libphosphor_dbus.so on x86.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie0786cdbe2cac865f53c0874e5b1218c2208c09c
show more ...
|
| 39a2e3c6 | 25-Feb-2023 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: interface: move basic constructor inline
This saves 100k out of the libphosphor_dbus.so on x86.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iadd57bdb6517ac3dcb92c2165d99
sdbus++: interface: move basic constructor inline
This saves 100k out of the libphosphor_dbus.so on x86.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iadd57bdb6517ac3dcb92c2165d9913f622511c6e
show more ...
|
| 60a94305 | 06-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Fix meson warning
Meson warns on the calls to run_command.
WARNING: You should add the boolean check kwarg to the run_command call.
It currently defaults to false, but it will default to true in fu
Fix meson warning
Meson warns on the calls to run_command.
WARNING: You should add the boolean check kwarg to the run_command call.
It currently defaults to false, but it will default to true in future
releases of meson. See also:
https://github.com/mesonbuild/meson/issues/9300
This commit does as meson recommends, and adds check: true to all
run_command calls, which will be the default.
Change-Id: I281df6ed32c935ce7d3664a0ad628cc81dbac3a8
Signed-off-by: Ed Tanous <edtanous@google.com>
show more ...
|
| 1837cd59 | 06-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Remove dead code paths
There's a few places where we call return after another return
statement, or after a method that doesn't return. These are not
required, and can be removed.
Change-Id: I0917
Remove dead code paths
There's a few places where we call return after another return
statement, or after a method that doesn't return. These are not
required, and can be removed.
Change-Id: I091716bd0eb8ad6aec7a54b66d175b348cbe00e0
Signed-off-by: Ed Tanous <edtanous@google.com>
show more ...
|
| 5d26ec9e | 08-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
Revert "black: re-format"
It seems like some order of operations introduced this. Will need to
monitor and see if there is something we need to better handle with
the tools.
This reverts commit 79
Revert "black: re-format"
It seems like some order of operations introduced this. Will need to
monitor and see if there is something we need to better handle with
the tools.
This reverts commit 798efc347ebf381250f8f5d59bc31d6aae622c5b.
Change-Id: I418039ba2a0dba749438cfd7b9e83a21ba56e0f9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 798efc34 | 08-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
black: re-format
black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.
Change-Id: I92bbd158a38b4b9
black: re-format
black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.
Change-Id: I92bbd158a38b4b91020390f12c5aba81b4c1415f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 0050ce75 | 18-Nov-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: simplify namespace generation
Use nested namespaces in the server interface definitions to
simplify the mako template.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6f17d
sdbus++: simplify namespace generation
Use nested namespaces in the server interface definitions to
simplify the mako template.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6f17dd4069c818f9836cd47eb56926adeaa41b6e
show more ...
|
| 018b8ff1 | 05-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
shell: reformat with beautysh
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2717d31983fd17fab557bb92fc55e08e248f1159 |
| 6ec4fd75 | 05-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
black: reformat python scripts
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idf22526cce52cae58acacd7970cfe7efa1f564cd |
| 16a9a701 | 18-Nov-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: remove old 'NEW_CAMELCASE' define
All code is moved over to the new camelcase format, so remove
the #define.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I99bf1276acce70e
sdbus++: remove old 'NEW_CAMELCASE' define
All code is moved over to the new camelcase format, so remove
the #define.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I99bf1276acce70e60529b55be757bd2dcbb8784a
show more ...
|
| 44c6013c | 24-Oct-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: remove 'path' type
The type 'path' is ambiguous because it really isn't file-system
paths but dbus object paths. A while ago 'object_path' was added
for more clarity and 'path' has been de
sdbus++: remove 'path' type
The type 'path' is ambiguous because it really isn't file-system
paths but dbus object paths. A while ago 'object_path' was added
for more clarity and 'path' has been deprecated. All uses of 'path'
in phosphor-dbus-interfaces has been updated and it is a trivial fix
for any other downstream users. Removing 'path' so that the older
typename is no longer used.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icbbbe59538ca3f910a401dced51c239278b76194
show more ...
|
| 5c52484c | 13-Sep-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++-gendir: remove deprecated script
The sdbus++-gendir script has been deprecated for a while and removed
from all external users in the openbmc org. The internal usage
was also removed recent
sdbus++-gendir: remove deprecated script
The sdbus++-gendir script has been deprecated for a while and removed
from all external users in the openbmc org. The internal usage
was also removed recently, so fully delete this script.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6ceb7cceb59b36b6763d19682d09110cb8de386f
show more ...
|
| ce8d16d9 | 07-Sep-2022 |
Willam A. Kennington III <wak@google.com> |
treewide: Leverage sdbus++-gen-meson
This makes us more consistent with other projects instead of writing
meson builds for sdbus++ by hand.
Change-Id: I38b69bc67b6a3d80cda1b508a76e106a50d8ab93
Sign
treewide: Leverage sdbus++-gen-meson
This makes us more consistent with other projects instead of writing
meson builds for sdbus++ by hand.
Change-Id: I38b69bc67b6a3d80cda1b508a76e106a50d8ab93
Signed-off-by: Willam A. Kennington III <wak@google.com>
show more ...
|
| 293c8a26 | 02-Sep-2022 |
William A. Kennington III <wak@google.com> |
sdbus++: Fix meson dependency generation
All of the generated meson files optionally look for sdbus++ sources
that can be plumbed in to allow changes to the generator code to
correctly trigger rebui
sdbus++: Fix meson dependency generation
All of the generated meson files optionally look for sdbus++ sources
that can be plumbed in to allow changes to the generator code to
correctly trigger rebuilds.
This will require adding a new variable prior to generated sources,
`sdbusplusplus_depfiles`. You can convert previous meson defitions with
the follwing.
```
sdbusplus_dep = dependency('sdbusplus')
sdbusplusplus_prog = find_program('sdbus++', native: true)
sdbuspp_gen_meson_prog = find_program('sdbus++-gen-meson', native: true)
sdbusplusplus_depfiles = files()
if sdbusplus_dep.type_name() == 'internal'
sdbusplusplus_depfiles = subproject('sdbusplus').get_variable('sdbusplusplus_depfiles')
endif
```
Change-Id: Ic2d5bafdbdd2595be8c44e0e616e590143639f21
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| 76e37d49 | 02-Sep-2022 |
William A. Kennington III <wak@google.com> |
tools: Remove extra symlinks
We can just re-order the override statements to have the same effect.
Change-Id: I335174974e6162729a2a6940bae3bfb87fb25dfd
Signed-off-by: William A. Kennington III <wak
tools: Remove extra symlinks
We can just re-order the override statements to have the same effect.
Change-Id: I335174974e6162729a2a6940bae3bfb87fb25dfd
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| d77548a1 | 29-Apr-2022 |
Patrick Williams <patrick@stwcx.xyz> |
shellcheck: fix issues
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8d2f299a29a4fd8cf97ea238a982c15bae549207 |
| 36071788 | 19-Aug-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: handle 'DHCP{4,6}' better
The enum identifier 'DHCP4' was becoming 'dhcP4'. Revise the
`lower_camel_case` function to better handle this so it becomes
'dhcp4'.
Signed-off-by: Patrick Will
sdbus++: handle 'DHCP{4,6}' better
The enum identifier 'DHCP4' was becoming 'dhcP4'. Revise the
`lower_camel_case` function to better handle this so it becomes
'dhcp4'.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id999c4873e7c4c914dd03acd46144365aec066db
show more ...
|
| b78b1256 | 14-Apr-2022 |
Patrick Williams <patrick@stwcx.xyz> |
python: minor format fix
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia21b15bc9abc9cbd6c9dc19ff1788b7b398ac58e |
| 4dd3e299 | 21-Mar-2022 |
Patrick Williams <patrick@stwcx.xyz> |
meson: enable override_find_program for subprojects
When sdbusplus is used as a meson subproject it is helpful to have a
section like:
```
[provide]
sdbusplus = sdbusplus_dep
program_na
meson: enable override_find_program for subprojects
When sdbusplus is used as a meson subproject it is helpful to have a
section like:
```
[provide]
sdbusplus = sdbusplus_dep
program_names = sdbus++, sdbus++-gen-meson
```
This allows a project to easily find both the 'sdbusplus' dependency
without manually setting a 'fallback' and it allows it to obtain the
typically used programs utilizing the `find_program`. Doing this
requires usage of the `meson.override_find_program` in the subproject.
Meson doesn't like it if you pass an already `find_program` result into
the `override_find_program`. The typical expectation from meson appears
to be that you are exporting a program you've compiled rather than an
existing script. In order to work around this, add a simple indirection
where we symlink all of the executables to the same name prefixed with a
dot.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I23ab97d85c4c43d4e5ad0da00491b75ff03e110d
show more ...
|
| e4096f85 | 14-Mar-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++-gen-meson: fix shfmt introduced issue
The meson files generated in PDI were missing entries and caused CI
checks to break. This was caused by a mistake in the shfmt for bash
array syntax, w
sdbus++-gen-meson: fix shfmt introduced issue
The meson files generated in PDI were missing entries and caused CI
checks to break. This was caused by a mistake in the shfmt for bash
array syntax, which it assumed was a division operation and not a
string concatenation operation. Work around it by determining the
array key to split the two up.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If28d36347af36d164d655003fcb85e6cc47c5d15
show more ...
|
| 6f5ffc60 | 12-Mar-2022 |
Patrick Williams <patrick@stwcx.xyz> |
python: format with black,flake8,isort
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I08301dca84e3f0031cf9c79f7279cce20df3807a |
| 9ede18b4 | 12-Mar-2022 |
Patrick Williams <patrick@stwcx.xyz> |
shell: format with shfmt
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86a7c52c32a14bf0a1184b6d7dc50112c49ade91 |
| dce747bc | 16-Feb-2022 |
Ed Tanous <edtanous@google.com> |
Fix "x" in shellcheck
As seen here, the newest version of shellcheck flags this pattern of
if [ "x" == "x$1" ]
as no longer needed.
https://jenkins.openbmc.org/job/CI-MISC/job/ci-openbmc-build-scri
Fix "x" in shellcheck
As seen here, the newest version of shellcheck flags this pattern of
if [ "x" == "x$1" ]
as no longer needed.
https://jenkins.openbmc.org/job/CI-MISC/job/ci-openbmc-build-scripts/456/console
Interestingly, this actually causes openbmc-build-scripts to fail as a
project, which I don't fully understand why, but this seems unimportant
to the low effort, low impact fix to that it required.
Tested: I have no idea what this script does or how to test it, based on
the name I assume CI testing is enough, but changes were suggested by
the robot, and seem trivial.
Related change to scripts within openbmc-build-scripts:
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc-build-scripts/+/51279
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ibaa1dbf788a0dbc4be28cf124b6677fb8cb9b99b
show more ...
|
| e1353143 | 15-Dec-2021 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: property: invalid Python symbol
The `is_enum` function tried to use `false` when it meant `False`.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6fb52ee49acad48861ef7c832
sdbus++: property: invalid Python symbol
The `is_enum` function tried to use `false` when it meant `False`.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6fb52ee49acad48861ef7c83246d93973eab1bc0
show more ...
|
| a735ca5c | 19-Nov-2021 |
Patrick Williams <patrick@stwcx.xyz> |
vtable: shorten vtable type
Create an alias `sdbusplus::vtable_t` to `sdbusplus::vtable::vtable_t`
to reduce duplication.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0c3a8e40827
vtable: shorten vtable type
Create an alias `sdbusplus::vtable_t` to `sdbusplus::vtable::vtable_t`
to reduce duplication.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0c3a8e40827cb011a07d75c99550a371afdefc64
show more ...
|