#
74eea519 |
| 03-Jan-2025 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++-gen-meson: leverage `install_dir` for custom targets
Meson has had a `install_dir` directive on `custom_target` which allows specifying per-output where the file should be installed. Leverag
sdbus++-gen-meson: leverage `install_dir` for custom targets
Meson has had a `install_dir` directive on `custom_target` which allows specifying per-output where the file should be installed. Leveraging this greatly simplifies the meson in consumers (such as phosphor-dbus-interfaces) and makes the install less error-prone.
The previous method for installing was to use a `install_subdir` call with large exclude lists (so that markdown did not end up in the include tree). The result of this was that many empty directories were created in the include, markdown, and registry install paths.
Using this method reduces by 25% the meson content in phosphor-dbus-interfaces.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I2b03116f517caa75de902ac7e44e6923d6652cad
show more ...
|
#
31607399 |
| 02-Jan-2025 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: events: add meson support for registry generation
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ia8b95c291256726fdb729bcf886fa7f664ead4a5
|
#
0ac157a0 |
| 23-Sep-2024 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++-gen-meson: fix [more] meson dependencies
As a follow on to 5800d07910384ffad8409515bc510812e4f34334, additional cases were noticed where the meson dependencies are not correctly updated when
sdbus++-gen-meson: fix [more] meson dependencies
As a follow on to 5800d07910384ffad8409515bc510812e4f34334, additional cases were noticed where the meson dependencies are not correctly updated when multiple YAML files are used (such as interfaces and events).
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ie47bc156c2b3954d3c47c9d07a2e106d7cc87c63
show more ...
|
#
0336a2fc |
| 05-Sep-2024 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: add stubs to generate event files
Add options to `sdbus++` to generate the files for `events.yaml` files: header, cpp, markdown. Create simple stubs for these that generate empty files. E
sdbus++: add stubs to generate event files
Add options to `sdbus++` to generate the files for `events.yaml` files: header, cpp, markdown. Create simple stubs for these that generate empty files. Enable them in `sdbus++-gen-meson` and add an example for the Calculator.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ia1df9ca02e1de5fc3f6dadfd409d646e1341a3d6
show more ...
|
#
5800d079 |
| 16-Sep-2024 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++-gen-meson: fix meson dependencies
When multiple YAML files are used (for example both interface and error) only the `interface.yaml` was ending up in the generated `inputs` field in the `cus
sdbus++-gen-meson: fix meson dependencies
When multiple YAML files are used (for example both interface and error) only the `interface.yaml` was ending up in the generated `inputs` field in the `custom_target`. This made it so that changes in the other YAML files were not causing rebuilds.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ib550aade282ceca97f31a435d51f35e7de592224
show more ...
|
#
6403d56f |
| 18-Aug-2023 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: async: server: add generator stub
Add the needful changes in the tools and meson-generator to create an asynchronous server binding header.
Signed-off-by: Patrick Williams <patrick@stwcx.x
sdbus++: async: server: add generator stub
Add the needful changes in the tools and meson-generator to create an asynchronous server binding header.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I0607aefc006eafb9224d92b887cf2d3b30c8da06
show more ...
|
#
1caa5e8a |
| 19-Apr-2023 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++: add common header file
There are some items generated under server and client which are overlapping and some currently in server that will also be needed for async bindings. Create a commo
sdbus++: add common header file
There are some items generated under server and client which are overlapping and some currently in server that will also be needed for async bindings. Create a common header file that they can all include in order to reduce the content generated across all these types.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Id7af8542613503dbd745158c89892ca252eadf5a
show more ...
|
#
60a94305 |
| 06-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Fix meson warning
Meson warns on the calls to run_command.
WARNING: You should add the boolean check kwarg to the run_command call. It currently defaults to false, but it will default to true in fu
Fix meson warning
Meson warns on the calls to run_command.
WARNING: You should add the boolean check kwarg to the run_command call. It currently defaults to false, but it will default to true in future releases of meson. See also: https://github.com/mesonbuild/meson/issues/9300
This commit does as meson recommends, and adds check: true to all run_command calls, which will be the default.
Change-Id: I281df6ed32c935ce7d3664a0ad628cc81dbac3a8 Signed-off-by: Ed Tanous <edtanous@google.com>
show more ...
|
#
018b8ff1 |
| 05-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
shell: reformat with beautysh
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I2717d31983fd17fab557bb92fc55e08e248f1159
|
#
ce8d16d9 |
| 07-Sep-2022 |
Willam A. Kennington III <wak@google.com> |
treewide: Leverage sdbus++-gen-meson
This makes us more consistent with other projects instead of writing meson builds for sdbus++ by hand.
Change-Id: I38b69bc67b6a3d80cda1b508a76e106a50d8ab93 Sign
treewide: Leverage sdbus++-gen-meson
This makes us more consistent with other projects instead of writing meson builds for sdbus++ by hand.
Change-Id: I38b69bc67b6a3d80cda1b508a76e106a50d8ab93 Signed-off-by: Willam A. Kennington III <wak@google.com>
show more ...
|
#
293c8a26 |
| 02-Sep-2022 |
William A. Kennington III <wak@google.com> |
sdbus++: Fix meson dependency generation
All of the generated meson files optionally look for sdbus++ sources that can be plumbed in to allow changes to the generator code to correctly trigger rebui
sdbus++: Fix meson dependency generation
All of the generated meson files optionally look for sdbus++ sources that can be plumbed in to allow changes to the generator code to correctly trigger rebuilds.
This will require adding a new variable prior to generated sources, `sdbusplusplus_depfiles`. You can convert previous meson defitions with the follwing.
``` sdbusplus_dep = dependency('sdbusplus') sdbusplusplus_prog = find_program('sdbus++', native: true) sdbuspp_gen_meson_prog = find_program('sdbus++-gen-meson', native: true) sdbusplusplus_depfiles = files() if sdbusplus_dep.type_name() == 'internal' sdbusplusplus_depfiles = subproject('sdbusplus').get_variable('sdbusplusplus_depfiles') endif ```
Change-Id: Ic2d5bafdbdd2595be8c44e0e616e590143639f21 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
#
d77548a1 |
| 29-Apr-2022 |
Patrick Williams <patrick@stwcx.xyz> |
shellcheck: fix issues
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I8d2f299a29a4fd8cf97ea238a982c15bae549207
|
#
e4096f85 |
| 14-Mar-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++-gen-meson: fix shfmt introduced issue
The meson files generated in PDI were missing entries and caused CI checks to break. This was caused by a mistake in the shfmt for bash array syntax, w
sdbus++-gen-meson: fix shfmt introduced issue
The meson files generated in PDI were missing entries and caused CI checks to break. This was caused by a mistake in the shfmt for bash array syntax, which it assumed was a division operation and not a string concatenation operation. Work around it by determining the array key to split the two up.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: If28d36347af36d164d655003fcb85e6cc47c5d15
show more ...
|
#
9ede18b4 |
| 12-Mar-2022 |
Patrick Williams <patrick@stwcx.xyz> |
shell: format with shfmt
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I86a7c52c32a14bf0a1184b6d7dc50112c49ade91
|
#
dce747bc |
| 16-Feb-2022 |
Ed Tanous <edtanous@google.com> |
Fix "x" in shellcheck
As seen here, the newest version of shellcheck flags this pattern of if [ "x" == "x$1" ] as no longer needed.
https://jenkins.openbmc.org/job/CI-MISC/job/ci-openbmc-build-scri
Fix "x" in shellcheck
As seen here, the newest version of shellcheck flags this pattern of if [ "x" == "x$1" ] as no longer needed.
https://jenkins.openbmc.org/job/CI-MISC/job/ci-openbmc-build-scripts/456/console
Interestingly, this actually causes openbmc-build-scripts to fail as a project, which I don't fully understand why, but this seems unimportant to the low effort, low impact fix to that it required.
Tested: I have no idea what this script does or how to test it, based on the name I assume CI testing is enough, but changes were suggested by the robot, and seem trivial.
Related change to scripts within openbmc-build-scripts: https://gerrit.openbmc-project.xyz/c/openbmc/openbmc-build-scripts/+/51279
Signed-off-by: Ed Tanous <edtanous@google.com> Change-Id: Ibaa1dbf788a0dbc4be28cf124b6677fb8cb9b99b
show more ...
|
#
a42e97a6 |
| 17-May-2021 |
William A. Kennington III <wak@google.com> |
sdbus++-gen-meson: Don't build markdown by default
Not all builds want the markdown (notably subproject builds) and we can trivially create a target to build and install it.
``` custom_target(
sdbus++-gen-meson: Don't build markdown by default
Not all builds want the markdown (notably subproject builds) and we can trivially create a target to build and install it.
``` custom_target( 'md', command: 'true', output: 'md', capture: true, depends: generated_others, build_by_default: true) ```
This increments the version counter to ensure users notice the behavior change.
Change-Id: I55fd995d8ab27b2f06d3c382b3379bd36ba10c6f Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
#
56eb1775 |
| 18-May-2021 |
William A. Kennington III <wak@google.com> |
sdbus++-gen-meson: Support non-source root yaml directories
Right now, this tool assumes that the input root directory is the source root. Some of our packages have their yaml files in non-root dire
sdbus++-gen-meson: Support non-source root yaml directories
Right now, this tool assumes that the input root directory is the source root. Some of our packages have their yaml files in non-root directories and we want to support them.
Change-Id: I7e20a0a0966786ae0cbbef64522dc2993a2d074a Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
#
d9bb33e2 |
| 15-Apr-2021 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++-gen-meson: switch to project_source_root
The meson call 'source_root' is deprecated in 0.56 and is incorrect when the project using gen-meson is used as a subproject. Switch to 'project_sou
sdbus++-gen-meson: switch to project_source_root
The meson call 'source_root' is deprecated in 0.56 and is incorrect when the project using gen-meson is used as a subproject. Switch to 'project_source_root', which was introduced in 0.56, and is the correct replacement for the deprecated 'source_root' ('global_source_root' is incorrect for use in a sub-project).
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I6053f547ab48ee7c9f31acf966b94cda15a1d53b
show more ...
|
#
a4c9edc1 |
| 17-Dec-2020 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++-gen-meson: force locale for stable sort
Locale affects certain tools like `sort`. Force the locale to the POSIX ("C") locale for stability no matter what the user has set.
Signed-off-by: P
sdbus++-gen-meson: force locale for stable sort
Locale affects certain tools like `sort`. Force the locale to the POSIX ("C") locale for stability no matter what the user has set.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Id8993f6efcbee1904d8b068ac4bf328a630c0116
show more ...
|
#
847a0c37 |
| 24-Jun-2020 |
Patrick Williams <patrick@stwcx.xyz> |
sdbus++-gen-meson: create tool for helping with meson
The previous attempt at a meson-helper tool (sdbus++-gendir) had some usability issues integrating with meson that was not agreeable to other de
sdbus++-gen-meson: create tool for helping with meson
The previous attempt at a meson-helper tool (sdbus++-gendir) had some usability issues integrating with meson that was not agreeable to other developers. The two main complaints were that it did not automatically catch changes to YAML files and it re-ran the processing on every YAML file.
The new direction is to create this helper tool which will generate a tree of meson.build files that can be checked in directly to a repository and updated whenever a YAML file is added (or removed).
This tool will both create the tree of meson.build necessary for generating all C++/header and markdown files. The meson targets created by the tool also contain callbacks into this tool to abstract details on which / how sdbus++ is called to generate the output files.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I410ad2121274b2ba9e6f14985bc7b6a2c92e65e7
show more ...
|