message: Fix variant api usage

This makes our use of the mapbox variant consistent with std::variant.
We need this cleanup for the conversion to std::variant.

Tested:
Ran unit tests to make sur

message: Fix variant api usage

This makes our use of the mapbox variant consistent with std::variant.
We need this cleanup for the conversion to std::variant.

Tested:
Ran unit tests to make sure they still pass.

Change-Id: I990013eaaa2ec27f2fda71bfadd9a5369d50c187
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clang-format: Fix pointer alignment

Oenbmc documentation specifies a left alignment for pointers. Our
current format tries to left align if neither alignment is strictly
followed, but will allow rig

clang-format: Fix pointer alignment

Oenbmc documentation specifies a left alignment for pointers. Our
current format tries to left align if neither alignment is strictly
followed, but will allow right aligned files to exist. Lets make this
more strict so that all of our files are consistent.

Change-Id: I3a50043d28a9c25d0cf1ffb752800d05eb7615e1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clang-format: always break template declarations

To better match the defined openbmc style.

Change-Id: I68cda43857768bae4c904c367942cb1f0efa3e0c
Signed-off-by: Patrick Venture <venture@google.com>

update .clang-format header inclusion order

Added the header inclusion order to the .clang-format file generated
these changes.

Change-Id: Ia31b21d7ea451cac0309828006bc17c27cbd5bd5
Signed-off-by: P

update .clang-format header inclusion order

Added the header inclusion order to the .clang-format file generated
these changes.

Change-Id: Ia31b21d7ea451cac0309828006bc17c27cbd5bd5
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

test/message/read: Test that our error handling cases work

This improves our test coverage of sd_bus_message read functionality to
100%.

Tested:
Ran through the usual unit test scripts includin

test/message/read: Test that our error handling cases work

This improves our test coverage of sd_bus_message read functionality to
100%.

Tested:
Ran through the usual unit test scripts including valgrind and code
coverage.

Change-Id: Ifa849d05364349e27e39c6dda5e4cab4efa35476
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/message/read: Add missing variant skip

We were missing a test of the variant code which is used when the type
of the variant provided by the caller does not contain the type needed
at runtime t

test/message/read: Add missing variant skip

We were missing a test of the variant code which is used when the type
of the variant provided by the caller does not contain the type needed
at runtime to store the data in the message. This tests to make sure
that the skip is issued correctly when we can't read out the member.

Tested:
Unit tests still build and pass

Change-Id: I41fdc3e40589f1feedfadc3ab33fe808ff3a6d16
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/message/read: Use googletest and mocks

Similar to the append test, this test case relied on an ad-hoc system
using a separate daemon thread for echoing the messages back to each of
the unit tes

test/message/read: Use googletest and mocks

Similar to the append test, this test case relied on an ad-hoc system
using a separate daemon thread for echoing the messages back to each of
the unit tests. We don't want to depend on a system dbus instance if we
can avoid it. Instead, use the mocking system to make sure the correct
dbus calls are made when reading messages and ensure the resulting
output is built as expected.

Tested:
Build still works and all test cases pass. Ensured that the coverage
of the tests is the same as the old test cases.

Change-Id: I8d71c031391b962f1de6684d927b81e132c0886d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/message/append: Use googletest and mocks

The current test case depends on the system running a dbus daemon that
our test case can register and run a service with. It runs in multiple
threads an

test/message/append: Use googletest and mocks

The current test case depends on the system running a dbus daemon that
our test case can register and run a service with. It runs in multiple
threads and requires using raw sd_bus_message calls to determine if the
appends worked correctly. When systemd 237 becomes the minimum version
we could rely on message sealing and other new public members to deal
with the daemon issues. However, it will be a while before we can make
that the default version.

Lets mock out the expectations for the underlying sd_bus_message calls
to validate that we will build correct objects when using our
message.append() calls.

Tested:
Converted the tests from the old test cases to this new format
keeping very similar test functionality. Tests still pass.

Change-Id: Iafc8662389fe60ca2d519abfe472c61292f3239a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

tests: Write our own assert()

The cassert `assert()` function is only provided when NDEBUG is not
defined. Otherwise `assert()` becomes a no-op breaking our test cases.
Since we rely on the behavior

tests: Write our own assert()

The cassert `assert()` function is only provided when NDEBUG is not
defined. Otherwise `assert()` becomes a no-op breaking our test cases.
Since we rely on the behavior of assert to validate the tests, we always
want to provide one for the test implementation. This functionality will
be useful once code coverage is added since that forces NDEBUG to be
passed to the preprocessor.

Tested:
Test cases still work correctly if unmodified, and any changes that
should cause the asserts to fail still fail as expected.

Change-Id: I8d4132058308566310c58b7ae3e121eae55d37f5
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

tests: Fix memory leak from sd_bus calls

Some of the calls into sd_bus leak memory because they never unreference
the bus or messages. Fix this so we can eventually enable leak checking
from valgrin

tests: Fix memory leak from sd_bus calls

Some of the calls into sd_bus leak memory because they never unreference
the bus or messages. Fix this so we can eventually enable leak checking
from valgrind.

Tested:
Ran through valgrind and the errors went away.

Change-Id: Icc3d5d0860b3852401219c1ca511a1bc26aa1c48
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Allow reading and appending of more complex types

This commit makes sdbusplus compatible with most containers that meet
a few requirements. This includes:
std::unordered_map
std::array
std::set
boo

Allow reading and appending of more complex types

This commit makes sdbusplus compatible with most containers that meet
a few requirements. This includes:
std::unordered_map
std::array
std::set
boost::flat_set
boost::flat_map

Read requires a container to support emplace or emplace_back methods.
Append requires a container to suport a const iterator

Tested: The top level OpenBMC compiles properly, and the sdbusplus
unit tests compile and pass, and unit tests have been updated with a
few new types to ensure we see any breakages.

Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: I5eb1cf7dc07bacc7aca62d87844794223ad4de80
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Update repo to conform to openbmc code standard

Change-Id: If1d6b1f04514367cc544c2507a845b3e9d6d3435
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

test: convert message_native_types to gtest

Change-Id: I8aa9e996505d3083ff5650c3fa5107d4143ff482
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

test: convert message_types to gtest

Change-Id: Ifb5d2b9f4cb5c6700f5c0164466cc5289ee40a26
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

message-append: Add more string test cases

Add cases uncovered by openbmc/openbmc#1025.

Change-Id: I680b95b2127d50837dccd3ea1ff655fc1eb19ec9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

Allow implicit string_wrapper conversions

Add comparison operators to allow string_wrappers
to be implicity converted to strings for comparisons to
cut down on casting and/or str member access.

Do

Allow implicit string_wrapper conversions

Add comparison operators to allow string_wrappers
to be implicity converted to strings for comparisons to
cut down on casting and/or str member access.

Do not allow std::string to be impliclitly converted
to object_path to avoid a temporary string copy.

Change-Id: I2e45a4fc3ee07d1df55f6fab2cfa35da205c150e
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

message: allow obj-path and sig in STL containers

Allow object_path and signatures to be used in std::vector,
std::map, and std::unordered_map.

Change-Id: Ieb592aa518bfae08da393632a1dd0ed0dd684c7a

message: allow obj-path and sig in STL containers

Allow object_path and signatures to be used in std::vector,
std::map, and std::unordered_map.

Change-Id: Ieb592aa518bfae08da393632a1dd0ed0dd684c7a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

message-read: support obj-path and signature

Change-Id: Iafc2f26a10f0c5c84805e1d28bea8f17eaadc03c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

message-append: support obj-path and signature

Change-Id: I44d5195eba14c17f38cf2bf2b09eb071d54f59d8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

message-types: support obj-path and signature

Change-Id: I7cb1563af3375f2a8b22c78ac59f7e69f176933f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

message: Add class for object-path and signatures

Change-Id: I1ca54ecc5d4033c41738bd224399f80b95094430
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

append/read: additional testcases for bool forms

Added test-cases for false r-value reference and l-values,
in addition to existing false value.

Change-Id: I36952f06d84f9da157a618fbe093a8ca63662ceb

append/read: additional testcases for bool forms

Added test-cases for false r-value reference and l-values,
in addition to existing false value.

Change-Id: I36952f06d84f9da157a618fbe093a8ca63662ceb
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

message: testcase to read missing variant type

Commit ac52113 fixed an issue where reading a variant from a
message when the C++ variant did not contain the type of the
dbus variant caused the messa

message: testcase to read missing variant type

Commit ac52113 fixed an issue where reading a variant from a
message when the C++ variant did not contain the type of the
dbus variant caused the message to get into an invalid state.

Add a testcase for this condition.

Change-Id: Iea58a4440d72a1d2969d80f782ec1f316cb5ff29
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

message: fix parallel test issue

Both message/append and message/read were using the same
service name for testcases. Ensure they use different service
names to allow parallel execution of test cas

message: fix parallel test issue

Both message/append and message/read were using the same
service name for testcases. Ensure they use different service
names to allow parallel execution of test cases.

Change-Id: I060c03f69db0484b863af7cb45578f183cdff331
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

message: compile warning in testcases

Thread functions (non-void) were missing a return.

Change-Id: Ib7804d92f79b96428285058101e64dceea7ad66e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>