30827bad | 23-Apr-2020 |
Philippe Mathieu-Daudé <philmd@redhat.com> |
chardev: Extract system emulation specific code
Split out code only used during system emulation, to reduce code pulled in user emulation and tools.
Signed-off-by: Philippe Mathieu-Daudé <philmd@re
chardev: Extract system emulation specific code
Split out code only used during system emulation, to reduce code pulled in user emulation and tools.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20200423202112.644-6-philmd@redhat.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
show more ...
|
ffa0f7eb | 23-Apr-2020 |
Philippe Mathieu-Daudé <philmd@redhat.com> |
chardev: Reduce "char-mux.h" scope, rename it "chardev-internal.h"
No file out of chardev/ requires access to this header, restrict its scope.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.c
chardev: Reduce "char-mux.h" scope, rename it "chardev-internal.h"
No file out of chardev/ requires access to this header, restrict its scope.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20200423202112.644-5-philmd@redhat.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
show more ...
|
c383efd5 | 23-Apr-2020 |
Philippe Mathieu-Daudé <philmd@redhat.com> |
chardev: Restrict msmouse / wctablet / testdev to system emulation
The msmouse / wctablet / testdev character devices are only used by system emulation. Remove them from user mode and tools.
Signed
chardev: Restrict msmouse / wctablet / testdev to system emulation
The msmouse / wctablet / testdev character devices are only used by system emulation. Remove them from user mode and tools.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20200423202112.644-4-philmd@redhat.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
show more ...
|
68066019 | 20-Apr-2020 |
Marc-André Lureau <marcandre.lureau@redhat.com> |
char: fix use-after-free with dup chardev & reconnect
With a reconnect socket, qemu_char_open() will start a background thread. It should keep a reference on the chardev.
Fixes invalid read: READ o
char: fix use-after-free with dup chardev & reconnect
With a reconnect socket, qemu_char_open() will start a background thread. It should keep a reference on the chardev.
Fixes invalid read: READ of size 8 at 0x6040000ac858 thread T7 #0 0x5555598d37b8 in unix_connect_saddr /home/elmarco/src/qq/util/qemu-sockets.c:954 #1 0x5555598d4751 in socket_connect /home/elmarco/src/qq/util/qemu-sockets.c:1109 #2 0x555559707c34 in qio_channel_socket_connect_sync /home/elmarco/src/qq/io/channel-socket.c:145 #3 0x5555596adebb in tcp_chr_connect_client_task /home/elmarco/src/qq/chardev/char-socket.c:1104 #4 0x555559723d55 in qio_task_thread_worker /home/elmarco/src/qq/io/task.c:123 #5 0x5555598a6731 in qemu_thread_start /home/elmarco/src/qq/util/qemu-thread-posix.c:519 #6 0x7ffff40d4431 in start_thread (/lib64/libpthread.so.0+0x9431) #7 0x7ffff40029d2 in __clone (/lib64/libc.so.6+0x1019d2)
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Message-Id: <20200420112012.567284-1-marcandre.lureau@redhat.com>
show more ...
|
14a7a203 | 06-Jul-2020 |
Marc-André Lureau <marcandre.lureau@redhat.com> |
chardev: don't abort on attempt to add duplicated chardev
This is a regression from commit d2623129a7d ("qom: Drop parameter @errp of object_property_add() & friends").
(qemu) chardev-add id=null,b
chardev: don't abort on attempt to add duplicated chardev
This is a regression from commit d2623129a7d ("qom: Drop parameter @errp of object_property_add() & friends").
(qemu) chardev-add id=null,backend=null (qemu) chardev-add id=null,backend=null Unexpected error in object_property_try_add() at /home/elmarco/src/qemu/qom/object.c:1166: attempt to add duplicate property 'null' to object (type 'container')
That case is currently not covered in the test suite, but will be with the queued patch "char: fix use-after-free with dup chardev & reconnect".
Fixes: d2623129a7dec1d3041ad1221dda1ca49c667532 Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com>
show more ...
|