pldmtool : Migrate to placement_new from reinterpret casting

reinterpret_cast is prohibited by the C++ core guidelines because
it takes the behavior outside the language definition and gives
problem

pldmtool : Migrate to placement_new from reinterpret casting

reinterpret_cast is prohibited by the C++ core guidelines because
it takes the behavior outside the language definition and gives
problems with type safety. Placement-new on the other-hand allows
to control the object storage while still properly instantiating
an object,keeping the behavior inside the C++ language
specification.

Change-Id: Iaebfaa78c4d3c0c3658dbf9f2f6eaa932b061e83
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I95f756bab7f403af49a94011bbb1fe4e51f985ad
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I95f756bab7f403af49a94011bbb1fe4e51f985ad
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

Change-Id: If9e6c34c48821a7cf8577a2166727ce7db06fadc
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

pldmtool: GetPLDMCommands: Support more PLDM Base command numbers

Add more supported PLDM Base command numbers in table "Table 7 - PLDM
Messaging Control and Discovery Command Codes" of DSP0240 V1.2

pldmtool: GetPLDMCommands: Support more PLDM Base command numbers

Add more supported PLDM Base command numbers in table "Table 7 - PLDM
Messaging Control and Discovery Command Codes" of DSP0240 V1.2.0 when
`GetPLDMCommands` is called.

Change-Id: I63a326594b3d5e9ed3fb435746dc07d1b84cbf19
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

pldmtool: GetPLDMCommands: Support more PLDM Platform command numbers

Support more supported PLDM platform command numbers in table "Table 110
- Command numbers" of DSP0248 V1.3.0 when `GetPLDMComma

pldmtool: GetPLDMCommands: Support more PLDM Platform command numbers

Support more supported PLDM platform command numbers in table "Table 110
- Command numbers" of DSP0248 V1.3.0 when `GetPLDMCommands` is called.

Change-Id: Id8d706a41602010bee67b2aaea621766883da9cb
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

clang-tidy: Enable modernize-deprecated-headers check

Some headers from C library were deprecated in C++ and are no
longer welcome in C++ codebases. Some have no effect in C++ [1].

[1]: https://rel

clang-tidy: Enable modernize-deprecated-headers check

Some headers from C library were deprecated in C++ and are no
longer welcome in C++ codebases. Some have no effect in C++ [1].

[1]: https://releases.llvm.org/13.0.1/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-deprecated-headers.html

Change-Id: Ia3b1df10175e2e661c8fffb82e357c9db81b2e9c
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable bugprone-branch-clone check

This checks for repeated branches in if/else if/else chains,
consecutive repeated branches in switch statements and identical
true and false branches i

clang-tidy: Enable bugprone-branch-clone check

This checks for repeated branches in if/else if/else chains,
consecutive repeated branches in switch statements and identical
true and false branches in conditional operators.

Change-Id: I8776742c25f3f8c97617976ec4f6fc799aa249ae
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

Format meson files with meson.format

Meson 1.5.0 introduced a new feature to format all the meson
files. Formatting all the meson files is now as simple as running
`meson format -i -r` command in th

Format meson files with meson.format

Meson 1.5.0 introduced a new feature to format all the meson
files. Formatting all the meson files is now as simple as running
`meson format -i -r` command in the repository root folder.

more details : https://mesonbuild.com/Commands.html#format

Change-Id: I9c5468cc502ae78b7a055e2de2a10296930cb9ec
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I8c84201cb2343a8c8a5507a49de0721a1bee7063
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

pldm: Move off pldm_bios_table_attr_value_entry_encode_integer_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pl

pldm: Move off pldm_bios_table_attr_value_entry_encode_integer_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_value_entry_encode_integer_check.yaml
```

Change-Id: Ifdae4ebf848a43d9bd997292b35426b26dbf558c
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_value_entry_encode_string_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pld

pldm: Move off pldm_bios_table_attr_value_entry_encode_string_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_value_entry_encode_string_check.yaml
```

Change-Id: If3454dc8a7b2036c035d49b1e6d9ba1b23547138
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_value_entry_encode_enum_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_

pldm: Move off pldm_bios_table_attr_value_entry_encode_enum_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_value_entry_encode_enum_check.yaml
```

Change-Id: Id989540d8ad4ea114ee059992be4293254e1ecc2
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_string_decode_def_string_length_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions

pldm: Move off pldm_bios_table_attr_entry_string_decode_def_string_length_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_string_decode_def_string_length_check.yaml
```

gitlint-ignore: T1,B1
Change-Id: Ib7b44820870da32109981c8a8d44657214cf1d61
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pld

pldm: Move off pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_enum_decode_pv_hdls_check.yaml
```

Change-Id: I6dd0cf34f023aa1d4f806d0a24eb45ce5e822d12
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_enum_decode_def_num_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pld

pldm: Move off pldm_bios_table_attr_entry_enum_decode_def_num_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_enum_decode_def_num_check.yaml
```

Change-Id: I4a1777cf6b29ed8f1cf47770d058a3dd0b7c8e7b
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_enum_decode_pv_num_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm

pldm: Move off pldm_bios_table_attr_entry_enum_decode_pv_num_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_enum_decode_pv_num_check.yaml
```

Change-Id: I749ac6dd0423a82e16dc1a6d35bfec5a9041b565
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_string_entry_decode_string_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bi

pldm: Move off pldm_bios_table_string_entry_decode_string_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_string_entry_decode_string_check.yaml
```

Change-Id: I085a4b6bbd8a08db19156ab404d5dde6a20d32ba
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

clang-diagnostic error: error: use of undeclared identifiers

Clang was throwing use of undeclared identifiers for 'std',
'uint8_t', 'uint16_t' and expected unqualified-id errors
due to missing inclu

clang-diagnostic error: error: use of undeclared identifiers

Clang was throwing use of undeclared identifiers for 'std',
'uint8_t', 'uint16_t' and expected unqualified-id errors
due to missing inclusions.

Change-Id: I072eb27ee7a89e215afdd10f095b82c12be62599
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

pldmtool: Fix missing range begin

Iterating through the composite effecter count
could result in a seg fault

Tested:
```
root@bmc:~# pldmtool platform GetStateEffecterStates -m 9 -i 1323 -v
pldmtoo

pldmtool: Fix missing range begin

Iterating through the composite effecter count
could result in a seg fault

Tested:
```
root@bmc:~# pldmtool platform GetStateEffecterStates -m 9 -i 1323 -v
pldmtool: Tx: 80 02 3a 2b 05
pldmtool: Rx: 00 02 3a 00 08 01 00 01 01 00 01 01 00 01 01 00 01 01 00 01 01 00 01 01 00 01 01 00 01
{
"compositeEffecterCount": 8,
"effecterOpState[0])": "Effecter Enabled No Update Pending",
"pendingState[0]": 0,
"presentState[0]": 1,
"effecterOpState[1])": "Effecter Enabled No Update Pending",
"pendingState[1]": 0,
"presentState[1]": 1,
"effecterOpState[2])": "Effecter Enabled No Update Pending",
"pendingState[2]": 0,
"presentState[2]": 1,
"effecterOpState[3])": "Effecter Enabled No Update Pending",
"pendingState[3]": 0,
"presentState[3]": 1,
"effecterOpState[4])": "Effecter Enabled No Update Pending",
"pendingState[4]": 0,
"presentState[4]": 1,
"effecterOpState[5])": "Effecter Enabled No Update Pending",
"pendingState[5]": 0,
"presentState[5]": 1,
"effecterOpState[6])": "Effecter Enabled No Update Pending",
"pendingState[6]": 0,
"presentState[6]": 1,
"effecterOpState[7])": "Effecter Enabled No Update Pending",
"pendingState[7]": 0,
"presentState[7]": 1
}
```

Change-Id: I9c0f211478e30cda601fe163b4bbeaf3878dbecc
Signed-off-by: Tal Yacobi <talycb8@gmail.com>

show more ...

pldmtool: GetPLDMCommand: Support version option

`GetPLDMCommands` in DSP0240 v1.1.0 requires the PLDM supported type
version. In the current implementation, `pldmtool` always send `0xff
0xff 0xff 0

pldmtool: GetPLDMCommand: Support version option

`GetPLDMCommands` in DSP0240 v1.1.0 requires the PLDM supported type
version. In the current implementation, `pldmtool` always send `0xff
0xff 0xff 0xff` version to `GetPLDMCommand` with the assumption that the
terminus will response for the request with any version of PLDM type.

Some termini don't accept `0xff 0xff 0xff 0xff` as input
version to `GetPLDMCommands` command because value `0xff` only has
meaning `A value of 0xFF in the "update" field indicates that the field
to be ignored.` in the `Section 12.6.1 Version field encoding` in `MCTP
Base spec` DSP0236 v1.3.1 but not in `PLDM base spec` DSP0240 v1.1.0
where `GetPLDMCommand` is detailed.

Add `-d` option to allow the user input the PLDM supported type version
which is responded by terminus in `GetPLDMVersion` command. The input
version will be in hex format. eg version 1.1.0 will be input as `0x00
0xf0 0xf1 0xf1`.

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: I42a940ac6d8976b3630613211fcdbe1290895014

show more ...

pldmtool: Add GetStateEffecterStates command

Add GetStateEffecterStates command in pldmtool.
Used to get state effecter current and pending states
by supplying an effecter ID.

Tested:
```
root@bmc:

pldmtool: Add GetStateEffecterStates command

Add GetStateEffecterStates command in pldmtool.
Used to get state effecter current and pending states
by supplying an effecter ID.

Tested:
```
root@bmc:~# pldmtool platform GetStateEffecterStates -h
get the state effecter states
Usage: pldmtool platform GetStateEffecterStates [OPTIONS]

Options:
-h,--help Print this help message and exit
-m,--mctp_eid UINT MCTP endpoint ID
-v,--verbose
-n,--retry-count UINT Number of retry when PLDM request message is failed
-i,--effecter_id UINT REQUIRED
Effecter ID that is used to identify and access the effecter
root@bmc:~# pldmtool platform GetStateEffecterStates -m 9 -i 348
{
"compositeEffecterCount": 1,
"effecterOpState[0])": "Effecter Enabled No Update Pending",
"pendingState[0]": 1,
"presentState[0]": 1
}
```

Change-Id: Ib72d2181dec955367310d6218628bb26952346b2
Signed-off-by: Tal Yacobi <talycb8@gmail.com>

show more ...

pldmtool: support GetNextPart for GetPDR command

Current pldmtool assumes GetPDR command always have one PDR from each
response which causing incompleted PDR data if the devices have smaller
packet

pldmtool: support GetNextPart for GetPDR command

Current pldmtool assumes GetPDR command always have one PDR from each
response which causing incompleted PDR data if the devices have smaller
packet size limitation.

Add GetNextPart support for collecting a full PDR from multiple
commands.

Change-Id: Idf6805751e3870c65daf3e411c011b021992a912
Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

fix markdownlint issues reported in CI

There are a lot of warnings reported by markdownlint in the CI, this
commit aims at fixing all of them.

Tested :

No more warnings reported by markdownlint in

fix markdownlint issues reported in CI

There are a lot of warnings reported by markdownlint in the CI, this
commit aims at fixing all of them.

Tested :

No more warnings reported by markdownlint in the CI.

Change-Id: I92d24bc0efd230dd0974ff49853ef928caf1febd
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I539a0c5baa63be240fc1c76367c0af338dd89c7b
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

pldmtool: Add NumericSensor PDR

Added NumericSensor PDR to provide general sensor information,
such as the factors that are used for converting raw sensor
readings to normalized units, etc.

Tested

pldmtool: Add NumericSensor PDR

Added NumericSensor PDR to provide general sensor information,
such as the factors that are used for converting raw sensor
readings to normalized units, etc.

Tested result:
```
root@bmc:~# pldmtool platform getPdr -m9 -t numericSensor | head
[
,,,,,{
"nextRecordHandle": 1301,
"responseCount": 105,
"recordHandle": 1300,
"PDRHeaderVersion": 1,
"PDRType": "Numeric Sensor PDR",
"recordChangeNumber": 0,
"dataLength": 95,
"PLDMTerminusHandle": 100,
```

Change-Id: If64fc9d538dc673dacfba6e4c2dd2360cfe50a68
Signed-off-by: Ruslan Magomedov <velochimc@mail.ru>

show more ...