pldmbios: Adding a BIOS attribute that can limit the number of cores activated

Adding attribute "hb_field_core_override" that can be used to limit
the number of cores HB activates. The default is 0

pldmbios: Adding a BIOS attribute that can limit the number of cores activated

Adding attribute "hb_field_core_override" that can be used to limit
the number of cores HB activates. The default is 0 which is interpreted
as to activate all cores. If given value N which is not 0, then
for a fused core system 2N cores will be activated. For a non-fused
core system then N cores will be activated.

This is useful if a customer only wishes to activate N cores and not
activate all cores available.

Signed-off-by: Roland Veloz <rveloz@us.ibm.com>
Change-Id: Icca120b445810e1b7b8d41f0699ef87a4f0b6037

show more ...

Fix broken IBM OEM Unit tests

Tested Log:
ninja: no work to do.
1/28 libpldm_base_test OK 0.05s
2/28 libpldm_platform_test

Fix broken IBM OEM Unit tests

Tested Log:
ninja: no work to do.
1/28 libpldm_base_test OK 0.05s
2/28 libpldm_platform_test OK 0.04s
3/28 libpldm_bios_test OK 0.04s
4/28 libpldm_fru_test OK 0.03s
5/28 libpldm_utils_test OK 0.02s
6/28 libpldm_pdr_test OK 0.02s
7/28 ../../oem/ibm/test/libpldm_fileio_test OK 0.05s
8/28 ../../oem/ibm/test/libpldm_host_test OK 0.05s
9/28 libpldmresponder_base_test OK 0.05s
10/28 libpldmresponder_bios_test OK 0.04s
11/28 libpldmresponder_bios_attribute_test OK 0.04s
12/28 libpldmresponder_bios_string_attribute_test OK 0.06s
13/28 libpldmresponder_bios_integer_attribute_test OK 0.06s
14/28 libpldmresponder_bios_config_test OK 0.07s
15/28 libpldmresponder_bios_enum_attribute_test OK 0.06s
16/28 libpldmresponder_pdr_effecter_test OK 0.06s
17/28 libpldmresponder_pdr_sensor_test OK 0.05s
18/28 libpldmresponder_bios_table_test OK 0.07s
19/28 pldmd_instanceid_test OK 0.05s
20/28 pldmd_registration_test OK 0.05s
21/28 libpldmresponder_platform_test OK 0.07s
22/28 pldm_utils_test OK 0.05s
23/28 libpldmresponder_fru_test OK 0.04s
24/28 libpldmresponder_dbus_to_host_effecter_test OK 0.04s
25/28 ../oem/ibm/test/libpldmresponder_oem_platform_test OK 0.02s
26/28 ../oem/ibm/test/host_bmc_lamp_test OK 0.02s
27/28 ../oem/ibm/test/libpldmresponder_fileio_test OK 0.04s
28/28 libpldm_bios_table_test OK 2.14s

Ok: 28
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 0
Timeout: 0

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Iaacbefffebee252f0588db267c3e26f583a9edba

show more ...

bios: Add/remove bios attributes

A) Adding three bios attributes to the supported list. Newly
added bios attributes are:
1. pvm_system_operating_mode
2. pvm_rpa_boot_mode
3. pvm_os_ipl_type

B) Remo

bios: Add/remove bios attributes

A) Adding three bios attributes to the supported list. Newly
added bios attributes are:
1. pvm_system_operating_mode
2. pvm_rpa_boot_mode
3. pvm_os_ipl_type

B) Removed the unused bios attribute 'pvm_os_boot_side'.

Tested by:
Verified the values using the pldmtool, redfish and hyperviosr
macro.

1. pldmtool bios GetBIOSTable -t 1
{
"AttributeHandle": 23,
"AttributeNameHandle": "41(pvm_system_operating_mode)",
"AttributeType": "BIOSEnumeration",
"NumberOfPossibleValues": 2,
"PossibleValueStringHandle[0]": "15(Normal)",
"PossibleValueStringHandle[1]": "14(Manual)",
"NumberOfDefaultValues": 1,
"DefaultValueStringHandleIndex[0]": 0,
"StringHandle": "15(Normal)"
},
{
"AttributeHandle": 24,
"AttributeNameHandle": "36(pvm_rpa_boot_mode)",
"AttributeType": "BIOSEnumeration",
"NumberOfPossibleValues": 6,
"PossibleValueStringHandle[0]": "15(Normal)",
"PossibleValueStringHandle[1]": "23(SavedList)",
"PossibleValueStringHandle[2]": "24(SmsMenu)",
"PossibleValueStringHandle[3]": "18(OkPrompt)",
"PossibleValueStringHandle[4]": "7(DefaultList)",
"PossibleValueStringHandle[5]": "19(PblBootLid)",
"NumberOfDefaultValues": 1,
"DefaultValueStringHandleIndex[0]": 0,
"StringHandle": "15(Normal)"
},
{
"AttributeHandle": 25,
"AttributeNameHandle": "34(pvm_os_ipl_type)",
"AttributeType": "BIOSEnumeration",
"NumberOfPossibleValues": 4,
"PossibleValueStringHandle[0]": "1(A_Mode)",
"PossibleValueStringHandle[1]": "4(B_Mode)",
"PossibleValueStringHandle[2]": "5(C_Mode)",
"PossibleValueStringHandle[3]": "6(D_Mode)",
"NumberOfDefaultValues": 1,
"DefaultValueStringHandleIndex[0]": 3,
"StringHandle": "6(D_Mode)"
}

2. pldmtool bios GetBIOSTable -t 2
{
"AttributeHandle": 23,
"AttributeType": "BIOSEnumeration",
"NumberOfCurrentValues": 1,
"CurrentValueStringHandleIndex[0]": "Normal"
},
{
"AttributeHandle": 24,
"AttributeType": "BIOSEnumeration",
"NumberOfCurrentValues": 1,
"CurrentValueStringHandleIndex[0]": "Normal"
},
{
"AttributeHandle": 25,
"AttributeType": "BIOSEnumeration",
"NumberOfCurrentValues": 1,
"CurrentValueStringHandleIndex[0]": "D_Mode"
}
3. GET https://${bmc}/redfish/v1/Systems/system/Bios
"pvm_os_ipl_type": "D_Mode",
"pvm_rpa_boot_mode": "Normal",
"pvm_system_operating_mode": "Normal",

Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
Change-Id: Id2bc14f1825ea3e62899d6a749b740cd67bf4d60

show more ...

Fix a possible null pointer dereference

- This commit would fix a potential null pointer dereference.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Ic323bde2c4bd35c35132e43104

Fix a possible null pointer dereference

- This commit would fix a potential null pointer dereference.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Ic323bde2c4bd35c35132e4310466cd6ae7ec7aeb
Signed-off-by: George Liu <liuxiwei@inspur.com>

show more ...

pldmbios: Add BIOS attributes huge_page_count lmb_size mfg_flags

Hostboot reads hb_requested_number_huge_pages and sets
ATTR_HUGE_PAGE_COUNT, reads hb_pending_memory_region_size and
sets ATTR_LMB_SI

pldmbios: Add BIOS attributes huge_page_count lmb_size mfg_flags

Hostboot reads hb_requested_number_huge_pages and sets
ATTR_HUGE_PAGE_COUNT, reads hb_pending_memory_region_size and
sets ATTR_LMB_SIZE, reads hb_mfg_flags and sets ATTR_MFG_FLAGS.
Tested: manually added bios attrs in rainier simics and
successfully read from hostboot.

Signed-off-by: Corey Swenson <cswenson@us.ibm.com>
Change-Id: Idfef7fd97b16d7cbf1bf72764387535e200c78e0

show more ...

Remove the print traces from the oem code

- Currently oem-ibm code does not have verbose infrastructure
in place,so removing the print traces for now & if need be we
can add the verbose infrastr

Remove the print traces from the oem code

- Currently oem-ibm code does not have verbose infrastructure
in place,so removing the print traces for now & if need be we
can add the verbose infrastructure which needs more changes in
the handler code and that can be taken up as a separate
activity.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Ic81c86aa62ab1760ceb13f8f3f78be2d98b6db80

show more ...

oem-ibm: Support system reboot after inband code update

This commit adds a bmc effecter that causes a system reboot(
phyp, chassis and bmc)

After bmc sends an end update successful event, Host will

oem-ibm: Support system reboot after inband code update

This commit adds a bmc effecter that causes a system reboot(
phyp, chassis and bmc)

After bmc sends an end update successful event, Host will
set this new effecter. Upon getting the setStateEffecterStates
call bmc-pldm does the following:
1. Set the power restore to reboot the host once the BMC
is rebooted
2. power off Host and Chassis
3. reboot the bmc

Tested with pldmtool
Steps after patching changes:
1. Boot host to STANDBY
2. Fetch the effecter to note the effecterId
Ex: ./pldmtool platform GetPDR -d 28
3. Trigger the system reboot by toggling the effecter
./pldmtool platform SetStateEffecterStates -i 10 -c 1
-d 1 1

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: Id2d4201a7d61ae335adc64f2583571a37dc7879d

show more ...

oem-ibm: Fix the hostfw image file name

The name of the hostfw image file should be image-hostfw, not
image-host-fw:
https://github.com/openbmc/openbmc/blob/50c538c2b942fecba6fa1fc3cfe0f5a339f10999/

oem-ibm: Fix the hostfw image file name

The name of the hostfw image file should be image-hostfw, not
image-host-fw:
https://github.com/openbmc/openbmc/blob/50c538c2b942fecba6fa1fc3cfe0f5a339f10999/meta-phosphor/classes/phosphor-software-manager-mmc.bbclass#L7

Tested: Verified inband code update updated this the hostfw image file.

Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
Change-Id: I64fc78190682bcc8acfe9255b1deb27cf7ff71e0

show more ...

PLDM:Fix for file I/O by type (lids) writes returning error

This commit fixes the issue where file I/O by Type (lids)
writes were returning generic PLDM_ERROR.

Tested on a rainier.

Before the fix:

PLDM:Fix for file I/O by type (lids) writes returning error

This commit fixes the issue where file I/O by Type (lids)
writes were returning generic PLDM_ERROR.

Tested on a rainier.

Before the fix:
Sending Msg
08 3f 0c 01 00 00 00 00

Afetr the fix:
Sending Msg
09 3f 0c 00 ff 03 00 00

Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>
Change-Id: Icc64c3a7c101700fdd626f9b9c9837c141e97648

show more ...

oem-ibm : Add new filetype & logic for handling Progress Codes

- The intent behind this commit , is to add a new file type
for handling IBM Progress Codes.

- The Progress Codes are typically in b

oem-ibm : Add new filetype & logic for handling Progress Codes

- The intent behind this commit , is to add a new file type
for handling IBM Progress Codes.

- The Progress Codes are typically in bytes(<200 bytes), which
is why the host does an inband write rather than using the DMA.

- Once the Progress Code structure is received, pldm would peek into
the buffer to find out the Primary Code which is typically an 8 byte
Hex number (starts at a standard offset 40).

- Once , we get the Primary Code then we pack it into a structure and
set the dbus property which is hosted by the snoopd daemon.

Tested By :

1. PLDM Tool

./pldmtool raw --data 0x80 0x3F 0xC 0x0A 0x00 0x00 0x00 0x00 0x00 0x07
0x00 0x00 0x00 0x48 0x00 0x00 0x00 0x02 0x00 0x00 0x01 0x00 0x00 0x00
0x48 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x00 0x00 0x00 0x00 0x00 0x53 0x54 0x41 0x4e 0x44 0x42 0x59 0x20 0x20
0x20 0x20 0x20 0x20 0x20 0x20 0x20 0x20 0x20 0x20 0x20 0x20 0x20 0x20
0x20 0x20 0x20 0x20 0x20 0x20 0x20 0x20 0x20
Request Message:
08 01 80 3f 0c 0a 00 00 00 00 00 07 00 00 00 48 00 00 00 02 00 00 01 00
00 00 48 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 53 54 41 4e 44 42 59 20 20 20 20 20 20
20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20
Progress SRC Structure : 02 00 00 01 00 00 00 48 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
53 54 41 4e 44 42 59 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20
20 20 20 20 20 20 20 20
Primary Progress Code in Hex : 5354414e44425920

The Ascii Value of 5354414e44425920 is STANDBY(Host reaching standby)

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I1c8529070ed0718e7770bae99964445e5b14bd65

show more ...

Bring back the dbus backend for bios attributes

- This commit would bring back the dbus backend support
for the bios attributes.

- This was required to be supported as we have two redfish
inter

Bring back the dbus backend for bios attributes

- This commit would bring back the dbus backend support
for the bios attributes.

- This was required to be supported as we have two redfish
interfaces that can be used to poke the same bios settings,
and we should make sure that they should be in sync.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I032594c90ac6cfdaff1197ea98710c5efa27d7c3

show more ...

oem-ibm: Resource dump support

This commit includes the changes to support resource dump. Input
parameters to initiate resource dump are vsp string and the
password.

Resource Dump Flow:
1. PLDM wai

oem-ibm: Resource dump support

This commit includes the changes to support resource dump. Input
parameters to initiate resource dump are vsp string and the
password.

Resource Dump Flow:
1. PLDM waits for the resource dump create signal from
dump manager
2. BMC sends the NewfileAvailable command to hypervisor with
resource dump paramters
Format: <Length of the VSP String><VSP String>
<Length of the Password><Password>
3. Hypervisor reads and validates the data and send the File Ack
command back to BMC
4. Once completed, BMC receives the NewfileAvailable command from
hypervisor with resource dump details
5. User initiates the dump offload
6. BMC receives the write file by type from memory command from
hypervisor
7. Once this operation is completed BMC receives the File Ack
command from hyperviosr

Tested By:
1. Initiating the resource dump using pldmtool, busctl and redfish
2. Verified that resource dump entry is updated with source id,
length, completion time and status.
3. Dump offload is successful with initiating from redfish
4. Verified that new resource dump is generated at hypervisor level
5. Error scenarios tested are like empty vsp string, not supported
vsp string etc.

Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
Change-Id: Iedcdf3cf16c263a2d1749bb5251f7f6244c327ea

show more ...

Upstream pldm-hypervisor services under OEM

- The intent behind this commit is to create a folder
for all the pldm services(including the oem services)
& installs the respective services base

Upstream pldm-hypervisor services under OEM

- The intent behind this commit is to create a folder
for all the pldm services(including the oem services)
& installs the respective services based on the meson
configuration.
- This commit would also remove a redundant systemd dependency
which was missed in earlier cleanup.

Tested By:
1. meson buiddir -Doem-ibm=enabled/disabled
2. ninja -C builddir
3. ninja install

Post the install step, was able to see the respective systemd
unit files in the systemd_unit_dir (lib/systemd/system)

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I4d9e093be25ac7a8a94bcccc9f8c1e7d3de1c68c

show more ...

Upstream BIOS Attributes under oem extensions

- This commit would upstream all the bios attributes
that ibm machines use.
- These attributes will be copied onto the BMC when
it is compiled with

Upstream BIOS Attributes under oem extensions

- This commit would upstream all the bios attributes
that ibm machines use.
- These attributes will be copied onto the BMC when
it is compiled with oem-ibm flag enabled.

Tested By:
- meson builddir -Doem-ibm=enabled -Dprefix=<>
- ninja -C builddir
- ninja install

Post install step, was able to see all the bios attribute
jsons inside <prefix>/share/pldm/bios folder.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Iea030b773946298b26bbb26443ef4015f19ff37d

show more ...

Remove undefined behavior

The commit here:
https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/39481

Located this issue. open needs to be called with permissions, otherwise
it results in

Remove undefined behavior

The commit here:
https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/39481

Located this issue. open needs to be called with permissions, otherwise
it results in undefined behavior.

Tested:
Code now compiles with security flags enabled.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I597c5dff37a4e89af9a68f264782ada973c70622

show more ...

Platform: Unit tests for OEM PDRs

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: Ie2aa3fc910c524079b0d658aabcb4dd778230cab

oem ibm: marker LID validation

This commit adds code for writing marker LID
from Host and also send a PlatformEventMessage
after validation.

This commit also subscribes for the interface added
sign

oem ibm: marker LID validation

This commit adds code for writing marker LID
from Host and also send a PlatformEventMessage
after validation.

This commit also subscribes for the interface added
signal to fetch the new image id and sends the relevant
sensor event to host

Change-Id: I92476beca18e6dd255f372dd82d6eaeca18e282c
Signed-off-by: Sampa Misra <sampmisr@in.ibm.com>

show more ...

Inband code update: send PLDM events up for all code update states

send pldm events to Host to respond to the code update commands.

Signed-off-by: Varsha Kaverappa <vkaverap@in.ibm.com>
Change-Id:

Inband code update: send PLDM events up for all code update states

send pldm events to Host to respond to the code update commands.

Signed-off-by: Varsha Kaverappa <vkaverap@in.ibm.com>
Change-Id: Iae90a4663d4c5ed20b3a8a6222edb6055a533589

show more ...

oem-ibm: Implement SetEffecter actions corresponding to code
update actions

This commit defines the actions taken corresponding to the code
update actions.

Code update actions include- START, END,

oem-ibm: Implement SetEffecter actions corresponding to code
update actions

This commit defines the actions taken corresponding to the code
update actions.

Code update actions include- START, END, ABORT, ACCEPT and REJECT

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: I2e86177efe4c8924069cc400b79e4fc4b8983df4

show more ...

pldm: inband code update: clear the image LIDs when pldm daemon comes up

Clear the LID_STAGING_DIR path when pldm daemon comes up. This function
will also be used during code update process.

Signed

pldm: inband code update: clear the image LIDs when pldm daemon comes up

Clear the LID_STAGING_DIR path when pldm daemon comes up. This function
will also be used during code update process.

Signed-off-by: Varsha Kaverappa <vkaverap@in.ibm.com>
Change-Id: I2a757caaa3e204e4089235d9e3baf6d425f5bec5

show more ...

oem-ibm: inband: Add assembleCodeUpdateImage()

The assembleCodeUpdateImage will build the final tarball out of the
BMC and hostfw image files and copy it to the update directory
to trigger a softwar

oem-ibm: inband: Add assembleCodeUpdateImage()

The assembleCodeUpdateImage will build the final tarball out of the
BMC and hostfw image files and copy it to the update directory
to trigger a software version interface to be created.

Change-Id: I7dd100e46c34c941fd574047551ddc5fee8c387b
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

oem-ibm: inband: Handle BMC lids

If the file is a BMC lid, strip off the header and concatenate
it. The BMC lids are a tarball file divided into chunks.

Change-Id: I36e622231d07658524225a36b932c983

oem-ibm: inband: Handle BMC lids

If the file is a BMC lid, strip off the header and concatenate
it. The BMC lids are a tarball file divided into chunks.

Change-Id: I36e622231d07658524225a36b932c983f0df2538
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

oem-ibm: inband: Remove the lid header

The host sends the LID files with a header that needs to be
stripped out before adding it to the code update image.

Since the write interface is not unique to

oem-ibm: inband: Remove the lid header

The host sends the LID files with a header that needs to be
stripped out before adding it to the code update image.

Since the write interface is not unique to the inband update
process, we can't strip the header there, so need to make a
copy of the lid file without the header. Remove the original
one once the lid without header has been created.

Change-Id: Id1e009e1716e3103bc38f7111ba1865228db2bad
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

oem-ibm: inband: Check lid is complete

A lid file can be written in one or more write requests. Read
the header for the expected size to check if the lid has been
fully written. The file size should

oem-ibm: inband: Check lid is complete

A lid file can be written in one or more write requests. Read
the header for the expected size to check if the lid has been
fully written. The file size should be the lid size listed in
the header minus the size of the header.

Change-Id: I0fa02af3e50f13b40cea2494471445918826d716
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

oem-ibm: inband: Add processCodeUpdateLid()

The new processCodeUpdateLid() function will process the LID
files sent by the hypervisor so that they can be used by the
code update application to be wr

oem-ibm: inband: Add processCodeUpdateLid()

The new processCodeUpdateLid() function will process the LID
files sent by the hypervisor so that they can be used by the
code update application to be writtent to flash.

This first commit validates that the LID files contain a valid
magic number in their header.

Change-Id: I9113d46fa6af0d0ef8a0c7b898c1229d49ff05e6
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...