oem-ibm: requester: dbus_to_file_handler: Drop unused mctp_fd

```
../oem/ibm/requester/dbus_to_file_handler.hpp:83:9: error: private field 'mctp_fd' is not used [-Werror,-Wunused-private-field]
8

oem-ibm: requester: dbus_to_file_handler: Drop unused mctp_fd

```
../oem/ibm/requester/dbus_to_file_handler.hpp:83:9: error: private field 'mctp_fd' is not used [-Werror,-Wunused-private-field]
83 | int mctp_fd;
| ^
```

Change-Id: I03751463e91b5f62c1e60c1ef47c22dcfcc20215
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

oem-ibm: libpldmresponder: oem_ibm_handler: Remove unused `this`

```
../oem/ibm/libpldmresponder/oem_ibm_handler.hpp:101:14: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture

oem-ibm: libpldmresponder: oem_ibm_handler: Remove unused `this`

```
../oem/ibm/libpldmresponder/oem_ibm_handler.hpp:101:14: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
101 | [this](sdbusplus::message_t& msg) {
| ^~~~
```

Change-Id: I155758a25488d747eed2af0ac24407561ab3cc9f
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

oem-ibm: libpldmresponder: file_io_type_vpd: Remove unused vpdFileType

```
In file included from ../oem/ibm/libpldmresponder/file_io_type_vpd.cpp:1:
../oem/ibm/libpldmresponder/file_io_type_vpd.hpp:

oem-ibm: libpldmresponder: file_io_type_vpd: Remove unused vpdFileType

```
In file included from ../oem/ibm/libpldmresponder/file_io_type_vpd.cpp:1:
../oem/ibm/libpldmresponder/file_io_type_vpd.hpp:72:14: error: private field 'vpdFileType' is not used [-Werror,-Wunused-private-field]
72 | uint16_t vpdFileType; //!< type of the VPD file
| ^
```

Change-Id: If1208f21bcedaff912079371cf2e79df4b17093f
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

oem-ibm: libpldmresponder: file_io: Remove unused fields

```
../oem/ibm/libpldmresponder/file_io.hpp:418:9: error: private field 'hostSockFd' is not used [-Werror,-Wunused-private-field]
418 |

oem-ibm: libpldmresponder: file_io: Remove unused fields

```
../oem/ibm/libpldmresponder/file_io.hpp:418:9: error: private field 'hostSockFd' is not used [-Werror,-Wunused-private-field]
418 | int hostSockFd;
| ^
../oem/ibm/libpldmresponder/file_io.hpp:419:13: error: private field 'hostEid' is not used [-Werror,-Wunused-private-field]
419 | uint8_t hostEid;
| ^
../oem/ibm/libpldmresponder/file_io.hpp:420:25: error: private field 'instanceIdDb' is not used [-Werror,-Wunused-private-field]
420 | pldm::InstanceIdDb* instanceIdDb;
| ^
../oem/ibm/libpldmresponder/file_io.hpp:433:57: error: private field 'handler' is not used [-Werror,-Wunused-private-field]
433 | pldm::requester::Handler<pldm::requester::Request>* handler;
|
```

Change-Id: Ifd2e813423b7bc0bd67780c0fc21e32cf8de3e85
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: I9be2bd75eae5c5098b6206b900b9956e764cf03a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Add support for the coreCount property in DBus

This commit introduces support for counting the number of CPU cores
during BMC power-on and populates this information to a DBus property
named coreCou

Add support for the coreCount property in DBus

This commit introduces support for counting the number of CPU cores
during BMC power-on and populates this information to a DBus property
named coreCount. Upon BMC power-on, the remote terminus detects the
number of CPU cores and send this data and PLDM will updates the
coreCount property accordingly.

Tested:
tested on simulator for hosting DBus property

Change-Id: I37adbe399414fcff3f089fb819349ca4bb537edd
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

oem-ibm: Implement Host lamp test interface

IBM has a feature called LampTest and what it does is this:
- BMC would set the state of LEDs to [ON] on all the BMC accessible
LEDs.
- For LEDs t

oem-ibm: Implement Host lamp test interface

IBM has a feature called LampTest and what it does is this:
- BMC would set the state of LEDs to [ON] on all the BMC accessible
LEDs.
- For LEDs that are not accessible by BMC, a message is sent to the
Host, so that the Host can exercise all the LEDs on the connected
drawers and anything else that the BMC does not have access to.

This commit adds support to send message to Host when BMC has to tell
the Host to exercise LEDs accessible by host.

When Host sees the effector is set, it goes ahead and turns [ON] all
the LEDs for a specified time and automatically restores the states
at timer expiration. BMC does not have to tell the Host to stop the
test and it is part of Host's lamp test requirement.

TESTED: By setting the asserted property of the LED groups object

busctl set-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/lamp_test
xyz.openbmc_project.Led.Group Asserted b true

And verifying that the setEffecterStates call was made to the
remote state effecter to turn on all LEDs

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I990dce28d3017f20c73ff9029fced0e7ac84868f

show more ...

oem-ibm: Adding value_name json key for dynamic deallocation of Memory

This commit adds value_name json key to BIOS attribute that allows user
to enable/disable the dynamic deallocation of memory ba

oem-ibm: Adding value_name json key for dynamic deallocation of Memory

This commit adds value_name json key to BIOS attribute that allows user
to enable/disable the dynamic deallocation of memory based on predictive
memory fail events.

Tested: Verified the BIOS attribute with get bios attribute command from
pldmtool.

Change-Id: I913d2062c1d7af024a447f9eb4e0289fa7ebdf12
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

oem-ibm: libpldmresponder: Replace deprecated libpldm header path

The non-deprecated paths for OEM header files use a directory hierarchy
that reflects the OEM in question.

The fix was generated us

oem-ibm: libpldmresponder: Replace deprecated libpldm header path

The non-deprecated paths for OEM header files use a directory hierarchy
that reflects the OEM in question.

The fix was generated using the following command with the coccinelle
patch from [1]:

```
$ spatch \
--sp-file ../libpldm/origin/evolutions/current/oem-ibm-header-compat.cocci \
--in-place \
$(git ls-files | grep -E '\.[ch](pp)?')
```

[1]: https://gerrit.openbmc.org/c/openbmc/libpldm/+/72202

Change-Id: Iabea7a20e6e59b9671abb7b4f838215c50873594
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Use system include directives for libpldm headers

libpldm is now an external dependency rather than an in-tree library.
Adjust the includes accordingly.

Change-Id: I97218ec9cf7ffb7afa98e78c01

pldm: Use system include directives for libpldm headers

libpldm is now an external dependency rather than an in-tree library.
Adjust the includes accordingly.

Change-Id: I97218ec9cf7ffb7afa98e78c01dc9d030271c3f4
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: I3aa6b1e86072f2af81e7792bc4a13a012c359187
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

pldm: Rearranging datatype declaration

This commit adds support to eliminating duplication of datatypes which
enhancing clarity and manageability throughout the pldm repository.
This is rearrangemen

pldm: Rearranging datatype declaration

This commit adds support to eliminating duplication of datatypes which
enhancing clarity and manageability throughout the pldm repository.
This is rearrangement of declaration of data types so it can be used
host-bmc and oem layer both the places.

Change-Id: Ieb1232884b8e2128e8bf97dafd01e4ad5524ede0
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I539a0c5baa63be240fc1c76367c0af338dd89c7b
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

oem-ibm: Parse the pcie topology file

PLDM receives topology data in IBM proprietary format from remote
terminus. As part of this commit, we are parsing the topology
and cable data and caching the i

oem-ibm: Parse the pcie topology file

PLDM receives topology data in IBM proprietary format from remote
terminus. As part of this commit, we are parsing the topology
and cable data and caching the information.

Tested: Power ON/OFF successful

Change-Id: I15a563aeecdd2b193fbc40b23dc225456b882be2
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

bios: Converting bios json keys to lower snake case

Converting following bios attribute json keys to lower snake case
displayName --> display_name
helpText --> help_text
readOnly --> read_only

bios: Converting bios json keys to lower snake case

Converting following bios attribute json keys to lower snake case
displayName --> display_name
helpText --> help_text
readOnly --> read_only

Tested:
Power on/off
Gtest passed

Change-Id: Iad88ed7bc381d66182c99e31e7d385f65750e0ed
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

pldm: Removing default string length

Removing default string length from BIOS json configuration
files.

String BIOS attributes defined in BIOS configuration json file
contains "default_string_lengt

pldm: Removing default string length

Removing default string length from BIOS json configuration
files.

String BIOS attributes defined in BIOS configuration json file
contains "default_string_length". Providing default string length
manually is error prone. As String length can be calculated and
populated easily in the code, removing json support for
default_string_length.

Tested: Power on/off
Gtests passed.

Change-Id: I7604d8ccedd60a39ba07e1df67ff5712f31e7f6e
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

pldm: Add bios configuration in single json file

Currently bios attributes are added in three json configuration
files based on the attribute type(integer, string, enum).
Combining all the attribute

pldm: Add bios configuration in single json file

Currently bios attributes are added in three json configuration
files based on the attribute type(integer, string, enum).
Combining all the attributes in single bios attribute json file
to organize the attributes based on the usage pattern.

Tested:
BMC powered on successfully
Unit tests passed

Change-Id: I42cc7c2394918e48d27dca2041f8ce00509c565a
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

pldm: Remove unnecessary type casting in logs

This commit removes the unnecessary type casting of values of the
journal logs based on supported types mentioned in LG2 documentation
[1].

Testing: Ve

pldm: Remove unnecessary type casting in logs

This commit removes the unnecessary type casting of values of the
journal logs based on supported types mentioned in LG2 documentation
[1].

Testing: Verified the debug traces to correct.

'''
For Instance:
Earlier -
error(”TYPE = {TYPE} “, “TYPE”, static_cast<unsigned>(PLDM_STATE_EFFECTER_PDR));
Journal trace -
May 27 08:16:51 p10bmc pldmd[931]: TYPE = 11

After Correction -
error(”TYPE = {TYPE}“, “TYPE”, PLDM_STATE_EFFECTER_PDR);
Journal trace -
May 27 08:16:51 p10bmc pldmd[931]: TYPE = Enum(11)
'''

[1]: https://github.com/openbmc/phosphor-logging/blob/master/docs/structured-logging.md#lg2

Change-Id: Ia649ecd4ecbb73c421f7844885f58a6835805719
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

Make containerId optional in the event json file

During the PDR exchange, normalization causes the container IDs of
remote entities to change. Therefore, checking for a predefined
container ID from

Make containerId optional in the event json file

During the PDR exchange, normalization causes the container IDs of
remote entities to change. Therefore, checking for a predefined
container ID from a remote terminus for sensor events does not provide
any benefit. This commit adds support for optionally skipping the check
for remote container id for sensor events when needed.

Tested:
Unit tests passed.

Change-Id: I871044815194b7aed507c105ae04f1418e084de1
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

oem-ibm: Adding BIOS attribute for dynamic deallocation of Memory

This commit adds BIOS attribute for allowing user to enable/disable
the dynamic deallocation of memory.

Tested: Verified the BIOS a

oem-ibm: Adding BIOS attribute for dynamic deallocation of Memory

This commit adds BIOS attribute for allowing user to enable/disable
the dynamic deallocation of memory.

Tested: Verified the BIOS attribute with get bios attribute command from
pldmtool.

Change-Id: Ife96c4544adf142e6c354e0dbd658d96625b8c13
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

oem-ibm: Setting the slot power state to Off

The commit sets the slot power state to off when the
host powers off. The host only powers on the slots and
the BMC needs to turn all the slots off when

oem-ibm: Setting the slot power state to Off

The commit sets the slot power state to off when the
host powers off. The host only powers on the slots and
the BMC needs to turn all the slots off when the host powers off.

Tested by powering off and using busctl commands to verify the
power state.

Change-Id: I3eb531105ea58e06d0dc5ffdf35491e2e0c63b2e
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

oem-ibm : File I/O read-write with length 0

This commit implements pldm to dishonor file I/O read/write for length
zero. Additional changes: - Implemented check for response code of
encode/decode AP

oem-ibm : File I/O read-write with length 0

This commit implements pldm to dishonor file I/O read/write for length
zero. Additional changes: - Implemented check for response code of
encode/decode APIs and along with appropriate error message. - Added
check for performing read operation from a file size 0.

Tested: Functional testing passed.

Change-Id: Ibab1981202775b672b3d50040884e9db4c16d5c2
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

oem-ibm: Improving logs (lg2)

This commit corrects the severity level of logs and also formats the
message string, fixing the ill-defined message string of the logs as
mentioned in the anti-pattern

oem-ibm: Improving logs (lg2)

This commit corrects the severity level of logs and also formats the
message string, fixing the ill-defined message string of the logs as
mentioned in the anti-pattern document [1]. Additionally, based on the
requirement this commit adds more debug information to logs.

[1]: https://github.com/openbmc/docs/blob/master/anti-patterns.md#ill-defined-data-structuring-in-lg2-message-strings

Change-Id: I24ca21de35d5a1a9b3cc64b28a149e4c213055f9
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

oem_ibm: Implement timer for Surveillance Pings

This commit introduces a timer for surveillance pings sent by the
remote terminus to monitor the BMC. If a ping is not received
within 120 seconds, an

oem_ibm: Implement timer for Surveillance Pings

This commit introduces a timer for surveillance pings sent by the
remote terminus to monitor the BMC. If a ping is not received
within 120 seconds, an informational error will be logged.

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: Ia52ed2461b2c2f8ea0102e60ed2a22c7691b2d2a

show more ...

oem-ibm: Fix size corruption during DMA transfer

When the remote terminus performs read/write operations on BMC
utilizing DMA(Direct Memory Access), the BMC verifies the data length
to be transferre

oem-ibm: Fix size corruption during DMA transfer

When the remote terminus performs read/write operations on BMC
utilizing DMA(Direct Memory Access), the BMC verifies the data length
to be transferred and segments it into chunks if the length exceeds
the maximum allowable size (8384512 byte) by DMA. This modification
addresses an issue in PLDM where it incorrectly reports data transfer
status to the remote terminus, including the leftover length in its
response, which is erroneous. With this enhancement, PLDM now delivers
accurate responses with the appropriate length specified.

Tested:
Tested IPL flow on simulator.

Change-Id: I48d4f825f1e049b06f291e401a02f8dacc1ad970
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...