PLDM:Use new alias of DBUS_TIMEOUT for bus.call

This commit uses a new global variable for DBUS_TIMEOUT which is included as an input parameter for bus.call dbus calls. The new alias makes the bus.c

PLDM:Use new alias of DBUS_TIMEOUT for bus.call

This commit uses a new global variable for DBUS_TIMEOUT which is included as an input parameter for bus.call dbus calls. The new alias makes the bus.call function shorter and readable.

Change-Id: I336c97bc0631d5370ff3648e41f50e3e283d771b
Signed-off-by: vkaverap@in.ibm.com <vkaverap@in.ibm.com>

show more ...

PLDM: 5 sec timeout for dbus calls without reply

This commit adds 5 second dbus timeout value to dbus calls with no reply. Previously a commit was merged that included 5 seconds dbus timeout value f

PLDM: 5 sec timeout for dbus calls without reply

This commit adds 5 second dbus timeout value to dbus calls with no reply. Previously a commit was merged that included 5 seconds dbus timeout value for all dbus call with reply.

This is added to make sure PLDM does not wait for more than 5 seconds when a dbus call is made with or without reply if no response is received from other daemon or host.

The 5 second timeout value is overridden to 10 seconds in meta-ibm layer

Change-Id: Ic20005d903732ac58bb22a657bf1b0c07439d435
Signed-off-by: vkaverap@in.ibm.com <vkaverap@in.ibm.com>

show more ...

PLDM: Implementing Phosphor-Logging/LG2 logging

This commit migrates std::cerr/cout added as part
of new changes in PLDM to LG2.

Change-Id: I8e85732684d47b6740521e95712433a7c6760d8a
Signed-off-by:

PLDM: Implementing Phosphor-Logging/LG2 logging

This commit migrates std::cerr/cout added as part
of new changes in PLDM to LG2.

Change-Id: I8e85732684d47b6740521e95712433a7c6760d8a
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

oem-ibm: Call PEL API when host drops event log

When IBM's hypervisor receives an event log (PEL) using the file API, it
may end up discarding it, returning the reason the file was discarded in
the

oem-ibm: Call PEL API when host drops event log

When IBM's hypervisor receives an event log (PEL) using the file API, it
may end up discarding it, returning the reason the file was discarded in
the status argument of the file ack command. It can do this for two
reasons, either it doesn't have any more room to store event logs, or
the event log was malformed.

In these cases, call the HostReject D-Bus method on the PEL daemon so it
can handle it. The code must convert the value of the status returned
into the proper D-Bus enum value.

Without this call, the operating system was missing event logs when
there were floods of them.

Tested:
API was called when system was flooded with event logs, allowing the PEL
daemon to resend them as space opens up.

Change-Id: I9d3acf4e5c5f885934ef96e89ddb93dd8f9c10a3
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

BIOS attribute to configure network parameter

Adding bios attribute to configure network boot parameter from the
GUI webpage, GUI would then populate these BIOS attributes through
redfish and this s

BIOS attribute to configure network parameter

Adding bios attribute to configure network boot parameter from the
GUI webpage, GUI would then populate these BIOS attributes through
redfish and this selection will be communicated to pldm remote
terminus via these PLDM BIOS attributes.

Change-Id: I133714fa4637166072793b60df280ff7f5a4cb01
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

Add additional information for logging

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: Idbc2245a89866db1a0a039c106c5c40c71228493

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: I47fca4c5cc35086034911f026c2c48d28136db5f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

PLDM: System specific BIOS attributes

This commit adds code to populate BIOS attributes
based on the system type that is the platform.

The BIOS Jsons are installed based on the platform/
system typ

PLDM: System specific BIOS attributes

This commit adds code to populate BIOS attributes
based on the system type that is the platform.

The BIOS Jsons are installed based on the platform/
system type. The system type is populated by entity
manager.

TESTED on hardware across different platform/system type.
On systems where the compatible system interface is not
implemented or entity manager not running, then the BIOS
Jsons with default values are installed.

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: I179dad34537ed0d1fb263584d687a1b8cb64c335

show more ...

Enhance traces for File Size Exceeds Offset

This commit adds changes to enhance or give context
to the generic error traces related to errors for
file size exceeding file offset provided by remote
t

Enhance traces for File Size Exceeds Offset

This commit adds changes to enhance or give context
to the generic error traces related to errors for
file size exceeding file offset provided by remote
terminus.

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: Ic088a54190c2f990d07609a35c9b45bab637a15b

show more ...

use fs.copyfile instead of deprecated copy

copy arg in configure_file API is deprecated since meson
version 0.64.0. As we moved to meson version 1.1.1 we can
leverage the filesystem module copyfile(

use fs.copyfile instead of deprecated copy

copy arg in configure_file API is deprecated since meson
version 0.64.0. As we moved to meson version 1.1.1 we can
leverage the filesystem module copyfile() to achive the
same result.

Change-Id: I8ec540a505060306ff643a153cb2ca1b1ca4d35e
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Adding BIOS attribute to select OS load source

- Previously user had to do this configuration of selecting load
source, alternate load source and DASD load source manually,
and this was tedious task

Adding BIOS attribute to select OS load source

- Previously user had to do this configuration of selecting load
source, alternate load source and DASD load source manually,
and this was tedious task. These are network adapters connected
to PCI slots whose part location information is available in redfish.
- Adding bios attribute to handle selection of PCI slot location codes
for these network adapters to be selected from the GUI webpage, GUI
would then populate these BIOS attributes through redfish and this
selection will be communicated to Host via these PLDM BIOS attributes.

Change-Id: I7fa7cefe3323f4b21fb0335d0292ee136424fbe9
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

clang-error: fix clang-diagnostic-unused-const-variable error

This clang-error is generated when there is a constant unused
variable.

Change-Id: I4c101d3d58d468b728768fd63c1fd842e8c09ac4
Signed-off

clang-error: fix clang-diagnostic-unused-const-variable error

This clang-error is generated when there is a constant unused
variable.

Change-Id: I4c101d3d58d468b728768fd63c1fd842e8c09ac4
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

oem-ibm : Support New record to the backplane vpd

This commit is to support a new VPD record called PSPD that contains
few keywords called #D and VM. Since these keywords are typically
larger in siz

oem-ibm : Support New record to the backplane vpd

This commit is to support a new VPD record called PSPD that contains
few keywords called #D and VM. Since these keywords are typically
larger in size (4K bytes) than what is managed by PLDM, we are adding
a file into which these keywords will be extracted. This keyword file
is transferred to the HB PLDM layer with a readFileByType request
from HB.

This also includes transfer of PSPD record data via PLDM with
offset included.

Tested by using pldmtool to send read request command to PLDM

Change-Id: Iba814a802cbbd2c2d641ee5a4c81919c3b8bdf20
Signed-off-by: Varsha Kaverappa <vkaverap@in.ibm.com>

show more ...

oem: ibm: Use `truncate(1)` to create NVRAM related files

Use of `dd(1)` results in back-to-back `read(2)` and `write(2)` syscalls;
the performance of `dd(1)` is O(n) with respect to the file size.

oem: ibm: Use `truncate(1)` to create NVRAM related files

Use of `dd(1)` results in back-to-back `read(2)` and `write(2)` syscalls;
the performance of `dd(1)` is O(n) with respect to the file size. Poor
choice of the `bs=` parameter to `dd(1)` can significantly amplify the
amount of syscalls required to achieve the task.

By contrast, `truncate(1)` generally invokes a single syscall, either
`truncate(2)` or `ftruncate(2)`. As a consequence, `truncate(1)` is O(1)
with respect to file size.

Switch to `truncate(1)` to improve runtime efficiency of the scripts.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I69dd925f36e733fc2a1ee71cb8354ee04ee8871b

show more ...

pldm: Include config.h via compiler argument

This removes any ambiguity about which config.h is being included.
Subprojects such as libpldm and phosphor-logging also generate config.h
files, and the

pldm: Include config.h via compiler argument

This removes any ambiguity about which config.h is being included.
Subprojects such as libpldm and phosphor-logging also generate config.h
files, and these are exposed in the include path.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I3e0ccd6339f088380ffa29d41167b07aefc7dd16

show more ...

PLDM : Change the dbus timeout to 5 seconds

Dbus timeout value for every dbus call in PLDM is set to 5 seconds
instead of default 25 seconds so that all dbus calls that expect a
reply exists after 5

PLDM : Change the dbus timeout to 5 seconds

Dbus timeout value for every dbus call in PLDM is set to 5 seconds
instead of default 25 seconds so that all dbus calls that expect a
reply exists after 5 seconds if there is no response from the client.
While BMC is still waiting for a response on any dbus calls it is
possible that host can timeout and return an error.
Another reason is that memory address from where BMC would read data
sent by host may get deallocated after 20 seconds and it is possible
for this to happen even before BMC has read the data. This has lead
to DMA issues.

Tested by adding a sleep for 10 seconds inside main function of
phospher-host-postd and executed get dbus property on snoopd
interface from pldm. PLDM dbus call timed out after 5 seconds.

Change-Id: I1aa1b4ad7fceff2224a3ccc3bcf6abd5705963bc
Signed-off-by: Varsha Kaverappa <vkaverap@in.ibm.com>

show more ...

Change the default partition mode to A_Mode

Traditional IBM systems since 1988 used to ship with A_Mode
as the default partition mode for iBMi. Changing the default
value from D_Mode to A_Mode to ma

Change the default partition mode to A_Mode

Traditional IBM systems since 1988 used to ship with A_Mode
as the default partition mode for iBMi. Changing the default
value from D_Mode to A_Mode to match the behaviour of our systems
and align them with the earlier behaviour.

Change-Id: I4fed505de3cf5628e5ad668870b6fd1ac00dc588
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Bios: support IPv4-mapped IPv6 address length

The existing code will allow ::<ipv4_address> without
any error. However, if the address is expanded like the
below, there will be "length out of range"

Bios: support IPv4-mapped IPv6 address length

The existing code will allow ::<ipv4_address> without
any error. However, if the address is expanded like the
below, there will be "length out of range" error:
0000:0000:0000:0000:0000:ffff:xxx.xxx.xxx.xxx

This commit changes the maximum string length of
IPv6 address from 39 to 45, to support IPv4-mapped
IPv6 address.

Change-Id: I8c6e90e5a0ddbf38e7826e5918408b5d29811bfd
Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>

show more ...

oem-ibm: Support new UTIL keywords

This commit adds new UTIL record keywords RT, F5 and F6 under the
motherboard. F5 and F6 keywords are used to fill up the desired
host splash screen name displayed

oem-ibm: Support new UTIL keywords

This commit adds new UTIL record keywords RT, F5 and F6 under the
motherboard. F5 and F6 keywords are used to fill up the desired
host splash screen name displayed at the host console. The RT
keyword is used to hold the record name.

Tested: Verified that the name filled up through the F5 and F6
keywords are displayed at the host splash screen

Change-Id: I26f1c03db3e9f6a5b8cdc435d9e80d7c92563e16
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>

show more ...

pldmd: Migrate instance ID allocation to pldm::InstanceIdDb

This removes use of `pldm::dbus_api::Requester` from around the
code-base. This makes progress towards removing the DBus API entirely
once

pldmd: Migrate instance ID allocation to pldm::InstanceIdDb

This removes use of `pldm::dbus_api::Requester` from around the
code-base. This makes progress towards removing the DBus API entirely
once all its consumers are converted to the libpldm instance ID APIs.

There was never a good reason for the code using the class to have
knowledge that it was related to DBus anyway, so this is, in-effect, a
double clean up improving separation of concerns.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I2d9397cae1b3c8c251c32e36ca520aad9c9b8cf6

show more ...

pldmd: move to libpldm instance ID alloc/free

Refactor the dbus_api::Requester class to be implemented in terms of
libpldm's instance ID database. To make that easier to deal with we
introduce a lig

pldmd: move to libpldm instance ID alloc/free

Refactor the dbus_api::Requester class to be implemented in terms of
libpldm's instance ID database. To make that easier to deal with we
introduce a light-weight RAII C++ binding along with a helper class for
unit tests.

Change-Id: Ia03de8245dfb114e6266ba36dcf26ca4398a4ce0
Signed-off-by: Rashmica Gupta <rashmica@linux.ibm.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I61b093f75011417cc9c7acf9605200f4fa429bac
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

oem-ibm: remove OSStart as indication host is running

This logic is checking whether PHYP is at standby or runtime. The
OSStart was never implemented by PHYP so it should not be looked at to
determi

oem-ibm: remove OSStart as indication host is running

This logic is checking whether PHYP is at standby or runtime. The
OSStart was never implemented by PHYP so it should not be looked at to
determine this state. The hostboot team is going to utilize this
BootProgress to indicate when they are starting PHYP.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Iebb1260232c60ae77a0f0e25e79fd2fa354238ba

show more ...

Adding bios attributes for VMI Support

- Adding host controlled VMI support bios attribute
for HMC Enablement Control for eBMC based systems.

Change-Id: I56b24c28440bdc7dc8f89f8fa845fc86be661d8e
Si

Adding bios attributes for VMI Support

- Adding host controlled VMI support bios attribute
for HMC Enablement Control for eBMC based systems.

Change-Id: I56b24c28440bdc7dc8f89f8fa845fc86be661d8e
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

pldmd: instance_id: Fix compilation under GCC 13

GCC 13 appears to have refactored some system headers so make sure to
include what we use[1].

[1]: https://include-what-you-use.org/

Resolves the f

pldmd: instance_id: Fix compilation under GCC 13

GCC 13 appears to have refactored some system headers so make sure to
include what we use[1].

[1]: https://include-what-you-use.org/

Resolves the following errors:

```
[8/113] Compiling C++ object libpldmresponder/test/libpldmresponder_base_test.p/.._.._pldmd_instance_id.cpp.o
FAILED: libpldmresponder/test/libpldmresponder_base_test.p/.._.._pldmd_instance_id.cpp.o
ccache c++ -Ilibpldmresponder/test/libpldmresponder_base_test.p -Irequester -I../requester -Isubprojects/libpldm/include -I../subprojects/libpldm/include -Isubprojects/libpldm/src -I../subprojects/libpldm/src -Isubprojects/libpldm/include/libpldm -I../subprojects/libpldm/include/libpldm -Ilibpldmresponder -I../libpldmresponder -I. -I.. -I../subprojects/googletest/googletest/include -I../subprojects/googletest/googletest -Isubprojects/googletest/__CMake_build -I../subprojects/googletest/__CMake_build -Isubprojects/googletest -I../subprojects/googletest -I../subprojects/googletest/googlemock/include -I../subprojects/googletest/googlemock -I../subprojects/nlohmann-json/single_include -Isubprojects/phosphor-dbus-interfaces/gen -I../subprojects/phosphor-dbus-interfaces/gen -I../subprojects/sdbusplus/include -Isubprojects/phosphor-logging/lib/include -I../subprojects/phosphor-logging/lib/include -Isubprojects/sdeventplus/src -I../subprojects/sdeventplus/src -Isubprojects/stdplus/include -I../subprojects/stdplus/include -Isubprojects/stdplus/include-fd -I../subprojects/stdplus/include-fd -I../subprojects/fmt/include -Isubprojects/fmt/__CMake_build -I../subprojects/fmt/__CMake_build -Isubprojects/fmt -I../subprojects/fmt -I../subprojects/function2/include -Isubprojects/function2/__CMake_build -I../subprojects/function2/__CMake_build -Isubprojects/function2 -I../subprojects/function2 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Wpedantic -Werror -std=c++20 -O2 -g -Wno-psabi -DLIBPLDMRESPONDER -DFMT_LOCALE -DBOOST_ASIO_DISABLE_THREADS -DBOOST_ALL_NO_LIB -DBOOST_SYSTEM_NO_DEPRECATED -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_COROUTINES_NO_DEPRECATION_WARNING -pthread -isystem../subprojects/googletest/googletest -isystem../subprojects/googletest/googletest/include -MD -MQ libpldmresponder/test/libpldmresponder_base_test.p/.._.._pldmd_instance_id.cpp.o -MF libpldmresponder/test/libpldmresponder_base_test.p/.._.._pldmd_instance_id.cpp.o.d -o libpldmresponder/test/libpldmresponder_base_test.p/.._.._pldmd_instance_id.cpp.o -c ../pldmd/instance_id.cpp
In file included from ../pldmd/instance_id.cpp:1:
../pldmd/instance_id.hpp:19:5: error: ‘uint8_t’ does not name a type
19 | uint8_t next();
| ^~~~~~~
../pldmd/instance_id.hpp:4:1: note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
3 | #include <bitset>
+++ |+#include <cstdint>
4 |
../pldmd/instance_id.hpp:24:19: error: ‘uint8_t’ has not been declared
24 | void markFree(uint8_t instanceId)
| ^~~~~~~
../pldmd/instance_id.cpp:8:1: error: ‘uint8_t’ does not name a type
8 | uint8_t InstanceId::next()
| ^~~~~~~
../pldmd/instance_id.cpp:4:1: note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
3 | #include <stdexcept>
+++ |+#include <cstdint>
4 |
[9/113] Compiling C++ object libpldmresponder/test/libpldmresponder_base_test.p/.._.._pldmd_dbus_impl_requester.cpp.o
FAILED: libpldmresponder/test/libpldmresponder_base_test.p/.._.._pldmd_dbus_impl_requester.cpp.o
ccache c++ -Ilibpldmresponder/test/libpldmresponder_base_test.p -Irequester -I../requester -Isubprojects/libpldm/include -I../subprojects/libpldm/include -Isubprojects/libpldm/src -I../subprojects/libpldm/src -Isubprojects/libpldm/include/libpldm -I../subprojects/libpldm/include/libpldm -Ilibpldmresponder -I../libpldmresponder -I. -I.. -I../subprojects/googletest/googletest/include -I../subprojects/googletest/googletest -Isubprojects/googletest/__CMake_build -I../subprojects/googletest/__CMake_build -Isubprojects/googletest -I../subprojects/googletest -I../subprojects/googletest/googlemock/include -I../subprojects/googletest/googlemock -I../subprojects/nlohmann-json/single_include -Isubprojects/phosphor-dbus-interfaces/gen -I../subprojects/phosphor-dbus-interfaces/gen -I../subprojects/sdbusplus/include -Isubprojects/phosphor-logging/lib/include -I../subprojects/phosphor-logging/lib/include -Isubprojects/sdeventplus/src -I../subprojects/sdeventplus/src -Isubprojects/stdplus/include -I../subprojects/stdplus/include -Isubprojects/stdplus/include-fd -I../subprojects/stdplus/include-fd -I../subprojects/fmt/include -Isubprojects/fmt/__CMake_build -I../subprojects/fmt/__CMake_build -Isubprojects/fmt -I../subprojects/fmt -I../subprojects/function2/include -Isubprojects/function2/__CMake_build -I../subprojects/function2/__CMake_build -Isubprojects/function2 -I../subprojects/function2 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Wpedantic -Werror -std=c++20 -O2 -g -Wno-psabi -DLIBPLDMRESPONDER -DFMT_LOCALE -DBOOST_ASIO_DISABLE_THREADS -DBOOST_ALL_NO_LIB -DBOOST_SYSTEM_NO_DEPRECATED -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_COROUTINES_NO_DEPRECATION_WARNING -pthread -isystem../subprojects/googletest/googletest -isystem../subprojects/googletest/googletest/include -MD -MQ libpldmresponder/test/libpldmresponder_base_test.p/.._.._pldmd_dbus_impl_requester.cpp.o -MF libpldmresponder/test/libpldmresponder_base_test.p/.._.._pldmd_dbus_impl_requester.cpp.o.d -o libpldmresponder/test/libpldmresponder_base_test.p/.._.._pldmd_dbus_impl_requester.cpp.o -c ../pldmd/dbus_impl_requester.cpp
In file included from ../pldmd/dbus_impl_requester.hpp:3,
from ../pldmd/dbus_impl_requester.cpp:1:
../pldmd/instance_id.hpp:19:5: error: ‘uint8_t’ does not name a type
19 | uint8_t next();
| ^~~~~~~
../pldmd/instance_id.hpp:4:1: note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
3 | #include <bitset>
+++ |+#include <cstdint>
4 |
../pldmd/instance_id.hpp:24:19: error: ‘uint8_t’ has not been declared
24 | void markFree(uint8_t instanceId)
| ^~~~~~~
../pldmd/dbus_impl_requester.cpp: In member function ‘virtual uint8_t pldm::dbus_api::Requester::getInstanceId(uint8_t)’:
../pldmd/dbus_impl_requester.cpp:25:23: error: ‘std::map<unsigned char, pldm::InstanceId>::mapped_type’ {aka ‘class pldm::InstanceId’} has no member named ‘next’
25 | id = ids[eid].next();
| ^~~~
[19/113] Compiling C++ object libpldmresponder/libpldmresponder.so.0.1.p/.._host-bmc_dbus_to_host_effecters.cpp.o
ninja: build stopped: subcommand failed.
```

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I8aab8ee5c9b9fe66e868b829342f4c2b071f0127

show more ...