| 87083f26 | 17-Apr-2023 |
Pavithra Barithaya <pavithra.b@ibm.com> |
Fix a bug in libpldmresponder
This commit fixes the bug in the getStateSensorReading
command handler. We need to check the correct request bytes for
getStateSensorReading command (Section 20.2 in DS
Fix a bug in libpldmresponder
This commit fixes the bug in the getStateSensorReading
command handler. We need to check the correct request bytes for
getStateSensorReading command (Section 20.2 in DSP0248)
and not getSensorReading command (Section 18.2 in DSP0248).
Change-Id: I0e5bf8774903c724ef3d9a4db76686ac6b0f897a
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>
show more ...
|
| 49cfb138 | 02-Mar-2023 |
Riya Dixit <riyadixitagra@gmail.com> |
PLDM: Implementing Phosphor-Logging/LG2 logging
This commit adds changes in PLDM for implementing
structured LG2 logging, thereby moving away from
std::cout/cerr practice of logging which are
output
PLDM: Implementing Phosphor-Logging/LG2 logging
This commit adds changes in PLDM for implementing
structured LG2 logging, thereby moving away from
std::cout/cerr practice of logging which are
output streams and not logging mechanism.
PLDM now can make use of lg2 features like accurate
CODE LINE Number and CODE_FUNCTION Name and better
detailing in json object values which can be used in
log tracking.
More detailed logging change:
https://gist.github.com/riyadixitagra/c251685c1ba84248181891f7bc282395
Tested:
Ran a power off, on, cycle, and reset-reload.
Change-Id: I0485035f15f278c3fd172f0581b053c1c37f3a5b
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>
show more ...
|
| 6c39c7a7 | 05-Dec-2022 |
ArchanaKakani <archana.kakani@ibm.com> |
Populate correct terminusId
Hardcoded terminus id 0 is used at multiple places in the current code.
Made changes to populate correct terminus id instead of hardcoded one.
Change-Id: I63cedcb38fb2d9
Populate correct terminusId
Hardcoded terminus id 0 is used at multiple places in the current code.
Made changes to populate correct terminus id instead of hardcoded one.
Change-Id: I63cedcb38fb2d993e2e4a2b45846c19531d55839
Signed-off-by: ArchanaKakani <archana.kakani@ibm.com>
show more ...
|
| 5f213471 | 29-Aug-2022 |
Pavithra Barithaya <pavithra.b@ibm.com> |
PLDM : fix the invalid effecter and sensor PDRs
The LED effecter and sensor PDRs where created even when
the FRU or the entity path was not present which puts the
entity ID in the PDR as 0. This com
PLDM : fix the invalid effecter and sensor PDRs
The LED effecter and sensor PDRs where created even when
the FRU or the entity path was not present which puts the
entity ID in the PDR as 0. This commit fixes that issue.
Change-Id: I70f1838cfe613a4f11432105b793e465e8fa8adb
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>
show more ...
|
| b90fb7fd | 12-Apr-2023 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t
Change-Id: I3f8b8f54bcb0018d48d1e9aa0628f9bb271a8fd7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 8fbf3ccc | 11-Apr-2023 |
Andrew Jeffery <andrew@aj.id.au> |
libpldmresponder: platform: Remove awkward reinterpret_cast()
Arrays naturally decay to pointers. The reinterpret_cast() is required
if you're trying to take the address of the array and coerce the
libpldmresponder: platform: Remove awkward reinterpret_cast()
Arrays naturally decay to pointers. The reinterpret_cast() is required
if you're trying to take the address of the array and coerce the type
into the array's underlying type, but if we exploit the natural decay we
can drop the reinterpret_cast():
```
$ g++ -std=c++20 -x c++ -Wall -pedantic -Werror - \
> <<< 'unsigned char a[4]; unsigned char *s = &a; int main() { }'
<stdin>:1:40: error: cannot convert ‘unsigned char (*)[4]’ to ‘unsigned char*’ in initialization
$ g++ -std=c++20 -x c++ -Wall -pedantic -Werror - \
> <<< 'unsigned char a[4]; unsigned char *s = a; int main() { }'
$ echo $?
0
$
```
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I6ab3912d9065e33d2c36ea916c9abaa98a2b3076
show more ...
|
| d987c94c | 24-Mar-2023 |
Matt Spinler <spinler@us.ibm.com> |
Listen for ifacesAdded for BIOS attribute props
PLDM was just watching for PropertiesChanged signals on the D-Bus
properties that back BIOS attributes. Just doing that can miss
properties on interf
Listen for ifacesAdded for BIOS attribute props
PLDM was just watching for PropertiesChanged signals on the D-Bus
properties that back BIOS attributes. Just doing that can miss
properties on interfaces that get added after PLDM starts and then never
change after that, because they would just send a single InterfacesAdded
signal.
Close that hole by also adding an InterfacesAdded match along with the
PropertiesChanged match.
Change-Id: Iab6679b0c99d049bd5f11e6508f784b2e8eb9349
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
show more ...
|
| 040c618b | 20-Feb-2023 |
Archana Kakani <archana.kakani@ibm.com> |
Handle Dbus query exception gracefully
For every Dbus query PLDM uses new_method_call defined in
Sdbusplus. Any error during dbus query it throws an exception.
Modifying code to handle the exception
Handle Dbus query exception gracefully
For every Dbus query PLDM uses new_method_call defined in
Sdbusplus. Any error during dbus query it throws an exception.
Modifying code to handle the exception thrown by new_method_call
Change-Id: Ie474e1d230773cb184127b71d333846090ad6c84
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>
show more ...
|
| d21b57d7 | 09-Feb-2023 |
Sagar Srinivas <sagar.srinivas@ibm.com> |
PLDM: Add the full namespaces reference
This commit is to add complete namespaces for
function parameters.
Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: I2b55bd3a0b0f78ce0299a46
PLDM: Add the full namespaces reference
This commit is to add complete namespaces for
function parameters.
Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: I2b55bd3a0b0f78ce0299a46e6a624934d7ac2116
show more ...
|
| c453e164 | 21-Dec-2022 |
George Liu <liuxiwei@inspur.com> |
libpldm: Correct reference to libpldm header files
When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.
Tested: Built pldm succ
libpldm: Correct reference to libpldm header files
When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.
Tested: Built pldm successfully after enabling ibm-oem
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia1997de7e0f61564055bbd837f4e24c8f14e55a5
show more ...
|
| 3618064e | 08-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
prettier: re-format
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.
prettier: re-format
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.
Change-Id: I0d25f27a5e449578967915d9f570cc29246927d7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 561c019a | 06-Dec-2022 |
ArchanaKakani <archana.kakani@ibm.com> |
Fixed compilation error
Fixed the compilation error caused due to libpldm changes.
Change-Id: I63c6a015ac626114cfbe15681facbfbf14c2abf4
Signed-off-by: ArchanaKakani <archana.kakani@ibm.com> |
| cac0ebb2 | 23-Nov-2021 |
Sagar Srinivas <sagar.srinivas@ibm.com> |
pldm: Trace out BIOS attribute change
To remove "setBIOSTable:: updateBaseBIOSTableProperty()"
trace. Instead add trace to indicate which attribute
changed, what is the new value it is changed to an
pldm: Trace out BIOS attribute change
To remove "setBIOSTable:: updateBaseBIOSTableProperty()"
trace. Instead add trace to indicate which attribute
changed, what is the new value it is changed to and
who is it set by.
TESTED:
* Value not set by BMC
pldmtool bios SetBIOSAttributeCurrentValue -a fw_boot_side_current -d Temp
{
"Response": "SUCCESS"
}
BIOS:fw_boot_side_current, updated to value: Temp(42), by BMC: false
* Value set by BMC
busctl set-property xyz.openbmc_project.BIOSConfigManager /xyz/openbmc_project/bios_config/manager xyz.openbmc_project.BIOSConfig.Manager PendingAttributes a{s\(sv\)} 1 "fw_boot_side_current" "xyz.openbmc_project.BIOSConfig.Manager.AttributeType.Enumeration" s "Temp"
BIOS:fw_boot_side_current, updated to value: Temp(42), by BMC: true
Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: I70e31b730026941a9973b1eb1118d8c300be5a54
show more ...
|
| 68f5bbdf | 07-Oct-2022 |
Patel-Kamalkumar <kamalkumar.patel@ibm.com> |
PLDM: Fixed broken testcase for upstream
- This commit fixed broken testcase for upstream.
- Testcase was broken due to container id got changed from
0 to 1.
Container ID changed as part of this com
PLDM: Fixed broken testcase for upstream
- This commit fixed broken testcase for upstream.
- Testcase was broken due to container id got changed from
0 to 1.
Container ID changed as part of this commit:
97296e0355bb93fec84daa4623f4873f5f3875af
Signed-off-by: Patel-Kamalkumar <kamalkumar.patel@ibm.com>
Change-Id: Ib40d2334ddf742f40fded65ee90f4384ebf2bcad
show more ...
|
| 27a022ca | 10-Aug-2022 |
Andrew Jeffery <andrew@aj.id.au> |
libpldm: Migrate to subproject
Organize files in libpldm to make it a subproject
In the current state, libpldm is not readily consumable
as a subproject.This commit does all the necessary re-organi
libpldm: Migrate to subproject
Organize files in libpldm to make it a subproject
In the current state, libpldm is not readily consumable
as a subproject.This commit does all the necessary re-organisation
of the source code to make it work as a subproject.
There are no .c/.h files changes in this commit, only meson
changes and re-organising the code structure.
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I20a71c0c972b1fd81fb359d604433618799102c6
show more ...
|
| eefe49bf | 27-Jun-2022 |
Sridevi Ramesh <sridevra@in.ibm.com> |
Add API to create fru records only for present frus.
This commit builds the fru records only for the present
frus. Any item which is a FRU should by default implement
the Inventory.Item Interface an
Add API to create fru records only for present frus.
This commit builds the fru records only for the present
frus. Any item which is a FRU should by default implement
the Inventory.Item Interface and host the present property.
So, if the present property is not hosted then FRU is absent.
Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>
Change-Id: I5534d6cc1a9f7a1b329975cdd5de54110f456f39
show more ...
|
| 297720aa | 12-Sep-2022 |
Pavithra Barithaya <pavithra.b@ibm.com> |
PLDM : Changes in setDateTime command
The BMC will have the correct time when in NTP mode, so we
don't need to try and set the time again which may cause
potential time drifts.
Tested: Using pldmto
PLDM : Changes in setDateTime command
The BMC will have the correct time when in NTP mode, so we
don't need to try and set the time again which may cause
potential time drifts.
Tested: Using pldmtool
Change-Id: I86b2c056ea6628ed4dffeb7ad754bdd1ba295f42
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>
show more ...
|
| ae5c97eb | 29-Aug-2022 |
Pavithra Barithaya <pavithra.b@ibm.com> |
PLDM: Handling modified PDRs
This commit handles the PDRs which are modified.
This also prevents the looping of host PDRs when we get
the modified PDR in between the PDR exchange. With this
change w
PLDM: Handling modified PDRs
This commit handles the PDRs which are modified.
This also prevents the looping of host PDRs when we get
the modified PDR in between the PDR exchange. With this
change we will fetch only the modified PDRs and not all
the PDRs again.
Change-Id: If674f23ce83f44853c74139c9d3c4e5aea05259a
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>
show more ...
|
| 52aad393 | 02-Aug-2022 |
Pavithra Barithaya <pavithra.b@ibm.com> |
PLDM: Restrain from adding duplicate TL PDRs
This commit inhibits adding the duplicate terminus locator PDRs
to the repo. When the PDRs are removed based on the
terminus handle, the terminus locator
PLDM: Restrain from adding duplicate TL PDRs
This commit inhibits adding the duplicate terminus locator PDRs
to the repo. When the PDRs are removed based on the
terminus handle, the terminus locator PDR info is also
deleted from the map.
Tested with the normal poweron.
Change-Id: Ib973a41dc42324f9b5453a5f1a6592dc306729ff
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>
show more ...
|
| e7cd7ce3 | 29-Aug-2022 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
responder : Improve tracing to debug problems
Improving the tracing , so that when we see it on journal
we can actually find some thing useful & hopefully be able
to find the root cause of the probl
responder : Improve tracing to debug problems
Improving the tracing , so that when we see it on journal
we can actually find some thing useful & hopefully be able
to find the root cause of the problem.
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Id589a36db81300f9ca3cc8553a72141865e15a10
show more ...
|
| b941eeb4 | 17-Aug-2022 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Fix libpldm includes in the responder
The header files from libpldm are installed in
libpldm/<.h> pattern, so fixing the header includes to
have folder name prepended.
Signed-off-by: Manojkiran Eda
Fix libpldm includes in the responder
The header files from libpldm are installed in
libpldm/<.h> pattern, so fixing the header includes to
have folder name prepended.
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I0c1c326b3bac4e328d679253c60ac69f2082041e
show more ...
|
| 998dc4eb | 27-Jul-2022 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Move oem libpldm code inside libpldm
Moving the oem support inside the libpldm folder would
help us to migrate libpldm folder into its own repository.
Signed-off-by: Manojkiran Eda <manojkiran.eda@
Move oem libpldm code inside libpldm
Moving the oem support inside the libpldm folder would
help us to migrate libpldm folder into its own repository.
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I4596e9e001c985864431a56343318e5f93d3ede3
show more ...
|
| 84b790cb | 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8e2242adb79be342562c9b7f3d2153dfdf578085
show more ...
|
| cb454677 | 29-Jun-2022 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
libpldm : Fix ver32 encoding declaration
This commit would attempt to fix the wrongly captured
ver32 structure declaration in libpldm & impacted test
cases.
Resolves : https://github.com/openbmc/pl
libpldm : Fix ver32 encoding declaration
This commit would attempt to fix the wrongly captured
ver32 structure declaration in libpldm & impacted test
cases.
Resolves : https://github.com/openbmc/pldm/issues/27
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I9dccd4377bb1ef0e7738527ff154fd75f6277f39
show more ...
|
| fc0ce97a | 24-Jun-2022 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Fix typos/incorrect naming in public API's
This commit attempts to fix the pointed typo's &
incorrect naming in the public API's exposed by libpldm.
Resolves https://github.com/openbmc/pldm/issues/
Fix typos/incorrect naming in public API's
This commit attempts to fix the pointed typo's &
incorrect naming in the public API's exposed by libpldm.
Resolves https://github.com/openbmc/pldm/issues/30
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I5ddab36222ee2a19980fdc507d7c508f3fd18eff
show more ...
|