bb45d021 | 27-Aug-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Fix certificate management tabbing
- Adds focus to "choose file" button when replacing certificate - Adds input-file.scss to elements
Tested: - Passes DAP - Tabs correctly in all browsers
Signed-o
Fix certificate management tabbing
- Adds focus to "choose file" button when replacing certificate - Adds input-file.scss to elements
Tested: - Passes DAP - Tabs correctly in all browsers
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I48c61f4176bc3e3fe55425dafc79e8f2edb934b2
show more ...
|
f4a43cca | 26-Aug-2019 |
Kuiying Wang <kuiying.wang@intel.com> |
Fix issue on IE cannot open SOL page
The root cause is that TextEncoder/TextDecoder does not support IE More detail at https://caniuse.com/#feat=textencoder
One workable solution is to include text
Fix issue on IE cannot open SOL page
The root cause is that TextEncoder/TextDecoder does not support IE More detail at https://caniuse.com/#feat=textencoder
One workable solution is to include text-encoder lib, as this patch did.
Tested: IE visit BMC and navigate to "#/server-control/remote-console" SOL page is working well.
Change-Id: I5019c626afcf67916252db4115af7616c7a9759b Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>
show more ...
|
fa8697b3 | 26-Aug-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Fix SoL open in new tab Safari bug
Wrapped WebSocket constructor in try/catch block to avoid compile errors in controller.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I38fb
Fix SoL open in new tab Safari bug
Wrapped WebSocket constructor in try/catch block to avoid compile errors in controller.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I38fbc1e5898b0b70d8a16e3f16a244e04e18347e
show more ...
|
c799714d | 03-Sep-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Update local user role table
Currently the Operator and User roles are not able to change their own account's password. This commit will remove checkmarks from 'Update password for current user acco
Update local user role table
Currently the Operator and User roles are not able to change their own account's password. This commit will remove checkmarks from 'Update password for current user account' description for Operator and User until it is supported by Redfish.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I93f1b37c116b74970790c9e4ad358db071ca8524
show more ...
|
0c1e09e6 | 26-Aug-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Fix IE11 replace certificate button
- Refactored button and icon markup on certificate management in order to trigger click in IE11
Tested: - Confirmed button functionality in Chrome, IE11, Firef
Fix IE11 replace certificate button
- Refactored button and icon markup on certificate management in order to trigger click in IE11
Tested: - Confirmed button functionality in Chrome, IE11, Firefox, Edge and Safari - Buttons and icons pass DAP - File upload inaccessible, unable to tab to "choose file" button Will correct in separate commit
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I6b0b9a56386a74b25a7a35d0cc03c9b0d32c3478
show more ...
|
0769609d | 27-Aug-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Fix IE11 remove button on network settings
- Adds button type to buttons for IPv4 and DNS
Tested: Verified remove button deletes IPv4 and DNS server
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.co
Fix IE11 remove button on network settings
- Adds button type to buttons for IPv4 and DNS
Tested: Verified remove button deletes IPv4 and DNS server
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I7827f49a910c14b9df0575f678d8f121258446f6
show more ...
|
8c80dbd9 | 08-Aug-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add user role privilege table
Created a directive to handle display of user privilege roles on the local user management page.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I
Add user role privilege table
Created a directive to handle display of user privilege roles on the local user management page.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I83caea33356012752c7a67301fa2a372f0c28620
show more ...
|
bb688795 | 12-Aug-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add tableActions component
Creating a separate table actions component to allow row action customizations like disabling certain actions and rendering different icons.
Signed-off-by: Yoshie Muranak
Add tableActions component
Creating a separate table actions component to allow row action customizations like disabling certain actions and rendering different icons.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I85e96045af27701f5ecc4af9bf824e248abccbf5
show more ...
|
b4d9c09a | 01-Aug-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add local user manual unlock
Enables manual unlock from the GUI when a user is locked out due to failed login attempts above allowed threshold.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.
Add local user manual unlock
Enables manual unlock from the GUI when a user is locked out due to failed login attempts above allowed threshold.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I63e28a4d6feed9eb6d4d09c0431d31e7bd6924c2
show more ...
|
dbafdc5f | 28-Jun-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Enable CA certificate upload
This patchset enables CA certificate type to be uploaded in the GUI.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I52953933f6fd3dbd363c42b887996
Enable CA certificate upload
This patchset enables CA certificate type to be uploaded in the GUI.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I52953933f6fd3dbd363c42b887996942b99b358e
show more ...
|
5e8785d3 | 10-Jun-2019 |
miramurali23 <miramurali23@gmail.com> |
Create csr modal
The CSR Modal allows users to generate a CSR code. Once the user types in the necessary information to generate the CSR code, that modal will then render the code and the user will
Create csr modal
The CSR Modal allows users to generate a CSR code. Once the user types in the necessary information to generate the CSR code, that modal will then render the code and the user will be able to either copy the code or download the code in a txt file.
Tested: loaded onto Witherspoon and able to view on certificate management page. Click on generate csr and type in necessary (or any additional info), then click on generate CSR. The CSR code is then visible and is able to be copied or downloaded. In error state in which CSR code is unable to generate, the modal closes and an error toast message appears. FYI: Sometimes you have to reboot system in order for csr to successfully generate.y
Signed-off-by: Mira Murali <miramurali23@gmail.com> Change-Id: I3cca09c494357496166164b5ee8ff99250ef981d
show more ...
|
0433e005 | 13-Aug-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Fix app header template rendering in Safari
Add 'connect-src' directive to Content Security Policy to allow WebSocket connection. Added additional error handling when Websocket connection refused.
Fix app header template rendering in Safari
Add 'connect-src' directive to Content Security Policy to allow WebSocket connection. Added additional error handling when Websocket connection refused.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I83cfaa0b314099aea57ee7f2be75a0658462b2a9
show more ...
|
e368108f | 21-Jun-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Add boot option override and TPM enable toggle
- Adds ability to set a bootsource override to allowable target value - Adds ability to enable or disable TPM required policy - Replaces power operatio
Add boot option override and TPM enable toggle
- Adds ability to set a bootsource override to allowable target value - Adds ability to enable or disable TPM required policy - Replaces power operations confirm directive with bootstrap modal
Tested: Confirmed override settings saved to redfish but unable to verify if settings are automatically set to disabled by petitboot after a one time boot. Passes DAP.
Resolves openbmc/phosphor-webui#82 Resolves openbmc/phosphor-webui#90
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: If0ffd6f9328939d70c7958ee11fb90bd20a1e685 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
fb79e54c | 12-Aug-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add password visibility toggle
This commit will add a new password visibility toggle directive. The new directive was added to the local user management, user modal password input fields.
Signed-of
Add password visibility toggle
This commit will add a new password visibility toggle directive. The new directive was added to the local user management, user modal password input fields.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I4e2baf53eec04aaff1bba26948779de6e447e3e7
show more ...
|
fa56273d | 17-Jul-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Update local user table to new design
This commit will introduce a reusable data table component. By creating a reusable component, we can ensure tables in the GUI will look consistent and common ta
Update local user table to new design
This commit will introduce a reusable data table component. By creating a reusable component, we can ensure tables in the GUI will look consistent and common table actions (sort, select row) are shared.
- Created new components directory to store shared components - Add password-confirmation directive - Remove some error handling from API utils so it can be handled in the UI
TODO: - Add show/hide toggle to password fields - Enhance table component with icons - Manual user unlock - Batch table actions - Role table
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I03c95874d2942a2450a5da2f1d2a8bb895aa1746
show more ...
|
30d7c637 | 31-Jul-2019 |
Derick Montague <derick.montague@ibm.com> |
Update overview page to use new UI patterns
- Use page, section, list-pair to establish consistent layout - Update header and overview page to use new caret icon - Reordered Server and BMC infor
Update overview page to use new UI patterns
- Use page, section, list-pair to establish consistent layout - Update header and overview page to use new caret icon - Reordered Server and BMC information to accomodate small screen views - Added chevron icons to create consistency between header and server overview page quick links - Changed edit hostname text to use the standard icon - Added OR operator to short circuit the server model, server serial number, and server manufacturer to display N/A if the information is not available
Change-Id: I6619f5369ff290555142e85aa432e901c4f93d2d Signed-off-by: Derick Montague <derick.montague@ibm.com>
show more ...
|
c652ed18 | 19-Jul-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Update toggle component
- Adds text to indicate the current state of the toggle button to meet accessibility guidelines - Update size, color, and focus of toggle component to fix DAP violations
Update toggle component
- Adds text to indicate the current state of the toggle button to meet accessibility guidelines - Update size, color, and focus of toggle component to fix DAP violations - Add page, section, and list-pair layout patterns established on the power usage page to begin a pattern for consistent page layout - Add form__field and form__actions to help with form layout consistency.
Tested: Verified toggle functions in the GUI and tested with screen reader. Passes DAP.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: Iaa8646b1179cc307971065c455f4b9448095d1ec
show more ...
|
c81cdd4a | 25-Jul-2019 |
Zbigniew Kurzynski <zbigniew.kurzynski@intel.com> |
Extending certificate table with Issuer and Subject columns.
This commit introduce two new columns on certificate table. It should help user to differentiate multiple mTLS certificates.
Date format
Extending certificate table with Issuer and Subject columns.
This commit introduce two new columns on certificate table. It should help user to differentiate multiple mTLS certificates.
Date format was changed to 'medium' one to accommodate two new columns. Small corrections were made to action button paddings to make the icon better centered.
Tested: GUI tests were done on Chromium v74.0.3729 browser. Desktop and mobile version.
Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com> Change-Id: I660b74dd8b50f854ebbdad1890bbf99b3675f4cd
show more ...
|
dc25db03 | 31-Jul-2019 |
Ed Tanous <ed.tanous@intel.com> |
Fix IE11 support
While we don't really officially support IE, it would be nice if _most_ non-complicated things actually worked. Given where transpilation is, and the fact that we already have webp
Fix IE11 support
While we don't really officially support IE, it would be nice if _most_ non-complicated things actually worked. Given where transpilation is, and the fact that we already have webpack, this isn't actually that riddiculous of an idea.
using babel was the intent with the original webpack stuff, but it turns out babel-loader wasn't pulling in the babelrc properly when it was in the root dir, so babel wasn't actually transpiling anything properly.
Functionally, this commit does 3 things: 1. Fixes the published Accepts header, as the ajax call confuses IE if it doesn't have an encoding. 2. Includes core-js, to allow us to not really have to worry about javascript features that aren't present in a given browser. 4. Includes the config to support all browsers with > 0.25% market share, which should keep us compatible with most stuff.
Requires a patch to bmcweb for the updated charset header, as we didn't handle that properly previously. https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/24063
Tested: Loaded the bmcweb patch. Started the webui in IE11 with the console open. Observed that webui launches and logs in properly with no errors on the console. Opened the webui in chrome to verify that nothing was broken. Appears working as it was before.
Measured the pre-rootfs size before and after this patchset. It adds 36KB to the final package size. (404KB to 440KB). For supporting IE11 (and probably other browsers) I think this is well worth the cost.
Signed-off-by: Ed Tanous <ed.tanous@intel.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Change-Id: Ie402e3296deede466a7a05726ebd7a18bead0b80
show more ...
|
c9c8e67b | 24-Jul-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove Associations property from inventory item
If the inventory item had a Assocations interface, it would have a Assocations property. This Assocations property showed on the inventory panel unde
Remove Associations property from inventory item
If the inventory item had a Assocations interface, it would have a Assocations property. This Assocations property showed on the inventory panel under the individual inventory item dropdown.
There can be a lot of Associations, the chassis for example associates to a lot of sensors, and they are long, full D-Bus paths. Not very useful and can overwhelm the dropdown so remove the property.
One day we might want something to associate an inventory item to an object (e.g. sensors). This would require design changes to accommodate this.
Support both the old and new Associations interface. See https://github.com/openbmc/openbmc/issues/3584
Tested: Built an image and loaded on a Witherspoon. No longer see this property. Change-Id: Ib67e36c7536a42eb56e65b6dbe6fd8798976ee08 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
f1aadb90 | 01-Jul-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Update icons to fix sizing and overflow issues
Re-exported icon-control.svg and icon-replace.svg to resolve issues around sizing and overflow. These new icons will allow us to remove CSS 'hacks' in
Update icons to fix sizing and overflow issues
Re-exported icon-control.svg and icon-replace.svg to resolve issues around sizing and overflow. These new icons will allow us to remove CSS 'hacks' in place to prevent unexpected focus state overflows and allow icon resizing by changing the width on the icon class name. Small scss updates were included to account for this fix.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I07bbe5bb0c82ee653f2342089c0c1373a51cc168
show more ...
|
5ff98780 | 18-Jul-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Refactor power operations
Refactored power operations to use checkHostStatus function that checks host_status property provided by dataService, instead of polling for host/chassis status. Added prop
Refactor power operations
Refactored power operations to use checkHostStatus function that checks host_status property provided by dataService, instead of polling for host/chassis status. Added property to check when a power operation is in progress. This property will show/hide the in progress message and make other operations unavailable until the operation completes. We were previously checking whether the server_state property was set to 'Unreachable', which enables the Power on button in the middle of a reboot, since the server_state changes to 'Off' during reboot.
- Removed unused $timeout service
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I234749a9a875c7370b52bd23ed74d6e9617cf5e2
show more ...
|
eaa40dd3 | 17-Jul-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add 403 $location redirect to http interceptor service
This is a temporary solution to redirect any 403 responses to a dedicated 403 'Unauthorized' page. This could occur on inital navigation to a p
Add 403 $location redirect to http interceptor service
This is a temporary solution to redirect any 403 responses to a dedicated 403 'Unauthorized' page. This could occur on inital navigation to a page or while attempting an operation.
Once permission role mapping is defined, the code should be updated to handle 403 responses in context of user attempted actions.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ia207f2bcdd87fb20888fe6a1588d0ccd310e484c
show more ...
|
22d7822d | 18-Jul-2019 |
George Liu <liuxiwei@inspur.com> |
Fix array index out of bounds exception
We should be verified string length when the phosphor-webui calls the getFirmwares function to handle the property value of ExtenVersion. because it is risky
Fix array index out of bounds exception
We should be verified string length when the phosphor-webui calls the getFirmwares function to handle the property value of ExtenVersion. because it is risky to get the first address of array when that is empty
Tested: Built phosphor-webui and get a effective array of titlePart via console from WEBUI.
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: Ife08d208eb7fbeb71284ae0700fb5d871343a298
show more ...
|
6f7ec80e | 24-Jun-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Clean up color values
This update will clean up slight color variations in the code base by creating and using Sass color variables instead of hex values. Available colors are defined in colors.scss
Clean up color values
This update will clean up slight color variations in the code base by creating and using Sass color variables instead of hex values. Available colors are defined in colors.scss. Any usage of CSS color properties should refer to the mapped color variables in colors.scss.
- Removed tags.scss file since tag components no longer used
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I045030a158469e59d07a9fa8cd8aa9f125f0d383
show more ...
|