Fix date and time settings bug

When time mode is initially set to Manual from NTP,
NTP service is disabled and the NTP service is stopping
but not stopped, setting time will return an error.
There a

Fix date and time settings bug

When time mode is initially set to Manual from NTP,
NTP service is disabled and the NTP service is stopping
but not stopped, setting time will return an error.
There are no response messages to notify when
NTP is completely stopped.

To work around, a timeout is set to allow NTP to fully stop
before saving date/time changes.

https://github.com/openbmc/phosphor-time-manager/blob/master/README.md

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: Icb86dfe339a10567aecf9aedd9b0dd696937a398

show more ...

Enabling multiple TrustStore Certificates uploading.

The TrustStore should be used to hold TLS certificates, but current
TrustStore implementation does not support multiple certificates.
This GUI ch

Enabling multiple TrustStore Certificates uploading.

The TrustStore should be used to hold TLS certificates, but current
TrustStore implementation does not support multiple certificates.
This GUI change should allow users to add more than one certificate
to TrustStore managed by OpenBMC.

Tested: GUI tests were done on Chromium v74.0.3729 browser.
It is possible to add multiple TrustStore Certificate
and only single LDAP and HTTPs certificates.

Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: Ia7c8400d039e980ad3d1c2cfd25aa7e29699d683
Depends-On: Icd33723c1fc2580679aaaf54b3e99dfb09342402

show more ...

Clean up icons

Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss files.

- Moved/removed

Clean up icons

Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss files.

- Moved/removed on, off, critical, warning svg icons from
assets directory
- Updated background-image status icons to use <icon>
or <status-icon> directive

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ic0f06d78b0861d6f60d40b2dcc0b80fd6dad2a88

show more ...

Update Callback role privileges

The "Callback" role currently is an IPMI access point, can ssh
to the BMC, and is a Readonly user in Redfish and the WebUI.

Added a TODO to revisit this.

See:
https

Update Callback role privileges

The "Callback" role currently is an IPMI access point, can ssh
to the BMC, and is a Readonly user in Redfish and the WebUI.

Added a TODO to revisit this.

See:
https://github.com/openbmc/bmcweb/commit/88e097c4cfa1172504d802e9f6b327f095f2748e

Tested: Loaded on a Witherspoon. Now see checkmarks for Callback
in the following rows: Log in to the service and read
resources, IPMI access point, Redfish access point, SSH
access point, and WebUI access point.

Change-Id: Ica4863b1a424d0b115fb48b988c712fe27c99d74
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fix SoL and KVM refresh bug

Clicking the refresh button in the app header on the SoL and
KVM pages would fail to reload because the wrong element reference
is passed to the contructor after the relo

Fix SoL and KVM refresh bug

Clicking the refresh button in the app header on the SoL and
KVM pages would fail to reload because the wrong element reference
is passed to the contructor after the reload. Angular recommends
using directives for any DOM manipulation.

- Use the $element ref availble in serial-console.js directive to
select DOM element to open the terminal
- Switch kvm controller to directive to be able to use element ref
in the link function to select DOM element to pass as target

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ia7391e42bf335b8c3558d25df15c052db245ee3d

show more ...

Change navigation submenu transition duration and ease

The current submenu navigation expanstion is too fast.
This commit will change the speed from 110ms to 400ms
and change the timing function fro

Change navigation submenu transition duration and ease

The current submenu navigation expanstion is too fast.
This commit will change the speed from 110ms to 400ms
and change the timing function from ease to cubic-bezier.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Iec1b9ac9dd19aa8ef43bf1845ab4f1d259b9ef0b

show more ...

Fix rounded button styling

Add 'btn' class on Reboot and Shutdown buttons on
power operations page to make sure borders aren't
rounded.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Cha

Fix rounded button styling

Add 'btn' class on Reboot and Shutdown buttons on
power operations page to make sure borders aren't
rounded.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I3369acd52ad1992d4340ef6c194b81b5dc0ce001

show more ...

Improve LDAP accessibility

-Fixes accessibility issues for table sort buttons,
fieldset legend, checkboxes and radio buttons
-Fixes tabbing to checkboxes
-Stops tabbing to disabled sort buttons by a

Improve LDAP accessibility

-Fixes accessibility issues for table sort buttons,
fieldset legend, checkboxes and radio buttons
-Fixes tabbing to checkboxes
-Stops tabbing to disabled sort buttons by adding ng-disabled
-Removes aria-hidden from modals

Tested: Verified no violations using DAP tool.

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I9ad240d5ed151a362c0000fdab3ebf1f2997b226

show more ...

Update users navigation section

- Changed the section name to be access-control
- Moved LDAP Settings and Certificate Management to access-control navigation
- Changed Manage User Account subsection

Update users navigation section

- Changed the section name to be access-control
- Moved LDAP Settings and Certificate Management to access-control navigation
- Changed Manage User Account subsection name to Local User Management

Resolves: openbmc/phosphor-webui#619

Signed-off-by: Mira Murali <miramurali23@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I0d94c80c295b997d94c04330fd87f4fc4d229bf8

show more ...

LDAP configuration and user groups

Adds LDAP page and ability to add and change configuration settings.
Adds ability to add, remove and edit user groups for LDAP.

Resolves openbmc/phosphor-webui#38

LDAP configuration and user groups

Adds LDAP page and ability to add and change configuration settings.
Adds ability to add, remove and edit user groups for LDAP.

Resolves openbmc/phosphor-webui#38
Resolves openbmc/phosphor-webui#39

Tested: Loaded on to a witherspoon and able to add initial LDAP config
as well us update the configuration and role groups. Appropriate messages displayed
to user when required fields are missing or in the incorrect format.

Change-Id: If8a21f3f9d9334415ead73472e90b2a0823bf9ea
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>

show more ...

Update boot override UI messaging visibility

When a user changes the boot setting override option
to 'None' on the Server power operations page, the
Enable one time boot checkbox should not be check

Update boot override UI messaging visibility

When a user changes the boot setting override option
to 'None' on the Server power operations page, the
Enable one time boot checkbox should not be checked and
'Pending one time boot' message should not be displayed.

- Removed duplicate id and unused ng-change attributes

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ia8771c2984fe41c64dde9b0c702b82a3d8305d7f

show more ...

Add error messaging for error log date filtering and Safari support

- Updated filters to use semantic markup (fieldset)
- Added check for input date type support and updated
expected date format t

Add error messaging for error log date filtering and Safari support

- Updated filters to use semantic markup (fieldset)
- Added check for input date type support and updated
expected date format to the legend
- Added error message if date format is invalid
- Updated layout to support error message

Tested the changes in the following browsers:
- Safari
- IE 11
- Chrome
- Edge
- Firefox

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: If0b874644b80640dc5bfd8211459c012807ea492

show more ...

Add batch actions to local user table

Add ability to remove, enable, disable local users in bulk.

- Updates to table-actions component to fix flickering issue
by including track by $index in ng-r

Add batch actions to local user table

Add ability to remove, enable, disable local users in bulk.

- Updates to table-actions component to fix flickering issue
by including track by $index in ng-repeat

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I67039e9b9d9cf7debe9f6ef87e71210bd4b64251

show more ...

Add batch action functionality to table Component

These changes aren't currently implemented on any table.
It will be added to event logs and local user table.

- Create tableCheckbox component to h

Add batch action functionality to table Component

These changes aren't currently implemented on any table.
It will be added to event logs and local user table.

- Create tableCheckbox component to handle custom styles
and indeterminate state which needs to be set with JS
- Update tableComponent layout to allow transition for
toolbar. Updated user-accounts layout and styles to
account for these changes

Tested on Chrome, Safari, Firefox, Edge, IE

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ic57a090db1ef66f9d33facfdc425db868ae8d8c6

show more ...

Remove unused image warn-slash.svg

This was not used anywhere.
https://github.com/openbmc/phosphor-webui/search?q=warn-slash.svg&unscoped_q=warn-slash.svg

This image was already not in the build. I

Remove unused image warn-slash.svg

This was not used anywhere.
https://github.com/openbmc/phosphor-webui/search?q=warn-slash.svg&unscoped_q=warn-slash.svg

This image was already not in the build. I.e. it was not
at /usr/share/www/app/assets/images/.

Tested: Built the GUI. Looks good.

Change-Id: Ieaacef83baf8c943f4f7679763af1529acd52720
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove unused image crit-x.svg

This was not used anywhere.
https://github.com/openbmc/phosphor-webui/search?q=crit-x.svg&unscoped_q=crit-x.svg

This image was already not in the build. I.e. it was n

Remove unused image crit-x.svg

This was not used anywhere.
https://github.com/openbmc/phosphor-webui/search?q=crit-x.svg&unscoped_q=crit-x.svg

This image was already not in the build. I.e. it was not
at /usr/share/www/app/assets/images/.

Tested: Built the GUI. Looks good.

Change-Id: I7650a8866745eae0a7ef789bd63ab94e4ec18ef2
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move Virtual Media files and route

"Virtual media" was already part of the "Server control" submenu but
the files were at app/configuration and the route was /configuration.

Marta Mazur did a simil

Move Virtual Media files and route

"Virtual media" was already part of the "Server control" submenu but
the files were at app/configuration and the route was /configuration.

Marta Mazur did a similar file and route move here as part of
supporting multiple Virtual Media endpoints:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/25218

Tested: Built and loaded on a Witherspoon. The VM route is now:
#/server-control/virtual-media. Was able to use the VM
panel.
Change-Id: Iec46a8ece7ddfbc356bc1e71875def70c4418027
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove Purpose property from inventory item

The Purpose property is not useful in the inventory item.
The field overflows to another line.

The Purpose property under a power supply inventory item:

Remove Purpose property from inventory item

The Purpose property is not useful in the inventory item.
The field overflows to another line.

The Purpose property under a power supply inventory item:
PURPOSE
xyz.openbmc_project.Software.Version.VersionPurpose.Other

When we move to Redfish, this can be removed.

An alternatives considered was only using the last part of the
purpose property (e.g. Other). Still didn not find this userful
to customers so just removed.

https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Software/Version.interface.yaml#L14

Tested: Built and loaded on a Witherspoon. Don't see the property.
Change-Id: Ie004c90f6a5e625cfa65ba39ab2be97e5e256705
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add expand/collapse functionality to table Component

This commit will add optional expand/collapse functionality
to the shared table component. Expand/collapse is not
implemented on any existing tab

Add expand/collapse functionality to table Component

This commit will add optional expand/collapse functionality
to the shared table component. Expand/collapse is not
implemented on any existing table but will be used on the
redesigned event log table.

Tested on Chrome, Safari, Firefox, Edge, IE

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ia7ecde7b5525c11c68ebdf9f609c8d690c312969

show more ...

Add sort functionality to table Component

Added optional sort function to the shared table component.
Table sort is not implemented on any existing table, but will
be used in the redesigned Event Lo

Add sort functionality to table Component

Added optional sort function to the shared table component.
Table sort is not implemented on any existing table, but will
be used in the redesigned Event Log table.

- Changed table model attribute to two separate properties
data and header to take advantage of $onChanges lifecycle
hook
- Update local user table and user role table to account for
these updates

Tested on Chrome, Safari, Firefox, Edge, IE

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I4fe68e78ae9d1228d7d9350538f61076036b1089

show more ...

Certificate management alert icons implementation and alignment

- Replaces background image icons with icon directive
- Sizes and aligns icons in certificate table

TODO:
- Remove critical icon back

Certificate management alert icons implementation and alignment

- Replaces background image icons with icon directive
- Sizes and aligns icons in certificate table

TODO:
- Remove critical icon background image in separate commit

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I2e10bc3f3432331b6dd9354dbcd0e32480894ece

show more ...

Fix filter bar clear filter button

Makes filter button screen reader friendly
and accessible.

- Adds icon directive for close icon
- Adds button type
- Icon is aria-hidden and uses an aria-label at

Fix filter bar clear filter button

Makes filter button screen reader friendly
and accessible.

- Adds icon directive for close icon
- Adds button type
- Icon is aria-hidden and uses an aria-label attribute with
the value set to clear filter

Tested:
- Filter inputs clear on close button click

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: Ifcbe603c2771156fe7a03359b144e0a0acd5e3f1

show more ...

Update SNMP page layout

This change applies global styles to improve
page layout consistency and removes unnecessary
custom styling.

- Adds page, section, form field and actions styles
- Removes un

Update SNMP page layout

This change applies global styles to improve
page layout consistency and removes unnecessary
custom styling.

- Adds page, section, form field and actions styles
- Removes unused styles

Tested:
- Passes DAP

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I96bb4732fdf160b2cc9eff0ad3ed9309ab1b9ea4

show more ...

Fix IE11 SNMP edit bug

- Removes edit button from form
- Removes focus-within (not compatible with IE11 and Edge)
and pointer-event

Tested:
- Input fields are editable and can be saved
- DAP viol

Fix IE11 SNMP edit bug

- Removes edit button from form
- Removes focus-within (not compatible with IE11 and Edge)
and pointer-event

Tested:
- Input fields are editable and can be saved
- DAP violations and page layout consistency will be addressed
in separate commit

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I2ccd06802137c2969fec686abc5b5f8e785725b6

show more ...

Fix missing expiring/expired icons and warnning messages in certificate table

- Confirmed with backend developer that we should be checking certificate expiration date with bmc date/time set
- Conve

Fix missing expiring/expired icons and warnning messages in certificate table

- Confirmed with backend developer that we should be checking certificate expiration date with bmc date/time set
- Converted both certificate expiration date and bmc date/time to EPOCH time to fix the bug

Tested: Go to Date and Time settings and change BMC time to be after or 30 days before a certificate expiration date.
Then either a warning or expiration icon and message will be displayed next to the date and message on top of the table.
To remove the expiration or warning date, upload a certificate that has an expiration date greater than 30 days after bmc time
set. The icon and warning message should now disappear.

Signed-off-by: Mira Murali <miramurali23@gmail.com>
Change-Id: I9389fe3cce5a555945adf9c56180897a6be047bf

show more ...