Remove unused sensors-controller

A 2nd sensors page was visible at server-health/sensors/:type.
This page was not reachable from the menu and did not work.
This page had several bugs flagged by sona

Remove unused sensors-controller

A 2nd sensors page was visible at server-health/sensors/:type.
This page was not reachable from the menu and did not work.
This page had several bugs flagged by sonar scanner.

Change-Id: Ib444fb398e49d469ba0693ba46856e0a5ac961d1
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove unused inventory-controller

A 2nd inventory page was visible at server-health/inventory.
This page had hardcoded data and was not reachable from the menu.
This page had several bugs flagged b

Remove unused inventory-controller

A 2nd inventory page was visible at server-health/inventory.
This page had hardcoded data and was not reachable from the menu.
This page had several bugs flagged by sonar scanner.

Change-Id: I672ad5436c877fedb409810d0ed71c58a48d1997
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove hack for 1/0 booleans

With
https://github.com/openbmc/phosphor-rest-server/commit/6691e7ca4e2adf52bac1fc3a82ed35adfce4349c
and
https://github.com/openbmc/bmcweb/commit/b79d4eef01f5fd2a24bb8dd

Remove hack for 1/0 booleans

With
https://github.com/openbmc/phosphor-rest-server/commit/6691e7ca4e2adf52bac1fc3a82ed35adfce4349c
and
https://github.com/openbmc/bmcweb/commit/b79d4eef01f5fd2a24bb8dd28792810aa718cdee
merged, this is no longer needed.
This code removed here was breaking displaying the DHCP value.

Change-Id: I465908190b1254238da8699a324a31a51771dace
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move to clang-format-6.0

The docker image moved from clang-format-5.0 to clang-format-6.0.

Change-Id: I3c615d7df1f21569531b4dc2cb0bc4f425cb43f8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Event log select all checkbox

Previously the select all checkbox selected
all events, regardless of the filter applied.
In addition, if all the events on a filtered
page were selected, the checkbox

Event log select all checkbox

Previously the select all checkbox selected
all events, regardless of the filter applied.
In addition, if all the events on a filtered
page were selected, the checkbox was not checked.

Resolves openbmc/openbmc#3373

Tested: select all checkbox selects only the
events visible to the user. If all events
are selected, 'select all' checkbox is
checked.

Change-Id: Ibd5d1942b5c1c745a544d680288fd10206c7bbc6
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Checkbox not selected with 0 log events selected

When 0 events are displayed, the 'select all'
checkbox should not be selected by default.

Resolves openbmc/openbmc#2747

Tested: box is not checked

Checkbox not selected with 0 log events selected

When 0 events are displayed, the 'select all'
checkbox should not be selected by default.

Resolves openbmc/openbmc#2747

Tested: box is not checked in the case of 0
events displayed.

Change-Id: I50a12175d29f433d9e2ba0d9c1ff4413ebc018f4
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Remove double variable set

"loading" was set twice in a row.
Remove the 1st.
Found using sonar scanner.

Change-Id: I21b40f316b7227ea003daae7924b992c1a1ed77b
Signed-off-by: Gunnar Mills <gmills@us.i

Remove double variable set

"loading" was set twice in a row.
Remove the 1st.
Found using sonar scanner.

Change-Id: I21b40f316b7227ea003daae7924b992c1a1ed77b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add config.json file

This config file will hold such data as page selection.
E.g. "powerManagement":false would disable importing the power
management page.

This file would be overwrote in bbappend

Add config.json file

This config file will hold such data as page selection.
E.g. "powerManagement":false would disable importing the power
management page.

This file would be overwrote in bbappends.

Change-Id: I740503c61b28e97792a91823cb37c7ae549650a9
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Set the power cap

Created toggle button to enable power cap and a text field to set
it. This form is similar to the set network form.
Moved logic for displaying the power cap as disabled to the
over

Set the power cap

Created toggle button to enable power cap and a text field to set
it. This form is similar to the set network form.
Moved logic for displaying the power cap as disabled to the
overview controller.

Resolves openbmc/openbmc#3221

Tested: Set the power cap on a Witherspoon
Change-Id: I62346fe3ed123b9df58d159cee2584937d46213c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove unused chassisPowerOn

chassisPowerOff was unused and called the host object.

Change-Id: If4ac2051f4eac594ac98810b157255e3294bf89a
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Add Power Usage Page

Created a new page, "Manage Power Usage".
This page is under the "Server control" tab.
This new page currently just displays the power consumption.
Future commits will allow the

Add Power Usage Page

Created a new page, "Manage Power Usage".
This page is under the "Server control" tab.
This new page currently just displays the power consumption.
Future commits will allow the user to set the power cap from
this page. One day, things like power consumption trending
data could also be on this page.

There was a blank unused controller which was for similar things,
removed it.

Tested: See the page and the consumption data. Uploaded screenshots
to openbmc/openbmc#3221
Change-Id: I9f97c58a086f34c1c1990c03d5e05b081619bd5c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove unused get BMC functions

getBMCEthernetInfo and getBMCInfo were unused.

Change-Id: I625e71803fb6c6e49ff968ad58a0021684aa723a
Tested: Manual GUI regression test on a Witherspoon.
Signed-off-b

Remove unused get BMC functions

getBMCEthernetInfo and getBMCInfo were unused.

Change-Id: I625e71803fb6c6e49ff968ad58a0021684aa723a
Tested: Manual GUI regression test on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Turn uglification back on

Fixes github bug openbmc/openbmc#2871

Turn on uglification again. It turns out, we only had one issue
preventing the UI from starting when running in uglified mode. This

Turn uglification back on

Fixes github bug openbmc/openbmc#2871

Turn on uglification again. It turns out, we only had one issue
preventing the UI from starting when running in uglified mode. This
patchset fixes the issue, and reenables uglification.

This patchset drops our gzip compressed payload size by about 50K (about
14%). While it doesn't seem like a lot now, it increases our ability
to scale the javascript payloads going forward.

Change-Id: I0744687203a9db0f4b26d1e1d2f4e3bdb4a52f78
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Last power operation

Displays correct power operation time. In the case
that there has not been a power operation, 'not
available' is displayed.

Resolves openbmc/openbmc#2957

Tested: The GUI displ

Last power operation

Displays correct power operation time. In the case
that there has not been a power operation, 'not
available' is displayed.

Resolves openbmc/openbmc#2957

Tested: The GUI displayed 'not available' when it
received a 0 value and the correct date when an
epoch was recieved.

Signed-off-by: beccabroek <rebecca.shaw@ibm.com>
Change-Id: I9573a1cdcd31ba4c02888bd46d195c91fdb916a7

show more ...

Focus on newly created DNS server field

Got feedback from IBM's design team that to help usability after adding
a DNS Server field, focus on the newly created DNS server field.

Decided to go with a

Focus on newly created DNS server field

Got feedback from IBM's design team that to help usability after adding
a DNS Server field, focus on the newly created DNS server field.

Decided to go with a directive instead of putting this in a controller
after reading:

https://stackoverflow.com/questions/22292832/angular-ng-init-pass-element-to-scope,
https://github.com/angular/angular.js/issues/9031,
https://groups.google.com/forum/#!topic/angular/6uxWl8Z0DPw

Having dom manipulation code in the controller is frowned upon.

Tested: Verified the field is in focus (i.e. the cursor is in the
textbox).
Change-Id: Ia548361e7ac47363e05ea2963807bca0c5bf51e2
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Transparent favicon background

Remove white background in OpenBmc favicon.

Resolves openbmc/openbmc#3193

Change-Id: Ia879def1046ee07f49019c021ac1080b5ce09ca4
Signed-off-by: beccabroek <rebecca.sha

Transparent favicon background

Remove white background in OpenBmc favicon.

Resolves openbmc/openbmc#3193

Change-Id: Ia879def1046ee07f49019c021ac1080b5ce09ca4
Signed-off-by: beccabroek <rebecca.shaw@ibm.com>

show more ...

Add Last Reboot Time

Added last reboot date and time to Reboot BMC Page.

Resolves openbmc/openbmc#2956

Tested: Rebooted and verified the date and time were correct.

Change-Id: I81cf46f0ad7f4e910c

Add Last Reboot Time

Added last reboot date and time to Reboot BMC Page.

Resolves openbmc/openbmc#2956

Tested: Rebooted and verified the date and time were correct.

Change-Id: I81cf46f0ad7f4e910cd6645de9830d2952091770
Signed-off-by: beccabroek <rebecca.shaw@ibm.com>

show more ...

Copy to clipboard button to include title

On the Event Log page, copy button previously copied error only.
Updates to also include title of event.

Resolves openbmc/openbmc#3146

Tested: The copy bu

Copy to clipboard button to include title

On the Event Log page, copy button previously copied error only.
Updates to also include title of event.

Resolves openbmc/openbmc#3146

Tested: The copy button now copies the title in
addition to the error to the clipboard.

Change-Id: I9580a620046203cdcb2025d0ea1cf0030e0851cb
Signed-off-by: beccabroek <rebecca.shaw@ibm.com>

show more ...

Fix change priority down arrow logic

If the Boot priority was an "Active" image then a "Functional" image.
The down arrow would be grayed out on the "Active" image.
It should not have been grayed ou

Fix change priority down arrow logic

If the Boot priority was an "Active" image then a "Functional" image.
The down arrow would be grayed out on the "Active" image.
It should not have been grayed out, i.e. the user should be able to
lower the priority on an "Active" image if there is a functional
image below it in the table.

Resolves openbmc/openbmc#3228

Tested: Tested this case and uploaded an image of the result to 3228.
Change-Id: I6033886354f76671a4d33c4d8a79097428311e93
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fix firmware page not loading

Had an image without an "Activation" property.
This image did not have an Activation interface.
Added an if for the Activation property.
Also moved the activationStatus

Fix firmware page not loading

Had an image without an "Activation" property.
This image did not have an Activation interface.
Added an if for the Activation property.
Also moved the activationStatus var so it would be empty if the
Activation property did not exist.

Resolves openbmc/openbmc#3309

Tested: The page loads now with the image missing the Activation
property.
Change-Id: I252e1277c88ce0a8b59b4f7441b1032954cef3e0
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove diagnostics page

This page was unused and unreachable from the menu.
Cleaning up the code base.

Change-Id: Icebccb111f0d775cc6bd2c95a5588f67a75af9cf
Signed-off-by: Gunnar Mills <gmills@us.ib

Remove diagnostics page

This page was unused and unreachable from the menu.
Cleaning up the code base.

Change-Id: Icebccb111f0d775cc6bd2c95a5588f67a75af9cf
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove file page

This page was unused and unreachable from the menu.
Cleaning up the code base.

Change-Id: Id2529d95768d3885448efebb6d24833ffe35c3b6
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Remove security page

This page was unused and haven't heard of any plans to implement it.
Cleaning up the code base.

Change-Id: Ie4fadc57e42f9b1c8fbc7f4c848f001ff062210f
Signed-off-by: Gunnar Mills

Remove security page

This page was unused and haven't heard of any plans to implement it.
Cleaning up the code base.

Change-Id: Ie4fadc57e42f9b1c8fbc7f4c848f001ff062210f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Date validation on event log filtering

User can no longer select an invalid date range.

Resolves openbmc/openbmc#3158

Change-Id: Ife8479b465786a617a1746fdbc5b6359f3c36e40
Signed-off-by: beccabroek

Date validation on event log filtering

User can no longer select an invalid date range.

Resolves openbmc/openbmc#3158

Change-Id: Ife8479b465786a617a1746fdbc5b6359f3c36e40
Signed-off-by: beccabroek <rebecca.shaw@ibm.com>

show more ...

Fixed spelling errors

Change-Id: I4b668b6246508d3bedda75ca179da1615516bad4
Signed-off-by: Rebecca Shaw <rebecca.shaw@ibm.com>