Create alert banner component

This reusuable component will help to make sure banner
implementations are consistent and will help reduce
redundant code.

Signed-off-by: Yoshie Muranaka <yoshiemurana

Create alert banner component

This reusuable component will help to make sure banner
implementations are consistent and will help reduce
redundant code.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I3a16f65d36c2d61abf54c300e2ed5defeadee298

show more ...

Create firmware-card component

Create reusable firmware card component that will be
used in the updated firmware page:
https://ibm.invisionapp.com/share/4XNZ0JAMJ7B#/screens/319212821_4-8-D-1_Home

Create firmware-card component

Create reusable firmware card component that will be
used in the updated firmware page:
https://ibm.invisionapp.com/share/4XNZ0JAMJ7B#/screens/319212821_4-8-D-1_Home

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I86e526c59ac5c2e2c011aed0ce4bc3d82db63b5e

show more ...

Fix table-actions error

When using the table component with table actions
enabled, if an icon file name isn't provided, the
action type should display in the table.
This will fix the webpack error w

Fix table-actions error

When using the table component with table actions
enabled, if an icon file name isn't provided, the
action type should display in the table.
This will fix the webpack error when compiling the
table component without an icon to display by changing
the ng-if directive to check for falsy values instead
of just 'null' to also catch 'undefined' values.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I72daeb035e4e5f0391953f9f2ae042d0b9fc2b99

show more ...

Remove firmware reboot timeout

A 10 second timeout was used as a tempoary work-around
before rebooting the BMC on the firmware page–removing
the timeout since it is no longer needed.

Signed-off-by:

Remove firmware reboot timeout

A 10 second timeout was used as a tempoary work-around
before rebooting the BMC on the firmware page–removing
the timeout since it is no longer needed.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I6a95d5f5bb377d3fd3cc0802f7fb3d6d0f177870

show more ...

Send password when saving LDAP settings

- Add password to the createLdapEnableRequest Authentication object to
be sent with the LDAP payload
- Add a Password to scoped ldapProperties object

Sign

Send password when saving LDAP settings

- Add password to the createLdapEnableRequest Authentication object to
be sent with the LDAP payload
- Add a Password to scoped ldapProperties object

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I63a880548bc3d9d61c4b73719457ce19222aa354

show more ...

Certificate delete API – frontend

With introducing option to add multiple certificates there is a need to give
user a possibility to remove selected certificates, for example when they
expire.
This

Certificate delete API – frontend

With introducing option to add multiple certificates there is a need to give
user a possibility to remove selected certificates, for example when they
expire.
This commit adds implementation of DELETE function to GUI.
A new icon will appear in action section on certificate table.
The delete icon will be enabled only for TrustStore certificates and disabled
for others which does not have support for delete option.
When user clicks on the delete icon then ‘user prompt’ is displayed and after
confirmation, proper redfish action is used to delete the certificate.

Middlewere implementation is here:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/25281

Backend implementation is here:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-certificate-manager/+/25268

Tested on Chrome and Mozilla.
New icon appears in action section.
The delete option is available only for TrustStore certificates.
User is able to delete selected certificate.

Depends-On: I9781c5c79288ec5d080e80e42c63a55e471ddb77
Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: I68c5f54767d6982ae3cb00830b3a1b4f5e237bea

show more ...

Remove CSP protections from HTML

When I originally wrote CSP into the webui files, I intended to drop it
into the HTML file so it could be removed from bmcweb. Unfortunately,
that plan doesn't fly,

Remove CSP protections from HTML

When I originally wrote CSP into the webui files, I intended to drop it
into the HTML file so it could be removed from bmcweb. Unfortunately,
that plan doesn't fly, as the CSP headers in bmcweb need to remain for
non-html files.

This normally wouldn't matter, but a number of people utilize
BMCWEB_INSECURE_DISABLE_XSS_PREVENTION to run the webui locally and
debug a new webui patch from a working BMC. This causes the CSP headers
to conflict, and the browser to fail with a CSP error on connect-src
when debugging locally.

Removing the CSP section entirely from the webui resolves this, and
doesn't change functionality at all, as it's still covered in bmcweb.

Tested: Will verify on a real platform.

Verified that building the webui locally with the above bmcweb flag
allows the webui to launch correctly.

Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: I60e5011361ec3ce1930249a20cf34480beb48a7f

show more ...

Update toast notification

Added new toast notification types, warn and info,
and updated visual styling. All toasts will need
to be manually closed by clicking the 'X' close icon,
except a success t

Update toast notification

Added new toast notification types, warn and info,
and updated visual styling. All toasts will need
to be manually closed by clicking the 'X' close icon,
except a success toast which will be dismissed
automatically after 10 secs.

- Small updates to critical and success/on icon
- Added new colors for toast status background colors

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I9077109042621b2d3346b4121d6344da502b6b26

show more ...

Rename "User" role "ReadOnly"

https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/26156
is renaming the User role ReadOnly. Update the Roles table.

26156 needs to merge first.

Tested: Loaded on

Rename "User" role "ReadOnly"

https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/26156
is renaming the User role ReadOnly. Update the Roles table.

26156 needs to merge first.

Tested: Loaded on a Witherspoon.
Change-Id: I948a6287d2c447072d5c34595589387e127d59ac
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Update certificate management page consistency

This change applies global styles to improve
page layout consistency and modal management

- Adds page and section styles
- Removes unused styles
- Cre

Update certificate management page consistency

This change applies global styles to improve
page layout consistency and modal management

- Adds page and section styles
- Removes unused styles
- Creates individual html files for modals
- Updates certificate modals to bootstrap modal
- Updates global styles for input file field in file-upload.scss

TODO:
- Update certificate table with table component in separate commit
- Update CSR modal to use global form-field styles in separate commit

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I9b800cb684740da1a9168294433e726efb0f9d0e

show more ...

Update object-mapper.md link

object-mapper.md is moving under architecture/ as part of
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/26250/

26250 should merge before this is merged.

Change-I

Update object-mapper.md link

object-mapper.md is moving under architecture/ as part of
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/26250/

26250 should merge before this is merged.

Change-Id: Ie2372690faf6af9629a15badccb4af31da9041bb
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add tooltip styles

Adding styles to make sure the Bootstrap tooltip
directive works by adding opacity to 'in' class that
is added to the tooltip when triggered. This commit
also includes additional

Add tooltip styles

Adding styles to make sure the Bootstrap tooltip
directive works by adding opacity to 'in' class that
is added to the tooltip when triggered. This commit
also includes additional custom styles to override
defaults.
We will need these styles to implement tooltips which
are included in upcoming changes like the firmware
page redesign.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I08e8f1f1762dcc24f8a803b87348a5bff25bd65b

show more ...

Fix IE11 icon alignment on header and system overview

Made height and width changes to icons on app header
and system overview to properly align icons in IE11.
Removes additional space in system ove

Fix IE11 icon alignment on header and system overview

Made height and width changes to icons on app header
and system overview to properly align icons in IE11.
Removes additional space in system overview quick
links.

Tested in Chrome, IE11, Safari, Edge.

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I7ae24df3fe73ea3502565ed3ee2ccabb2506e098

show more ...

Fix IE 11 primary navigation icon positioning

Added height value of 100% to nav-icon in order to properly align
in IE11.

Tested on Chrome, Firefox, Safari, Edge and IE11.

Signed-off-by: Dixsie Wol

Fix IE 11 primary navigation icon positioning

Added height value of 100% to nav-icon in order to properly align
in IE11.

Tested on Chrome, Firefox, Safari, Edge and IE11.

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I66b2d4de1b67f546e0709eab70a780a297efbb7a

show more ...

NTP: Remove workaround for empty list array

This workaround is no longer needed with bmcweb.

curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [] }' \
https://${bmc}/xyz/openbmc_pr

NTP: Remove workaround for empty list array

This workaround is no longer needed with bmcweb.

curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [] }' \
https://${bmc}/xyz/openbmc_project/network/eth0/attr/NTPServers

See https://github.com/openbmc/openbmc/issues/3240

Tested: Built and loaded on a Witherspoon. Added, removed, and
edited NTP servers.
Change-Id: Ia106067a479c63a5761b1f62c624d3ccc6df55c7
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

DNS: Remove workaround for empty list array

This workaround is no longer needed with bmcweb.

curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [] }' \
https://${bmc}/xyz/openbmc_pr

DNS: Remove workaround for empty list array

This workaround is no longer needed with bmcweb.

curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [] }' \
https://${bmc}/xyz/openbmc_project/network/eth0/attr/Nameservers
{
"data": null,
"message": "200 OK",
"status": "ok"

and actually casues an error now do to
https://github.com/openbmc/phosphor-networkd/commit/5fb6c33a49ee2b9718cc9ce0f921d3b6cf38a463

curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [""] }' \
https://${bmc}/xyz/openbmc_project/network/eth0/attr/Nameservers
"data": {
"description": "xyz.openbmc_project.Common.Error.InvalidArgument"
},
"message": "Invalid argument was given.",

See https://github.com/openbmc/openbmc/issues/3240

Tested: Built and loaded on a Witherspoon. Added, removed,
and edited DNS servers.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Change-Id: I278489a8c4682641b61a0e5ab08fd714603b0234

show more ...

Inventory: Remove old associations interface

Moved to the new associations interface here:
https://github.com/openbmc/openbmc/issues/3584

Tested: Loaded on a Witherspoon
Change-Id: I2065f0919c8cc9d

Inventory: Remove old associations interface

Moved to the new associations interface here:
https://github.com/openbmc/openbmc/issues/3584

Tested: Loaded on a Witherspoon
Change-Id: I2065f0919c8cc9d9dd219a1f9d8d0fc75265fa6f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Logs: Move over to new Associations

Logging moved over to the new Associations interface here:
https://github.com/openbmc/phosphor-logging/commit/27d82814c3e79865221f599b98ce069c31c4d60a

Without th

Logs: Move over to new Associations

Logging moved over to the new Associations interface here:
https://github.com/openbmc/phosphor-logging/commit/27d82814c3e79865221f599b98ce069c31c4d60a

Without this change was seeing:
TypeError: "r.data[h].associations is undefined"
getLogs https://w81.aus.stglabs.ibm.com/app.bundle.js:41
d https://w81.aus.stglabs.ibm.com/app.bundle.js:6
d https://w81.aus.stglabs.ibm.com/app.bundle.js:6
$digest https://w81.aus.stglabs.ibm.com/app.bundle.js:6
$apply https://w81.aus.stglabs.ibm.com/app.bundle.js:6
y https://w81.aus.stglabs.ibm.com/app.bundle.js:6
C https://w81.aus.stglabs.ibm.com/app.bundle.js:6
onload https://w81.aus.stglabs.ibm.com/app.bundle.js:6
Possibly unhandled rejection: {}

Added an hasOwnProperty before the foreach.

Tested: No longer see the error. See the "Related items:" on the
event log panel.
Change-Id: I60be885feea72b1388b7cbf4c3a7b9df7dbb9a02
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fix SNMP multiple calls bug

- Added a call to reload the route in the promise success callback. This
assures that a newly added manager has a path.
- Update the use of var in for blocks to scope

Fix SNMP multiple calls bug

- Added a call to reload the route in the promise success callback. This
assures that a newly added manager has a path.
- Update the use of var in for blocks to scope the variable to the
block rather than overwriting the i variable that is hoisted and
scoped to the setSNMP function.
- Change i variable name to managerLength to improve readability

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I18fe9ecc3ca7cca29781a5c24caca73bda71ee43

show more ...

Add error message when image fails to activate

If an image fails to activate a toast message is displayed.

Tested on Witherspoon with master build image and
field mode turned on. When image fails t

Add error message when image fails to activate

If an image fails to activate a toast message is displayed.

Tested on Witherspoon with master build image and
field mode turned on. When image fails to activate,
the failed activation status response returns a 200
ok and an error toast is displayed. Tested with field
mode turned off to verify image activates and BMC reboots.
Tested on all browsers.

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I517f184549673e7b807cc0a553a728d05d6dbba1

show more ...

Fix invalid gateway toast message

Add check for gateway value before testing if the string is valid.
The backend seems to handle an empty gateway the same as sending
0.0.0.0. When the GET call is ma

Fix invalid gateway toast message

Add check for gateway value before testing if the string is valid.
The backend seems to handle an empty gateway the same as sending
0.0.0.0. When the GET call is made after sending 0.0.0.0 as the
gateway value, the response returns an empty string. This field
seems to be an override for the default gateway input for the
interface.

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Id6a5575e73a7c8adfff052c89bb4e8ca986d45f9

show more ...

Fix LDAP service update error

When a service is enabled, it must be disabled prior
to changing the service type, e.g change from OpenLDAP
to ActiveDirectory.

- Add check to determine if a service i

Fix LDAP service update error

When a service is enabled, it must be disabled prior
to changing the service type, e.g change from OpenLDAP
to ActiveDirectory.

- Add check to determine if a service is already enabled
- Make two calls if service is already enabled. First to
disable existing service. Second to enable updated
service
- Remove toast message for ssl check and replace with
error message which also keeps submit button disabled
if the regex pattern is not met

Tested:
- Edge
- Safari
- Firefox
- Chrome
- IE 11

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I195eeb7d1cd3621681c18f4dd9aa4414eb079c09

show more ...

Fix icon-warning syntax error

There were a few instances of the icon-warning icon that didn't
include the file extenstion needed to when adding the file attribute
property in the icon directive.

Si

Fix icon-warning syntax error

There were a few instances of the icon-warning icon that didn't
include the file extenstion needed to when adding the file attribute
property in the icon directive.

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ib25c28c72285fa214f75258b0b09790d52bb6cc1

show more ...

Add searchable properties to event log filter

The current event log search doesn't match inputs like
the event id, severity or priority.
This commit will add additional searchable log properties
to

Add searchable properties to event log filter

The current event log search doesn't match inputs like
the event id, severity or priority.
This commit will add additional searchable log properties
to the search filter so users can enter search terms like
'High' or 'Error' or other visible keywords.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I569112468a9f97034449799f407137f1651cec16

show more ...

Update KVM layout and add open in new window functionality

-Adds heading with new layout consistency class name
-Adds open in new window functionality

Resolves: openbmc/phosphor-webui#81

Tested on

Update KVM layout and add open in new window functionality

-Adds heading with new layout consistency class name
-Adds open in new window functionality

Resolves: openbmc/phosphor-webui#81

Tested on a Witherspoon with power on and with build
that allows up to 4 kvm sessions connected
at a time https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/25231.

KVM console loads in firefox, chrome, safari, edge and IE11.
Opening new window and returning to parent window is
functional across all browsers.

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I32cda025bdd459740ca2b42d573b431fac687860

show more ...