11adec7e | 19-Dec-2018 |
Ed Tanous <ed.tanous@intel.com> |
webui: enable ngCSP
ngCSP allows angular to avoid using inline style and unsafe eval mechanisms. Enabling this will allow us to update to a more stringent content-security policy.
for more details
webui: enable ngCSP
ngCSP allows angular to avoid using inline style and unsafe eval mechanisms. Enabling this will allow us to update to a more stringent content-security policy.
for more details, see documentation here: https://docs.angularjs.org/api/ng/directive/ngCsp
Tested by: Launching the GUI, and saw no ill effects.
Change-Id: I4db732e997c2901d1fe57eee99607007b5e3afec Signed-off-by: Ed Tanous <ed.tanous@intel.com>
show more ...
|
f04960f5 | 06-Dec-2018 |
AppaRao Puli <apparao.puli@linux.intel.com> |
Enabling redfish support under configuration.
This commit contains: 1) Enabling redfish support under configuration. While loading header, get the redfish root node and sets the redfishSupp
Enabling redfish support under configuration.
This commit contains: 1) Enabling redfish support under configuration. While loading header, get the redfish root node and sets the redfishSupport configuration param. 2) Depending on redfish support flag, it decide to use redfish URI or REST uri for user password change.
Tested: - Tested both redfish enable and dsiable scenarios.
Change-Id: I98ecc7f419ddcfdbfac9c212ad2834479e9986b5 Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
show more ...
|
86caba11 | 19-Dec-2018 |
Ed Tanous <ed.tanous@intel.com> |
webui: Fix redfish to use proper styles
Redfish was using inline style tags, which is conflicting with our desire to disable inline styles. This moves the redfish styles to an appropriate SCSS file
webui: Fix redfish to use proper styles
Redfish was using inline style tags, which is conflicting with our desire to disable inline styles. This moves the redfish styles to an appropriate SCSS file.
Tested by: Launched redfish GUI, and observed no style differences
Change-Id: Ifb96730f0d6a34700f8c05666b6963a77d511911 Signed-off-by: Ed Tanous <ed.tanous@intel.com>
show more ...
|
fdb701d3 | 19-Dec-2018 |
Ed Tanous <ed.tanous@intel.com> |
Remove style tags from svg
The style tags in the svg inline images will trigger an issue when the browser attempts to interpret them, and flags them as inline-styles (which we want to disallow via p
Remove style tags from svg
The style tags in the svg inline images will trigger an issue when the browser attempts to interpret them, and flags them as inline-styles (which we want to disallow via policy). This commit removes them, which, given that they shouldn't have been there in the first place, should have no ill effects.
Tested By: Launched GUI, observed button behavior did not change
Change-Id: I9b6443051fd30770853e589fcd2a7231f85fd082 Signed-off-by: Ed Tanous <ed.tanous@intel.com>
show more ...
|
84e7a936 | 13-Dec-2018 |
Ryan Arnell <iffy.ryan@ibm.com> |
Fix issue about menu not disappearing on firmware page
In firmware update page "More info” dialog did not disappear until it is clicked again. With this push users can click anywhere outside the me
Fix issue about menu not disappearing on firmware page
In firmware update page "More info” dialog did not disappear until it is clicked again. With this push users can click anywhere outside the menu and it disappears.
Resolves openbmc/phosphor-webui#32
Change-Id: I1519caf2428c702af03fb0e4dd8a08d0c0588abf Signed-off-by: Ryan Arnell <iffy.ryan@ibm.com>
show more ...
|
0b0e26de | 15-Nov-2018 |
Iftekharul Islam <iffy.ryan@ibm.com> |
Make actions visible in a disabled state
In event log page, main actions are made visible all the time in a disabled state. Once select a log item is selected, the corresponding actions become activ
Make actions visible in a disabled state
In event log page, main actions are made visible all the time in a disabled state. Once select a log item is selected, the corresponding actions become active.
Resolves openbmc/phosphor-webui#26
Change-Id: Idd7dced5984b7d103a706abc12c1e4889710d420 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
show more ...
|
97195447 | 26-Nov-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Fix Server power operations page style
On the Server power operations page, need a width: 100% for the "Select a power operation" header.
Drop "Row" from power operations div to fix confirm modal b
Fix Server power operations page style
On the Server power operations page, need a width: 100% for the "Select a power operation" header.
Drop "Row" from power operations div to fix confirm modal being cut off.
These are needed because of the move to Bootstrap 4. 84e114a
Resolves openbmc/phosphor-webui#51
Change-Id: I7250daf2aed4ce5af7ed5acdf61a65cc38deac72 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
dbf04811 | 16-Nov-2018 |
Alexander Filippov <a.filippov@yadro.com> |
fix date/time representation in national locales
Added "localeDate" filter to present date and time in preferred format: - the date will be displayed as: 'Dec 3, 2018' - the time will be displayed
fix date/time representation in national locales
Added "localeDate" filter to present date and time in preferred format: - the date will be displayed as: 'Dec 3, 2018' - the time will be displayed in locale preferred format. - the timezone will be displayed as abbrev or GMT+/-offset.
At the 'Date and Time setting' the time zone name will displayed in long format if it is possible.
All text parts of date/time representation will be in English.
Resolves: openbmc/phosphor-webui#42
Change-Id: I2fdbb47c62dfc5000039b0c00a20f64a9a389fc6 Signed-off-by: Alexander Filippov <a.filippov@yadro.com>
show more ...
|
bd500cd2 | 03-Dec-2018 |
beccabroek <beccabroek@gmail.com> |
Remove AngularUtils
The AngularUtils library is no longer maintained. This brings the pagination directive used on the log events page into the project and removes it from package.json
Resolves ope
Remove AngularUtils
The AngularUtils library is no longer maintained. This brings the pagination directive used on the log events page into the project and removes it from package.json
Resolves openbmc/phosphor-webui#10
Change-Id: I8235ef6ff325c9b0d8440d203816a38ded5d3890 Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
1c43b312 | 16-Nov-2018 |
Ed Tanous <ed.tanous@intel.com> |
phosphor-webui: Allow after login redirects
When redirecting a user to a login url, it is helpful to be able to point them to a url that after login, will forward to the requested page.
This is acc
phosphor-webui: Allow after login redirects
When redirecting a user to a login url, it is helpful to be able to point them to a url that after login, will forward to the requested page.
This is accomplished by the use of a url param named "next" which specifies the URL that the user wants to be redirected to after login. If no next url is specified, the user is redirected to the overview page, like the vehavior before.
Change-Id: Iff0da65632119a8f7ae3f35eb74147ca67563f30 Signed-off-by: Ed Tanous <ed.tanous@intel.com>
show more ...
|
0ad2604b | 16-Nov-2018 |
Alexander Filippov <a.filippov@yadro.com> |
log-filter: remove tip for date format
The date picker already has the tip for the date format, which one uses locale settings. This commit removes the tip from the label.
Change-Id: Ib45b6c620dab2
log-filter: remove tip for date format
The date picker already has the tip for the date format, which one uses locale settings. This commit removes the tip from the label.
Change-Id: Ib45b6c620dab2031cf0f36c5389111df7cb91ef5 Signed-off-by: Alexander Filippov <a.filippov@yadro.com>
show more ...
|
ce1e9f99 | 15-Nov-2018 |
Iftekharul Islam <iffy.ryan@ibm.com> |
Present number of sensors available
- Following the same pattern as event logs where number count of items are visible all the time
Resolves openbmc/phosphor-webui#29
Change-Id: I1c79c72f9a
Present number of sensors available
- Following the same pattern as event logs where number count of items are visible all the time
Resolves openbmc/phosphor-webui#29
Change-Id: I1c79c72f9afa98eb834a4504543ed88e3973f034 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
show more ...
|
84e114a4 | 14-Nov-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Move to Bootstrap 4
Bootstrap < 4.1.2 has the following CVE: https://nvd.nist.gov/vuln/detail/CVE-2018-14041
Removed bootstrap-theme.css due to "Replaced the separate optional theme with configurab
Move to Bootstrap 4
Bootstrap < 4.1.2 has the following CVE: https://nvd.nist.gov/vuln/detail/CVE-2018-14041
Removed bootstrap-theme.css due to "Replaced the separate optional theme with configurable options via SCSS variables (e.g., $enable-gradients: true)."
Added "width: 100%" to a few places where width 100% was no longer getting inherited. Moved a few elements and adjusted styles to get the same look as before.
See https://getbootstrap.com/docs/4.0/migration/ for more information.
Tested: Manually on a Witherspoon. Change-Id: I0a72665ac1ca6eacd0b553a585b1fb15e14ae62c Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
bc5cc7f7 | 13-Nov-2018 |
James Feist <james.feist@linux.intel.com> |
redfish: fix json format
Quotes were missing on Arrays, and some commas were in the wrong spot.
Tested-by: Copied the output of the managers schema and ran it through python json formatter and it s
redfish: fix json format
Quotes were missing on Arrays, and some commas were in the wrong spot.
Tested-by: Copied the output of the managers schema and ran it through python json formatter and it started to pass.
Change-Id: Ica6b35b0076654fae6204a99380c05dec1ac401b Signed-off-by: James Feist <james.feist@linux.intel.com>
show more ...
|
5760e531 | 12-Nov-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Server Health: Check if logs are resolved
When determining the server health, check if the logs are resolved. A resolved log should not cause the server health to display "Warning" or "Critical".
C
Server Health: Check if logs are resolved
When determining the server health, check if the logs are resolved. A resolved log should not cause the server health to display "Warning" or "Critical".
Change-Id: I9bd46150410719441876b03c129cdf2e280150d4 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
1cc7021c | 05-Nov-2018 |
beccabroek <beccabroek@gmail.com> |
Move more info icon
Currently, the more info icon (...) is positioned too far from the server version on the firmware page. This places the icon 20 px to the right, so that it is clearly associated
Move more info icon
Currently, the more info icon (...) is positioned too far from the server version on the firmware page. This places the icon 20 px to the right, so that it is clearly associated with the version.
Resolves openbmc/phosphor-webui#23
Change-Id: I5d1dc6bf1446c9f10ee0181d9b9fa2eb3e53e498 Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
9c5aa667 | 06-Nov-2018 |
Gunnar Mills <gmills@us.ibm.com> |
app/index: Remove author
This is the only file with a "@author".
Change-Id: Iaf95c79f387532750dea44cd5cb16154103ce498 Signed-off-by: Gunnar Mills <gmills@us.ibm.com> |
af0e3b47 | 06-Nov-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Remove Gulp
Moved to webpack here: https://github.com/openbmc/phosphor-webui/commit/bbcf670a1c8c7463556eb006bc8f6bbfe29af3e4
Gulp is no longer used and would not work without some restructuring of
Remove Gulp
Moved to webpack here: https://github.com/openbmc/phosphor-webui/commit/bbcf670a1c8c7463556eb006bc8f6bbfe29af3e4
Gulp is no longer used and would not work without some restructuring of the app.
Tested: Built the app and scped onto a Witherspoon. Change-Id: Id2f5feff2608c33460dd4276a5293973dfe8e9c8 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
569ccf66 | 29-Oct-2018 |
beccabroek <beccabroek@gmail.com> |
Display log events in user time
Allows user to display events in their timezone or in UTC. Previously allowed either ETC or UTC, but listed ETC as 'user timezone'. Updates date time page from GMT o
Display log events in user time
Allows user to display events in their timezone or in UTC. Previously allowed either ETC or UTC, but listed ETC as 'user timezone'. Updates date time page from GMT offset to UTC offset for overall consistency. Also updates overview page to list critical events in user timezone
Resolves openbmc/phosphor-webui#36
Tested: changed timezone settings locally and validated that correct timezone and UTC offset was presented in the UI.
Change-Id: I89ca5045eeb789527aa07f5b1baebaa3fbd6b1fa Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
35d18cbc | 05-Oct-2018 |
Gunnar Mills <gmills@us.ibm.com> |
SNMP: Use lowerCamelCase for vars
Following https://google.github.io/styleguide/jsguide.html.
Change-Id: Ib7704018622571cf1701d3a525dc01297bed7243 Signed-off-by: Gunnar Mills <gmills@us.ibm.com> |
8751084c | 18-Sep-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Only update SNMP fields if changed
Use ng-change to determine if the SNMP fields, Address and Port, have changed and should be updated.
Tested: Only see the rest calls when the fields have changed.
Only update SNMP fields if changed
Use ng-change to determine if the SNMP fields, Address and Port, have changed and should be updated.
Tested: Only see the rest calls when the fields have changed. Change-Id: I324c9c422a8b6dfb8816925167953e16099f8044 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
4640320d | 30-Oct-2018 |
Gunnar Mills <gmills@us.ibm.com> |
API Utils: Remove date-time headers
These are not needed due to: https://github.com/openbmc/phosphor-webui/commit/dd9d4c32992568d0b634df10a0eeaf7fcd06d3dd
Change-Id: Ic58569c774bc2524089e74fb108fb7
API Utils: Remove date-time headers
These are not needed due to: https://github.com/openbmc/phosphor-webui/commit/dd9d4c32992568d0b634df10a0eeaf7fcd06d3dd
Change-Id: Ic58569c774bc2524089e74fb108fb764df89c4e7 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
d7557e5c | 16-Oct-2018 |
beccabroek <beccabroek@gmail.com> |
Consistent date time format
Format on event log page and overview page of date and time should match the format of 'data last refreshed' with the exception of the timezone being listed with the even
Consistent date time format
Format on event log page and overview page of date and time should match the format of 'data last refreshed' with the exception of the timezone being listed with the event log.
Resolves openbmc/phosphor-webui#21
Change-Id: I21d43e45f45d2f9eebc7c08f4345201bef354a06 Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
022b6cf1 | 18-Sep-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Remove SNMP Managers
Allow the user to remove SNMP Managers. If the SNMP Manager being removed exists in the backend, make a call to remove it.
Tested: Removed SNMP Managers on a Witherspoon Change
Remove SNMP Managers
Allow the user to remove SNMP Managers. If the SNMP Manager being removed exists in the backend, make a call to remove it.
Tested: Removed SNMP Managers on a Witherspoon Change-Id: Ib392cda30754adfaa58f6301592c2d666ff2c29e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
854fbba1 | 13-Sep-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Add and modify SNMP Managers
This allows the user to add and edit SNMP managers.
Tested: Added SNMP managers on a Witherspoon. Change-Id: Iab8d6463b03de75928e4989135172d93ab0f28a3 Signed-off-by: Gu
Add and modify SNMP Managers
This allows the user to add and edit SNMP managers.
Tested: Added SNMP managers on a Witherspoon. Change-Id: Iab8d6463b03de75928e4989135172d93ab0f28a3 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|