309b5da3 | 07-Nov-2018 |
beccabroek <beccabroek@gmail.com> |
Create certificate management page
Displays certificates and the ability to add up to one of each type of certificate (as limited by the backend implementation). HTTPS certificate and LDAP client ce
Create certificate management page
Displays certificates and the ability to add up to one of each type of certificate (as limited by the backend implementation). HTTPS certificate and LDAP client cert are implemented in this commit, with the ability to add more types as needed by adding them to the constants.js CERTIFICATE_TYPES array.
Also provides the ability to replace a certificate once it is added.
Resolves openbmc/phosphor-webui#43
Tested: loaded onto a witherspoon and able to view and replace both the HTTPS certificate and the LDAP certificate. GUI only allows to upload an LDAP certificate if one doesn't already exist. The GUI limits the user to one file per type as expected at this time and provides the appropriate validation messages. Alert messages appear above the table if the certificate is expired or within 30 days of expiring.
Change-Id: I345267280ecd3cb257e9304886cde9ebb69b1240 Signed-off-by: beccabroek <beccabroek@gmail.com> Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
show more ...
|
d5bf6baa | 10-Jun-2019 |
Ed Tanous <ed.tanous@intel.com> |
Fix the opacity of the loading screen
Currently the loading screen has a 0.7 opacity, which leads to some strange behaviors at times when changing screens. Old scopes pop under new ones, leading to
Fix the opacity of the loading screen
Currently the loading screen has a 0.7 opacity, which leads to some strange behaviors at times when changing screens. Old scopes pop under new ones, leading to a page "jump" once the loading is complete.
Making the loading page fully opaque and removing the transition effect reduces this behavior, and makes the page transitions feel cleaner.
Tested: Loaded webui locally. Observed problem goes away when navigating between pages. Navigated between several pages to verify, including pages with a lot of static data.
Signed-off-by: Ed Tanous <ed.tanous@intel.com> Change-Id: I5549d5c49901429f6e9c353524c6f7060725c2ea
show more ...
|
1f690f3e | 23-Jun-2019 |
Derick Montague <derick.montague@ibm.com> |
Fix sensors table header and body alignment
- Update markup to use semenatic table - Update table to flex based layout to support responsive table design
Tested: Small screen and large screen lay
Fix sensors table header and body alignment
- Update markup to use semenatic table - Update table to flex based layout to support responsive table design
Tested: Small screen and large screen layout in Chrome, Firefox, and Safari. Safari has issues with the sticky header, which is an acceptable trade off and meets cross-browser standards.
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I8ea323e45a2659562f229d4fd6d4e53887664cad
show more ...
|
06f69455 | 20-Jun-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Rename option to enable Redfish Eventlog
IBM has a need for more granular options for turning panels off and on. Renamed redfishSupportEnabled, redfishEventLogDisabled. By default, it continues to b
Rename option to enable Redfish Eventlog
IBM has a need for more granular options for turning panels off and on. Renamed redfishSupportEnabled, redfishEventLogDisabled. By default, it continues to be enabled. Redfish is used for user management already so this setting was a bit of misnomer (i.e. it did not "turn off" Redfish use). LDAP and Certificates, both in review, also use Redfish.
Moved to "Disable" so that if not defined in the config.json, the panel is still visible. A meta layer has to overwrite the config.json with "redfishEventLogDisabled" : true to make the panel not appear on the navigation.
Pushed a patch here to disable the Redfish Event Log page in the meta-openpower layer: https://gerrit.openbmc-project.xyz/c/openbmc/meta-openpower/+/22923
Pushed a patch here to remove the redfishSupportEnabled in Intel's layer: https://gerrit.openbmc-project.xyz/c/openbmc/meta-intel/+/22870
An improvement would be to not import if disabled.
Tested: Built Witherspoon with 22923. Did not see "System logs" panel. Change-Id: I8722f43191ec73d21d6a181223d00256dbcd062f Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
9cf17f8d | 20-Jun-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Capitalize System logs correctly
The other panels capitalize the first word only. E.g. Hardware status, Server power operations, and Manage power usage. Follow this standard.
Change-Id: Icbbc2df25e
Capitalize System logs correctly
The other panels capitalize the first word only. E.g. Hardware status, Server power operations, and Manage power usage. Follow this standard.
Change-Id: Icbbc2df25e1a3c9dd5e44db4c1d3f6a9f8252144 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
afcfda7b | 21-Jun-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Fix cold reboot error
Cold reboot will check the host status by referring to the server_state property in the dataService instead of making API requests to check host/chassis status.
TODO: Refactor
Fix cold reboot error
Cold reboot will check the host status by referring to the server_state property in the dataService instead of making API requests to check host/chassis status.
TODO: Refactor other power control options to follow a similar pattern.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I74b1b78fa39caee514fbaea8492c8a5ad6f8145b
show more ...
|
c86ce3c9 | 05-Jun-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Consolidate button styles
This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes.
This patchset also
Consolidate button styles
This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes.
This patchset also implements a consistent strategy for including icon assets. Currently, svg icons are imported as CSS background images or inlined into the markup. Inlining an svg is preferred, especially when used with buttons or links so the colors can be easily changed for different states (hover, focus, disabled) without having to request variants. The icon provider allows us to inline svgs without cluttering the markup. Webpack config was adjusted to use svg-inline-loader when resolving svgs that are used by the icon provider directive.
- All svgs were optimized to remove unncessary information. - Removed unused svg color variants - Moved icons used by icon provider to separate directory to avoid Webpack parsing the files twice - Small changes to navigation icons
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43
show more ...
|
e4194ce0 | 24-May-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add remote logging server
Remote logging enables the user to configure a remote server to stream out local logs. This feature will be available on the Event Log page. The user can add a remote serve
Add remote logging server
Remote logging enables the user to configure a remote server to stream out local logs. This feature will be available on the Event Log page. The user can add a remote server, edit/change an existing server configuration and remove/disable the remote server.
Resolves openbmc/phosphor-webui#68
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I8284cbdbdaaf85f5c95f237efc72290c66904b40
show more ...
|
e4ae854c | 10-Jun-2019 |
Alexander Filippov <a.filippov@yadro.com> |
Sort sensors alphanumerically
Sort the list of sensors in alphanumeric order.
Relatives openbmc/openbmc#3386
Change-Id: Ie30f48417038a2cdf8c67de6ac357f078c8aaae7 Signed-off-by: Alexander Filippov
Sort sensors alphanumerically
Sort the list of sensors in alphanumeric order.
Relatives openbmc/openbmc#3386
Change-Id: Ie30f48417038a2cdf8c67de6ac357f078c8aaae7 Signed-off-by: Alexander Filippov <a.filippov@yadro.com>
show more ...
|
e6bc9b21 | 14-Jun-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Fix Unknown Provider error
This patchset will fix the Unknown Provider error caused by the toggle-flag directive by declaring the required $document dependency.
Tested: Navigated to Event Log page
Fix Unknown Provider error
This patchset will fix the Unknown Provider error caused by the toggle-flag directive by declaring the required $document dependency.
Tested: Navigated to Event Log page and no longer seeing the error in the browser console.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I446f0a1d120526dfa250862018dfa09b289cae74
show more ...
|
5bd1dec7 | 16-May-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Change button styles from rounded to straight corners
This will create more visual consistency between the components in the GUI since there are elements, such as text fields and dropdowns that are
Change button styles from rounded to straight corners
This will create more visual consistency between the components in the GUI since there are elements, such as text fields and dropdowns that are styled with straight corners.
- Removes border radius from buttons - Removes some redundant styles - Adds input types that aren't currently inheriting defined styles
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I6ff1bde91e2e57df01484dd20003925cd914ffa2
show more ...
|
6a3b3b2c | 16-May-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Fix tablet alignment issues for event logs
This will make sure our event log content is properly aligned on tablet and desktop views. It will also make the date/time value on the server overview pag
Fix tablet alignment issues for event logs
This will make sure our event log content is properly aligned on tablet and desktop views. It will also make the date/time value on the server overview page always display underneath the 'BMC time' label in a destkop view–currently the date value will wrap to a new line if the string is too long.
- Update markup to use Foundation grid layout classes on the server overview event log table
Tested: Event log tables on server overview page and event log page
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I7d765ebbe679f954e606d1d25e2182d983a7b3f3
show more ...
|
21f8cb94 | 22-May-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Fix the tabbing order in the primary and secondary navigation
The main navigation will follow a natural tabbing order. When the secondary menu is expanded with the keyboard, the first item in the se
Fix the tabbing order in the primary and secondary navigation
The main navigation will follow a natural tabbing order. When the secondary menu is expanded with the keyboard, the first item in the secondary menu will be in focus. Tabbing after the last item in the secondary menu will return focus to the primary menu.
- Restructures markup so secondary menu is nested in primary navigation
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I4ecb17ef6721ee443310f81e1554620352c145a4
show more ...
|
1a606bee | 23-May-2019 |
Derick Montague <derick.montague@ibm.com> |
Add .ng-leave and .ng-enter rulesets for page transition
Adding ngAnimation dependency created added animation to pages during route or location changes. Added transitions to create an elegant trans
Add .ng-leave and .ng-enter rulesets for page transition
Adding ngAnimation dependency created added animation to pages during route or location changes. Added transitions to create an elegant transition.
Tested: I navigated to every page including logging in and out in Chrome, Firefox and Safari to assure all browsers handle the transition consistently.
Resolves openbmc/phosphor-webui#86
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I14fa1bd790e80f977b7a0ccceccc3eb20ce33ae6
show more ...
|
7920baeb | 23-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove unused errors.html
Also removed errorModalDetails and displayErrorModal from dataService since they are no longer used.
errors.html was only active when displayErrorModal was true. displayEr
Remove unused errors.html
Also removed errorModalDetails and displayErrorModal from dataService since they are no longer used.
errors.html was only active when displayErrorModal was true. displayErrorModal was only true when activateErrorModal was called.
activateErrorModal was removed in a previous commit. activateErrorModal's only use was removed here: https://github.com/openbmc/phosphor-webui/commit/a38a287ccaa97eddc9df7333e33357b14772d4c6#diff-65affd2488457363c5b9e9266258c3b8
Tested: Searched the repo. Built an image and loaded onto a Witherspoon. No regressions observed.
Change-Id: I96e26dd3817d7b02bbce74b4cc093b75dab669ed Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
8a111586 | 23-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove unused chassis_state
Only display the server/host state on the GUI.
Tested: Searched the repo for 'chassis_state'. Built an image, loaded on a Witherspoon, power on/off, and
Remove unused chassis_state
Only display the server/host state on the GUI.
Tested: Searched the repo for 'chassis_state'. Built an image, loaded on a Witherspoon, power on/off, and verified correct host state. Change-Id: Ibdefeef7744e08cd737410741a1402ccb9e69200 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
f75dc93f | 23-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove unused activateErrorModal
activateErrorModal was unused. Also remove Constants.ERROR_MODAL since activateErrorModal was the only place which used it.
https://github.com/openbmc/phosphor-webu
Remove unused activateErrorModal
activateErrorModal was unused. Also remove Constants.ERROR_MODAL since activateErrorModal was the only place which used it.
https://github.com/openbmc/phosphor-webui/commit/a1d238f3a53db2ec3cc4c2fd52fe78738b37968b#diff-65affd2488457363c5b9e9266258c3b8 added activateErrorModal / deactivateErrorModal. https://github.com/openbmc/phosphor-webui/commit/a38a287ccaa97eddc9df7333e33357b14772d4c6#diff-65affd2488457363c5b9e9266258c3b8 removed its use.
Tested: Searched the repo and when testing the GUI on a a Witherspoon, toasts worked as expected. Change-Id: I98107f397fab039123f8507cd7bbac2ef8e5fb7b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
419233f8 | 23-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove unused server_status
dataService.server_status is unused. server_status was set to a HOST_STATE constants which are now unused. Removed the HOST_STATE constants also.
Tested: Searched the re
Remove unused server_status
dataService.server_status is unused. server_status was set to a HOST_STATE constants which are now unused. Removed the HOST_STATE constants also.
Tested: Searched the repo for 'server_status' and 'HOST_STATE' Built an image, loaded on a Witherspoon, power on/off, and verified correct host state. Change-Id: I10a915852634277bb5261e113b9706857acf66d6 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
6f4e12e3 | 23-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Firmware: Remove unused interpolate
Interpolate was used prior to the ngToast. https://github.com/openbmc/phosphor-webui/commit/90ae95eb6f5f30e3863f24ad364b111258ea4ee4#diff-44385b1119c2cae41d7331ab
Firmware: Remove unused interpolate
Interpolate was used prior to the ngToast. https://github.com/openbmc/phosphor-webui/commit/90ae95eb6f5f30e3863f24ad364b111258ea4ee4#diff-44385b1119c2cae41d7331ab4a5cd5fe moved to ngToast (later toastService) and removed the use of interpolate.
Tested: Build this and the commits below and loaded onto a Witherspoon system. Uploaded an image and activated it.
Change-Id: I161c7860cec006dc434bc00495b25b588f069775 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
44da471f | 20-Mar-2019 |
beccabroek <beccabroek@gmail.com> |
Virtual media page
Adds page to manage virtual media devices. User selects file and pushes 'start' button to establish websocket connection. nbdServerService added to provide ability for user to nav
Virtual media page
Adds page to manage virtual media devices. User selects file and pushes 'start' button to establish websocket connection. nbdServerService added to provide ability for user to navigate away from the page and return with the ability to see the current active sessions.
Currently only supports 1 Virtual Media device.
Resolves openbmc/phosphor-webui#40
Tested: uploaded ubuntu image file, started the connection and mounted virtual media device from host console. Able to see Ubuntu image file. Also uploaded file and navigated away from the page, checking that the websocket remained open and was sending / recieving messages. Finally, tested that when connection was stopped, 'USB disconnect' log was present in host console.
Change-Id: Ia3155d27cbcfef94c2753dde1303a151e08847cc Signed-off-by: beccabroek <beccabroek@gmail.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Signed-off-by: Derick Montague <derick.montague@ibm.com>
show more ...
|
a1b5fb6a | 17-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove unused interpolate
Interpolate was used prior to the ngToast. https://github.com/openbmc/phosphor-webui/commit/92d13b62f56fa302a8231690e7371c6ae04f50ba#diff-bbc57e73eb8aa4f1c2de7b8e033393e3 m
Remove unused interpolate
Interpolate was used prior to the ngToast. https://github.com/openbmc/phosphor-webui/commit/92d13b62f56fa302a8231690e7371c6ae04f50ba#diff-bbc57e73eb8aa4f1c2de7b8e033393e3 moved to ngToast and removed the use of interpolate.
Tested: Build this and the commits below and loaded onto a Witherspoon system. Did a power on, warm reboot, and immediate shutdown. Change-Id: I99c2f3705df413fc744066dd34ba38a383c174fc Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
aa4734d5 | 17-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Added comments to help clarify "confirm"
For the next person digging in this code. :)
Change-Id: Ib6c21da3fb53a4277a90bf2e5cab90ed29496724 Signed-off-by: Gunnar Mills <gmills@us.ibm.com> |
f61631eb | 17-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove done TODO
This TODO is complete, remote it.
Change-Id: Ifb775aa932bf54e790ff60352611a716f2d7fb02 Signed-off-by: Gunnar Mills <gmills@us.ibm.com> |
834eb010 | 17-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove unused testState
Change-Id: I9235c146fcd1288add4eeaa209d0f7b12f4d394e Signed-off-by: Gunnar Mills <gmills@us.ibm.com> |
11f36032 | 17-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove unused powerOnConfirm and powerConfirm
There is no confirm for Powering on the system. These were unused.
Change-Id: I4f5c3eb0a7676877ccbb0fef687ab525e585e428 Signed-off-by: Gunnar Mills <gm
Remove unused powerOnConfirm and powerConfirm
There is no confirm for Powering on the system. These were unused.
Change-Id: I4f5c3eb0a7676877ccbb0fef687ab525e585e428 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|