Remove unused dataService sensorData

dataService.sensorData was set but never used.

Change-Id: I0fffd578c1c4391fec3bc3354e09dfb00db5d03e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Fix '$scope.filteredLogs is undefined'

When loading the "Event log" page '$scope.filteredLogs is undefined'
is logged in the console.

https://github.com/openbmc/phosphor-webui/commit/1ca1d7e10ed0ef

Fix '$scope.filteredLogs is undefined'

When loading the "Event log" page '$scope.filteredLogs is undefined'
is logged in the console.

https://github.com/openbmc/phosphor-webui/commit/1ca1d7e10ed0ef47206bb89f6dcc5778b1239519
moved the watch on the all logs checkbox to $scope.filteredLogs.

Add $scope.filteredLogs to the top of the file so it is not
undefined on page load.

Tested: No longer see the console message.
Change-Id: Ifa49b416db1a692fc16b3325cef26f59189855a8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove unused sensors-controller

A 2nd sensors page was visible at server-health/sensors/:type.
This page was not reachable from the menu and did not work.
This page had several bugs flagged by sona

Remove unused sensors-controller

A 2nd sensors page was visible at server-health/sensors/:type.
This page was not reachable from the menu and did not work.
This page had several bugs flagged by sonar scanner.

Change-Id: Ib444fb398e49d469ba0693ba46856e0a5ac961d1
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove unused inventory-controller

A 2nd inventory page was visible at server-health/inventory.
This page had hardcoded data and was not reachable from the menu.
This page had several bugs flagged b

Remove unused inventory-controller

A 2nd inventory page was visible at server-health/inventory.
This page had hardcoded data and was not reachable from the menu.
This page had several bugs flagged by sonar scanner.

Change-Id: I672ad5436c877fedb409810d0ed71c58a48d1997
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move to clang-format-6.0

The docker image moved from clang-format-5.0 to clang-format-6.0.

Change-Id: I3c615d7df1f21569531b4dc2cb0bc4f425cb43f8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Event log select all checkbox

Previously the select all checkbox selected
all events, regardless of the filter applied.
In addition, if all the events on a filtered
page were selected, the checkbox

Event log select all checkbox

Previously the select all checkbox selected
all events, regardless of the filter applied.
In addition, if all the events on a filtered
page were selected, the checkbox was not checked.

Resolves openbmc/openbmc#3373

Tested: select all checkbox selects only the
events visible to the user. If all events
are selected, 'select all' checkbox is
checked.

Change-Id: Ibd5d1942b5c1c745a544d680288fd10206c7bbc6
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Checkbox not selected with 0 log events selected

When 0 events are displayed, the 'select all'
checkbox should not be selected by default.

Resolves openbmc/openbmc#2747

Tested: box is not checked

Checkbox not selected with 0 log events selected

When 0 events are displayed, the 'select all'
checkbox should not be selected by default.

Resolves openbmc/openbmc#2747

Tested: box is not checked in the case of 0
events displayed.

Change-Id: I50a12175d29f433d9e2ba0d9c1ff4413ebc018f4
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Remove double variable set

"loading" was set twice in a row.
Remove the 1st.
Found using sonar scanner.

Change-Id: I21b40f316b7227ea003daae7924b992c1a1ed77b
Signed-off-by: Gunnar Mills <gmills@us.i

Remove double variable set

"loading" was set twice in a row.
Remove the 1st.
Found using sonar scanner.

Change-Id: I21b40f316b7227ea003daae7924b992c1a1ed77b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add Power Usage Page

Created a new page, "Manage Power Usage".
This page is under the "Server control" tab.
This new page currently just displays the power consumption.
Future commits will allow the

Add Power Usage Page

Created a new page, "Manage Power Usage".
This page is under the "Server control" tab.
This new page currently just displays the power consumption.
Future commits will allow the user to set the power cap from
this page. One day, things like power consumption trending
data could also be on this page.

There was a blank unused controller which was for similar things,
removed it.

Tested: See the page and the consumption data. Uploaded screenshots
to openbmc/openbmc#3221
Change-Id: I9f97c58a086f34c1c1990c03d5e05b081619bd5c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Turn uglification back on

Fixes github bug openbmc/openbmc#2871

Turn on uglification again. It turns out, we only had one issue
preventing the UI from starting when running in uglified mode. This

Turn uglification back on

Fixes github bug openbmc/openbmc#2871

Turn on uglification again. It turns out, we only had one issue
preventing the UI from starting when running in uglified mode. This
patchset fixes the issue, and reenables uglification.

This patchset drops our gzip compressed payload size by about 50K (about
14%). While it doesn't seem like a lot now, it increases our ability
to scale the javascript payloads going forward.

Change-Id: I0744687203a9db0f4b26d1e1d2f4e3bdb4a52f78
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Remove diagnostics page

This page was unused and unreachable from the menu.
Cleaning up the code base.

Change-Id: Icebccb111f0d775cc6bd2c95a5588f67a75af9cf
Signed-off-by: Gunnar Mills <gmills@us.ib

Remove diagnostics page

This page was unused and unreachable from the menu.
Cleaning up the code base.

Change-Id: Icebccb111f0d775cc6bd2c95a5588f67a75af9cf
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move server LED files

The WebUI has a main menu with 5 options: Server overview,
Server health, Server control, Server Configuration, Users.

These 5 main menu items each have a directory in /app/,

Move server LED files

The WebUI has a main menu with 5 options: Server overview,
Server health, Server control, Server Configuration, Users.

These 5 main menu items each have a directory in /app/,
although the directory names differ slightly.
These 5 main menu items are also modules whose content includes
their sub-menu items (again names differ slightly).

E.g. "Firmware" and "Network settings" are sub-menu items of the
main menu item "Server configuration" which is located in the
app/configuration dir and part of the app.configuration module.

The Server LED sub menu item did not follow this pattern and was
under the wrong directory and in the wrong module. Moved it.
In a future commit I renamed it from unit-id.

Tested: Verified server LED still works.
Change-Id: I02e3a7995cf8ccc5b487c345866651d984c8d70c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fix event log sorting

The error logs were ordered "81, 80, 8, 79 ..."
sortAscending was causing this, remove it and switch "+Id" to "-Id"
which is the correct way to do descending ordering.
http://w

Fix event log sorting

The error logs were ordered "81, 80, 8, 79 ..."
sortAscending was causing this, remove it and switch "+Id" to "-Id"
which is the correct way to do descending ordering.
http://www.tutorialspark.com/AngularJS/AngularJS_Filter_orderBy.php

Resolves openbmc/openbmc#3233

Tested: Server Overview page and event log page both show correct
order now.
Change-Id: Ie1aee542cec8a6157c538838037ce82fc2525e46
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Format code using clang-format-5.0

Once merged, this repository will have CI enforce
the coding guidelines in the .clang-format file.

Change-Id: I96a05972665f9c67625c6850c3da25edc540be06
Signed-off

Format code using clang-format-5.0

Once merged, this repository will have CI enforce
the coding guidelines in the .clang-format file.

Change-Id: I96a05972665f9c67625c6850c3da25edc540be06
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Run js-beautify and fixjsstyle on code

Found this pointer on stackoverflow:
https://stackoverflow.com/a/31660434/5508494

End goal is to get the code formatted well enough that
clang format will run

Run js-beautify and fixjsstyle on code

Found this pointer on stackoverflow:
https://stackoverflow.com/a/31660434/5508494

End goal is to get the code formatted well enough that
clang format will run correctly against it.

Change-Id: I80053e78d253d8eee49233e42d55e5807ae8fdc8
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Display event logs in ascending order

Reversed the event log order to show the newest event first

Resolves openbmc/openbmc#3161

Tested: Running GUI locally and verified the order in both Server
ov

Display event logs in ascending order

Reversed the event log order to show the newest event first

Resolves openbmc/openbmc#3161

Tested: Running GUI locally and verified the order in both Server
overview page and in Server health -> Event log page

Change-Id: I1f1265332bb426d3f2a13932cfd5445740c3f49b
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>

show more ...

Remove the version from each file

Already have a Web UI version, no need to track the version
of each file. These have not been getting updated.

Change-Id: I1cd3a2c2d67b24ded5edcca9dbfd3f6806d93ed4

Remove the version from each file

Already have a Web UI version, no need to track the version
of each file. These have not been getting updated.

Change-Id: I1cd3a2c2d67b24ded5edcca9dbfd3f6806d93ed4
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Adding new button 'Normal' in sensors page

- Adding a 3rd option called Normal in
addition to Critical and Warning based on the
discussion in openbmc/openbmc#2750

Fixes openbmc/openbmc#2750

Teste

Adding new button 'Normal' in sensors page

- Adding a 3rd option called Normal in
addition to Critical and Warning based on the
discussion in openbmc/openbmc#2750

Fixes openbmc/openbmc#2750

Tested: Verified the 'Normal' button works.
Change-Id: Ied4d37aa9284392f08818f8111ebbcc677234586
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Revert "Fix refresh for event log page"

This reverts commit a4dacb6a365609ec8e602b3b020030fe73da6087.

https://gerrit.openbmc-project.xyz/#/c/10063/ refreshes all
pages so individual refresh functio

Revert "Fix refresh for event log page"

This reverts commit a4dacb6a365609ec8e602b3b020030fe73da6087.

https://gerrit.openbmc-project.xyz/#/c/10063/ refreshes all
pages so individual refresh functions are no longer needed

Change-Id: Icbe38276b53457cc2a0c22b29a58c9fee84e6f25
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Revert "Fix refresh on system & sensors overview pages"

This reverts commit 23217dae2bdc8e9bd6b3f20a395d1892382b0682.

https://gerrit.openbmc-project.xyz/#/c/10063/ refreshes all
pages so individual

Revert "Fix refresh on system & sensors overview pages"

This reverts commit 23217dae2bdc8e9bd6b3f20a395d1892382b0682.

https://gerrit.openbmc-project.xyz/#/c/10063/ refreshes all
pages so individual refresh functions are no longer needed

Change-Id: I52151ba0e356f000324538e4b5eac6c9846c2eb3
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Ia35dc

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Ia35dc209cd7965842d439399768987b47d55a4ef
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fix refresh for event log page

Coded the refresh button in log page so
that upon clicking on it will run the rest
command to get the latest event log data.
This sample code can be used to fetch the

Fix refresh for event log page

Coded the refresh button in log page so
that upon clicking on it will run the rest
command to get the latest event log data.
This sample code can be used to fetch the
relevant data for other pages when refresh
button is clicked.

Fixes openbmc/openbmc#3009

Change-Id: Iefdc3f77895881df44238142148eb298663c3b5a
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

show more ...

Fix refresh on system & sensors overview pages

Partially resolves openbmc/openbmc#2927

Change-Id: I7f449c41ef645b67253c5d3c2ed6c8b1984f0408
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>

Display warning icons on non-functional subcomponents

Warning icons are now displayed only in subcomponents that are
present and non-functional. Only "present" subcomponents are
displayed so only ne

Display warning icons on non-functional subcomponents

Warning icons are now displayed only in subcomponents that are
present and non-functional. Only "present" subcomponents are
displayed so only need to check for functional.
An example of using this is cores of the cpu. Only display
a warning on a present and non-functional core.

Resolves openbmc/openbmc#2989

Tested: Only see a warning on a non-functional core.
Change-Id: Ic22b7531de4dfcc445bfc5eae7dd23b0089f2cdf
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Only display "present" subcomponents

Only display "present" subcomponents of an inventory item.
An example of this would be cores of the cpu. Only display
present cores.

Tested: See only present co

Only display "present" subcomponents

Only display "present" subcomponents of an inventory item.
An example of this would be cores of the cpu. Only display
present cores.

Tested: See only present cores.
Change-Id: Ib53d72d24e35f17a047baa15b1eaad0e099576a5
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...