Remove firmware reboot timeout

A 10 second timeout was used as a tempoary work-around
before rebooting the BMC on the firmware page–removing
the timeout since it is no longer needed.

Remove firmware reboot timeout

A 10 second timeout was used as a tempoary work-around
before rebooting the BMC on the firmware page–removing
the timeout since it is no longer needed.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I6a95d5f5bb377d3fd3cc0802f7fb3d6d0f177870

show more ...

Add error message when image fails to activate

If an image fails to activate a toast message is displayed.

Tested on Witherspoon with master build image and
field mode turned on

Add error message when image fails to activate

If an image fails to activate a toast message is displayed.

Tested on Witherspoon with master build image and
field mode turned on. When image fails to activate,
the failed activation status response returns a 200
ok and an error toast is displayed. Tested with field
mode turned off to verify image activates and BMC reboots.
Tested on all browsers.

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I517f184549673e7b807cc0a553a728d05d6dbba1

show more ...

Firmware: Remove unused interpolate

Interpolate was used prior to the ngToast.
https://github.com/openbmc/phosphor-webui/commit/90ae95eb6f5f30e3863f24ad364b111258ea4ee4#diff-44385b1119c2

Firmware: Remove unused interpolate

Interpolate was used prior to the ngToast.
https://github.com/openbmc/phosphor-webui/commit/90ae95eb6f5f30e3863f24ad364b111258ea4ee4#diff-44385b1119c2cae41d7331ab4a5cd5fe
moved to ngToast (later toastService) and removed the use of
interpolate.

Tested: Build this and the commits below and loaded onto a Witherspoon
system. Uploaded an image and activated it.

Change-Id: I161c7860cec006dc434bc00495b25b588f069775
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fix activate image and reboot BMC

- Change bmcReboot callback in apiutils.js to HTTP request that returns a promise that is resolved with response object
- Remove emitted 'user-logged-in

Fix activate image and reboot BMC

- Change bmcReboot callback in apiutils.js to HTTP request that returns a promise that is resolved with response object
- Remove emitted 'user-logged-in' as it is not needed to reboot BMC on firmware controller and bmc reboot controller
- Add toast message for visual confirmation of successful BMC reboot

Tested: On Server Configuration > Firmware page uploaded new image to activate and automatically reboot. After 2-3 minutes confirmed image activated and then BMC rebooted after image activation. Tested Server Control > Reboot BMC page by selecting Reboot BMC, confirmed BMC rebooted.

Resolves openbmc/phosphor-webui#79

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: Ied6809ad1ed6cc3c73ac5c818c7a06607810c396

show more ...

Firmware page upload not working in some cases

Upload was not working in some cases because of two separate
issues. Inline onchange is no longer executed in Chrome. This
removes the

Firmware page upload not working in some cases

Upload was not working in some cases because of two separate
issues. Inline onchange is no longer executed in Chrome. This
removes the inline onchange event since it was updating a variable
not being used anyway. This also updates the click-outside
directive as it was missing [ ] brackets that were necessary and
throwing an error in the console when loaded onto a witherspoon.

see https://developer.chrome.com/extensions/contentSecurityPolicy

and

https://stackoverflow.com/questions/35126898/error-after-minifica
tion-of-angular-js-error-injectorunpr-unknown-provider

Resolves openbmc/phosphor-webui#77

Tested: Able to upload image onto Witherspoon. Click-outside directive
worked when GUI was mounted on a Witherspoon

Change-Id: I7b1c385751e114b2d31f516e391dd0737117ab42
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Add role alert to toasts

For accessibility reasons, 'role="alert" is required for toast
messages. This notifies screen readers that an error or success
message has appeared. Adds a s

Add role alert to toasts

For accessibility reasons, 'role="alert" is required for toast
messages. This notifies screen readers that an error or success
message has appeared. Adds a service layer for toast messages
that adds the role attribute to the message.

Change-Id: Ic4dbf5556337eea589de5692c1b4c3323e771813
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Add toast to Firmware page

Replace error and success messages with toast notifications.

Change-Id: I6c68568b7c9db4fd1f85b3de843289cf1bfba376
Signed-off-by: beccabroek <beccabroe

Add toast to Firmware page

Replace error and success messages with toast notifications.

Change-Id: I6c68568b7c9db4fd1f85b3de843289cf1bfba376
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Revert "Remove unused dataService"

This reverts commit e13275b837ed38b7e8553316accedb51b32ef37b.
dataService is used in powerOn(), warmReboot() and
isServerOff().

Change-Id:

Revert "Remove unused dataService"

This reverts commit e13275b837ed38b7e8553316accedb51b32ef37b.
dataService is used in powerOn(), warmReboot() and
isServerOff().

Change-Id: I8635ac88f93b6354ea7d352f92c9a7f4281e21a5
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove unused dataService

Change-Id: I99e0d16a56908beb1397bb4c15390c72c3b2f3f5
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Activate image and reboot host

When activating a host image, gives the option to:
a) Activate image without booting
b) Activate image and boot host. If server is
in 'off

Activate image and reboot host

When activating a host image, gives the option to:
a) Activate image without booting
b) Activate image and boot host. If server is
in 'off' status the option is to power on.
If the server is in 'unavailable', 'on', or
'error' status the option is to reboot
Also updated polling during boot and reboot to use
/subscribe API.

Resolves openbmc/openbmc#3323

Tested: The GUI displays the options and boots /
reboots appropriately based on server status.

Change-Id: I62c19e094ecc7112263c26844fcd30b2bf3c2b84
Signed-off-by: beccabroek <rebecca.shaw@ibm.com>

show more ...

Move to clang-format-6.0

The docker image moved from clang-format-5.0 to clang-format-6.0.

Change-Id: I3c615d7df1f21569531b4dc2cb0bc4f425cb43f8
Signed-off-by: Gunnar Mills <gmil

Move to clang-format-6.0

The docker image moved from clang-format-5.0 to clang-format-6.0.

Change-Id: I3c615d7df1f21569531b4dc2cb0bc4f425cb43f8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Format code using clang-format-5.0

Once merged, this repository will have CI enforce
the coding guidelines in the .clang-format file.

Change-Id: I96a05972665f9c67625c6850c3da25e

Format code using clang-format-5.0

Once merged, this repository will have CI enforce
the coding guidelines in the .clang-format file.

Change-Id: I96a05972665f9c67625c6850c3da25edc540be06
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Run js-beautify and fixjsstyle on code

Found this pointer on stackoverflow:
https://stackoverflow.com/a/31660434/5508494

End goal is to get the code formatted well enough that

Run js-beautify and fixjsstyle on code

Found this pointer on stackoverflow:
https://stackoverflow.com/a/31660434/5508494

End goal is to get the code formatted well enough that
clang format will run correctly against it.

Change-Id: I80053e78d253d8eee49233e42d55e5807ae8fdc8
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Only reboot BMC if it is BMC image activation

Some internal testing found that when a server image is
uploaded and activated, the BMC reboots. This is because
the reboot variable def

Only reboot BMC if it is BMC image activation

Some internal testing found that when a server image is
uploaded and activated, the BMC reboots. This is because
the reboot variable defaults to true and it is not manipulated
in the server image activate code path, but it shares the
common activate image code path with the BMC which look at this
variable to determine if it should reboot the BMC.

Testing: Verified server image activate did not result in BMC
rebooting. Verified when option to reboot BMC after BMC update,
that BMC rebooted. Verified when option to not reboot BMC after
BMC update, that BMC did not reboot.

Resolves openbmc/openbmc#3188

Change-Id: Ib2f6b9cb6af27c11ad0f5c6fc33f161ac3ffa611
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Display success message after uploading image

Fix includes:
- Displaying an 'Upload complete' message and clearing the image's
file name if the upload succeeds.
- Displaying an

Display success message after uploading image

Fix includes:
- Displaying an 'Upload complete' message and clearing the image's
file name if the upload succeeds.
- Displaying an error pop-up with reason for failure when the
upload fails.

Change-Id: Id9474b62ed62e1b40ffa018eb273abbf19be26ce
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>

show more ...

Refresh the firmware page after downloading image

Fix includes
- Polling the number of software objects for a new image. During
which time the 'Downloading in progress' status bar

Refresh the firmware page after downloading image

Fix includes
- Polling the number of software objects for a new image. During
which time the 'Downloading in progress' status bar will be
displayed. A 2-minute timeout is used.
- Displaying a 'Download complete' message if the download succeeds
and refreshing the firmware page to show the new image once it is
downloaded.
- Displaying an error pop-up with reason for failure when the
download fails.

Resolves openbmc/openbmc#3054

Change-Id: I79a8b8c661c01474a12cef4af524cafdc2cee1fe
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>

show more ...

Remove the version from each file

Already have a Web UI version, no need to track the version
of each file. These have not been getting updated.

Change-Id: I1cd3a2c2d67b24ded5ed

Remove the version from each file

Already have a Web UI version, no need to track the version
of each file. These have not been getting updated.

Change-Id: I1cd3a2c2d67b24ded5edcca9dbfd3f6806d93ed4
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Display error if error on upload

We were missing the rejected promise when image upload returned
an error. Now with this change and
https://gerrit.openbmc-project.xyz/#/c/9594/ image

Display error if error on upload

We were missing the rejected promise when image upload returned
an error. Now with this change and
https://gerrit.openbmc-project.xyz/#/c/9594/ image upload
now uploads an image and refreshes the page to display the image
or displays an error if the upload failed.

Resolves openbmc/openbmc#2960

Tested: See an error if a bad image. GUI refreshes if the image
was uploaded successfully.
Change-Id: I5f4030fb29fc08aa65dd0d36e32368106c31a76b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Wait for 10 seconds before rebooting

After the image is active wait 10 seconds before rebooting
if "activate and reboot" was selected. We had an issue,
https://github.com/openbmc/ope

Wait for 10 seconds before rebooting

After the image is active wait 10 seconds before rebooting
if "activate and reboot" was selected. We had an issue,
https://github.com/openbmc/openbmc/issues/2764, that a
system could brick if the system reboots before the service
to set the U-Boot variables is complete.
Wait 10 seconds before rebooting to ensure this service is
complete. This issue is fixed in newer images, but the user
may be updating from an older image that does not that have
this fix.

Tested: Verified the system waits 10 seconds after the image
becomes active before rebooting.

Change-Id: I00115680cca14e50814e44c302d6134aca242d3f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Display error if TFTP post fails

Display an error if the DownloadViaTFTP returns an
error code. This code replaces some unused code.

Resolves openbmc/openbmc#3029

Teste

Display error if TFTP post fails

Display an error if the DownloadViaTFTP returns an
error code. This code replaces some unused code.

Resolves openbmc/openbmc#3029

Tested: Verified I see this error if the DownloadViaTFTP call
returns an error code.
Change-Id: I1547689059f45953b29aedda75c0599aec30079d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Display error if TFTP field empty

If either TFTP Server IP Address or File Name is empty for the
"Download image file from TFTP server" function, return and
display an error.

Display error if TFTP field empty

If either TFTP Server IP Address or File Name is empty for the
"Download image file from TFTP server" function, return and
display an error.

Tested: Verified I see this error if either field is empty.

Change-Id: I3da3353dad7cfb0f765d8a662412c3adb3fa4efd
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add Activate firmware and reboot button

Added a radio button to activate firmware and reboot the BMC.
If the "Activate firmware and reboot" option is selected, reboot
the BMC after a

Add Activate firmware and reboot button

Added a radio button to activate firmware and reboot the BMC.
If the "Activate firmware and reboot" option is selected, reboot
the BMC after activating the firmware. The user is then logged
out.

Resolves openbmc/openbmc#3027

Tested: When "Activate firmware and reboot" option is selected,
the BMC reboots after activating. When it is not selected,
the BMC image just activates.
Change-Id: I07293dc8a6ddfac4cf58ba2c1d1352c9afd6fa8d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Update the GUI after an image activated

When activating an image the firmware page does not refresh
after the image is activated and show the image as "Active".
To get the image to s

Update the GUI after an image activated

When activating an image the firmware page does not refresh
after the image is activated and show the image as "Active".
To get the image to show as "Active", a user must refresh the
page.

The activating image code now waits until the image is activated
and the REST call returns "Active" or "Failed" and then refreshes
the page.

Resolves openbmc/openbmc#2966

Tested: Activated an image and verfied it refreshed after
"Active".
Change-Id: Ic68e3c9e6cb5c2ea4f5d66f48fd09252c4807f26
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add server confirm activation modal

Added text specific to server images that appears in the
activation modal when a "server" image is activated.
The "server" and "BMC" images use th

Add server confirm activation modal

Added text specific to server images that appears in the
activation modal when a "server" image is activated.
The "server" and "BMC" images use the same modal, but the text
and if radio buttons appear differ.

Resolves openbmc/openbmc#2967

Tested: Activated both a server and BMC image on a Witherspoon.
Change-Id: I83693641ebfef802d403141ade55a950f359ba6e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove "reboot" modal

This modal was not used.

Tested: Uploaded and activated an image on a Witherspoon.
Change-Id: I3eb549b04f09565da06a28815b2b3843dd72cafb
Signed-off-by:

Remove "reboot" modal

This modal was not used.

Tested: Uploaded and activated an image on a Witherspoon.
Change-Id: I3eb549b04f09565da06a28815b2b3843dd72cafb
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...