27ce84d2 | 05-Feb-2019 |
beccabroek <beccabroek@gmail.com> |
Add role alert to toasts
For accessibility reasons, 'role="alert" is required for toast messages. This notifies screen readers that an error or success message has appeared. Adds a service layer for
Add role alert to toasts
For accessibility reasons, 'role="alert" is required for toast messages. This notifies screen readers that an error or success message has appeared. Adds a service layer for toast messages that adds the role attribute to the message.
Change-Id: Ic4dbf5556337eea589de5692c1b4c3323e771813 Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
a09cc2da | 23-Jan-2019 |
beccabroek <beccabroek@gmail.com> |
Form validation on login page
Using ngMessages, adds form validation to login page. Also creates a directive, hasError, to be used to validate form field by passing in a boolean. This is a proposed
Form validation on login page
Using ngMessages, adds form validation to login page. Also creates a directive, hasError, to be used to validate form field by passing in a boolean. This is a proposed pattern to be used moving forward, as form validation is added to additional pages.
Validation error messages are shown on $touched and on submit. Unreachable Server and Invalid username and password error messages remain until input is no longer $pristine after form submission.
In addition, this removes unneeded and unused css styling
Resolves openbmc/phosphor-webui#47
Change-Id: I7a067af67ac74d4cf2977d10f66445720ecae9eb Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
97280b3e | 16-Nov-2018 |
Iftekharul Islam <iffy.ryan@ibm.com> |
Fix table header
Makes the table header in sensor page stay fixed after scrolling. Fixes the allignment of filter button.
Resolves openbmc/phosphor-webui#28
Change-Id: If9b8b0848169b5924b811e67588
Fix table header
Makes the table header in sensor page stay fixed after scrolling. Fixes the allignment of filter button.
Resolves openbmc/phosphor-webui#28
Change-Id: If9b8b0848169b5924b811e67588ff57c8dae7c5c Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
show more ...
|
90ae95eb | 15-Jan-2019 |
beccabroek <beccabroek@gmail.com> |
Add toast to Firmware page
Replace error and success messages with toast notifications.
Change-Id: I6c68568b7c9db4fd1f85b3de843289cf1bfba376 Signed-off-by: beccabroek <beccabroek@gmail.com> |
a30394b7 | 14-Dec-2018 |
beccabroek <beccabroek@gmail.com> |
Add toast notifications to SNMP page
Design team proposed that our error and success messages be delivered as 'toast' messages on the right side of the screen. This brings in ngToast and implements
Add toast notifications to SNMP page
Design team proposed that our error and success messages be delivered as 'toast' messages on the right side of the screen. This brings in ngToast and implements notifications on SNMP page. Notifications will fade after 10 seconds or can be dismissed.
https://github.com/tameraydin/ngToast
Change-Id: I1053534cd1ab189ae5c2ac07e2a922acea231c70 Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
84e114a4 | 14-Nov-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Move to Bootstrap 4
Bootstrap < 4.1.2 has the following CVE: https://nvd.nist.gov/vuln/detail/CVE-2018-14041
Removed bootstrap-theme.css due to "Replaced the separate optional theme with configurab
Move to Bootstrap 4
Bootstrap < 4.1.2 has the following CVE: https://nvd.nist.gov/vuln/detail/CVE-2018-14041
Removed bootstrap-theme.css due to "Replaced the separate optional theme with configurable options via SCSS variables (e.g., $enable-gradients: true)."
Added "width: 100%" to a few places where width 100% was no longer getting inherited. Moved a few elements and adjusted styles to get the same look as before.
See https://getbootstrap.com/docs/4.0/migration/ for more information.
Tested: Manually on a Witherspoon. Change-Id: I0a72665ac1ca6eacd0b553a585b1fb15e14ae62c Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
569ccf66 | 29-Oct-2018 |
beccabroek <beccabroek@gmail.com> |
Display log events in user time
Allows user to display events in their timezone or in UTC. Previously allowed either ETC or UTC, but listed ETC as 'user timezone'. Updates date time page from GMT o
Display log events in user time
Allows user to display events in their timezone or in UTC. Previously allowed either ETC or UTC, but listed ETC as 'user timezone'. Updates date time page from GMT offset to UTC offset for overall consistency. Also updates overview page to list critical events in user timezone
Resolves openbmc/phosphor-webui#36
Tested: changed timezone settings locally and validated that correct timezone and UTC offset was presented in the UI.
Change-Id: I89ca5045eeb789527aa07f5b1baebaa3fbd6b1fa Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
7ddc7274 | 12-Apr-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Set MAC address on "Save Settings"
Make a REST call to set the MAC address when the "Save Settings" button is pressed.
Tested: Verified the MAC Address is set. Change-Id: I39f6d4688842b3453fd219795
Set MAC address on "Save Settings"
Make a REST call to set the MAC address when the "Save Settings" button is pressed.
Tested: Verified the MAC Address is set. Change-Id: I39f6d4688842b3453fd219795d07f819ba4ba481 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
6d7b4a8d | 02-Apr-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Display error if TFTP field empty
If either TFTP Server IP Address or File Name is empty for the "Download image file from TFTP server" function, return and display an error.
Tested: Verified I see
Display error if TFTP field empty
If either TFTP Server IP Address or File Name is empty for the "Download image file from TFTP server" function, return and display an error.
Tested: Verified I see this error if either field is empty.
Change-Id: I3da3353dad7cfb0f765d8a662412c3adb3fa4efd Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
25fdeb8e | 21-Feb-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Add "block" to active modals
When a modal is active make it blocked so it can be viewed. The modals such as confirming activating an image were not visible. This change makes those modal visible whe
Add "block" to active modals
When a modal is active make it blocked so it can be viewed. The modals such as confirming activating an image were not visible. This change makes those modal visible when active.
Tested: Activated several images on a Witherspoon system. Change-Id: I6667af017ea397344df6b6ed7e08949ffb4a3c55 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
bbcf670a | 06-Oct-2017 |
Ed Tanous <ed.tanous@intel.com> |
Modernize web GUI and make it installable on BMC
1. Move from gulp server to webpack. This allows the proper compression to allow the webui to be embedded in the BMC. 2. Update js paths to use requ
Modernize web GUI and make it installable on BMC
1. Move from gulp server to webpack. This allows the proper compression to allow the webui to be embedded in the BMC. 2. Update js paths to use requires, not hardcoded paths. This was required to make the packaging work correctly. 3. Add babel config to do translation. 4. Update angularjs directive calls to use the angular 1.6 syntax for promises intead of success and fail.
https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$http
5. As a consequence of using NPM/webpack, the versions of angular and associated modules that were checked in have been updated.
Change-Id: Icb71e2eedb0d9a8943fc914f9dc4be11d0983c00 Signed-off-by: Ed Tanous <ed.tanous@intel.com> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
show more ...
|
ec6bcd10 | 06-Sep-2017 |
Iftekharul Islam <iffy.ryan@ibm.com> |
Revisiting log status info in header with better styes
Change-Id: I0b2ee399243f0bc3e5ed44bc578a0d153486ed55 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com> |
98e66604 | 28-Aug-2017 |
Michael Davis <michael.s.davis@ibm.com> |
changed modal behavior to animate/slide in from topand fixed overlay to fade in/out.
Change-Id: I9942715f424b0e79196916551d161ccdbf94b7bf Signed-off-by: Michael Davis <michael.s.davis@ibm.com> |
9632d71c | 28-Aug-2017 |
Michael Davis <michael.s.davis@ibm.com> |
fixed sizes and positioning of icons
Change-Id: Idc6930c87f61217f9bf4daab5b82c418606cdf80 Signed-off-by: Michael Davis <michael.s.davis@ibm.com> |
85661253 | 25-Aug-2017 |
Michael Davis <michael.s.davis@ibm.com> |
fixed colors and text
Change-Id: Ib2d1caf520302555b3bfb7b49cb69ae68b6bcfa8 Signed-off-by: Michael Davis <michael.s.davis@ibm.com> |
96bbf310 | 22-Aug-2017 |
Iftekharul Islam <iffy.ryan@ibm.com> |
Updated master after merge conflicts
Change-Id: Ibea933c20071cc85201420ba1e31fedf9356f55b Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com> |
b8a41c18 | 14-Aug-2017 |
Michael Davis <michael.s.davis@ibm.com> |
Accessibility fixes:
- changed buttons to spans since not being used in forms - added aria roles to html elements - changed low contrast colors
Change-Id: I56e784b226baa7f9b24346446a0a023fcea633
Accessibility fixes:
- changed buttons to spans since not being used in forms - added aria roles to html elements - changed low contrast colors
Change-Id: I56e784b226baa7f9b24346446a0a023fcea633d4 Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
show more ...
|
428375e8 | 01-Aug-2017 |
Michael Davis <michael.s.davis@ibm.com> |
loader animation added to pages
Change-Id: Id8c890714d0a90ae913b6581cd655abcf6cd6781 Signed-off-by: Michael Davis <michael.s.davis@ibm.com> |
54013ac9 | 09-Aug-2017 |
Michael Davis <michael.s.davis@ibm.com> |
fixed code to display proper icon when server is in off state.
Change-Id: Iad633b0986bf37ce63943ab64fdc3279bd419180 Signed-off-by: Michael Davis <michael.s.davis@ibm.com> |
2d289422 | 03-Aug-2017 |
Michael Davis <michael.s.davis@ibm.com> |
minor QA fixes to margins
Change-Id: If3730f75e796f8f48fd036234711efa23e23f794 Signed-off-by: Michael Davis <michael.s.davis@ibm.com> |
20389abb | 31-Jul-2017 |
Michael Davis <michael.s.davis@ibm.com> |
extended disabled status indicator to use "off" icon
Change-Id: If46c5dfa5656948747cbf4f2faacab9244f8e40c Signed-off-by: Michael Davis <michael.s.davis@ibm.com> |
7f89fad6 | 31-Jul-2017 |
Michael Davis <michael.s.davis@ibm.com> |
UI changes and fixes based on QA feedback
Change-Id: I13bae30e86330a8831d35f1d8a2f7da821324e37 Signed-off-by: Michael Davis <michael.s.davis@ibm.com> |
dc7479b9 | 31-Jul-2017 |
Michael Davis <michael.s.davis@ibm.com> |
Event log: copy and UI fixes based on QA feedback
Change-Id: Ife1b7e691f5fcf023616b9151cff6598d346c2c4 Signed-off-by: Michael Davis <michael.s.davis@ibm.com> |
8b527990 | 31-Jul-2017 |
Michael Davis <michael.s.davis@ibm.com> |
changes to global search filter:
- Added clear button to clear input - changed submit to resize based on content
Change-Id: Ida69f961effc261dc44319ba8710d9b4349ba847 Signed-off-by: Michael Davis <m
changes to global search filter:
- Added clear button to clear input - changed submit to resize based on content
Change-Id: Ida69f961effc261dc44319ba8710d9b4349ba847 Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
show more ...
|
f050485e | 27-Jul-2017 |
Michael Davis <michael.s.davis@ibm.com> |
fixed alignment and margins of global buttons to match designs
Change-Id: Ib932b23aa891a1dd3ad3942dc9c8fbcf94f87f2b Signed-off-by: Michael Davis <michael.s.davis@ibm.com> |