build: Subproject support

Change-Id: I4451ad2b516d585a71f74e2897548d22ac5d0472
Signed-off-by: William A. Kennington III <wak@google.com>

watchdog: support a default interval parameter

IBM has a desire to be able to define a Interval value different then
the default on watchdog startup. Some systems need a larger starting
value and it

watchdog: support a default interval parameter

IBM has a desire to be able to define a Interval value different then
the default on watchdog startup. Some systems need a larger starting
value and it's easiest to pass this in at watchdog startup time.

Tested:
- Verified when new parameter is not passed, the standard 30000 default
is used.
- Verified when the new --default_interval is passed in that it is used

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I51908f69b4f9af26a7bb49101c4ca2ee97ef555c

show more ...

mainapp: Fix postcode path

This was changed from /raw to /raw0

Change-Id: Idf99ffa36aca41ff5da5bab357ab6446cff737ee
Signed-off-by: William A. Kennington III <wak@google.com>

Move source into src directory

This makes the source more distinguishable from top-level metadata.

Change-Id: I5e41186d4606422937ec7d37402a3031d3f776b6
Signed-off-by: William A. Kennington III <wak

Move source into src directory

This makes the source more distinguishable from top-level metadata.

Change-Id: I5e41186d4606422937ec7d37402a3031d3f776b6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/watchdog: Remove separate header

The header contents are not being shared anywhere and the name collides
with the source header.

Change-Id: I2ddfd4488e2318b9fdd34cc1663044dbe413f4f1
Signed-off

test/watchdog: Remove separate header

The header contents are not being shared anywhere and the name collides
with the source header.

Change-Id: I2ddfd4488e2318b9fdd34cc1663044dbe413f4f1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

meson: Move to c++20

Change-Id: I823469db19cfc8ae785d6f884069241b239fd938
Signed-off-by: William A. Kennington III <wak@google.com>

meson: Add missing CLI11 check and subproject support

Change-Id: I86b9116a489e61642ee27e3dbee2fcbc267d6bca
Signed-off-by: William A. Kennington III <wak@google.com>

meson: Use subprojects where possible

Change-Id: Id49b7db21f7f44d5183549430988fd33b9166edb
Signed-off-by: William A. Kennington III <wak@google.com>

meson: Propagate watchdog library dependencies

Change-Id: I0d5d52ef456ca829b759c65c6fd7e30eb8270744
Signed-off-by: William A. Kennington III <wak@google.com>

meson: Remove explicit werror override

We don't want to break most builders by default and the CI already
includes this option when building code.

Change-Id: Ib1a141ae5be7c4a29ce268dee279c053d0057d

meson: Remove explicit werror override

We don't want to break most builders by default and the CI already
includes this option when building code.

Change-Id: Ib1a141ae5be7c4a29ce268dee279c053d0057d68
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

meson: Fixup formatting

Change-Id: Ia948e7605bead1ddfb17b8071cd39cc28353eadc
Signed-off-by: William A. Kennington III <wak@google.com>

MAINTAINERS: Remove Deepak

Signed-off-by: Deepak Kodihalli <deepak.kodihalli.83@gmail.com>
Change-Id: I4270b995697768a8c87412394fdb1238058a4c4d

test/watchdog: Fix multi-object acquisition

The tests were mistakenly trying to acquire the same DBus path for
watchdog objects while older versions of the objects were still alive.
This fixes the i

test/watchdog: Fix multi-object acquisition

The tests were mistakenly trying to acquire the same DBus path for
watchdog objects while older versions of the objects were still alive.
This fixes the issue by purging the old objects before creating new
ones.

Change-Id: I65bef2f0edab7057c05af9ecd31e554da6565184
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Fix minInterval option

The number option needs to be specified using add_option,
not add_flag.

Tested: with the fix, --min_interval=60000 sets the minInterval to 60
seconds.

Resolves: openbmc/phos

Fix minInterval option

The number option needs to be specified using add_option,
not add_flag.

Tested: with the fix, --min_interval=60000 sets the minInterval to 60
seconds.

Resolves: openbmc/phosphor-watchdog#2

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I2b318454d13b5f7e607f9c9b9de1903edf7bc3a6

show more ...

Test min interval is used when setting remaining time

Test that min interval is used when setting remaining time by extending
the existing test case.

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Chan

Test min interval is used when setting remaining time

Test that min interval is used when setting remaining time by extending
the existing test case.

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I595464b5b6e4c1ef9968849ca63d09a7665d9190

show more ...

Fix setting remaining time lower than minInterval

When a minimum interval is specified, setting the remaining time should
also honor the setting and keep the initial remaining time (initial
countdow

Fix setting remaining time lower than minInterval

When a minimum interval is specified, setting the remaining time should
also honor the setting and keep the initial remaining time (initial
countdown in IPMI terms) at a mimimal interval values.

Tested: see next patch for unit tests

Resolves: openbmc/phosphor-watchdog#1

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I1f5d244bb7b0985227344a3634e3b7c4da2624fc

show more ...

Add a test for the fallback reset timer case

Add a test to verify that reset timer enable will set the timer to the primary
interval.

Tested: tests pass

Signed-off-by: Kun Yi <kunyi731@gmail.com>

Add a test for the fallback reset timer case

Add a test to verify that reset timer enable will set the timer to the primary
interval.

Tested: tests pass

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I0c74b250d1ca2ff20c4a331de9290d73db2774d8

show more ...

Add vishwa as Maintainer

I have implemented the first version of phosphor-watchdog
and have started to follow the changes in gerrit / mailing list

Change-Id: Iac9a135bf1447e62d3513c2be82139c78ca0d4

Add vishwa as Maintainer

I have implemented the first version of phosphor-watchdog
and have started to follow the changes in gerrit / mailing list

Change-Id: Iac9a135bf1447e62d3513c2be82139c78ca0d4f4
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

Implementation of minimum watchdog interval.

Tested: phosphor-watchdog CI unittest - set interval to value smaller than
the minimum interval and test that the minimum interval was set as the
interva

Implementation of minimum watchdog interval.

Tested: phosphor-watchdog CI unittest - set interval to value smaller than
the minimum interval and test that the minimum interval was set as the
interval.
Change-Id: I88d7ca865ce57eaccea8aaf50396dbb50bd396fb
Signed-off-by: Ofer Yehielli <ofery@google.com>

show more ...

autotools: Remove

Meson is now used to build this package in all of the necessary places.

Change-Id: I7fec7c28defc8b5f6aeb2384dd984ee6278a4bcb
Signed-off-by: William A. Kennington III <wak@google.c

autotools: Remove

Meson is now used to build this package in all of the necessary places.

Change-Id: I7fec7c28defc8b5f6aeb2384dd984ee6278a4bcb
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

watchdog: Log timer use during expiration

Change-Id: Ie6dd1da92ffc225a313db208455ad24f4787a990
Signed-off-by: William A. Kennington III <wak@google.com>

mainapp: Add an option for watching post codes

We have some machines that use an IPMI watchdog, but can sometimes take
so long to reboot that the watchdog ends up tripping during the boot
process. U

mainapp: Add an option for watching post codes

We have some machines that use an IPMI watchdog, but can sometimes take
so long to reboot that the watchdog ends up tripping during the boot
process. Unfortunately the boot firmware has no method of talking IPMI
to pet the watchdog, but does emit post codes during the boot up process
when it makes forward progress.

This change adds a flag to instruct the watchdog that it should reset
the TimeRemaining on the watchdog any time new post codes are seen from
the host.

Tested:
Verified that post codes signals were received during
the boot process and the watchdog TimeRemaining was updated
accordingly.

Change-Id: Ie0616f0fe4ee6601f9afdc4eba71f34968780794
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I9d2a01a37179f19ce272f13641217f9bdc4a1315

Set expiredTimerUse when timer expired

IPMI get watchdog command needs this expiredTImerUse property,
For the Timer Use Expiration flags

Tested:
After timer expired, check this dbus property:
busct

Set expiredTimerUse when timer expired

IPMI get watchdog command needs this expiredTImerUse property,
For the Timer Use Expiration flags

Tested:
After timer expired, check this dbus property:
busctl get-property "xyz.openbmc_project.Watchdog" \
"/xyz/openbmc_project/watchdog/host0" \
"xyz.openbmc_project.State.Watchdog" \
"ExpiredTimerUse"

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: I65f15cee5a436e9ffbf5e7094373386f4dfba6b3

show more ...

meson: Add alternate build system

For now we will support both the autotools and meson build systems
alongside each other, until support for meson is ready across the
ecosystem.

Tested:
Run thr

meson: Add alternate build system

For now we will support both the autotools and meson build systems
alongside each other, until support for meson is ready across the
ecosystem.

Tested:
Run through build and unit tests that leverage the new build system
and all of the tests pass and the install puts phosphor-watchdog in
the correct location.

Change-Id: I0454e763acc648ac76efd7728f6da498d9acf5dd
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...