build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I224523adb4da044b8000ede20d3882549e6cd2a6

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: I40f23300f54e7d44ae069dd190d07

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: I40f23300f54e7d44ae069dd190d07a69a01864f2
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Add support for individual property update

SNMP Manager D-Bus object doesn't have support
for individual D-Bus property update.
This commit adds the support for the same.

Resolves openbmc/phosphor-

Add support for individual property update

SNMP Manager D-Bus object doesn't have support
for individual D-Bus property update.
This commit adds the support for the same.

Resolves openbmc/phosphor-snmp#2

Change-Id: Ic72366b6b18190e66e23d400a5f2c95037947809
Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>

show more ...

Add the check for the existense of the client

Don't add the client if it is already configured.

Change-Id: Ib0c64e2eb73b272a290599e1b83630a8ab5709ec
Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.

Add the check for the existense of the client

Don't add the client if it is already configured.

Change-Id: Ib0c64e2eb73b272a290599e1b83630a8ab5709ec
Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>

show more ...

Change the logic of generating the D-Bus object identifier

Presently D-Bus object identifier is generated with the hash of
D-Bus properties, as a result of this if the value of D-Bus property
gets c

Change the logic of generating the D-Bus object identifier

Presently D-Bus object identifier is generated with the hash of
D-Bus properties, as a result of this if the value of D-Bus property
gets change the D-Bus object identifier will get change.

This commit fixes this problem by keeping the last identifier
value in the manager object so whenever user creates new snmp
manager object it is incremented by 1, hence the object path
becomes unique.

This commit also takes care of that if at any point of time
if snmp manager app restart it gets the same D-Bus identifier
as it was before the restart.

Change-Id: I456c11f7824ff678ae470bc6641f0e0cc7c1f6bc
Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>

show more ...

Create Interface returns the D-Bus object path

In current code when the client creates the SNNP manager D-Bus object,
snmp-conf-manager(D-Bus service) implementing the create interface
was not retur

Create Interface returns the D-Bus object path

In current code when the client creates the SNNP manager D-Bus object,
snmp-conf-manager(D-Bus service) implementing the create interface
was not returning the newly created D-Bus object path, hence
client needs to make the enumerate call on the
network namespace to find the newly create D-Bus object path.

This commit fixes this problem where Create interface starts
returning the newly created D-Bus object path.

Resolves openbmc/phosphor-snmp#1

Change-Id: I26e1ee4a2b869553e511576457148bd1dd9dc224
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Fix usage of std::variant

The .get() member interface is mapbox specific and will not work when we
transition to std::variant.

Change-Id: Ia2b580339af0ef08f4e43503b774988a30062645
Signed-off-by: Wi

Fix usage of std::variant

The .get() member interface is mapbox specific and will not work when we
transition to std::variant.

Change-Id: Ia2b580339af0ef08f4e43503b774988a30062645
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

phosphor-snmp: use c++17

Update configure.ac to choose the c++17 standard

Change-Id: I7fe64e02441c06b7354fa9495e66c61328346012
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

Fix spelling errors

Change-Id: I60d7f1974dc665647115bbeb9d8172b8790e9c92
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

Fix broken link

Change-Id: I9218fd3be89338d30ba05a149c3cca758fb1b0a9
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I8da47

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I8da47d0cc4531fe83cf09ed311bea35014f05659
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add SNMP user documentation

Change-Id: I1076f58f2813bf5eecc0792e1d958f4bdf307de3
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

Persist the snmp manager configuration

This commit persist the manager configuration D-Bus objects
and restores it once service starts.

This commit also deletes the associated persistent file whene

Persist the snmp manager configuration

This commit persist the manager configuration D-Bus objects
and restores it once service starts.

This commit also deletes the associated persistent file whenever
snmp client D-Bus object gets deleted.

Change-Id: I1526b52870ee5dfea30e6527bad3fd12d1191a13
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Validate the client address

Address could be hostname or IPaddress,Address validation
is being done by calling the gethostbyname system function.

Change-Id: I7d7eecd164c471c80af0b440a4b541badd2f966

Validate the client address

Address could be hostname or IPaddress,Address validation
is being done by calling the gethostbyname system function.

Change-Id: I7d7eecd164c471c80af0b440a4b541badd2f966f
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Send the trap to the configured SNMP managers

Get the snmp manager details from the D-bus service and send the
trap to all the configured snmp managers.

Resolves openbmc/openbmc#3058

Change-Id: I9

Send the trap to the configured SNMP managers

Get the snmp manager details from the D-bus service and send the
trap to all the configured snmp managers.

Resolves openbmc/openbmc#3058

Change-Id: I9c59ae866ab194e92a85254ca646ecc299803f26
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Implement the Client create interface

This commit also implement the D-Bus service which would be
used for snmp client configuration and would add the
snmp manager/trap receiver D-Bus objects under

Implement the Client create interface

This commit also implement the D-Bus service which would be
used for snmp client configuration and would add the
snmp manager/trap receiver D-Bus objects under
namespace /xyz/openbmc_project/network/snmp/manager/

It implements the delete interface for SNMP client D-Bus Object.

Resolves openbmc/openbmc#3057

Change-Id: I0df7b1475f81325b9ac497c1fb350c3f62329686
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Add client create interface

This interface would be implemented by the
phosphor-snmp-conf process which would be used to
configure the snmp manager info.

Change-Id: Ib501cdba4b472d11a8f5bec4a8c6025

Add client create interface

This interface would be implemented by the
phosphor-snmp-conf process which would be used to
configure the snmp manager info.

Change-Id: Ib501cdba4b472d11a8f5bec4a8c6025fc5cce675
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Implement the sendTrap(library) function

This function is a library function which would be
used by the process which wants to send the snmp trap.

This function is a templatized function and templa

Implement the sendTrap(library) function

This function is a library function which would be
used by the process which wants to send the snmp trap.

This function is a templatized function and template parameter
would be snmp notification type.

Change-Id: I63920f8c4593ba366a34b344dfab3a4562bf5d36
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Implement sendTrap function

This function gets all the objects from the specific
notification class and send the snmp trap using the
netsnmp lib functions.

This commt adds the configure, makefile,

Implement sendTrap function

This function gets all the objects from the specific
notification class and send the snmp trap using the
netsnmp lib functions.

This commt adds the configure, makefile, bootstrap.sh,
clangformat file.

Add the unit test cases for ErrorNotification unit.

Change-Id: I2e982f18eb2745f2c0c8de0702cc85d12e80f6e3
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Add SNMP Error Notification

This class represents the Error Notification
mib object.

The object of this class would be constructed from
the function (sendTrap<>()) which would be implemented
in lat

Add SNMP Error Notification

This class represents the Error Notification
mib object.

The object of this class would be constructed from
the function (sendTrap<>()) which would be implemented
in later commit.

Change-Id: I3a737a20570acafb8263f3a69cf0464680f42b13
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Merge "Add mib for Error Log Notification"

Add mib for Error Log Notification

This mib represents the openbmc ErrorLog.

Resolves openbmc/openbmc#3060

Change-Id: Id817f4a0c6e343991532cb1ed9231afee41673a2
Signed-off-by: Ratan Gupta <ratagupt

Add mib for Error Log Notification

This mib represents the openbmc ErrorLog.

Resolves openbmc/openbmc#3060

Change-Id: Id817f4a0c6e343991532cb1ed9231afee41673a2
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Add MAINTAINERS file

Change-Id: I1c4f5f84fcf4218fcba178fa4bbea78c10c33909
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Initial commit