fix cppcheck warnings

- Single parameter constructor was not marked 'explicit'.
- Member variable was not initialized in the constructor init.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Ch

fix cppcheck warnings

- Single parameter constructor was not marked 'explicit'.
- Member variable was not initialized in the constructor init.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I42c35e8300ca6670155840ddf47f61a7b93d5b42

show more ...

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6d8796f14e3e25c9dbf7149e9affdb3d826d220c

show more ...

mako: Support interfaces without property

If a settings interface contains no property, the code get compiles
failure that the cereal does not know how to de-serialize the object.

It turns out that

mako: Support interfaces without property

If a settings interface contains no property, the code get compiles
failure that the cereal does not know how to de-serialize the object.

It turns out that if an interface has no property, it does not need to
serialize/de-serialize the properties at all.

Add a check in mako to skip the above for interfaces without properties,
and then the code compiles fine.

Tested: Verify we could add an interface without property to a DBus
object, e.g. xyz.openbmc_project.Inventory.Item.Bmc

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I68a9e689c2e2a9da65c8b090ac925baebd27733a

show more ...

Add OWNERS file

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I4420a15554f0b650d4b79cd8c11fbee867da80ea

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic4d935b6d33e49dfb5606239b20db10514a95c1a

Use full name for enum default values

In the case where there were multiple interfaces specified in the
settings YAML that had the same last segment, the code generator would
create unbuildable code

Use full name for enum default values

In the case where there were multiple interfaces specified in the
settings YAML that had the same last segment, the code generator would
create unbuildable code when those classes both specified default values
for properties that were enums. This happened because there was a
'using namespace ...' line for every class at global scope, so when
the default value for the enum was specified, the compiler wouldn't know
which class to use.

For example, if there were two interfaces that used a class called Mode
that each tried to set default values like:
* Mode::bootMode::Safe
* Mode::powerMode::Static
then the generated code wouldn't compile.

Fix this by removing the global using namespace lines and add the full
prefix to the enum default values when they are set in the initSetting
lambdas.

Note that the code still won't compile when classes of the same name are
used on the same object path. This is because of the 'using IfaceX'
lines in the scope of each Impl class. Fixing that is outside of the
scope of this commit, which was done to fix a real world use.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I25ac36a58febe4449a29af845e5faba12bb0e63f

show more ...

Use sdbus++ python library for name conversion

This code attempts to come up with sdbus++ property names by
doing its own string manipulation. That conversion is likely
wrong in the future. Instea

Use sdbus++ python library for name conversion

This code attempts to come up with sdbus++ property names by
doing its own string manipulation. That conversion is likely
wrong in the future. Instead, import the sdbus++ python code
directly and call the appropriate function from it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I767ff842c37b183f925d7add87e96bb850092810

show more ...

bootstrap: fix shellcheck warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86ef079c9632e5563a1a56d6a2e23aad59ecbc57

MAINTAINERS: Change Deepak's email id

Also replace IRC by Discord. Discord is becoming the chat server of
choice.

Signed-off-by: Deepak Kodihalli <deepak.kodihalli.83@gmail.com>
Change-Id: I70bb7dd

MAINTAINERS: Change Deepak's email id

Also replace IRC by Discord. Discord is becoming the chat server of
choice.

Signed-off-by: Deepak Kodihalli <deepak.kodihalli.83@gmail.com>
Change-Id: I70bb7dd8726a005fc7f0834fe7ae247e42c9f289

show more ...

Remove TimeOwner interface from settings.yaml

The TimeOwner feature is confusing from feedback from the community and
we should be removed.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id

Remove TimeOwner interface from settings.yaml

The TimeOwner feature is confusing from feedback from the community and
we should be removed.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I5a75ca2ee595f8b56cb76c31352ac6fdc9d48192

show more ...

delete deprecated python scripts

These are around from before settingsd was re-written into C++
and can now be deleted.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I38d1f66f4e6b6

delete deprecated python scripts

These are around from before settingsd was re-written into C++
and can now be deleted.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I38d1f66f4e6b620268d5dcf8c635ea4b070db9de

show more ...

MAINTAINERS: update Deepak's email address

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7d4693cd2d53dada35c80fe2629621a0d3186412

python2 to python3 conversion

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1716d022bb67b1301f771c575842175372b04bef

Makefile.am: Fix mixed tabs and spaces

In some cases I noticed build is failing possibly due to
mixed tabs and spaces in Makefile.

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I5d724b9f48b

Makefile.am: Fix mixed tabs and spaces

In some cases I noticed build is failing possibly due to
mixed tabs and spaces in Makefile.

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I5d724b9f48b583b50c71b3e03884c88f9eb8d6de

show more ...

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I1b683415bf518045de5571b0b9517345ea2df77a

Add array support for defauts

Based on:
https://uscilab.github.io/cereal/stl_support.html

To support vector we need to #include the cereal
vector header.

Closes #12

Tested-by: Was able to add an

Add array support for defauts

Based on:
https://uscilab.github.io/cereal/stl_support.html

To support vector we need to #include the cereal
vector header.

Closes #12

Tested-by: Was able to add an array default using
C++ vector syntax

Change-Id: I3b00c372b668ddcda69a56ede8edbc51ab2693f5
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: Ifa7c986a2102fdee5d83b52dd4bbc

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: Ifa7c986a2102fdee5d83b52dd4bbc030c43d8c7d
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Add clang-format to repo

Add clang-format to repo.

Change-Id: I85129fe964c15ac389a1117f7a7716f2f6175dd6
Signed-off-by: Patrick Venture <venture@google.com>

gitignore: add autotools files to list

Add autotools files to list for gitignore.

Change-Id: I772927c48431182243faacbc0f8332e109b53227
Signed-off-by: Patrick Venture <venture@google.com>

phosphor-settingsd: use c++17

Update configure.ac to choose the c++17 standard

Change-Id: I5aa098f4d573ce14f8d5ee5c74f1b85fd10d1bb6
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

Add MAINTAINERS file

Change-Id: Ib29725cba6e78f31123a1713d791fecb04d2257c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

settings_manager: Use raw string for regex

Avoids a warning about an invalid escape sequence:

./settings_manager.py:221:36: W605 invalid escape sequence '\-'
regex = '([a-fA-F0-

settings_manager: Use raw string for regex

Avoids a warning about an invalid escape sequence:

./settings_manager.py:221:36: W605 invalid escape sequence '\-'
regex = '([a-fA-F0-9]{2}[:|\-]?){6}'

Fixes openbmc/openbmc#3140

Change-Id: I3be3d27bf9505b104db53a3a93e26fdc2e79e4db
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

PEP 8 fixes

Added E402 to the ignore errors list.
E402 is "module level import not at top of file"
and ignoring since settings_manager.py needs to modify
the sys.path before importing certain modul

PEP 8 fixes

Added E402 to the ignore errors list.
E402 is "module level import not at top of file"
and ignoring since settings_manager.py needs to modify
the sys.path before importing certain modules.
Since the default ignore list is not used anymore,
rules E121,E123,E126,E226,E24,E704,W503 are now enforced.
Looking at those rules, I believe we should enforce them.
Note E121,E123,E126,E226,E24,E704,W503 are all in the default
ignore list, so if no ignore list is provided in the
setup.cfg these errors are ignored.

from pycodestyle --help

--ignore=errors skip errors and warnings (e.g. E4,W) (default:
E121,E123,E126,E226,E24,E704,W503)

Change-Id: I0f64535eb4b4ba471466c8c9c3dbda1f8b33f702
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Enable Cereal class versioning

Fixes openbmc/openbmc#2320

Change-Id: Iac2649cd5f4794e2049cbdd4eb2df874d26beaaa
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

cereal: Fix empty file scenario

Cereal throws execption when deserialising empty file, add code
to handle empty exception and default the setting to the default
value.

Change-Id: I466f44d07c902a273

cereal: Fix empty file scenario

Cereal throws execption when deserialising empty file, add code
to handle empty exception and default the setting to the default
value.

Change-Id: I466f44d07c902a27344a483b5b574e0507baa2f4
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

show more ...