Expose host serial console over a websocket

Expose host serial console over a "/console" route, using a
websocket. An authenticated client can access the host serial console
via reads/writes to this

Expose host serial console over a websocket

Expose host serial console over a "/console" route, using a
websocket. An authenticated client can access the host serial console
via reads/writes to this websocket.

Change-Id: I0f63a3844e777d4f4c45194c85a63c9f10a91744
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

rest_dbus: upload: Add version id error code

If there was no D-Bus object created, it means that either the version
already existed, or there was a failure extracting the file. Ideally the
REST serv

rest_dbus: upload: Add version id error code

If there was no D-Bus object created, it means that either the version
already existed, or there was a failure extracting the file. Ideally the
REST server would query to see if the version already exists, but it
doesn't know the version id to look for, so adding a single error msg
for all error cases. It still makes sense to have a 400 (client) error
for tar errors since a failure to untar is most likely an invalid or
corrupted file that the user would need to address.

Tested:
Uploading a regular file (that triggers a tar failure) or a
version that already exists on the system:
Before:
{
"data": null,
"message": "200 OK",
"status": "ok"
}

After:
{
"data": {
"description": "Version already exists or failed to be extracted"
},
"message": "400 Bad Request",
"status": "error"
}

Fixes openbmc/openbmc#2939

Change-Id: Ia4be5fe1dac3c2c7ebb5eb2aa28e4d58f9222c7f
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

rest_dbus: upload: Return version id

In the put/post upload handler, subscribe to the signal for InterfacesAdded to
the software path and return the version id which is the last item of the path,
wa

rest_dbus: upload: Return version id

In the put/post upload handler, subscribe to the signal for InterfacesAdded to
the software path and return the version id which is the last item of the path,
wait up to 10 seconds for the new software D-Bus object to be created.

Tested: https://${bmc}/upload/image method returns the version id:

Before:
{
"data": null,
"message": "200 OK",
"status": "ok"
}

After:
{
"data": "84fb16be",
"message": "200 OK",
"status": "ok"
}

Change-Id: I307079f9a3b8f05bc42bc77c89e7976920c668a5
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Support optional parameter to not enable ssl

This server can be started in two different ways:
1. Via systemd socket, which can itself come in two different paths:
a. Direct bind to external HTTPS

Support optional parameter to not enable ssl

This server can be started in two different ways:
1. Via systemd socket, which can itself come in two different paths:
a. Direct bind to external HTTPS port 443
b. Reverse proxy to local port like 8081
2. Via command line call

This commit keeps backward compatibility and allows this new --no-ssl
option to be passed in when using a proxy.

Change-Id: I713b53e492862684eb6db45c602ce3c9e8e2f453
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Ia286e

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Ia286ebed549741e15a9661f5797d71e9f93ae83d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove use of deprecated ListMatch

This class was broken with pyphosphor aea38c65. Drop use of the
class altogether and just use a lambda.

Change-Id: I6f36487c1d6fe2003aa007c2a174fe97abf0267a
Test

Remove use of deprecated ListMatch

This class was broken with pyphosphor aea38c65. Drop use of the
class altogether and just use a lambda.

Change-Id: I6f36487c1d6fe2003aa007c2a174fe97abf0267a
Tested: Enumerated HTTP root and verified content
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Port to python 3

Port code to python 3 yet remain backward compatible to python 2.
This port is in preparation for yocto 2.4 upgrade.

Partially resolves openbmc/openbmc#2920

Change-Id: I418395fc7f

Port to python 3

Port code to python 3 yet remain backward compatible to python 2.
This port is in preparation for yocto 2.4 upgrade.

Partially resolves openbmc/openbmc#2920

Change-Id: I418395fc7fbda247d702551af69cbedbbdc3a7aa
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>

show more ...

Fix-up broken event notification

Commit 91ff110 broke the event notification feature, by creating a
duplicate App object, that's not passed the input keywords.

Change-Id: If92ea10c11aade3a846dfae71

Fix-up broken event notification

Commit 91ff110 broke the event notification feature, by creating a
duplicate App object, that's not passed the input keywords.

Change-Id: If92ea10c11aade3a846dfae718f2d5e11e3e34eb
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

Add web UI routing support

Route the calls that a browser will request when
it's pointed at https://<bmc> to the specified
files in /usr/share/www, which come from the
phosphor-webui repository.

Th

Add web UI routing support

Route the calls that a browser will request when
it's pointed at https://<bmc> to the specified
files in /usr/share/www, which come from the
phosphor-webui repository.

This takes over the '/' REST endpoint, but that provides
no functionality to the customer anyway.

The long term vision is to use a more advanced server
like nginx, but this is needed until something else is ready.

Tested: Served the phosphor-webui GUI from the BMC with
the script.

Resolves openbmc/openbmc#2821

Change-Id: Id491f9e0865a445160b91897082eb1c69695f562
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Phosphor-gevent: Pass the kwargs while creating WSGIServer

It was missed in earlier commit

Change-Id: Ib1ee9610e7e2a31e9247cab212eddf8b84af1011
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

Revert "Remove org.openbmc.* from REST server"

This reverts commit 9e2a211304d667756bc4136ec4bd1be27a2b5457, which
breaks code update for non-UBIFS bmcs.

Change-Id: Iecdad70f4ca9d2b4852addac3c2550e

Revert "Remove org.openbmc.* from REST server"

This reverts commit 9e2a211304d667756bc4136ec4bd1be27a2b5457, which
breaks code update for non-UBIFS bmcs.

Change-Id: Iecdad70f4ca9d2b4852addac3c2550e081253366
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Remove org.openbmc.* from REST server

Added a plug-in which runs on each request and checks if the requested
URL consists of /org/openbmc, if so, fails with an error message. So as
to ensure the ext

Remove org.openbmc.* from REST server

Added a plug-in which runs on each request and checks if the requested
URL consists of /org/openbmc, if so, fails with an error message. So as
to ensure the external interfaces are in the /xyz/openbmc_project
namespace, and to disallow the old /org/openbmc namespace.

Resolves openbmc/openbmc#2378

Change-Id: I4aab5ab716c40a460d7b3c28249e7047d3302a0a
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>

show more ...

Configure new ssl certificate

As the web server certificate got expired so configuring the
new one.
I would come up with proposal for certificate management.

Partially Resolves openbmc/openbmc#2423

Configure new ssl certificate

As the web server certificate got expired so configuring the
new one.
I would come up with proposal for certificate management.

Partially Resolves openbmc/openbmc#2423

Change-Id: I69642cb324b8030c7cd21f5efbbadbf2ce459e18
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Security: Disable weak ciphers

Configure the strong ciphers while web server starts.

Partially Resolves openbmc/openbmc#2423

Change-Id: I6aad0b292d3755a879e407784dce6a57fd217948
Signed-off-by: Rat

Security: Disable weak ciphers

Configure the strong ciphers while web server starts.

Partially Resolves openbmc/openbmc#2423

Change-Id: I6aad0b292d3755a879e407784dce6a57fd217948
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Security: Cross Site Scripting

This commit fixes the Cross Site scripting attack
by adding security headers in response packet.

Partially Resolves openbmc/openbmc#2423

Change-Id: Ie0ea05408af3d841

Security: Cross Site Scripting

This commit fixes the Cross Site scripting attack
by adding security headers in response packet.

Partially Resolves openbmc/openbmc#2423

Change-Id: Ie0ea05408af3d841a54f528863ed1bf65a8c3ed7
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

module: pep8 fixes

A couple pep8 errors found their way in.

Change-Id: I31c1de3b2bc92b20a809b9c2638df0d83c2b2ea3
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

rest_dbus.py:Update abort message for do_post

-When args are in correct format, but are not in accepted
range, in this case the current abort message not seems
meaningful.
-Updated abort message to

rest_dbus.py:Update abort message for do_post

-When args are in correct format, but are not in accepted
range, in this case the current abort message not seems
meaningful.
-Updated abort message to suite for both cases when the arg
type is not correct or arg value is not in accepted range.

Fixes openbmc/openbmc#2576

Change-Id: Id35241b05cd193172e2b7b1c905c396d0f9a9b4b
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>

show more ...

rest_dbus.py: Fix UnknownInterface error

The string "org.freedesktop.UnknownInterface" is not an
existing dbus error string, all errors are of format
*.DBus.Error.* so remove it.

Also check the dbu

rest_dbus.py: Fix UnknownInterface error

The string "org.freedesktop.UnknownInterface" is not an
existing dbus error string, all errors are of format
*.DBus.Error.* so remove it.

Also check the dbus name instead of message for this error.
The dbus message is the description of the error, like
"Unknown interface 'foo'". The dbus name is the actual
error string, like "org.freedesktop.DBus.Error.UnknownInterface",

Change-Id: Ib54adef852713bc30f3eefc6598e28fcf5be3d29
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Fix infinite do_put recursive call with retry only once

For failure in do-put method call REST server computes
the argument types based on the signature and makes a
recursive call with the modified

Fix infinite do_put recursive call with retry only once

For failure in do-put method call REST server computes
the argument types based on the signature and makes a
recursive call with the modified argument types.

Without proper exit clause recursive call is falling into an
infinite loop, modified to retry only once.

Also fixed do_post which has similar retry logic.

Fixes openbmc/openbmc#2653

Change-Id: I150464de5585ebdfab4ae2da2083a62bd63caca1
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

websocket client_simple example: add login code

Change-Id: Iff44de21e71508d81f7c5bfbe24b5f317fff000d
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

Fix missing return value from do_post

- For example user-initiated dump REST request has to respond with dump ID.
This is not happening, the dump-manager is returning the ID, but rest-bus
is not

Fix missing return value from do_post

- For example user-initiated dump REST request has to respond with dump ID.
This is not happening, the dump-manager is returning the ID, but rest-bus
is not passing the ID to caller.
- These changes will fix the issue.

Fixes openbmc/openbmc#2592

Change-Id: I7ff3f24236249a4ca58ac6ce90cc9dec6fbe0341
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>

show more ...

Don't create Image Dir if not present

Return error if the Image directory is not present.
The Upload code should not create the image dir, instead the
code update or the inotify code should create i

Don't create Image Dir if not present

Return error if the Image directory is not present.
The Upload code should not create the image dir, instead the
code update or the inotify code should create it.
Even if the Upload code creates the directory,
the inotify is not looking for a file in that dir and won't
untar it. We saw this with 2544. Although not the root cause of
2544 this change would have let the user know sooner (on upload),
that there was a problem.

Change-Id: I9f161354e1c3243567efb73b6974e8f52ff4c5db
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Call all instances of an objectPath when executing "POST"

- For example "DeleteAll" exists in both bmc updater and host updater.
Therefore when a user executes DeleteAll using REST, both the two

Call all instances of an objectPath when executing "POST"

- For example "DeleteAll" exists in both bmc updater and host updater.
Therefore when a user executes DeleteAll using REST, both the two
instances should be called upon.

Resolves openbmc/openbmc#2490

Change-Id: Ic38b00de137593bc344ff9d743d3144a48bd5f13
Signed-off-by: Saqib Khan <khansa@us.ibm.com>

show more ...

Spelling fixes

Change-Id: If4902b7c900f4108f4563a49ee8aca18294b32f7
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Add websocket client example

Add an example client html/js to denote subscription to BMC events via
websockets.

Change-Id: I9d07c7f720965de0272af31fc1a84faa49e901f5
Signed-off-by: Deepak Kodihalli

Add websocket client example

Add an example client html/js to denote subscription to BMC events via
websockets.

Change-Id: I9d07c7f720965de0272af31fc1a84faa49e901f5
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...