sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit` or `action::emit_interface_added`.

Signed-off-by: Tang Yiwei <tangyiwei.2022@bytedance.com>
Change-Id: Ibb77315bca56d6cebfb540976f44ee362534f942

show more ...

openssl: stop using deprecated SHA512_* functions

The openssl/sha.h header is deprecated for OpenSSL 3 along with all the
functions in it. Switch to use the EVP_MD interfaces.

Signed-off-by: Georg

openssl: stop using deprecated SHA512_* functions

The openssl/sha.h header is deprecated for OpenSSL 3 along with all the
functions in it. Switch to use the EVP_MD interfaces.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I17f9cd3652d92caab1baf29829e8e0cd6f781142

show more ...

MAINTAINERS and OWNERS: Update info

Move Chicago and Matt to maintertainers.
Remove Carol who is not in OpenBMC community now.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I789933745ab

MAINTAINERS and OWNERS: Update info

Move Chicago and Matt to maintertainers.
Remove Carol who is not in OpenBMC community now.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I789933745abead652de330ebe288b625de75bd94

show more ...

Add OWNERS file

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Id892ae78fd6c200da9fcfacbcb3fd41e350180c3

build: switch to C++20

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id79f75b9740509bc0c66a251263ac2c443f54acd

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3f173e46d23ab9a21f37356df848f5226ccf7962

show more ...

Fix unavailable code-update.md link

Fix unavailable code-update.md link.

Tested:
The new link test is OK

Signed-off-by: Chicago Duan <duanzhijia01@inspur.com>
Change-Id: If5466abb8eb28570e90c921eb

Fix unavailable code-update.md link

Fix unavailable code-update.md link.

Tested:
The new link test is OK

Signed-off-by: Chicago Duan <duanzhijia01@inspur.com>
Change-Id: If5466abb8eb28570e90c921eb629f92fe17f0ba7

show more ...

sdbusplus: replace message::variant with std::variant

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Id94a72c3195a2ffefac9b47eb77cd7748f4e61bc

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia0910c101ca50cbfee460f0476562b9c66e4c5d1

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie341309b8c1811fe3960dc25aaa9c7f6a9e7aafb

Cleanup the code related to emit_interface_added

sdbusplus now supports action::emit_interface_added() when an object is
constructed, so the code that manually invokes emit_interface_added()
could b

Cleanup the code related to emit_interface_added

sdbusplus now supports action::emit_interface_added() when an object is
constructed, so the code that manually invokes emit_interface_added()
could be cleaned up and use the above action instead.

Tested:Tested on fp5280g2, and psu update is normal.

Signed-off-by: Albert Zhang <zhanghaodi@inspur.com>
Change-Id: I0ca12a0941c1d45c860478c6f0d72675668de653

show more ...

Add updateable association

Add 'updateable' association to the functional PSU firmware.
This 'updateable' association can be used to mark all the
firmware components which can be programmable from B

Add updateable association

Add 'updateable' association to the functional PSU firmware.
This 'updateable' association can be used to mark all the
firmware components which can be programmable from BMC
interfaces like Redfish.

Resolves openbmc/phosphor-psu-code-mgmt#2

Tested: Verify unit tests success;
Verify the updateable associations are created for PSU firmware
objects on Witherspoon, and the Redfish has "Updateable": true
for the PSU images.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: I579121587b0d2c14f08beceaa68e380eaf1eefd9

show more ...

generate-psu-tar: Add machine name and remove single "-" options

Remove single "-" options because there are too many similar options.

The openbmc image manager expects "MachineName" in MANIFEST th

generate-psu-tar: Add machine name and remove single "-" options

Remove single "-" options because there are too many similar options.

The openbmc image manager expects "MachineName" in MANIFEST that matches
the BMC's OPENBMC_TARGET_MACHINE in /etc/os-release.
* If there is no MachineName in MANIFEST, it logs a warning for now;
* If they do not match, an error is reported and the version is deleted.

Add --machineName argument for generate-psu-tar to make it support the
"MachineName".

Tested: Verify that when a correct machine name is given, the tarball is
processed by image manager correctly;
And if an invalid machine name is given, the tarball uploaded
will get "Machine name doesn't match" error and is deleted.

Signed-off-by: Chicago Duan <duanzhijia01@inspur.com>
Change-Id: Ie39e01ae7e4a48fade3459a7eb82da214e0400e9

show more ...

Install example psu-update@.service

The repo needs an example psu-update@.service, it was expected to be
installed by a bitbake recipe, but during the recipe review it turns
out that the repo is bet

Install example psu-update@.service

The repo needs an example psu-update@.service, it was expected to be
installed by a bitbake recipe, but during the recipe review it turns
out that the repo is better to install a default one and it could be
overriden by a bbappend.

Move the psu-update@.service from vendor-example to services directory
and install it.

Tested: Verify the service is installed.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: I105b201972b32ca3d9e14878b92c9d038a41cbdb

show more ...

Set the service busname correctly

The BusName in the service unit file was {BUSNAME}, and it depends on
the tools in obmc-phosphor-dbus-service.bbclass to translate the
{BUSNAME} to the D-Bus servic

Set the service busname correctly

The BusName in the service unit file was {BUSNAME}, and it depends on
the tools in obmc-phosphor-dbus-service.bbclass to translate the
{BUSNAME} to the D-Bus service name.

Change it to the D-Bus service name specifically so that it does not
depend on such tools to install the service.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: I1705de25a3244078963847e5c122a4bcb9eda75e

show more ...

README: Add description about the usage of this repo

Add the description of several usage of this repo:
* How to generate a PSU image tarball;
* How to update the PSU image;
* How the version is upd

README: Add description about the usage of this repo

Add the description of several usage of this repo:
* How to generate a PSU image tarball;
* How to update the PSU image;
* How the version is updated when PSU is replaced.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: I8727a27be138e03e6feecc26205f1c4b0adf8fbe

show more ...

README: Introduce vendor-specific tools

Add detailed description about what the vendor-specific tools shall do,
and how to configure meson to specify the vendor-specific tools.

It also updates meso

README: Introduce vendor-specific tools

Add detailed description about what the vendor-specific tools shall do,
and how to configure meson to specify the vendor-specific tools.

It also updates meson_options.txt to use updated psutils from
phosphor-power by default.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: I17a508b675a754e76645d08d49547f669385813e

show more ...

Tools: add script to create an update tarball

This script is used to generate the tarball using the PSU image and MANIFEST
usage: generate-psu-tar [OPTION] <parameter>...
Options:
-i, --image

Tools: add script to create an update tarball

This script is used to generate the tarball using the PSU image and MANIFEST
usage: generate-psu-tar [OPTION] <parameter>...
Options:
-i, --image <file> PSU FW image
-v, --version <version> PSU FW version
-model, --model <model> PSU FW model
-mf, --manufacture <version> PSU FW manufacture
-o, --outfile <filename> Outfile name
For example : -o psufw.tar
The default outfile name is image.tar,and
"image" is what you input.
-s, --sign <path> Sign the image. The optional path argument specifies
the private key file. Defaults to the bash variable
PRIVATE_KEY_PATH if available, or else uses the
open-source private key in this script.
-h, --help Display this help text and exit.

Tested: Use this script to generate the tarball for PSU update.
for example :
./generate-psu-tar -i PSU.hex -v 12-34 -model 432-1
-mf LITEON -o test.tar -s /home/chicago/test/private_key

./generate-psu-tar -i PSU.hex -v 12-34 -model 432-1
-mf LITEON -o test.tar -s test/private_key

./generate-psu-tar -i PSU.hex -v 12-34 -model 432-1 -mf LITEON -o test.tar -s

./generate-psu-tar -i PSU.hex -v 12-34 -model 432-1 -mf LITEON -o test.tar

./generate-psu-tar -i PSU.hex -v 12-34 -model 432-1 -mf LITEON

Signed-off-by: Chicago Duan <duanzhijia01@inspur.com>
Change-Id: I50ea116bc6e1e49d7fea3e0974453c442784fbe1

show more ...

Activation: add BMC reboot guard

BMC shall not reboot during PSU update, otherwise it has the risk of
putting the PSU in a bad state.
So add BMC reboot guard in ActivationBlocksTransition to enable

Activation: add BMC reboot guard

BMC shall not reboot during PSU update, otherwise it has the risk of
putting the PSU in a bad state.
So add BMC reboot guard in ActivationBlocksTransition to enable reboot
guard when PSU update is started, and disable it when it's finished or
failed.

During test, it's found that the ActivationBlocksTransition is created
too early before checking the PSU compatibility, it is fixed by
constructing ActivationBlocksTransition after the check.

Tested: Verify the BMC guard is enabled and disabled during PSU update.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: I405fe640929aa91ecbcb3d48e19309d38b6849e5

show more ...

Version: support CRLF line feed in MANIFEST

When a MANIFEST is generated from Windows and it contains CRLF as line
feed, the code was getting each line with '\r' at the end, and thus the
parsed stri

Version: support CRLF line feed in MANIFEST

When a MANIFEST is generated from Windows and it contains CRLF as line
feed, the code was getting each line with '\r' at the end, and thus the
parsed string contains '\r' and it incorrectly parses the string.

Add a piece of code to support CRLF line feed so support such MANIFEST
files.

Tested: Added a unit test case to verify CRLF is correctly handled.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: I99e146717b815e3e40c232376555b2b48d77bc56

show more ...

Fix an incorrect logging

It was incorrectly using "%d" to log a "METHOD" string.
Fix it.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: I792f82feb894f5d5a83c4d4f60f52135f6d08dd0

Check and sync PSU image when PSU is plugged in

When a PSU is plugged out and in, the service shall check the version
and do update if it is with an old software.
When the PSU is plugged in, the mod

Check and sync PSU image when PSU is plugged in

When a PSU is plugged out and in, the service shall check the version
and do update if it is with an old software.
When the PSU is plugged in, the model is not available for a while, so
the service subscribe the model property as well, and only create the
software object when both present and model properties are set.

Tested: With dummy update service, verify on Witherspoon that when PSU
is plugged out (by setting "Present" property in inventory), the
software object is removed, and when it's pluggd int (by setting
"Present" property), the software object is created after the
model is got, and is upgraded by a newer image stored in BMC
filesystem.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: Ia7516e5bc9c642158b216036bcddf404157f9204

show more ...

Activation: remove old objects after update done

The update on PSUs is one-by-one, after each PSU is updated, notify
ItemUpdater by onUpdateDone() so that the old object for the PSU is
removed.

Tes

Activation: remove old objects after update done

The update on PSUs is one-by-one, after each PSU is updated, notify
ItemUpdater by onUpdateDone() so that the old object for the PSU is
removed.

Tested: With dummy PSU image and update service, verify the old
objects are removed on Witherspoon.

Change-Id: I212b8cba9570ad96083d362bf57691fdabb4e42f

show more ...

Sync PSU images on service startup

On service startup, it shall check the PSU images, find a latest
version, and update to the PSUs that are not with this version.

Tested: With dummy image and serv

Sync PSU images on service startup

On service startup, it shall check the PSU images, find a latest
version, and update to the PSUs that are not with this version.

Tested: With dummy image and service, test on Witherspoon with 2
different running PSU software:
* When startup without stored image, the serive tries to update an older
PSU but it does not have PSU image, so it's skipped with below journal
log:
Automatically update PSU
No image for the activation, skipped
* When startup with an older image stored in BMC, it behaves the same as
above.
* When startup with a new image stored in BMC, it updates the PSUs, with
below example journal log:
Automatically update PSU
Starting Update PSU
/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply0
/var/lib/obmc/psu/2B1D...
Started Update PSU
/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply0
/var/lib/obmc/psu/2B1D.
Starting Update PSU
/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply1
/var/lib/obmc/psu/2B1D...
Started Update PSU
/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply1
/var/lib/obmc/psu/2B1D.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: I6d676c5a4441685fb2b5920455f439c00f6097af

show more ...

utils: Add function to check if PSU is associated

Add a helper function to check if a PSU is in an association list, which
will be used in future commits to check if a PSU is running a software
imag

utils: Add function to check if PSU is associated

Add a helper function to check if a PSU is in an association list, which
will be used in future commits to check if a PSU is running a software
image.

Tested: added unit test case and verify it passes.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: I99b5d3d8d09f8e09a1eb42ba104a4804b7214cf1

show more ...