Modified sensorConfig map index name about fan

- Like the phosphor-pid-control github issue #19,
if a fan is set as input sensor and has multiple output setting,
there are some problems when bui

Modified sensorConfig map index name about fan

- Like the phosphor-pid-control github issue #19,
if a fan is set as input sensor and has multiple output setting,
there are some problems when building sensorConfig map that
only have the last setting in sensorConfig map.

TEST:
https://gist.github.com/harveyquta/e2d3c91bf86299e5301bfb080711dbb4

Signed-off-by: Harvey.Wu <Harvey.Wu@quantatw.com>
Change-Id: I4f070888ce64c45a420467c6a07fcbd8312aa7a0

show more ...

Add --strict-failsafe-pwm compile flag

This build flag is used to set the fans strictly at the failsafe
percent when in failsafe mode, even when the calculated PWM is higher
than failsafe PWM. Witho

Add --strict-failsafe-pwm compile flag

This build flag is used to set the fans strictly at the failsafe
percent when in failsafe mode, even when the calculated PWM is higher
than failsafe PWM. Without this enabled, the PWM is calculated and set
to the calculated PWM the failsafe PWM, whichever is higher.

Added a unit test that can test this new build flag code path if the
compile flag is defined.

Tested:

Verified on an internal machine that by adding the following to the
bbappend:

EXTRA_OECONF:append = " --enable-strict-failsafe-pwm=yes"

With flag:
ipmitool sensor list
fan_pwm | 89.768

Without flag:
ipmitool sensor list
fan_pwm | 99.960

We can see that the fan pwm was limited to the failsafe percentage when
in failsafe mode with the flag. Without the flag, it ran at 100%

Bug-Id: openbmc/phosphor-pid-control#17
Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: I72a1e5aab8d3e5b0e3716f0b3720d704a6f05008

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I72e6cf31187e6864cc83ba5bab4cc00af51defc9

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie36d234f4580029a7832a0cd179f3bb78a1a403f

show more ...

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iaa050737155ad72fadd0a177841ddb75d45141c1

show more ...

For each zone log sensor name with max setpoint

Add sensor name that has the maximum setpoint for a PID zone.
Log a debug message when the sensor is changed.
The name is also added to the log file f

For each zone log sensor name with max setpoint

Add sensor name that has the maximum setpoint for a PID zone.
Log a debug message when the sensor is changed.
The name is also added to the log file for each log record.

Tested:
Override one CPU temperature sensor
busctl set-property xyz.openbmc_project.CPUSensor /xyz/openbmc_project/sensors/temperature/DTS_CPU1 xyz.openbmc_project.Sensor.Value Value d 82
Observed log message:
swampd[443]: PID Zone 0 max SetPoint 34.5546 requested by DTS_CPU1

Signed-off-by: Nirav Shah <nirav.j2.shah@intel.com>
Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: Ifc12cb9a106da1bf41dd35697210f74ba1b589db

show more ...

build: enable C++20

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3be3bf550d4319f42d33da3c4d51e23cee6708cb

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I94aa9a4451cebc772d3259323ff1b679e53f90bb

show more ...

pid/zone: Restore PWM when fans returned to auto

This makes use of the improved write() interface, to allow the
PID-loop-determined PWM to be restored, when the fan is returned to
automatic mode.

W

pid/zone: Restore PWM when fans returned to auto

This makes use of the improved write() interface, to allow the
PID-loop-determined PWM to be restored, when the fan is returned to
automatic mode.

Without this fix, a fan set to manual mode, then manually set to a
different speed, would not properly return to the correct speed, when
transitioning back to automatic from manual.

This patch also adds a stub to allow the caller to learn the raw PWM
value written as output, another useful write() interface improvement.
Although not the topic of this change, it is included here, to avoid
later patch conflicts.

Tested: I can now correctly toggle between automatic, and manual, fan
control. Upon resuming automatic control, after a few seconds, the fan
PWM is now properly restored, to what the PID loop wanted it to be at.

Signed-off-by: Josh Lehan <krellan@google.com>
Signed-off-by: Jason Ling <jasonling@google.com>
Change-Id: I46fc65d6b931755d51093ea475c64cf5e3e6bacb

show more ...

phosphor-pid-control: Remove venture from reviewer

Change-Id: Ife861f6a07cb5e7f743f36868b214760b3152c3f
Signed-off-by: Willy Tu <wltu@google.com>

ipmi.md: Clarification of some docs

Clarify that "OEM Set Control" can perform both Get and Set
Advise using ExternalSensor instead of nonexistent future OEM command
Advise to use BMC sensors normal

ipmi.md: Clarification of some docs

Clarify that "OEM Set Control" can perform both Get and Set
Advise using ExternalSensor instead of nonexistent future OEM command
Advise to use BMC sensors normally, no OEM IPMI extensions needed

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: I5dcd1b5242b9c64324dbaea8e64d96ef2114a8b1

show more ...

Make specific UNA sensors not trigger failsafe

By convention, sensors at some states like 'not present',
'power state not matching' are marked as 'unavailable' on dbus.
At such states, some specific

Make specific UNA sensors not trigger failsafe

By convention, sensors at some states like 'not present',
'power state not matching' are marked as 'unavailable' on dbus.
At such states, some specific sensors should not be considered as
failed and trigger pid 'failsafe'.

A typical example is when a system is powered-off, its CPU/DIMM temp
sensors are 'unavailable', these sensors should not be treated as
'failed' and trigger pid 'failsafe'. This is necessary for systems
whose Fans will keep working when the CPU is off.

This feature is configurable per sensor (valid on thermal sensors). It
can be enabled by setting the Pid controller option
"InputUnavailableAsFailed" to 'false' when one configuring the PID module
via entity-manager, or by setting the sensor option "unavailableAsFailed"
to 'false' when one configuring the PID module via JSON. (These options are
optional and default to 'true')

Tested:
1. On a Fan 'always-on' system, enabale this feature on CPU temp sensors,
poweroff the system, 'unavailable' CPU temp sensors do not trigger the
failsafe mode.
2. 'Unavailable' Fans still trigger the failsafe mode.
3. 'Unfunctional' or 'failed' sensors still trigger the failsafe mode.

Signed-off-by: Zheng Song <zheng.song@intel.com>
Change-Id: I1dd1d76466f43e7dcf51c161c96714f1bcfae88d

show more ...

sdbusplus: remove usage of deprecated alias

The alias `server::match` has been deprecated since 2016. Use the new
alias under bus.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib

sdbusplus: remove usage of deprecated alias

The alias `server::match` has been deprecated since 2016. Use the new
alias under bus.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibccf347f7016b69f78f74b8debe714b8a0c30ba5

show more ...

Add OWNERS file

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I92fc6c49839f541972dbdc24d9ecd11fc6a415ee

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icea9b76115b6c3c7856574605ead3fedc0eca5d6

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I16eeca31de290221c7a9184ee0c48cc923466832

show more ...

configure.md: add stepwise documentation

Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Change-Id: I4059037e5ad8095c2d547961c32d62476fd405a7

configure.md: updates and clarifications

Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Change-Id: I9fcaa5d7c563c59a9efcf41500db231010a32557

main: Remove shared_ptr copy

GCC 11 complains about it and it isn't needed.

Change-Id: Ia0bb3d1aea29d0505a9868b1f922338a87710ddb
Signed-off-by: William A. Kennington III <wak@google.com>

Fix command-line parsing of loggingPath

The "-l" option for loggingPath was not enabling logging when given,
as it should have been. Now, logging can be enabled either by use of
command line or by e

Fix command-line parsing of loggingPath

The "-l" option for loggingPath was not enabling logging when given,
as it should have been. Now, logging can be enabled either by use of
command line or by existence of sentinel file, as intended.

Thanks to Anton Kachalov and Konstantin Klubnichkin for catching this
bug.

Also cleaned up the printing of the informational lines printed, for
loggingEnabled and tuningEnabled, to be correct as originally
intended: printed when enabled, no output when disabled.

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: I3f20a4dee997e04985d32cd6020b719e0b4d117e

show more ...

Add object manager

Added object manager to FanCtrl node so that it can be queried mapper
and GetManagedObjects method can be called.

Tested: verified this using busctl command and see object manage

Add object manager

Added object manager to FanCtrl node so that it can be queried mapper
and GetManagedObjects method can be called.

Tested: verified this using busctl command and see object manager
interface has been added to this service.

Signed-off-by: Bruce Lee <Bruce_Lee@quantatw.com>
Change-Id: Ibbd6f63993aa26914fa42d0205263fd7a490f95e

show more ...

enable shellcheck

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iab2bc6a25e444259d6c08da390b10f26e974c5f3

bootstrap: fix shellcheck warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86ef079c9632e5563a1a56d6a2e23aad59ecbc57

Eliminate ControlLoop init delay.

Introducing extra delay for the first loop is unnecessary and the
increasement of gap between dbus name request and object creation
sometimes crashes phosphor-objmg

Eliminate ControlLoop init delay.

Introducing extra delay for the first loop is unnecessary and the
increasement of gap between dbus name request and object creation
sometimes crashes phosphor-objmgr.

Notice this patch only recovers the gap to the previous status as
before 40786 instead of completely eliminating the gap.

Tested: internal project with IPMI sensors.
Signed-off-by: Hao Jiang <jianghao@google.com>
Change-Id: I0d689809347e9dffa9a1059577455f3224502600

show more ...

sensors: host: Implement getFailed function to HostSensor

1. Add getFailed function to check the dbus value in HostSensor
is finite or not, if not, pid control will into failsafe mode.

Signed-of

sensors: host: Implement getFailed function to HostSensor

1. Add getFailed function to check the dbus value in HostSensor
is finite or not, if not, pid control will into failsafe mode.

Signed-off-by: Harvey Wu <Harvey.Wu@quantatw.com>
Change-Id: Ib198aecf512a3a107793319014f6c0b531cc6211

show more ...