conf change: s/feedFwdOffOffsetCoeff/feedFwdOffsetCoeff/g

Fixup spelling mistake for configuration field name.

Change-Id: I92d0af06f4e15f4408dd10f0dd9cd71099b77f4f
Signed-off-by: Patrick Venture <v

conf change: s/feedFwdOffOffsetCoeff/feedFwdOffsetCoeff/g

Fixup spelling mistake for configuration field name.

Change-Id: I92d0af06f4e15f4408dd10f0dd9cd71099b77f4f
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

DBusConfiguration: Fix scaling

Revert the removal of the /100 because that caused
90% to be passed as 90 instead of .9. To counter-act
this multiply the stepwise controller by 100 so that
setting 50

DBusConfiguration: Fix scaling

Revert the removal of the /100 because that caused
90% to be passed as 90 instead of .9. To counter-act
this multiply the stepwise controller by 100 so that
setting 50 is 50%.

Tested-by: Used sensor override to make stepwise jump
threshold and got desired pwm result.

Change-Id: I629bf0d4b0b3bc77660c09fccae82b1bdac4c578

show more ...

build: drop support for YAML configurations

phosphor-pid-control now only supports json configurations and no longer
builds from a YAML configuration.

Change-Id: I25fa7766399a1345dca89aac20e7b49caa

build: drop support for YAML configurations

phosphor-pid-control now only supports json configurations and no longer
builds from a YAML configuration.

Change-Id: I25fa7766399a1345dca89aac20e7b49caa46797e
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

main: if json configuration, override yaml built

Override the yaml built objects if there is a configuration file.

Change-Id: Id7b21fa171f5f133b2d888b4095047551b3d65b9
Signed-off-by: Patrick Ventur

main: if json configuration, override yaml built

Override the yaml built objects if there is a configuration file.

Change-Id: Id7b21fa171f5f133b2d888b4095047551b3d65b9
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

main: add json configuration path

If swampd is compiled to check for its configuration at run-time, it
will check one specific path.

Change-Id: I5c37ccbb2229db742c0f43b3d9ee0c368df19479
Signed-off-

main: add json configuration path

If swampd is compiled to check for its configuration at run-time, it
will check one specific path.

Change-Id: I5c37ccbb2229db742c0f43b3d9ee0c368df19479
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: I8db71f0c975d9c3078b1c6be7faf7

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: I8db71f0c975d9c3078b1c6be7faf75667d0a223e
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Convert host-ipmid -> libipmid

phosphor-host-ipmid now exposes a library along with headers for
interfacing with the ipmi daemon. Compile and link against the new
library.

Change-Id: I747c3a585d646

Convert host-ipmid -> libipmid

phosphor-host-ipmid now exposes a library along with headers for
interfacing with the ipmi daemon. Compile and link against the new
library.

Change-Id: I747c3a585d646c7ff54efb14968c8f04daafe071
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

build: check for json header

Check for the json header during configuration.

Change-Id: I15c04b0f4892ce6498b4f171abe34a9b0944014e
Signed-off-by: Patrick Venture <venture@google.com>

swap libconfig++ for json in configuration parsing

Parse the configuration file as json and not libconfig++.

Change-Id: Ic3e71cc810195387617b545566cf757c61c71942
Signed-off-by: Patrick Venture <ven

swap libconfig++ for json in configuration parsing

Parse the configuration file as json and not libconfig++.

Change-Id: Ic3e71cc810195387617b545566cf757c61c71942
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

add json verification for configurations

Add json verificiation for configurations. A configuration is lightly
validated.

Change-Id: I42361daf6ad21d3480e92c3808f5fc8ab8318e0b
Signed-off-by: Patric

add json verification for configurations

Add json verificiation for configurations. A configuration is lightly
validated.

Change-Id: I42361daf6ad21d3480e92c3808f5fc8ab8318e0b
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

errors: add configuration exception

The configuration exception will be thrown for configuration errors.

Change-Id: Ibf9e220826ede46a5de748e73aa328300ed01f79
Signed-off-by: Patrick Venture <venture

errors: add configuration exception

The configuration exception will be thrown for configuration errors.

Change-Id: Ibf9e220826ede46a5de748e73aa328300ed01f79
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

add support to build zones and PIDs from json

Add support to build zones and PIDs from a json configuration file.

Change-Id: If8608dcd3e084cebabb71fc39851044df4d5d7c2
Signed-off-by: Patrick Venture

add support to build zones and PIDs from json

Add support to build zones and PIDs from a json configuration file.

Change-Id: If8608dcd3e084cebabb71fc39851044df4d5d7c2
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

conf change: s/set-point/setpoint/

Remove the dash from set-point, such that it's one word: setpoint.

Change-Id: I4c3033f3c2432a53d850e8f5defbe2ac1510daf8
Signed-off-by: Patrick Venture <venture@go

conf change: s/set-point/setpoint/

Remove the dash from set-point, such that it's one word: setpoint.

Change-Id: I4c3033f3c2432a53d850e8f5defbe2ac1510daf8
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

conf change: pid: all pid details are now camelCase

Convert all PID configuration details are now camelCase instead of snake
case.

Change-Id: Id132053f122dfcd8abaace17df91c99758eb2b0c
Signed-off-by

conf change: pid: all pid details are now camelCase

Convert all PID configuration details are now camelCase instead of snake
case.

Change-Id: Id132053f122dfcd8abaace17df91c99758eb2b0c
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

sysfs: style fix on sysfswrite

Fix camelCase styling on sysfswrite.

Change-Id: I6dec7f46687a1276e756687bc9669ab163b5fdc4
Signed-off-by: Patrick Venture <venture@google.com>

conf change: sensors: read and write path rename

Rename the readpath and writepath for camelcase styling to make all
configuration variables consistent.

Change-Id: I33f475075c8f40cd2029a5c0bfda9508

conf change: sensors: read and write path rename

Rename the readpath and writepath for camelcase styling to make all
configuration variables consistent.

Change-Id: I33f475075c8f40cd2029a5c0bfda950846cd5d44
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

conf change: rename zone variables

Rename the zone variables to make them camelCase as a step towards
making all configuration variables camelCase for consistency.

Note: This patchset requires a ch

conf change: rename zone variables

Rename the zone variables to make them camelCase as a step towards
making all configuration variables camelCase for consistency.

Note: This patchset requires a change to your yaml configuration if
you're using it, or libconfig if you're using it.

Change-Id: If9cf1d7eb8227d305a1625275f2f7082c0d6905a
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

pid: rename variables with full names

Use full names and camelcase for the variables in the pid loop to
improve readability and consistency.

Change-Id: I86be69d94d3008faa497eace050d1f3b9b6a9ff4
Sig

pid: rename variables with full names

Use full names and camelcase for the variables in the pid loop to
improve readability and consistency.

Change-Id: I86be69d94d3008faa497eace050d1f3b9b6a9ff4
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

pid: rename structure components for style

Rename the struct components to camelCase.

Change-Id: I0e76c4bd5aed0ec2d78edd31ddef66f852ddc71e
Signed-off-by: Patrick Venture <venture@google.com>

sensors: buildjson: add todo for failure

The daemon needs to validate the json configuration, either immediately
after it's parsed or when objects are built from it.

Change-Id: I52b5a558657ba1420bc

sensors: buildjson: add todo for failure

The daemon needs to validate the json configuration, either immediately
after it's parsed or when objects are built from it.

Change-Id: I52b5a558657ba1420bc4589de793cc496392f318
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

add support to build sensors from json

Add support to build sensors from a json configuration file.

Change-Id: Ic5bcbcd01e085ab0d4efaed314af8dc7e82b0b9d
Signed-off-by: Patrick Venture <venture@goog

add support to build sensors from json

Add support to build sensors from a json configuration file.

Change-Id: Ic5bcbcd01e085ab0d4efaed314af8dc7e82b0b9d
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Move all variant usage to std

This just a style change, remove variant_ns
in favor of std.

Tested-by: it built

Change-Id: Id5a075e8b73a7724cbc5153fb7dfcf369e79c483
Signed-off-by: James Feist <jame

Move all variant usage to std

This just a style change, remove variant_ns
in favor of std.

Tested-by: it built

Change-Id: Id5a075e8b73a7724cbc5153fb7dfcf369e79c483
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

sensors: add method to grab default timeout

Add a central method for grabbing the default timeout for a sensor.
This is required to allow for a configuration to leave out an
unnecessary field.

Chan

sensors: add method to grab default timeout

Add a central method for grabbing the default timeout for a sensor.
This is required to allow for a configuration to leave out an
unnecessary field.

Change-Id: I29ecd9db67b1eb1e66e60ef49859926cf14a4542
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Add Hysteresis to pid controllers

Add hysteresis to pid controllers to lower pwm changes.
It is defaulted to 0 so it should be transparent
to any controller that choses not to implement it.
This is

Add Hysteresis to pid controllers

Add hysteresis to pid controllers to lower pwm changes.
It is defaulted to 0 so it should be transparent
to any controller that choses not to implement it.
This is the same pattern used by the stepwise controller.

Tested-by: Unit tests passed

Change-Id: Ib47114285b0017258b7f77eaf067d310f95a0c60
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

[dbus-configuration] Add regex support

Add regex support to sensors when defining PIDs
so that we don't have to type all elements of a
single type, for instance all Cores of a CPU.

Tested-by: Added

[dbus-configuration] Add regex support

Add regex support to sensors when defining PIDs
so that we don't have to type all elements of a
single type, for instance all Cores of a CPU.

Tested-by: Added a configuration with inputs

"Inputs": [
"Core \\d+ CPU0"
],

And saw all Cores added when debug printing was turned
on.

Change-Id: I21c60d1cfc83b12aaa12039f09227f22f2b1d2b9
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...