Consolidate all util.hpp

This deletes all lower level util.hpp and cats them
into the top level util.hpp to avoid name conflicts.

Change-Id: Ia11e4a08053a3970b0aadf21d1156ab26def36bd
Signed-off-by:

Consolidate all util.hpp

This deletes all lower level util.hpp and cats them
into the top level util.hpp to avoid name conflicts.

Change-Id: Ia11e4a08053a3970b0aadf21d1156ab26def36bd
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

explicitly expect a directory for logging

Verify the logging parameter is explicitly a directory. Treat the path
as a directory for creating the logging files.

Signed-off-by: Patrick Venture <vent

explicitly expect a directory for logging

Verify the logging parameter is explicitly a directory. Treat the path
as a directory for creating the logging files.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I84d6be79780df3f52deeb1ff1b7a50de6175c055

show more ...

split parameters for logging and tuning

add a flag to enable/disable tuning: default off
add an option for specifying a folder for outputting logs.

Closes: #10
Signed-off-by: Patrick Venture <ventu

split parameters for logging and tuning

add a flag to enable/disable tuning: default off
add an option for specifying a folder for outputting logs.

Closes: #10
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I43864768f1dee8672f13288d3cf5a0c87c373aed

show more ...

main: drop log file path check

Remove check that the log file path exists.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I8324ea847fd57de54ab1a9d252fd12a3ddafc4d8

Remove threads

This converts phosphor-pid-control into an async
single threaded application. The reason for doing this
is on our systems phosphor-pid-control had the largest
VSZ when viewed under to

Remove threads

This converts phosphor-pid-control into an async
single threaded application. The reason for doing this
is on our systems phosphor-pid-control had the largest
VSZ when viewed under top. Before this patch the VSZ
was at 50720, after it is at 7760.

Tested-by: Could still interact with all interfaces
under rest-dbus and sensor override worked to ramp fans
when changing cpu temps.

Change-Id: Ie0a837bdf0d1b1df61dc7aff87e5d503b9e0e875
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Bugfix: dbusconfiguration: read correct hysteresis

s/positive/negative

Change-Id: Ib7761abae47404706c69255fc2861d0f58c26369
Signed-off-by: James Feist <james.feist@linux.intel.com>

build: install into bin instead of sbin

Installs swampd and setsensor into bin instead of sbin per guidelines.

Warning: Every platform requires its own service file, please update
your service file

build: install into bin instead of sbin

Installs swampd and setsensor into bin instead of sbin per guidelines.

Warning: Every platform requires its own service file, please update
your service file when you pick up this change.

Change-Id: Ib7fe057d8758a8851049e88d41d13ca80b0b9862
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

bugfix: grab hystersis parameter from pid json

The code incorrectly attempts to read the hystersis parameters from the
wrong scope of the json object. This fixes it to read from the pid
configurati

bugfix: grab hystersis parameter from pid json

The code incorrectly attempts to read the hystersis parameters from the
wrong scope of the json object. This fixes it to read from the pid
configuration's scope.

Tested: Added a new unit-test to hit this case.
Change-Id: I808bc907ec33a0b12d68a88fd316c3c9fae41516
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

autotools: Fix for autoconf-archive 2019.01.19

The code coverage macros from the archive changed in a backward
incompatible way. This adds a workaround to autodetect either version
and do the right

autotools: Fix for autoconf-archive 2019.01.19

The code coverage macros from the archive changed in a backward
incompatible way. This adds a workaround to autodetect either version
and do the right thing.

Change-Id: I63d1cdf6edb125d75872d6dae38f8602fc043431
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

pid: zone: add zone id to log name

When a log path is provided, append the zone id to the log so that each
zone will have its own log file.

Change-Id: I56f92669eda23148127f53fd50e119912a24200b
Sign

pid: zone: add zone id to log name

When a log path is provided, append the zone id to the log so that each
zone will have its own log file.

Change-Id: I56f92669eda23148127f53fd50e119912a24200b
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

swap out getopts for cli11

Swap out getopt for cli11 for parsing parameters.

Change-Id: If6845c359dafc28b545925faa4701d401c7b8dd2
Signed-off-by: Patrick Venture <venture@google.com>

experiment: cppcheck cleanup

[experiments/drive.cpp:83] -> [experiments/drive.cpp:96]: (style)
Variable 'check' is reassigned a value before the old one has been used.

Change-Id: I241a2b38418ab8979

experiment: cppcheck cleanup

[experiments/drive.cpp:83] -> [experiments/drive.cpp:96]: (style)
Variable 'check' is reassigned a value before the old one has been used.

Change-Id: I241a2b38418ab89790d2d8762aaceb3cd080ad77
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

use filesystem instead of experimental

Use filesystem now that it should be available instead of
experimental::filesystem.

Change-Id: I8648ac2b279eea42c13d6b12f312a2e1e02aa152
Signed-off-by: Patric

use filesystem instead of experimental

Use filesystem now that it should be available instead of
experimental::filesystem.

Change-Id: I8648ac2b279eea42c13d6b12f312a2e1e02aa152
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: add CODE_COVERAGE_CXXFLAGS everywhere

Add this explicitly everywhere.

Change-Id: Ia7a6edd077100de545186b9e298e3bc8e4456fba
Signed-off-by: Patrick Venture <venture@google.com>

build: enable code coverage

Enable code coverage for the project. Valgrind not enabled in this
step.

Change-Id: I62891f6054e5e5315d7f150a1f3dcf619f2740db
Signed-off-by: Patrick Venture <venture@go

build: enable code coverage

Enable code coverage for the project. Valgrind not enabled in this
step.

Change-Id: I62891f6054e5e5315d7f150a1f3dcf619f2740db
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: rework gtest checks

Rework gtest checks to be modeled after openbmc/gpioplus.

Change-Id: I54539c7031dbf87fea5d2c8ad56e415be8917f7a
Signed-off-by: Patrick Venture <venture@google.com>

gitignore: add coverage pieces

Add coverage bits to gitignore.

Change-Id: Ia023c7e8d3a0035d72774c90ad76b0895149573f
Signed-off-by: Patrick Venture <venture@google.com>

add tuning enable variable

Add a variable that when set, enables tuning logging. This variable is
set to false.

Tuning can be enabled via "-t" "--tuning" on the command line.
With a parameter is t

add tuning enable variable

Add a variable that when set, enables tuning logging. This variable is
set to false.

Tuning can be enabled via "-t" "--tuning" on the command line.
With a parameter is the path where to write the logging information.

Change-Id: I6eb8035d56cc3301face21e9375c02fc9fcc5b31
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Add fan profile support to dbusconfiguration

On start dbus configuration will look for profiles. If any exist it
will attempt to find the thermal mode interface:
https://github.com/openbmc/phosphor

Add fan profile support to dbusconfiguration

On start dbus configuration will look for profiles. If any exist it
will attempt to find the thermal mode interface:
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Control/ThermalMode.interface.yaml

This can be anywhere on d-bus, tested placement was in settingsd. Based
on the selected profile(s) it will create a 'whitelist' of controllers,
and will remove any not in that whitelist.

Tested-by: Added and removed curves based on acoustic or
performance mode

Change-Id: I9e83a77d71d7fcfe691cc4beb700b8a67024c64f
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Expand conf namespace

Put rest of conf.hpp in the conf namespace. This is
largely a sed replace, and wrapping from_json in
conf namespace as it failed to build.

Change-Id: I9fe5c7b2fface44618c43af2

Expand conf namespace

Put rest of conf.hpp in the conf namespace. This is
largely a sed replace, and wrapping from_json in
conf namespace as it failed to build.

Change-Id: I9fe5c7b2fface44618c43af2367035afc39bcb64
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

s/minThermalRPM/minThermalOutput

The minThermalRPM is only an RPM by the fact that
that is the units of the PID. As the PID units can
be anything, change this to minThermalOutput to allow
for differ

s/minThermalRPM/minThermalOutput

The minThermalRPM is only an RPM by the fact that
that is the units of the PID. As the PID units can
be anything, change this to minThermalOutput to allow
for different units (i.e. percent).

Change-Id: Ic53fef1159ade5a413e5d519d407947f3023d8e3
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

dbuspassive: allow scaling

For tachs it is beneficial to deal in percent so that
multiple controllers can be used with different fan
types without having to recalculate. This starts using
the unused

dbuspassive: allow scaling

For tachs it is beneficial to deal in percent so that
multiple controllers can be used with different fan
types without having to recalculate. This starts using
the unused min and max fields to be able to scale readings.
Since max and min are commonly on the value interface, the
special value of <int64_t>::lowest() allows these to be gathered
from dbus instead of having to enter them manually.

Tested-by: Moved pid control to percent and printed
outputs

Change-Id: I9496eb92a18b68a7cd7f034d41d40ef5175c6974
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

stepwise: Add ceiling type

Add a stepwise ceiling type, this is used as a
upper clipping curve to limit the max output based
on a temperature sensor. This is commonly used for
quiet fan mode where C

stepwise: Add ceiling type

Add a stepwise ceiling type, this is used as a
upper clipping curve to limit the max output based
on a temperature sensor. This is commonly used for
quiet fan mode where CPU throttling is allowed to
preserve a max fan noise.

Change-Id: I181d5913c92e5498a34e6d3f67cf99b67471479c
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

dbusconfiguration: set timeout to 0

Setting this value to zero so we can limit d-bus
traffic and not send updates unless there is one.

Tested-by: fan control worked normally after

Change-Id: Ie8bd

dbusconfiguration: set timeout to 0

Setting this value to zero so we can limit d-bus
traffic and not send updates unless there is one.

Tested-by: fan control worked normally after

Change-Id: Ie8bd7fbfd86c1643ea5bf76cf49a087923db0ccf
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Allow removal from failsafe if timeout=0

Initialize cache on start adds all sensors to failsafe.
Without being able to hit the removal in updatesensors
this causes the system to go into failsafe and

Allow removal from failsafe if timeout=0

Initialize cache on start adds all sensors to failsafe.
Without being able to hit the removal in updatesensors
this causes the system to go into failsafe and never
remove.

Closes #8

Change-Id: I83f495adb1475abc27dba1734022f28d89e03d8f
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...