ba8ffa73 | 11-Feb-2019 |
Patrick Venture <venture@google.com> |
swap libconfig++ for json in configuration parsing
Parse the configuration file as json and not libconfig++.
Change-Id: Ic3e71cc810195387617b545566cf757c61c71942 Signed-off-by: Patrick Venture <ven
swap libconfig++ for json in configuration parsing
Parse the configuration file as json and not libconfig++.
Change-Id: Ic3e71cc810195387617b545566cf757c61c71942 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
69c51061 | 11-Feb-2019 |
Patrick Venture <venture@google.com> |
conf change: sensors: read and write path rename
Rename the readpath and writepath for camelcase styling to make all configuration variables consistent.
Change-Id: I33f475075c8f40cd2029a5c0bfda9508
conf change: sensors: read and write path rename
Rename the readpath and writepath for camelcase styling to make all configuration variables consistent.
Change-Id: I33f475075c8f40cd2029a5c0bfda950846cd5d44 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
6f59cf25 | 08-Feb-2019 |
Patrick Venture <venture@google.com> |
sensors: buildjson: add todo for failure
The daemon needs to validate the json configuration, either immediately after it's parsed or when objects are built from it.
Change-Id: I52b5a558657ba1420bc
sensors: buildjson: add todo for failure
The daemon needs to validate the json configuration, either immediately after it's parsed or when objects are built from it.
Change-Id: I52b5a558657ba1420bc4589de793cc496392f318 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
eeeb867d | 08-Feb-2019 |
Patrick Venture <venture@google.com> |
add support to build sensors from json
Add support to build sensors from a json configuration file.
Change-Id: Ic5bcbcd01e085ab0d4efaed314af8dc7e82b0b9d Signed-off-by: Patrick Venture <venture@goog
add support to build sensors from json
Add support to build sensors from a json configuration file.
Change-Id: Ic5bcbcd01e085ab0d4efaed314af8dc7e82b0b9d Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
a510ea2b | 08-Feb-2019 |
Patrick Venture <venture@google.com> |
sensors: add method to grab default timeout
Add a central method for grabbing the default timeout for a sensor. This is required to allow for a configuration to leave out an unnecessary field.
Chan
sensors: add method to grab default timeout
Add a central method for grabbing the default timeout for a sensor. This is required to allow for a configuration to leave out an unnecessary field.
Change-Id: I29ecd9db67b1eb1e66e60ef49859926cf14a4542 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
9fa90c19 | 11-Jan-2019 |
James Feist <james.feist@linux.intel.com> |
Change all default_bus back to new_system bus
new_default now returns a reference to a single bus, phosphor-pid-control uses multiple busses so we do not want that. This was the way it was implement
Change all default_bus back to new_system bus
new_default now returns a reference to a single bus, phosphor-pid-control uses multiple busses so we do not want that. This was the way it was implemented prior to https://github.com/openbmc/sdbusplus/commit/8ca6025eed193c252149b2908c3d5e37b00b0107
Tested-by: swampd ran normally
These errors go away:
Jan 28 18:28:45 swampd[1760]: terminate called after throwing an instance of 'sdbusplus::exception::SdBusError' Jan 28 18:28:45 swampd[1760]: what(): sd_bus_request_name: org.freedesktop.DBus.Error.InconsistentMessage: Bad message
Change-Id: I708cd5e6c45509f27d4fe783c0b0cfb52ff10336 Signed-off-by: James Feist <james.feist@linux.intel.com>
show more ...
|
ffc5ca7f | 31-Oct-2018 |
Patrick Venture <venture@google.com> |
manager: use pass by reference by default
Even thought the string must be copied, pass by reference.
Change-Id: I48113237f342279e3f266bbda6e54d770afd2afc Signed-off-by: Patrick Venture <venture@goo
manager: use pass by reference by default
Even thought the string must be copied, pass by reference.
Change-Id: I48113237f342279e3f266bbda6e54d770afd2afc Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
c179d406 | 30-Oct-2018 |
Patrick Venture <venture@google.com> |
style: misc camel casing
Miscellaneous camel casing.
Change-Id: I90f7ab36448ad7c6a8e22677345d9d15591a64d5 Signed-off-by: Patrick Venture <venture@google.com> |
1248b153 | 30-Oct-2018 |
Patrick Venture <venture@google.com> |
style: use system path for dbus headers
Use system path for dbus headers.
Change-Id: I08088eb0932de738fc410104c28847aaf78d95bd Signed-off-by: Patrick Venture <venture@google.com> |
e7252864 | 30-Oct-2018 |
Patrick Venture <venture@google.com> |
sensors: throw build time exceptions on failure
Throw build time exceptions on failure.
Change-Id: I7f873e15d0827b2424b9a1cfb6b494546952f1aa Signed-off-by: Patrick Venture <venture@google.com> |
c404b3ec | 30-Oct-2018 |
Patrick Venture <venture@google.com> |
errors: add exception for build time failure
Add a specific exception for build-time failures.
Change-Id: I1e6189ca256398d6995d4d0e0127846e1a7249a9 Signed-off-by: Patrick Venture <venture@google.co
errors: add exception for build time failure
Add a specific exception for build-time failures.
Change-Id: I1e6189ca256398d6995d4d0e0127846e1a7249a9 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
f5e770b3 | 30-Oct-2018 |
Patrick Venture <venture@google.com> |
dbus: dbuswrite: use factory to catch errors
Add factories for creating DbusWrite and DbusWritePercent objects and use these factories.
Change-Id: Iad222d4bf6c1fdf561daa4ba9d88a6644c0a5965 Signed-o
dbus: dbuswrite: use factory to catch errors
Add factories for creating DbusWrite and DbusWritePercent objects and use these factories.
Change-Id: Iad222d4bf6c1fdf561daa4ba9d88a6644c0a5965 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
7af157b1 | 30-Oct-2018 |
Patrick Venture <venture@google.com> |
style: function names should be lower camel
Fix function names to be lower camel.
Change-Id: I145e1f4c03d7740bc1525dcffbdce2f78fd61075 Signed-off-by: Patrick Venture <venture@google.com> |
563a356f | 30-Oct-2018 |
Patrick Venture <venture@google.com> |
style: member functions should be lower camel
Rename member functions to be lower camel instead of snake case.
Change-Id: Ib227fd3dadb6d9607290277205223a4324cd4ce5 Signed-off-by: Patrick Venture <v
style: member functions should be lower camel
Rename member functions to be lower camel instead of snake case.
Change-Id: Ib227fd3dadb6d9607290277205223a4324cd4ce5 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
f3252315 | 30-Oct-2018 |
Patrick Venture <venture@google.com> |
style: fixup naming of structures
Fixup naming of structures to UpperCamel.
Change-Id: I6a9bf0b954298089c85d3362e86cd95b3fc5b944 Signed-off-by: Patrick Venture <venture@google.com> |
4a2dc4d8 | 23-Oct-2018 |
Patrick Venture <venture@google.com> |
cleanup: apply constness to read-only iterators
Apply const to read-only iterators to indicate intent more clearly.
Change-Id: Ic14304c69361da203d3d3a900180bd54346acc87 Signed-off-by: Patrick Ventu
cleanup: apply constness to read-only iterators
Apply const to read-only iterators to indicate intent more clearly.
Change-Id: Ic14304c69361da203d3d3a900180bd54346acc87 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
36b7d8eb | 05-Oct-2018 |
James Feist <james.feist@linux.intel.com> |
[dbus-passive] Add threshold fan failure
When a threshold is crossed for a monitored sensor, assert fan failure.
Tested-by: Changed a sensor threshold so that its current reading made the threshold
[dbus-passive] Add threshold fan failure
When a threshold is crossed for a monitored sensor, assert fan failure.
Tested-by: Changed a sensor threshold so that its current reading made the threshold asserted and noticed via print messages that the sensor went into failure state. Also noticed fans ramp. Wrote unit test to verify sensor can move in and out of error state correctly.
Change-Id: I83182536e4874eaba97f3f1d48d53ac110fba833 Signed-off-by: James Feist <james.feist@linux.intel.com>
show more ...
|
df766f25 | 13-Oct-2018 |
Patrick Venture <venture@google.com> |
cleanup: reduce scope of variables
Various things caught by cppcheck that are non-critical.
Change-Id: I495453c84bc15788b85036a163ee36b0ac601fa1 Signed-off-by: Patrick Venture <venture@google.com> |
da4a5dd1 | 31-Aug-2018 |
Patrick Venture <venture@google.com> |
add .clang-format
Change-Id: I6627b5569c2e0f730be7331403218b823a2c622f Signed-off-by: Patrick Venture <venture@google.com> |
7136a5ae | 19-Jul-2018 |
James Feist <james.feist@linux.intel.com> |
Add ability to configure from dbus
This allows configuration of PID control from dbus using entity manager. Sample configuration will be pushed to entity-manager repo shortly.
Tested-by: Used yaml
Add ability to configure from dbus
This allows configuration of PID control from dbus using entity manager. Sample configuration will be pushed to entity-manager repo shortly.
Tested-by: Used yaml configuration and dbus / entity-manager based configuration and pid seemed to work the same. Verified printout of configuration matched generated cpp files.
Change-Id: Ia7b016e53262791ffcccdb9b21c1ccddae2926bc Signed-off-by: James Feist <james.feist@linux.intel.com>
show more ...
|
0ef1faf7 | 13-Jun-2018 |
Patrick Venture <venture@google.com> |
test: dbus: passive read interface
Added basic unit-tests and added a factory for creating the DbusPassive read interface so that it can be nicely error checked. This is handled via a valid type ch
test: dbus: passive read interface
Added basic unit-tests and added a factory for creating the DbusPassive read interface so that it can be nicely error checked. This is handled via a valid type check where the only valid types are 'fan' and 'temp'.
Change-Id: I558ed09bf509d26f20c6e431bb0789074e9aa841 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
0df7c0fb | 13-Jun-2018 |
Patrick Venture <venture@google.com> |
dbus: transition to interface for testing
To make testing easier, the dbus objects now receive a helper interface to use instead of calling into a helper module.
Tested: Ran on quanta-q71l board an
dbus: transition to interface for testing
To make testing easier, the dbus objects now receive a helper interface to use instead of calling into a helper module.
Tested: Ran on quanta-q71l board and it behaved as expected.
Change-Id: I2521d9c75aec76e92d2e26dc044d01011e44d552 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
a58197cf | 11-Jun-2018 |
Patrick Venture <venture@google.com> |
test: pid: zone
Add unit-tests for the PID zone module. Add zone_mock.
Tested: Ran on quanta-q71l board and it behaved as expected.
Change-Id: I51185b2d2daacea6ffb687e8f38c4fe2b2a1bed3 Signed-off-
test: pid: zone
Add unit-tests for the PID zone module. Add zone_mock.
Tested: Ran on quanta-q71l board and it behaved as expected.
Change-Id: I51185b2d2daacea6ffb687e8f38c4fe2b2a1bed3 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
fe75b193 | 08-Jun-2018 |
Patrick Venture <venture@google.com> |
enable unit-tests: enable for SensorManager
Enabled unit-tests in general for the project, and more specifically started with a benign construction test for the SensorManager object.
Tested: Verifi
enable unit-tests: enable for SensorManager
Enabled unit-tests in general for the project, and more specifically started with a benign construction test for the SensorManager object.
Tested: Verified continues to build and link, and unit-test passes. Tested: Ran on quanta-q71l board and it behaved as expected.
Change-Id: I4ad9a0c57efd0b9ccc37d26faa0cc1b82026b8d7 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
5e929093 | 08-Jun-2018 |
Patrick Venture <venture@google.com> |
sensors: split building from manager object
To increase testability, split out the building of sensors from the sensor manager. And this further splits out building from a configuration file.
Test
sensors: split building from manager object
To increase testability, split out the building of sensors from the sensor manager. And this further splits out building from a configuration file.
Tested: Verified code continued to build and link. Tested: Ran on quanta-q71l board and it behaved as expected.
Change-Id: Ib63a11e1107b1864c3c370bba2bd9ef2effa42f3 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|