| bbf5e9e8 | 01-Feb-2023 |
William A. Kennington III <wak@google.com> |
ethernet_interface: Validate gateway IPs
We don't want to allow loopback, network id, or multicast spaces to be
used for the gateway.
Change-Id: I1ff762268321f8c0dacb760611cce8383d880997
Signed-off
ethernet_interface: Validate gateway IPs
We don't want to allow loopback, network id, or multicast spaces to be
used for the gateway.
Change-Id: I1ff762268321f8c0dacb760611cce8383d880997
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| 9ca5c8ec | 14-Dec-2022 |
William A. Kennington III <wak@google.com> |
ethernet_interface: Empty address also deletes the gateway
Since the address is invalid anyway, this is a straightforward way to
clear the entry.
Change-Id: I7c130d0e3c3c0d182e8a7c54d53be44b4ffe47a
ethernet_interface: Empty address also deletes the gateway
Since the address is invalid anyway, this is a straightforward way to
clear the entry.
Change-Id: I7c130d0e3c3c0d182e8a7c54d53be44b4ffe47a7
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| d4ff731e | 03-Feb-2023 |
William A. Kennington III <wak@google.com> |
ethernet_interface: Refactor gateway setting
Reduce duplication and re-use code.
Change-Id: Id0919c03f439af60f3e4e65860f22e4b61e609a1
Signed-off-by: William A. Kennington III <wak@google.com> |
| af77f827 | 23-Jun-2023 |
William A. Kennington III <wak@google.com> |
treewide: Add clang-tidy
Change-Id: I1aab00b0ff8c016650225fcd1c83678a91808941
Signed-off-by: William A. Kennington III <wak@google.com> |
| 9b2a20d3 | 17-Jun-2023 |
William A. Kennington III <wak@google.com> |
types: Migrate to stdplus ip
Change-Id: I777aa701204b0c4dbe5f0088cc2e6a4deb4f5d15
Signed-off-by: William A. Kennington III <wak@google.com> |
| e8af05c8 | 17-Jun-2023 |
William A. Kennington III <wak@google.com> |
types: Migrate to stdplus endian
Change-Id: Idd87f83672b7f97a8bdd13f7646760c0d77c5ff5
Signed-off-by: William A. Kennington III <wak@google.com> |
| b7d6a1a7 | 17-Jun-2023 |
William A. Kennington III <wak@google.com> |
types: Migrate to stdplus EtherAddr
Change-Id: I1ec2cd0b57a9f02fe96bbe9a068d1a437805b43a
Signed-off-by: William A. Kennington III <wak@google.com> |
| 11b59a35 | 02-Jun-2023 |
William A. Kennington III <wak@google.com> |
types: Migrate to stdplus hash
Trivial refactor to remove duplicate code.
Change-Id: I20ab453f9f85b5802ddcae0d389caf3b41381a86
Signed-off-by: William A. Kennington III <wak@google.com> |
| 60903ee7 | 02-Jun-2023 |
William A. Kennington III <wak@google.com> |
types: Migrate to stdplus string maps
Trivial refactor to share more code.
Change-Id: I665bec386ef13a4665536457ab174e621ef64d14
Signed-off-by: William A. Kennington III <wak@google.com> |
| 0d763826 | 27-Feb-2023 |
William A. Kennington III <wak@google.com> |
rtnetlink_server: Ignore errors on ignored interfaces
An example is MCTP device addresses that cannot be parsed by
phosphor-networkd. We don't need to parse them if they are ignored, so
we can just
rtnetlink_server: Ignore errors on ignored interfaces
An example is MCTP device addresses that cannot be parsed by
phosphor-networkd. We don't need to parse them if they are ignored, so
we can just ignored the errors.
Tested: Verified that MCTP devices no longer cause error messages to
print to the journal.
Change-Id: I60b0a24f1e9a2e1866ac902833eb94c034ddfce0
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| 9c441fd4 | 24-Feb-2023 |
William A. Kennington III <wak@google.com> |
treewide: Ignore non-ethernet devices
These are not regular ethernet devices that use INET protocols. We can
ignore them as they just produce journal spam otherwise.
Tested: Verified that our MCTP
treewide: Ignore non-ethernet devices
These are not regular ethernet devices that use INET protocols. We can
ignore them as they just produce journal spam otherwise.
Tested: Verified that our MCTP interfaces are no longer reported as
objects and that our NCSI and ETH interfaces are still added.
Change-Id: Idd5723e443b358fe76f039bcc4ce70390824094d
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| a7485305 | 30-May-2023 |
William A. Kennington III <wak@google.com> |
ethernet_interface: Remove unused try blocks
This makes the error handling more consistent with the rest of the
callers in the file. We don't need to handle exceptions from our reload
/ writer funct
ethernet_interface: Remove unused try blocks
This makes the error handling more consistent with the rest of the
callers in the file. We don't need to handle exceptions from our reload
/ writer functions.
Change-Id: Iee2b61c8282e4b466327f85bedd2acf2634f42b6
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| 1d25ca4e | 30-May-2023 |
William A. Kennington III <wak@google.com> |
treewide: Make logging variables more consistent
This aims to better group related variables and differentiate keywords
like INTERFACE_NAME into NET vs DBUS.
Tested: Ran on a machine to verify that
treewide: Make logging variables more consistent
This aims to better group related variables and differentiate keywords
like INTERFACE_NAME into NET vs DBUS.
Tested: Ran on a machine to verify that our info log messages still look
sane in the journal.
Change-Id: Ic4d1faaaf5c432e69cacd387fa972481916b6bc8
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| 89d734b9 | 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.
Change-Id: Ia4966a0790437eb0fc011c747f3be2a52884e4d8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| f78a415e | 17-Apr-2023 |
Jagpal Singh Gill <paligill@gmail.com> |
logging: switch networkd static_library to lg2
This commit switches logging to lg2 in the following files -
1. src/network_manager.cpp
2. src/util.cpp
3. src/ethernet_interface.cpp
Tested: Build pa
logging: switch networkd static_library to lg2
This commit switches logging to lg2 in the following files -
1. src/network_manager.cpp
2. src/util.cpp
3. src/ethernet_interface.cpp
Tested: Build passes with "ninja -C build".
Change-Id: Ib2492116ecf3f41f9cd0146dc4b5389a59bce87c
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>
show more ...
|
| a2947b4b | 17-Apr-2023 |
Jagpal Singh Gill <paligill@gmail.com> |
logging: switch networkd static_library to lg2
This commit switches logging to lg2 in the following files -
1. src/dhcp_configuration.cpp
2. src/dhcp_configuration.cpp
3. src/ipaddress.cpp
4. src/sy
logging: switch networkd static_library to lg2
This commit switches logging to lg2 in the following files -
1. src/dhcp_configuration.cpp
2. src/dhcp_configuration.cpp
3. src/ipaddress.cpp
4. src/system_configuration.cpp
5. src/system_queries.cpp
Tested: Build passes with "ninja -C build".
Change-Id: I492c7579c968810b783836b652e450ff89b8cd4b
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>
show more ...
|
| 49f9d255 | 17-Apr-2023 |
Jagpal Singh Gill <paligill@gmail.com> |
logging: switch phosphor-network-manager exe to lg2
Tested: Build passes with "ninja -C build".
Change-Id: Ib02682393aba65b16f55eece58ecf50321190a56
Signed-off-by: Jagpal Singh Gill <paligill@gmail.
logging: switch phosphor-network-manager exe to lg2
Tested: Build passes with "ninja -C build".
Change-Id: Ib02682393aba65b16f55eece58ecf50321190a56
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>
show more ...
|
| 7eb07c2d | 17-Apr-2023 |
Jagpal Singh Gill <paligill@gmail.com> |
logging: switch hyp-network-manager to lg2
Tested: Build passes with "ninja -C build".
Change-Id: If66b365354268d8577c48852876821f252ca88c8
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com> |
| d423bebf | 18-Apr-2023 |
Jagpal Singh Gill <paligill@gmail.com> |
logging: switch ncsi-netlink to lg2
Tested: Build passes with "ninja -C build".
Change-Id: Iac053348b1125d15bcf65e27487c6814fa85650a
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com> |
| b03a760f | 21-Apr-2023 |
Patrick Williams <patrick@stwcx.xyz> |
regenerate-meson: re-run with latest from sdbusplus
The sdbus++-gen-meson has a new version, which requires regenerating
all the meson in this repository. Re-run the `regenerate-meson`
script.
Sig
regenerate-meson: re-run with latest from sdbusplus
The sdbus++-gen-meson has a new version, which requires regenerating
all the meson in this repository. Re-run the `regenerate-meson`
script.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I45c691970d685403a15c1790eabc66663f338d4b
show more ...
|
| 0c671a1a | 19-Apr-2023 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t
Change-Id: I3d7315de3ebd770f1c05979226b932b928b6c109
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| cc7f5bf0 | 12-Apr-2023 |
Patrick Williams <patrick@stwcx.xyz> |
meson: remove deprecated get_pkgconfig_variable
Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig
meson: remove deprecated get_pkgconfig_variable
Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.
Change-Id: Iea38cd41ecdf6425bb335af39691dfac60cad7db
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| c8a5b7b7 | 19-Jul-2022 |
Asmitha Karunanithi <asmitk01@in.ibm.com> |
Add DHCP functionalities to hypervisor eth interfaces
This commit adds methods that provides dhcp functionalities on
the ethernet interface like - disable dhcp on an ethernet interface,
to check if
Add DHCP functionalities to hypervisor eth interfaces
This commit adds methods that provides dhcp functionalities on
the ethernet interface like - disable dhcp on an ethernet interface,
to check if dhcp is enabled on an interface.
Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: Ic713782d48c4c3cc1e1d029212b3ecf7ff5f39ad
show more ...
|
| c24de883 | 08-Jun-2021 |
Asmitha Karunanithi <asmitk01@in.ibm.com> |
Add ethernet objects under hypervisor network obj
In this commit, ethernet interface dbus objects are created
under the hypervisor network service.
busctl tree xyz.openbmc_project.Network.Hyperviso
Add ethernet objects under hypervisor network obj
In this commit, ethernet interface dbus objects are created
under the hypervisor network service.
busctl tree xyz.openbmc_project.Network.Hypervisor
└─/xyz
└─/xyz/openbmc_project
└─/xyz/openbmc_project/network
└─/xyz/openbmc_project/network/hypervisor
├─/xyz/openbmc_project/network/hypervisor/config
├─/xyz/openbmc_project/network/hypervisor/eth0
└─/xyz/openbmc_project/network/hypervisor/eth1
Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I4222fa29a9df607c8291d7f81f7f3e837442bc26
show more ...
|
| d43d12e3 | 05-Apr-2023 |
Johnathan Mantey <johnathanx.mantey@intel.com> |
Add Johnathan Mantey to reviewers list
Adding Johnathan Mantey to the reviewers list
Change-Id: Ic56fcb85c361f78798705c0bf682c322f78a9075
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.co
Add Johnathan Mantey to reviewers list
Adding Johnathan Mantey to the reviewers list
Change-Id: Ic56fcb85c361f78798705c0bf682c322f78a9075
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
show more ...
|