a7cd46ff | 14-Feb-2023 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
treewide: remove dependencies on mapper.target
The mapper is dbus activated now, so these explicit dependency declarations are unnecessary and redundant.
Change-Id: I097d42a26b1cbcc18a750416877643a
treewide: remove dependencies on mapper.target
The mapper is dbus activated now, so these explicit dependency declarations are unnecessary and redundant.
Change-Id: I097d42a26b1cbcc18a750416877643a756af5fba Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
show more ...
|
de333e14 | 10-Feb-2023 |
Patrick Williams <patrick@stwcx.xyz> |
inventory_mac: fix inventory sync
The inventory mac syncing feature was not working correctly. Fixed a few issues with it.
1. The code waited for signals for ethernet interfaces, but those
inventory_mac: fix inventory sync
The inventory mac syncing feature was not working correctly. Fixed a few issues with it.
1. The code waited for signals for ethernet interfaces, but those signals were likely already emitted. We need to also scan the existing interfaces for potential inventory lookups.
2. The code to register for inventory signals was after the inventory lookup. This leaves a race condition where inventory could be emitted and missed. Register the signal match before doing the inventory lookup and cancel the match if the lookup was successful.
3. Some places were needlessly re-reading the configuration file.
4. Some places were saving a reference to an on-stack representation of the configuration file into a callback (for signals). Move this to a global variable to avoid segfaults.
Tested:
Booted up in QEMU without an inventory EEPROM. Observed expected behavior from daemon. Issued a manual inventory Notify call to create a fake MAC address. Observed signal was reacted to appropriately. Restarted the service and observed that 'force-sync' occurs immediately.
(trimmed duplicate journal entries from various journalctl calls)
``` root@bletchley:~# journalctl -u xyz.openbmc_project.Network Feb 10 13:46:10 bletchley systemd[1]: Starting Phosphor Network Manager... Feb 10 13:46:12 bletchley phosphor-network-manager[537]: Force sync enabled, check VPD for MAC Feb 10 13:46:12 bletchley phosphor-network-manager[537]: Registering the Inventory Signals Matcher Feb 10 13:46:15 bletchley phosphor-network-manager[537]: No Object has implemented the interface Feb 10 13:46:15 bletchley phosphor-network-manager[537]: The operation failed internally. Feb 10 13:46:15 bletchley phosphor-network-manager[537]: Exception occurred during getting of MAC address from Inventory Feb 10 13:46:15 bletchley systemd[1]: Started Phosphor Network Manager. root@bletchley:~# busctl call xyz.openbmc_project.Inventory.Manager \ /xyz/openbmc_project/inventory \ xyz.openbmc_project.Inventory.Manager Notify \ a{oa{sa{sv}}} 1 \ /xyz/openbmc_project/inventory/system/chassis/bmc/ethernet \ 1 xyz.openbmc_project.Inventory.Item.NetworkInterface \ 1 MACAddress s "C01850F1D796" root@bletchley:~# journalctl -u xyz.openbmc_project.Network Feb 10 13:48:31 bletchley phosphor-network-manager[537]: Wrote networkd file: /etc/systemd/network/00-bmc-eth0.network Feb 10 13:48:31 bletchley phosphor-network-manager[537]: Setting MAC on eth0 root@bletchley:~# [ 185.469811] ftgmac100 1e670000.ftgmac eth0: Link is Up - 1Gbps/Full - flow control off [ 185.471607] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready ifconfig eth0 Link encap:Ethernet HWaddr C0:18:50:F1:D7:96 inet addr:10.0.2.16 Bcast:10.0.2.255 Mask:255.255.255.0 root@bletchley:~# systemctl restart xyz.openbmc_project.Network root@bletchley:~# journalctl -u xyz.openbmc_project.Network Feb 10 13:48:34 bletchley phosphor-network-manager[537]: Reloaded systemd-networkd Feb 10 13:55:24 bletchley phosphor-network-manager[537]: Got TERM, exiting Feb 10 13:55:24 bletchley systemd[1]: Stopping Phosphor Network Manager... Feb 10 13:55:24 bletchley systemd[1]: xyz.openbmc_project.Network.service: Deactivated successfully. Feb 10 13:55:24 bletchley systemd[1]: Stopped Phosphor Network Manager. Feb 10 13:55:24 bletchley systemd[1]: Starting Phosphor Network Manager... Feb 10 13:55:25 bletchley phosphor-network-manager[11066]: Using DHCP options from /etc/systemd/network/00-bmc-eth0.network Feb 10 13:55:25 bletchley phosphor-network-manager[11066]: Force sync enabled, check VPD for MAC Feb 10 13:55:25 bletchley phosphor-network-manager[11066]: Registering the Inventory Signals Matcher Feb 10 13:55:25 bletchley phosphor-network-manager[11066]: Setting MAC on eth0 Feb 10 13:55:25 bletchley phosphor-network-manager[11066]: Removing the match for ethernet interfaces Feb 10 13:55:25 bletchley systemd[1]: Started Phosphor Network Manager. ```
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Icf18e3d80f6d1f8c4567603fe51d774e9090334c
show more ...
|
a307b116 | 09-Jan-2023 |
Patrick Williams <patrick@stwcx.xyz> |
gen: update due to sdbusplus-gen-meson change
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ie7751b6f0253c46cf2329728e57759e23db8d3c6 |
52d70915 | 21-Nov-2022 |
William A. Kennington III <wak@google.com> |
main: Use workaround loop function
This makes sure our bus never leaks memory with a lack of processing match requests.
Change-Id: I980828324d8055acb1591ac5a072971a579821a2 Signed-off-by: William A
main: Use workaround loop function
This makes sure our bus never leaks memory with a lack of processing match requests.
Change-Id: I980828324d8055acb1591ac5a072971a579821a2 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
9ede1b74 | 21-Nov-2022 |
William A. Kennington III <wak@google.com> |
treewide: Codify memory pinning
This enforces movability constraints.
Change-Id: I49dbd43a791c1d70eb7e97f30708231c053901d9 Signed-off-by: William A. Kennington III <wak@google.com> |
a4c18d4e | 08-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
beautysh: re-format
beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh files to have a consistent formatting. Re-run the formatter on the whole repository.
Change-Id: Icd6c919f9
beautysh: re-format
beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh files to have a consistent formatting. Re-run the formatter on the whole repository.
Change-Id: Icd6c919f9a3643d76d0aa691229a2d0e440cb3d6 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
8110f7dd | 08-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
prettier: re-format
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML files to have consistent formatting for these file types. Re-run the formatter on the whole repository.
prettier: re-format
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML files to have consistent formatting for these file types. Re-run the formatter on the whole repository.
Change-Id: I455b949e6d20dcc5617774d521b77fb985c48122 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
9bc50f5e | 04-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are for: * bus_t * exception_t * manager_t * match_t * message_t * object_t * slot_t
Change-Id: I2d41abae9cbf4878979966d5509f68e34dacdbba Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
de70ccf6 | 20-Nov-2022 |
William A. Kennington III <wak@google.com> |
treewide: Move timers out of networkd lib scope
Change-Id: I5fd0fc70d007e0851329172b8421846a78016d57 Signed-off-by: William A. Kennington III <wak@google.com> |
1b594206 | 17-Nov-2022 |
William A. Kennington III <wak@google.com> |
test/util: Simplify
Change-Id: I4b92ecdc6ee38a9572a87fc38092e270419ec84a Signed-off-by: William A. Kennington III <wak@google.com> |
d6bd8fbe | 17-Nov-2022 |
William A. Kennington III <wak@google.com> |
util: Remove charconv
Change-Id: Ib423bb1c351e6624442557d58efbb1eb8b2d6b6c Signed-off-by: William A. Kennington III <wak@google.com> |
0b111d4e | 04-Oct-2022 |
William A. Kennington III <wak@google.com> |
inventory_mac: Migrate code out of other places
Change-Id: I5a84c07eebad1b9b0dc535a47edbf6bf0f72b6cb Signed-off-by: William A. Kennington III <wak@google.com> |
add08717 | 17-Nov-2022 |
William A. Kennington III <wak@google.com> |
ethernet_interface: Remove spurious reloads
Change-Id: I0929452666d50e8093670af36df77e05adb188d7 Signed-off-by: William A. Kennington III <wak@google.com> |
93f5c6d3 | 17-Nov-2022 |
William A. Kennington III <wak@google.com> |
ethernet_interface: Fix VLAN delete
This ensures that we delete the interface in the correct order with reloads.
Change-Id: I6fec890b112b62be15256af415a6df1bfb6ccd38 Signed-off-by: William A. Kenni
ethernet_interface: Fix VLAN delete
This ensures that we delete the interface in the correct order with reloads.
Change-Id: I6fec890b112b62be15256af415a6df1bfb6ccd38 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
876927cb | 17-Nov-2022 |
William A. Kennington III <wak@google.com> |
ethernet_interface: Fix updates without interface idx
This fixes VLAN creation
Change-Id: I1d2fa8f9d20edfc49077f77d38e3ddcfbf49a6de Signed-off-by: William A. Kennington III <wak@google.com> |
6d217512 | 17-Nov-2022 |
William A. Kennington III <wak@google.com> |
system_queries: Add netlink based delete
We shouldn't depend on calling the IP binary
Change-Id: I4e9b3229ef936dad96e2fcfcea8f6b32a9c9f801 Signed-off-by: William A. Kennington III <wak@google.com> |
de4668a9 | 17-Nov-2022 |
William A. Kennington III <wak@google.com> |
network_manager: Add reload post hooks
We need this to handle deleting interfaces after reloading.
Change-Id: I0f3ca4cedf0e112bc285e4e2ecc1c3cad8ef5677 Signed-off-by: William A. Kennington III <wak
network_manager: Add reload post hooks
We need this to handle deleting interfaces after reloading.
Change-Id: I0f3ca4cedf0e112bc285e4e2ecc1c3cad8ef5677 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
c0936200 | 17-Nov-2022 |
William A. Kennington III <wak@google.com> |
network_manager: Remove unhandled exception
We can't throw here, just log an error and move on.
Change-Id: I2493eaa3354e1df578d56849e15d047070064160 Signed-off-by: William A. Kennington III <wak@go
network_manager: Remove unhandled exception
We can't throw here, just log an error and move on.
Change-Id: I2493eaa3354e1df578d56849e15d047070064160 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
40c29b54 | 16-Nov-2022 |
William A. Kennington III <wak@google.com> |
system_configuration: Fix new hostname updates
This allows changes outside of phosphor-networkd to be processed and handled correctly.
Change-Id: I0bb8e90fe502a6d69f451a45cfecbee1bc89eb66 Signed-of
system_configuration: Fix new hostname updates
This allows changes outside of phosphor-networkd to be processed and handled correctly.
Change-Id: I0bb8e90fe502a6d69f451a45cfecbee1bc89eb66 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
d99e6dba | 15-Nov-2022 |
William A. Kennington III <wak@google.com> |
treewide: Cleanup signal emission
Don't emit properties changed prior to interfaces added.
Change-Id: I7f88b8052a323ca49ce9f16fe446596213e3fdb5 Signed-off-by: William A. Kennington III <wak@google.
treewide: Cleanup signal emission
Don't emit properties changed prior to interfaces added.
Change-Id: I7f88b8052a323ca49ce9f16fe446596213e3fdb5 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
13d665ca | 15-Nov-2022 |
William A. Kennington III <wak@google.com> |
ethernet_interface: Migrate object creation from network_manager
Change-Id: I861a7e7484b33bfc94fc30ff17fa27fca2b95bfa Signed-off-by: William A. Kennington III <wak@google.com> |
bf290464 | 15-Nov-2022 |
William A. Kennington III <wak@google.com> |
network_manager: Implement interface rename
Now that we persist the interface data, we can recreate the object when the name changes.
Change-Id: I3b6de84ba20e3a7917e60283a29fbac007bfc6cc Signed-off
network_manager: Implement interface rename
Now that we persist the interface data, we can recreate the object when the name changes.
Change-Id: I3b6de84ba20e3a7917e60283a29fbac007bfc6cc Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
2fb0c870 | 15-Nov-2022 |
William A. Kennington III <wak@google.com> |
network_manager: Keep interface info around
This will allow us to rebuild objects if needed and doesn't take much more memory to store.
Change-Id: Ifcc8b2b62472167e9cebbead4b6f9c6565c06f0f Signed-o
network_manager: Keep interface info around
This will allow us to rebuild objects if needed and doesn't take much more memory to store.
Change-Id: Ifcc8b2b62472167e9cebbead4b6f9c6565c06f0f Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
b6452547 | 15-Nov-2022 |
William A. Kennington III <wak@google.com> |
ethernet_interface: Remove optional signal emission
We don't ever need to turn this off anymore, so we can simplify creation arguments.
Change-Id: Idb1bde35041f16d409753ff661bfb248cfd4591e Signed-o
ethernet_interface: Remove optional signal emission
We don't ever need to turn this off anymore, so we can simplify creation arguments.
Change-Id: Idb1bde35041f16d409753ff661bfb248cfd4591e Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
a429c9d9 | 15-Nov-2022 |
William A. Kennington III <wak@google.com> |
ethernet_interface: Fix updating sub objects
Neighbors and addresses should not fail to be added if similar objects exist in the tree that need to be upgraded.
Change-Id: I6416c14025af28234de8a5317
ethernet_interface: Fix updating sub objects
Neighbors and addresses should not fail to be added if similar objects exist in the tree that need to be upgraded.
Change-Id: I6416c14025af28234de8a531753d7d59be11c455 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|