systemd: drop SyslogIdentifier

This is the default behavior, so specifing it is unnecessary.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I8a48acd733c84d3d3bc34b08d135d9cd1b4

systemd: drop SyslogIdentifier

This is the default behavior, so specifing it is unnecessary.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I8a48acd733c84d3d3bc34b08d135d9cd1b4a771c

show more ...

systemd: use qualified paths

Fix a documented anti-pattern:
https://github.com/openbmc/docs/blob/master/anti-patterns.md#use-of-usrbinenv-in-systemd-service-files

Signed-off-by: Brad Bishop <bradle

systemd: use qualified paths

Fix a documented anti-pattern:
https://github.com/openbmc/docs/blob/master/anti-patterns.md#use-of-usrbinenv-in-systemd-service-files

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Ia2c78f0d39982754f1758b2e6bd89cd8b3591c0d

show more ...

Fix the failure of calling GetSubTreePaths to get the path

Since upstream updated sdbusplus (sdbusplus: object: don't use 'bool'
argument constructor), now we can't get the newly added object path
t

Fix the failure of calling GetSubTreePaths to get the path

Since upstream updated sdbusplus (sdbusplus: object: don't use 'bool'
argument constructor), now we can't get the newly added object path
through GetSubTreePaths/GetSubTree, so need to set action::defer_emit
to delay emitting object.

Tested:
busctl call xyz.openbmc_project.Network /xyz/openbmc_project/network xyz.openbmc_project.Network.VLAN.Create VLAN su eth0 100
busctl call xyz.openbmc_project.ObjectMapper /xyz/openbmc_project/object_mapper xyz.openbmc_project.ObjectMapper GetSubTreePaths sias /xyz/openbmc_project/network 0 2 xyz.openbmc_project.Network.VLAN xyz.openbmc_project.Network.EthernetInterface --verbose
MESSAGE "as" {
ARRAY "s" {
STRING "/xyz/openbmc_project/network/eth0";
STRING "/xyz/openbmc_project/network/eth0_100";
STRING "/xyz/openbmc_project/network/eth1";
};
};

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia9bb76cb7b4944e25236509667a2706c178e8ab2

show more ...

network_config: Enable [DHCP] option parameters by default

After factory reset, ethernet interfaces are set to DHCP as
expected. But the DNS and NTP servers are not requested.

This commit adds the

network_config: Enable [DHCP] option parameters by default

After factory reset, ethernet interfaces are set to DHCP as
expected. But the DNS and NTP servers are not requested.

This commit adds the [DHCP] options to the default network
file so that the DHCP REQUEST asks for the required options
from the DHCP server when fetching the fresh lease

Tested by:
1. Factory reset the BMC and check if the DHCP request is sent
for DNS and NTP etc
2. Verify the default network file

Signed-off-by: sunharis <sunharis@in.ibm.com>
Change-Id: I082694834a427400bfbfe2b2b0f871b0ecaee47b

show more ...

ethernet_interface: Add UseDomains option to network file

When the interface is DHCP enabled, domain-search value 119
is not requested by the DHCP client.

This commit adds the UseDomains option to

ethernet_interface: Add UseDomains option to network file

When the interface is DHCP enabled, domain-search value 119
is not requested by the DHCP client.

This commit adds the UseDomains option to network file
so that when the DNS is enabled, the domain-search option
is requested via DHCP REQUEST, and search list provided by DHCP
server are pulled to the DHCP lease and the resolv.conf

Fixes https://github.com/openbmc/phosphor-networkd/issues/47

Tested by:
1.Enable DNS option at BMC and check the DHCP REQUEST packet for
option 119
2.Verify the list 'option domain-search' at the DHCP server is
fetched by the DHCP lease file at BMC
3.Verify the same list is added to the search list at resolv.conf

Signed-off-by: sunharis <sunharis@in.ibm.com>
Change-Id: I2f6ca7236bf3b5e7d3ded9294b8372d95ac50ac6

show more ...

Remove gateway properties in SystemConfiguration

Now default gateway are per-interface properties, the system-wide one
in the SystemConfiguration interface is deprecated. Updating the value
also mak

Remove gateway properties in SystemConfiguration

Now default gateway are per-interface properties, the system-wide one
in the SystemConfiguration interface is deprecated. Updating the value
also makes no difference, it will never be written to configuration.
This patch removes the code of initializing and updating them.

Change #52785 removes the properties in phosphor-dbus-interfaces yaml,
it is recommended to be merged after this change.

Tested:
In SystemConfiguration interface, DefaultGateway and DefaultGateway6 are
still there, but writing them only updates the displayed value on DBus.
No code in phosphor-networkd is called.

Change-Id: I58ac52c5318943941dcc92abede7763bddbca596
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

ncsi-netlink: Remove phosphor-logging dependency

As a CLI application, ncsi-netlink should use stderr for error messages
instead of phosphor-logging. This commits converts all phosphor-logging
logs

ncsi-netlink: Remove phosphor-logging dependency

As a CLI application, ncsi-netlink should use stderr for error messages
instead of phosphor-logging. This commits converts all phosphor-logging
logs calls to std::cerr and removes phosphor_logging_dep in meson file.

Tested:
Build pass.

Change-Id: I02227e31feab080c03d514b65dbeec4059867385
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

Allow unset default gateway

Default gateway addresses cannot be unset in current implementation as
it requires a valid IP address and writes it to systemd.network files
every time. This patch suppor

Allow unset default gateway

Default gateway addresses cannot be unset in current implementation as
it requires a valid IP address and writes it to systemd.network files
every time. This patch supports setting empty string on DefaultGateway
and DefaultGateway6 DBus properties to unset the value as empty strings
will not be written to config file.

Tested:
Disable DHCP and set default gateway for both IPv4 and IPv6, then set
empty string on DefaultGateway and/or DefaultGateway6, verified the
corresponding [Route] section is removed in config file.

Change-Id: I3be81f9c7c605b12cb225beeefec02f9841b0dcd
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.

Change-Id: I2e7ce5e279d65d101e1249f2b41f126143d3f03d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id8a090

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id8a0909445b38271c0cdea79bad0ca9198cf7f0a

show more ...

ResourceNotFound: Add RESOURCE field to exception

Change Id1e07b42bc3fb13ff45284342976b94734370402 is adding a RESOURCE
field to the phosphor-logging metadata for Common.ResourceNotFound.
Leverage i

ResourceNotFound: Add RESOURCE field to exception

Change Id1e07b42bc3fb13ff45284342976b94734370402 is adding a RESOURCE
field to the phosphor-logging metadata for Common.ResourceNotFound.
Leverage it here as well.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I63598474c82aa8d704c034465ad1735ff5146a77

show more ...

Allow writing MAC address to networkd config file to be blocked

The systemd.networkd configuration file can store the MAC
address. This allows the MAC address to be changed on demand. This
feature m

Allow writing MAC address to networkd config file to be blocked

The systemd.networkd configuration file can store the MAC
address. This allows the MAC address to be changed on demand. This
feature may not desirable to some vendors. Server suppliers may prefer
to have an immutable MAC address.

The change here adds a compile time switch that enables/disables
writing the MAC address to the configuration file.

Tested:
Confirmed the default configuration permitted the MAC address to be written to
the configuration file.
Added a OEMESON override to the phosphor-network.bbappend file and
confirmed the MAC address no longer gets written.

Change-Id: Ic1eb69980cea6864a30dac93dd472ba9e0e2c1a9
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

ethernet_interface: Remove custom socket holder

This object was not move safe, so we ended up creating use after close
issues when handling the previous socket object.

Change-Id: I04887357c4f2953ac

ethernet_interface: Remove custom socket holder

This object was not move safe, so we ended up creating use after close
issues when handling the previous socket object.

Change-Id: I04887357c4f2953ac1714c834b7fd68cb2d25b44
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Fix nicEnabled property ordering

This should have been set prior to writing the configuration file,
otherwise the incorrect value gets written and the interface doesn't get
updat

ethernet_interface: Fix nicEnabled property ordering

This should have been set prior to writing the configuration file,
otherwise the incorrect value gets written and the interface doesn't get
updated.

Change-Id: I970495ad8817f406252afccc1bb4291193d4bf61
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

An application for hypervisor network configuration

This application takes care of hypervisor network configuration
by communicating with the bios-settings-mgr in the backend.

It hosts xyz.openbmc_

An application for hypervisor network configuration

This application takes care of hypervisor network configuration
by communicating with the bios-settings-mgr in the backend.

It hosts xyz.openbmc_project.Network.Hypervisor.service similar
to that of network service and implements system config, ethernet
and ip interfaces whose properties are mapped to the appropriate
properties in the base bios table.

The flow will be like:
- User fires the redfish command to update hypervisor
network configuration properties
- BMCWeb updates the properties in the dbus object
hosted by this application
- This application would update these new values in
the base bios table

This is divided into multiple commits and this commit
hosts xyz.openbmc_project.Network.Hypervisor.service and
creates the /xyz/openbmc_project/network/hypervisor object.

Tested By:

busctl tree xyz.openbmc_project.Network.Hypervisor
└─/xyz
└─/xyz/openbmc_project
└─/xyz/openbmc_project/network
└─/xyz/openbmc_project/network/hypervisor

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I2d4582bc9c1dbf72c9963f3e43169b695b34b1ed

show more ...

util: fromString: Reduce string allocations

Change-Id: Ie6f7fa5dcc958081e7d7e2b880c17fe3548955a7
Signed-off-by: William A. Kennington III <wak@google.com>

util: enhance MAC address parsing

Current ether_aton does not support the MAC string without colons.
Add extra conversion when string length equal to 12.

Test log:
1/7 config_parser OK

util: enhance MAC address parsing

Current ether_aton does not support the MAC string without colons.
Add extra conversion when string length equal to 12.

Test log:
1/7 config_parser OK 0.01s
2/7 neighbor OK 0.01s
3/7 netlink OK 0.01s
4/7 util OK 0.01s
5/7 network_manager OK 0.01s
6/7 ethernet_interface OK 0.01s
7/7 vlan_interface OK 0.01s

Ok: 7
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 0
Timeout: 0

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: Id2125af85f1c3d75424ff6ea0980c1460614f14e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix nameserver property for VLAN interfaces

Currently, nameservers of VLAN interfaces assigned by DHCP will not be
populated on DBus, and static nameservers previously set disappears on
DBus. This p

Fix nameserver property for VLAN interfaces

Currently, nameservers of VLAN interfaces assigned by DHCP will not be
populated on DBus, and static nameservers previously set disappears on
DBus. This patch fixes this issue by loading nameserver info when
creating VLAN interface, same as how physical one does.

Tested:
Verified below 2 cases with VLAN interface
1. Nameservers assigned by DHCP is populated on DBus.
2. After restarting the xyz.openbmc_project.Network service, static
nameservers previously configured is populated DBus.

Change-Id: I0da0c3c25b749de14994ed3f1647a21c1ecfac7d
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

Fix missing line-feed for DHCPv6Client entry

Insertion of the DHCPv6Client causes subsequent systemd.network
entries to be parsed incorrectly. When a static address is configured
the "[Address]" sec

Fix missing line-feed for DHCPv6Client entry

Insertion of the DHCPv6Client causes subsequent systemd.network
entries to be parsed incorrectly. When a static address is configured
the "[Address]" section trails the DHCPv6Client line. The missing "\n"
prevents the static address from being honored.

Tested:
Assigned a static IPv4 address.
Prior to this commit the IPv4 address does not get assigned.
After applying this commit the static IPv4 address is assigned.

Change-Id: I416cba3d3b561baeab6d3ed88830602d9206fe86
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

ethernet_interface: Remove unused function

All references have since been deleted.

Change-Id: I69943f33c6c555f5cc596bb2f7609c4873b21be9
Signed-off-by: William A. Kennington III <wak@google.com>

ethernet_interface: Disable opportunistic DHCPv6 if disabled

Users who have DHCPv6 disabled do not expect that it becomes enabled
when an RA is received with the DHCP bit set. This syncs the DHCP
se

ethernet_interface: Disable opportunistic DHCPv6 if disabled

Users who have DHCPv6 disabled do not expect that it becomes enabled
when an RA is received with the DHCP bit set. This syncs the DHCP
settings in systemd to remain consistent with the DHCP intention.

Change-Id: I4159a9c7ba987312e1fcc019170b9f33fe0f21dd
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Remove superfluous logging

The message printed is not necessary and doesn't affect any of the
behavior of the application. It also makes the logic of detecting DHCP
enablement mo

ethernet_interface: Remove superfluous logging

The message printed is not necessary and doesn't affect any of the
behavior of the application. It also makes the logic of detecting DHCP
enablement more complicated.

Change-Id: Ifdbabf8293a364b7b6751e988539b90002fc4911
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

network_manager: Reloads should be delayed via timer

Our restarts of systemd waited a short amount of time (3s) prior to
triggering in the past and didn't cause it to reconfigure immediately.
This a

network_manager: Reloads should be delayed via timer

Our restarts of systemd waited a short amount of time (3s) prior to
triggering in the past and didn't cause it to reconfigure immediately.
This allowed lan users to queue up a bunch of configuration commands
that would reconfigure the network before it applied.

This patch restores that behavior.

Change-Id: I4c3c589c07528a9d90e6d7e5d3b649688fcf4587
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Defer setting NIC enabled

This is purely for consistency, to ensure that the network update only
happens once networkd is reloaded.

Change-Id: I4fc4a62a15cb32eb691d612c510adc729

ethernet_interface: Defer setting NIC enabled

This is purely for consistency, to ensure that the network update only
happens once networkd is reloaded.

Change-Id: I4fc4a62a15cb32eb691d612c510adc729559e767
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Defer link down for MAC change

We don't want the interface to become unavailable until right before a
reload is triggered. Right now this is okay because reloads happen
instantan

ethernet_interface: Defer link down for MAC change

We don't want the interface to become unavailable until right before a
reload is triggered. Right now this is okay because reloads happen
instantaneously. A follow up patch will defer reloads for a set amount
of time, and we don't want the NIC to be down for the entire time.

Change-Id: I3ad7ed0deb0a3154535f85e1a26a00add123b518
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...