system_queries: Log NIC up / down actions

This will help when debugging reconfiguration issues.

Change-Id: I3d5d9fe054b8afce47ea4fec4d4cb0ff3271f353
Signed-off-by: William A. Kennington III <wak@go

system_queries: Log NIC up / down actions

This will help when debugging reconfiguration issues.

Change-Id: I3d5d9fe054b8afce47ea4fec4d4cb0ff3271f353
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Fix race condition for mac setting

We have observed that if systemd-networkd reload is invoked by some
other process after a mac config kick off but before the real
phosphor-networkd reload, the int

Fix race condition for mac setting

We have observed that if systemd-networkd reload is invoked by some
other process after a mac config kick off but before the real
phosphor-networkd reload, the interface will be down and never be
brought back up. This CL ensures that the reload happens by touching
the config file.

Change-Id: I094b4dd71b37bb3b61837ee49a3b6d244cc8fe86
Signed-off-by: Yuxiao Zhang <yuxiaozhang@google.com>

show more ...

Revert "ethernet_interface: Fix link local autoconfiguration functio

This reverts commit 721d8f75fb6d8d22cc4afc11b06288a47a1a600d.

Commit 721d8f75 causes undesirable behavior when working with Link

Revert "ethernet_interface: Fix link local autoconfiguration functio

This reverts commit 721d8f75fb6d8d22cc4afc11b06288a47a1a600d.

Commit 721d8f75 causes undesirable behavior when working with Link
Local addresses.

Automatic Link Local addressing needs to allow the systemd-network
stack to automatically add/remove a link local address. When DHCPv4
addressing is enabled the link local needs to be automatically
disabled. When DHCPv4 addressing is disabled the link local address
must automatically be activated.

With commit 721d8f75 active this behavior does not occur. What happens
instead is when DHCPv4 is disabled, and then re-enabled a STATIC Link
Local address is added to the networkd.conf file. Once there the Link
Local address is present until actively removed. This causes the Link
Local addressing to quit being "automatic".

Automatic Link Local addressing creates an address with the "scope"
assigned to LINK_LOCAL_AUTOCONFIGURATION, and a "address origin" equal
to IP::AddressOrigin::Static (i.e. IFA_F_PERMANENT is true).

ethernet_interface.cpp addAddr(): adr: 169.254.147.57/16 scp:
000000fd flg: 00000080
ethernet_interface.cpp addAddr(): adr: fe80::207:e9ff:fe34:3c6f/64
scp: 000000fd flg: 00000080

There are also undesirable side effects in the IPMI Get LAN
Configuration command when querying IPv6 Dynamic Addresses (Param
59). The Link Local address now gets included in the DHCPv6 assigned
addresses despite the IFA_F_PERMANENT flag being asserted.

Tested:
Reverted the commit.
Disabled and Enabled DHCPv4 and confirmed 169.x.x.x addresses are no
longer written to the network.conf file.
Confirmed LLv6 addresses are no longer reported via the IPMI Get LAN
Config command.

Change-Id: I272653dca61b96b360f03dfdf00d7ca57b7e0b63
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

inventory_mac: Fix Update MAC for eth1

Whenever the network daemon starts, and if the inventory manager has
already started, then networkd should read the MAC address from the
inventory and update t

inventory_mac: Fix Update MAC for eth1

Whenever the network daemon starts, and if the inventory manager has
already started, then networkd should read the MAC address from the
inventory and update the dbus object and configuration file.

Currently, this is being done for just eth0 interface and is exiting
before updating the MAC on eth1.

This commit fixes the above issue.

Tested-By:
* Restarted network manager service; checked MAC on both
inventory and network dbus & config files.
* Checked for both reboot and factory reset usecases.

Change-Id: I49d94f22d914f74c23999a5fe175bfc4d97759a9
Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>

show more ...

DHCP: Populate nameservers D-bus property from resolv.conf

Currently when DHCP enabled, nameservers D-bus property does not have
updated DHCP provided nameservers.

This commit populates nameservers

DHCP: Populate nameservers D-bus property from resolv.conf

Currently when DHCP enabled, nameservers D-bus property does not have
updated DHCP provided nameservers.

This commit populates nameservers D-bus property from resolv.conf

Tested By: verify nameservers D-bus property value with DHCP
enable/disable

Change DHCP server nameservers configuration & verify name servers
D-bus property updated on the interface.

Change-Id: If1a2508927d5f4f0c9c5d8b3f533fdf384d68821
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

network_manager: Explicitly capture references in cb

We were accidentally capturing a reference to a stack variable and not
guaranteeing that we have an unmoving reference to the object being
refere

network_manager: Explicitly capture references in cb

We were accidentally capturing a reference to a stack variable and not
guaranteeing that we have an unmoving reference to the object being
referenced in the callback.

Change-Id: Ib16d264a5a1170ac6d11979d32800dce90a11a33
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Fix configuration

Include config.h to satisfy #ifdefs used in code.
Fixes config 'persist-mac' and 'uboot-env' having no effect.

Change-Id: I27a4984dc069871dc757388494fcf145069a

ethernet_interface: Fix configuration

Include config.h to satisfy #ifdefs used in code.
Fixes config 'persist-mac' and 'uboot-env' having no effect.

Change-Id: I27a4984dc069871dc757388494fcf145069a6143
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

show more ...

hyp_ethernet_interface: add missing header

There was an assumption that an sdbus++ header file was implicitly
included, but the generated files are changing. Explicitly add that
header.

Change-Id:

hyp_ethernet_interface: add missing header

There was an assumption that an sdbus++ header file was implicitly
included, but the generated files are changing. Explicitly add that
header.

Change-Id: I48519bfe5e07d648c26c339f8b59d6a70ee9f997
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

ethernet_interface: IPv6 Gateway is dynamic based on RA

The previous logic is technically incorrect, the gateway does not come
from DHCPv6 as the protocol is not intended to communicate the gateway.

ethernet_interface: IPv6 Gateway is dynamic based on RA

The previous logic is technically incorrect, the gateway does not come
from DHCPv6 as the protocol is not intended to communicate the gateway.
Instead, this value is dynamic based on RA.

Change-Id: I1167204efaed422ef616250f34d181bc29666a75
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsi_util: Cleanup joins over ranges

We can change these to std::format once we have c++23

Change-Id: If2cabd2ca57333549ca82e30f4953e7d3407ee72
Signed-off-by: William A. Kennington III <wak@google.

ncsi_util: Cleanup joins over ranges

We can change these to std::format once we have c++23

Change-Id: If2cabd2ca57333549ca82e30f4953e7d3407ee72
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

treewide: Convert most fmt::format -> std::format

Change-Id: I3c9ac1eed1c86c6cd9f7fd3a1ba356734e79f937
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Remove uses of FMT_COMPILE

We can use stdplus::strCat which takes even less code space.

Change-Id: I91185afa7f5d9041ca7477eb19d5d53755ed329d
Signed-off-by: William A. Kennington III <wak@

treewide: Remove uses of FMT_COMPILE

We can use stdplus::strCat which takes even less code space.

Change-Id: I91185afa7f5d9041ca7477eb19d5d53755ed329d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

treewide: Replace fmt::print with stdplus::print

Change-Id: I9b6ea48931496bf2ca6ab480e3a3795488f2ff61
Signed-off-by: William A. Kennington III <wak@google.com>

netlink: Use stdplus function_view

We are trying to get rid of function2 dependencies.

Change-Id: I7cd750b279e7e83b2c71f1c6cc53a114daf4532c
Signed-off-by: William A. Kennington III <wak@google.com>

Update the error on deleting a link local address

It is in reference to https://github.com/openbmc/openbmc/issues/2342

Currently, when a user tries to delete a non-static ip address,
it throws an e

Update the error on deleting a link local address

It is in reference to https://github.com/openbmc/openbmc/issues/2342

Currently, when a user tries to delete a non-static ip address,
it throws an error as "the operation failed internally"

With the update, when an attempt is made to delete the link-local
address of the bmc it throws "The operation is not allowed" error

Tested by:

Current behaviour:

busctl call xyz.openbmc_project.Network
/xyz/openbmc_project/network/eth1/_66e80_3a_3aa94...
xyz.openbmc_project.Object.Delete Delete

response: Call failed: The operation failed internally.

Modified behaviour:

busctl call xyz.openbmc_project.Network
/xyz/openbmc_project/network/eth1/_66e80_3a_3aa94...
xyz.openbmc_project.Object.Delete Delete

response: Call failed: The operation is not allowed

Change-Id: Ib5df33b8ad356a868aecc508ad6531ed15390a1d
Signed-off-by: Jishnu CM <jishnunambiarcm@duck.com>

show more ...

Fix IPv4 DHCP address origin

This commit popluates DHCPv4 address origin.

Tested By:
Check origin of LinkLocal IPv4 and IPv6 addresses.
Enable DHCPv4 and check origin of DHCP IP
Assign static addre

Fix IPv4 DHCP address origin

This commit popluates DHCPv4 address origin.

Tested By:
Check origin of LinkLocal IPv4 and IPv6 addresses.
Enable DHCPv4 and check origin of DHCP IP
Assign static address and check origin of static address
Enable DHCv6 and check origin of DHCP addresses
Enable DHCPv6 stateless addresses and check origin

Change-Id: I1d35829cf5b0c981621b5d476ac349567d8d9bdd
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

Populate address origin based on ifa_flags

Currently origin of ip address is populated based on DHCP enabled flag
so when DHCP is enabled then all static addresses are marked as DHCP
addresses and w

Populate address origin based on ifa_flags

Currently origin of ip address is populated based on DHCP enabled flag
so when DHCP is enabled then all static addresses are marked as DHCP
addresses and when DHCP is disabled all static addresses marked as
Static addresses.

This commit populates address origin based on ifa_flags from rtnetlink
message to fix this address origin issue.

Tested by: Check origin of D-bus object for different type of v4/v6
addresses Verified DHCPv4/v6 enable, disable with static addresses
configured.

Change-Id: I554e9353107ba62b638654d91b5dfe2c6ee90a03
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

ethernet_interface: Fix link local autoconfiguration functionality

When this option "default-link-local-autoconf" be enabled by default,
that will enable link local autoconfiguration feature. Howeve

ethernet_interface: Fix link local autoconfiguration functionality

When this option "default-link-local-autoconf" be enabled by default,
that will enable link local autoconfiguration feature. However, seems
the logical is mismatch in EthernetInterface::originIsManuallyAssigned.
Fix the logical to match code with option for correct functionality.

Change-Id: I5a4493d1230caef60031e7b366bc41da7b5e82f4
Signed-off-by: Tim Lee <timlee660101@gmail.com>

show more ...

treewide: Fix some aditional cases missing pinning

Change-Id: I8e832d5d2cf960c5139b6f9e54b63ab17beec137
Signed-off-by: William A. Kennington III <wak@google.com>

network_manager: Upgrade delayed executor to be more generically useful

We can now use this in more parts of the codebase and with timeouts that
have more precision than 1 second.

Change-Id: I77c67

network_manager: Upgrade delayed executor to be more generically useful

We can now use this in more parts of the codebase and with timeouts that
have more precision than 1 second.

Change-Id: I77c677230df6c288b29cd0895fe36f3f0158b393
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Validate IP addresses

We don't want multicast or link local addresses to be assignable as IPs.
Right now they won't do what the user expects and it causes undefined
problems with

ethernet_interface: Validate IP addresses

We don't want multicast or link local addresses to be assignable as IPs.
Right now they won't do what the user expects and it causes undefined
problems with the configuration.

Change-Id: Idefac159b7ce8b53988ddb4501a1c9321b2e6588
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Validate gateway IPs

We don't want to allow loopback, network id, or multicast spaces to be
used for the gateway.

Change-Id: I1ff762268321f8c0dacb760611cce8383d880997
Signed-off

ethernet_interface: Validate gateway IPs

We don't want to allow loopback, network id, or multicast spaces to be
used for the gateway.

Change-Id: I1ff762268321f8c0dacb760611cce8383d880997
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Empty address also deletes the gateway

Since the address is invalid anyway, this is a straightforward way to
clear the entry.

Change-Id: I7c130d0e3c3c0d182e8a7c54d53be44b4ffe47a

ethernet_interface: Empty address also deletes the gateway

Since the address is invalid anyway, this is a straightforward way to
clear the entry.

Change-Id: I7c130d0e3c3c0d182e8a7c54d53be44b4ffe47a7
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Refactor gateway setting

Reduce duplication and re-use code.

Change-Id: Id0919c03f439af60f3e4e65860f22e4b61e609a1
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Add clang-tidy

Change-Id: I1aab00b0ff8c016650225fcd1c83678a91808941
Signed-off-by: William A. Kennington III <wak@google.com>