network_manager: Allow faster non-reconfiguration reloads

The main reason we wait so long for reloads is because we need to be
sure it captures all of the reconfiguration data. Delay the reload time

network_manager: Allow faster non-reconfiguration reloads

The main reason we wait so long for reloads is because we need to be
sure it captures all of the reconfiguration data. Delay the reload timer
around reconfiguration to ensure we can lower the value sanely for
non-reconfiguration reloads.

Change-Id: I9b68d9330ee89e52f5adf364941a39b65eb8a336
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

routing_table: Remove unused Entry class

The Entry class is no longer used.

Tested:
Build pass.

Change-Id: Id111aeb6f53fde6a67d564ff0716aebf0b6f7fa3
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel

routing_table: Remove unused Entry class

The Entry class is no longer used.

Tested:
Build pass.

Change-Id: Id111aeb6f53fde6a67d564ff0716aebf0b6f7fa3
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ief1b330c4f623ecc1be771f36083780a12260834

show more ...

Adding system configuration object & UT

This commit adds the system config object that implements
the SystemConfiguration interface.

The hostname property under this interface will initially
be set

Adding system configuration object & UT

This commit adds the system config object that implements
the SystemConfiguration interface.

The hostname property under this interface will initially
be set from the bios table when the service starts.

Whenever user sets the property, the same will be updated
in the bios table.

busctl tree xyz.openbmc_project.Network.Hypervisor
└─/xyz
└─/xyz/openbmc_project
└─/xyz/openbmc_project/network
└─/xyz/openbmc_project/network/hypervisor
└─/xyz/openbmc_project/network/hypervisor/config

Tested By:

busctl set-property xyz.openbmc_project.Network.Hypervisor
/xyz/openbmc_project/network/hypervisor/config
xyz.openbmc_project.Network.SystemConfiguration HostName s "vmi HN"

busctl introspect xyz.openbmc_project.Network.Hypervisor /xyz/openbmc_project/network/hypervisor/config
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Network.SystemConfiguration interface - - -
.DefaultGateway property s "" emits-change writable
.DefaultGateway6 property s "" emits-change writable
.HostName property s "vmi HN" emits-change writable

busctl call xyz.openbmc_project.BIOSConfigManager /xyz/openbmc_project/bios_config/manager xyz.openbmc_project.BIOSConfig.Manager GetAttribute s vmi_hostname
svv "xyz.openbmc_project.BIOSConfig.Manager.AttributeType.String" s "vmi HN" s ""

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: Ib3afaef2da039d18cc672a1759b721698f9c14e2

show more ...

Add testcases for hypervisor nw manager

This commit includes three changes:
1. Add testcases for hypervisor nw manager
2. Removal of vmi_if_count support, as it is no longer
available in the bios

Add testcases for hypervisor nw manager

This commit includes three changes:
1. Add testcases for hypervisor nw manager
2. Removal of vmi_if_count support, as it is no longer
available in the bios table
3. Add methods to set default values to bios table
attributes

Tested.

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I78397f653658c88097e4566632b0ce36c7b3861b

show more ...

Fix behavior when writing MAC address is disabled

Current code only doesn't write MAC address to systemd-network config
file, the behavior of writing MAC address on DBus remains the same.
Writing th

Fix behavior when writing MAC address is disabled

Current code only doesn't write MAC address to systemd-network config
file, the behavior of writing MAC address on DBus remains the same.
Writing the MAC address on DBus can be successfully performed and the
value is changed. Though writing MAC address will reload DBus values
from systemd-network config, applications will read wrong MAC address
from DBus during the time before it reloads. And when compiled with
uboot-env=true, it still updates the MAC address in uboot env.

This patch resolves such issue by simply gives a NotAllowed error when
writing MAC address is disabled.

Tested:
Build with persist-mac=false
* Writing MAC address on DBus gives NotAllowed error.
* Updating MAC address from Redfish and IPMI returns error.

Change-Id: I32a81fe5ddac0c02209a785c6d595fdaf2456e3e
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

Delete DHCP IP object while moving from DHCP to static

Currently when DHCP is enabled, if user configures same DHCP IP
as static IP config then networkd disable DHCP, fails to add
static entry and r

Delete DHCP IP object while moving from DHCP to static

Currently when DHCP is enabled, if user configures same DHCP IP
as static IP config then networkd disable DHCP, fails to add
static entry and return error to the client.

This issue only seen if user configures static IP which is same as
DHCP IP.

Tested by:
Configured same DHCP IP as static IP via redfish

Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>
Change-Id: I7b703c0e70867f79212c3f8955d7f88d22b8328a

show more ...

Check existance on VLAN creation

This patch checks if the VLAN ID has already been used on the interface
when creating new VLANs.

Tested:
Creating VLAN with existing VLAN ID gives InvalidArgument e

Check existance on VLAN creation

This patch checks if the VLAN ID has already been used on the interface
when creating new VLANs.

Tested:
Creating VLAN with existing VLAN ID gives InvalidArgument error.

Change-Id: I73b4a932756863cec79d52f17fd462a20c99770b
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

Validate VLAN id on creation

As per IEEE 802.1Q, VLAN ID is a 12-bit unsigned value with 0 and 4095
being reserved. This patch adds check for the VLAN ID when creating
VLAN interface.

Tested:
Creat

Validate VLAN id on creation

As per IEEE 802.1Q, VLAN ID is a 12-bit unsigned value with 0 and 4095
being reserved. This patch adds check for the VLAN ID when creating
VLAN interface.

Tested:
Creating VLAN with invalid IDs like 0, 4095, 9999 on a valid interface
gives InvalidArgument error.

Change-Id: I27ccd3657b4e411c530762d6076902f22c7cbf5a
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

systemd: drop SyslogIdentifier

This is the default behavior, so specifing it is unnecessary.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I8a48acd733c84d3d3bc34b08d135d9cd1b4

systemd: drop SyslogIdentifier

This is the default behavior, so specifing it is unnecessary.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I8a48acd733c84d3d3bc34b08d135d9cd1b4a771c

show more ...

systemd: use qualified paths

Fix a documented anti-pattern:
https://github.com/openbmc/docs/blob/master/anti-patterns.md#use-of-usrbinenv-in-systemd-service-files

Signed-off-by: Brad Bishop <bradle

systemd: use qualified paths

Fix a documented anti-pattern:
https://github.com/openbmc/docs/blob/master/anti-patterns.md#use-of-usrbinenv-in-systemd-service-files

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Ia2c78f0d39982754f1758b2e6bd89cd8b3591c0d

show more ...

Fix the failure of calling GetSubTreePaths to get the path

Since upstream updated sdbusplus (sdbusplus: object: don't use 'bool'
argument constructor), now we can't get the newly added object path
t

Fix the failure of calling GetSubTreePaths to get the path

Since upstream updated sdbusplus (sdbusplus: object: don't use 'bool'
argument constructor), now we can't get the newly added object path
through GetSubTreePaths/GetSubTree, so need to set action::defer_emit
to delay emitting object.

Tested:
busctl call xyz.openbmc_project.Network /xyz/openbmc_project/network xyz.openbmc_project.Network.VLAN.Create VLAN su eth0 100
busctl call xyz.openbmc_project.ObjectMapper /xyz/openbmc_project/object_mapper xyz.openbmc_project.ObjectMapper GetSubTreePaths sias /xyz/openbmc_project/network 0 2 xyz.openbmc_project.Network.VLAN xyz.openbmc_project.Network.EthernetInterface --verbose
MESSAGE "as" {
ARRAY "s" {
STRING "/xyz/openbmc_project/network/eth0";
STRING "/xyz/openbmc_project/network/eth0_100";
STRING "/xyz/openbmc_project/network/eth1";
};
};

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia9bb76cb7b4944e25236509667a2706c178e8ab2

show more ...

network_config: Enable [DHCP] option parameters by default

After factory reset, ethernet interfaces are set to DHCP as
expected. But the DNS and NTP servers are not requested.

This commit adds the

network_config: Enable [DHCP] option parameters by default

After factory reset, ethernet interfaces are set to DHCP as
expected. But the DNS and NTP servers are not requested.

This commit adds the [DHCP] options to the default network
file so that the DHCP REQUEST asks for the required options
from the DHCP server when fetching the fresh lease

Tested by:
1. Factory reset the BMC and check if the DHCP request is sent
for DNS and NTP etc
2. Verify the default network file

Signed-off-by: sunharis <sunharis@in.ibm.com>
Change-Id: I082694834a427400bfbfe2b2b0f871b0ecaee47b

show more ...

ethernet_interface: Add UseDomains option to network file

When the interface is DHCP enabled, domain-search value 119
is not requested by the DHCP client.

This commit adds the UseDomains option to

ethernet_interface: Add UseDomains option to network file

When the interface is DHCP enabled, domain-search value 119
is not requested by the DHCP client.

This commit adds the UseDomains option to network file
so that when the DNS is enabled, the domain-search option
is requested via DHCP REQUEST, and search list provided by DHCP
server are pulled to the DHCP lease and the resolv.conf

Fixes https://github.com/openbmc/phosphor-networkd/issues/47

Tested by:
1.Enable DNS option at BMC and check the DHCP REQUEST packet for
option 119
2.Verify the list 'option domain-search' at the DHCP server is
fetched by the DHCP lease file at BMC
3.Verify the same list is added to the search list at resolv.conf

Signed-off-by: sunharis <sunharis@in.ibm.com>
Change-Id: I2f6ca7236bf3b5e7d3ded9294b8372d95ac50ac6

show more ...

Remove gateway properties in SystemConfiguration

Now default gateway are per-interface properties, the system-wide one
in the SystemConfiguration interface is deprecated. Updating the value
also mak

Remove gateway properties in SystemConfiguration

Now default gateway are per-interface properties, the system-wide one
in the SystemConfiguration interface is deprecated. Updating the value
also makes no difference, it will never be written to configuration.
This patch removes the code of initializing and updating them.

Change #52785 removes the properties in phosphor-dbus-interfaces yaml,
it is recommended to be merged after this change.

Tested:
In SystemConfiguration interface, DefaultGateway and DefaultGateway6 are
still there, but writing them only updates the displayed value on DBus.
No code in phosphor-networkd is called.

Change-Id: I58ac52c5318943941dcc92abede7763bddbca596
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

ncsi-netlink: Remove phosphor-logging dependency

As a CLI application, ncsi-netlink should use stderr for error messages
instead of phosphor-logging. This commits converts all phosphor-logging
logs

ncsi-netlink: Remove phosphor-logging dependency

As a CLI application, ncsi-netlink should use stderr for error messages
instead of phosphor-logging. This commits converts all phosphor-logging
logs calls to std::cerr and removes phosphor_logging_dep in meson file.

Tested:
Build pass.

Change-Id: I02227e31feab080c03d514b65dbeec4059867385
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

Allow unset default gateway

Default gateway addresses cannot be unset in current implementation as
it requires a valid IP address and writes it to systemd.network files
every time. This patch suppor

Allow unset default gateway

Default gateway addresses cannot be unset in current implementation as
it requires a valid IP address and writes it to systemd.network files
every time. This patch supports setting empty string on DefaultGateway
and DefaultGateway6 DBus properties to unset the value as empty strings
will not be written to config file.

Tested:
Disable DHCP and set default gateway for both IPv4 and IPv6, then set
empty string on DefaultGateway and/or DefaultGateway6, verified the
corresponding [Route] section is removed in config file.

Change-Id: I3be81f9c7c605b12cb225beeefec02f9841b0dcd
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.

Change-Id: I2e7ce5e279d65d101e1249f2b41f126143d3f03d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id8a090

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id8a0909445b38271c0cdea79bad0ca9198cf7f0a

show more ...

ResourceNotFound: Add RESOURCE field to exception

Change Id1e07b42bc3fb13ff45284342976b94734370402 is adding a RESOURCE
field to the phosphor-logging metadata for Common.ResourceNotFound.
Leverage i

ResourceNotFound: Add RESOURCE field to exception

Change Id1e07b42bc3fb13ff45284342976b94734370402 is adding a RESOURCE
field to the phosphor-logging metadata for Common.ResourceNotFound.
Leverage it here as well.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I63598474c82aa8d704c034465ad1735ff5146a77

show more ...

Allow writing MAC address to networkd config file to be blocked

The systemd.networkd configuration file can store the MAC
address. This allows the MAC address to be changed on demand. This
feature m

Allow writing MAC address to networkd config file to be blocked

The systemd.networkd configuration file can store the MAC
address. This allows the MAC address to be changed on demand. This
feature may not desirable to some vendors. Server suppliers may prefer
to have an immutable MAC address.

The change here adds a compile time switch that enables/disables
writing the MAC address to the configuration file.

Tested:
Confirmed the default configuration permitted the MAC address to be written to
the configuration file.
Added a OEMESON override to the phosphor-network.bbappend file and
confirmed the MAC address no longer gets written.

Change-Id: Ic1eb69980cea6864a30dac93dd472ba9e0e2c1a9
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

ethernet_interface: Remove custom socket holder

This object was not move safe, so we ended up creating use after close
issues when handling the previous socket object.

Change-Id: I04887357c4f2953ac

ethernet_interface: Remove custom socket holder

This object was not move safe, so we ended up creating use after close
issues when handling the previous socket object.

Change-Id: I04887357c4f2953ac1714c834b7fd68cb2d25b44
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Fix nicEnabled property ordering

This should have been set prior to writing the configuration file,
otherwise the incorrect value gets written and the interface doesn't get
updat

ethernet_interface: Fix nicEnabled property ordering

This should have been set prior to writing the configuration file,
otherwise the incorrect value gets written and the interface doesn't get
updated.

Change-Id: I970495ad8817f406252afccc1bb4291193d4bf61
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

An application for hypervisor network configuration

This application takes care of hypervisor network configuration
by communicating with the bios-settings-mgr in the backend.

It hosts xyz.openbmc_

An application for hypervisor network configuration

This application takes care of hypervisor network configuration
by communicating with the bios-settings-mgr in the backend.

It hosts xyz.openbmc_project.Network.Hypervisor.service similar
to that of network service and implements system config, ethernet
and ip interfaces whose properties are mapped to the appropriate
properties in the base bios table.

The flow will be like:
- User fires the redfish command to update hypervisor
network configuration properties
- BMCWeb updates the properties in the dbus object
hosted by this application
- This application would update these new values in
the base bios table

This is divided into multiple commits and this commit
hosts xyz.openbmc_project.Network.Hypervisor.service and
creates the /xyz/openbmc_project/network/hypervisor object.

Tested By:

busctl tree xyz.openbmc_project.Network.Hypervisor
└─/xyz
└─/xyz/openbmc_project
└─/xyz/openbmc_project/network
└─/xyz/openbmc_project/network/hypervisor

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I2d4582bc9c1dbf72c9963f3e43169b695b34b1ed

show more ...

util: fromString: Reduce string allocations

Change-Id: Ie6f7fa5dcc958081e7d7e2b880c17fe3548955a7
Signed-off-by: William A. Kennington III <wak@google.com>