util: isValidIP should be noexcept

Change-Id: Ia61742dc253a0a1cfce7e9659c1bb75a2f979cc7
Signed-off-by: William A. Kennington III <wak@google.com>

util: Refactor addrFromBuf

Change-Id: I1b2deed483eb25034ca9b4717388119af3da1c8d
Signed-off-by: William A. Kennington III <wak@google.com>

util: Remove unused toMask

Change-Id: I48a2af176e4f79a50de32092c92adf254e33aab9
Signed-off-by: William A. Kennington III <wak@google.com>

util: Refactor isValidPrefix to reduce address family re-use

Change-Id: I13abd5b110709210b98b4ea74e3129c3ab42bd46
Signed-off-by: William A. Kennington III <wak@google.com>

util: Fix mac truncation

We don't want to allow MACs to be silently truncated.

Change-Id: I1d2771c481bccb30e957b829fd1db1e4db0dc051
Signed-off-by: William A. Kennington III <wak@google.com>

util: Don't directly include config_parser.hpp

Change-Id: I6a228697d0b6d1767bf6f10b3f375e78cd8a623d
Signed-off-by: William A. Kennington III <wak@google.com>

netlink: Improve error output

Change-Id: I56a1b83e460ce42dad4a0f562d4240940f7f8005
Signed-off-by: William A. Kennington III <wak@google.com>

Move InterfaceList back to set

There are duplicated entries in InterfaceList and causing dbus object
creation failures for
- /xyz/openbmc_project/network/config
- /xyz/openbmc_project/network/config

Move InterfaceList back to set

There are duplicated entries in InterfaceList and causing dbus object
creation failures for
- /xyz/openbmc_project/network/config
- /xyz/openbmc_project/network/config/dhcp

Example Failure,
```
$ /tmp/phosphor-network-manager &
[1] 23394
$ busctl tree xyz.openbmc_project.Network
`-/xyz
`-/xyz/openbmc_project
`-/xyz/openbmc_project/network
$ sdeventplus: timeCallback: sd_bus_add_object_vtable: org.freedesktop.DBus.Error.FileExists: File exists
busctl tree xyz.openbmc_project.Network
`-/xyz
`-/xyz/openbmc_project
`-/xyz/openbmc_project/network
|-/xyz/openbmc_project/network/dummy0
| |-/xyz/openbmc_project/network/dummy0/ipv4
...
```

Tested:
The object is created with no error now.

Signed-off-by: Willy Tu <wltu@google.com>
Change-Id: Iaf91ceee118a4bd32ec8277e0c1372ccab1cb9d9

show more ...

util: Cleanup usage of string types

Change-Id: I8fd459dd9cf42974b62176384b25cf57c48fba79
Signed-off-by: William A. Kennington III <wak@google.com>

main: Catch and handle all exceptions

Change-Id: I75a04860fe0647ca655fcbc9c9bd674199ba13e5
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Cleanup unused includes

Change-Id: Ied2a0d97d2c31dc2b370452768a7f41d9ecf07f3
Signed-off-by: William A. Kennington III <wak@google.com>

util: Combine systemd value parsers

We want to use the same function for parsing out the last property of
a systemd file. This combines all of the lookups into a single function.

Change-Id: I590d31

util: Combine systemd value parsers

We want to use the same function for parsing out the last property of
a systemd file. This combines all of the lookups into a single function.

Change-Id: I590d31e5e1019cd38a78d640188e486b8854a544
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Support DHCP4/6 Properties

We are splitting the DHCPEnabled option into 3 new options to reflect
all of the desired states (DHCP4, DHCP6, IPv6AcceptRA). We will
still support DHC

ethernet_interface: Support DHCP4/6 Properties

We are splitting the DHCPEnabled option into 3 new options to reflect
all of the desired states (DHCP4, DHCP6, IPv6AcceptRA). We will
still support DHCPEnabled until all of the old users have transitioned
away. This commit makes DHCPEnabled a view / modifier of the other
options.

Tested: Toggled the DHCPEnabled settings on a BMC and verified that the
state updated correctly along with the other properties to affects.
Verified that changing the individual properties updates the DHCPEnabled
property to the correct enum state.

Change-Id: I2cef15d7eaf80c8d717a11d090f61ca5d275821a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Remove DHCP from constructor

It should be set or configured just like all other parameters.

Change-Id: Ic93de4e80b4da0de2e97b9655c424fa55a6844bf
Signed-off-by: William A. Kennin

ethernet_interface: Remove DHCP from constructor

It should be set or configured just like all other parameters.

Change-Id: Ic93de4e80b4da0de2e97b9655c424fa55a6844bf
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

network_config: Write configs from parser

Tested: Booted up a clean RWFS and saw that the configs were written
correctly from networkd.

Change-Id: I0915571f87ec803b127cd8c51af37832a2720fdd
Signed-o

network_config: Write configs from parser

Tested: Booted up a clean RWFS and saw that the configs were written
correctly from networkd.

Change-Id: I0915571f87ec803b127cd8c51af37832a2720fdd
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

network_config: Sync default values

Change-Id: Ica6b2177138b30135c1a060475955a1ae53569e3
Signed-off-by: William A. Kennington III <wak@google.com>

vlan_interface: Write configs from parser

This guarantees the values are valid and that the file is always swapped
out atomically instead of written piecewise

Tested: Manually created and modified

vlan_interface: Write configs from parser

This guarantees the values are valid and that the file is always swapped
out atomically instead of written piecewise

Tested: Manually created and modified a VLAN device and saw that the
config options were persisted to the RWFS

Change-Id: Ia3d61110ba54ec6b7ed5be61192c90fbaaf20764
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Write configs from parser

This guarantees the values are valid and that the file is always swapped
out atomically instead of written piecewise.

Tested: Manually executed setting

ethernet_interface: Write configs from parser

This guarantees the values are valid and that the file is always swapped
out atomically instead of written piecewise.

Tested: Manually executed settings changes on the BMC and saw them
persist to the RWFS as expected.

Change-Id: I719c856e713ce054726cc7f2f7844c0539b631b6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Add function for writing files

This will be used by the configuration writers shortly.

Change-Id: I6e72b181e365e34808c8e5e4790c446124dc13a3
Signed-off-by: William A. Kennington III <

config_parser: Add function for writing files

This will be used by the configuration writers shortly.

Change-Id: I6e72b181e365e34808c8e5e4790c446124dc13a3
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Allow modifying Parser map

This makes it possible to mutate the map owned by the parser. This will
eventually be used for implementing write updates.

Change-Id: I89deb4073a0a3bd59528

config_parser: Allow modifying Parser map

This makes it possible to mutate the map owned by the parser. This will
eventually be used for implementing write updates.

Change-Id: I89deb4073a0a3bd59528c6b70fc55b49bc6cd944
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Add type checking to config map

In order to guarantee the output file is consistent, the
constructed values are checked for safety.

Change-Id: Ib70e369471e9f2f47a1cdb5522f4a3bebc3780

config_parser: Add type checking to config map

In order to guarantee the output file is consistent, the
constructed values are checked for safety.

Change-Id: Ib70e369471e9f2f47a1cdb5522f4a3bebc37805e
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Split up sections

We can't always combine sections together in network files as sections
like

[Address]
Address=::1/128
Peer=fe80::1
[Address]
Address=::2/128
Peer=fe80::2

Require t

config_parser: Split up sections

We can't always combine sections together in network files as sections
like

[Address]
Address=::1/128
Peer=fe80::1
[Address]
Address=::2/128
Peer=fe80::2

Require that they are grouped accordingly. Rewrite the storage logic of
the config parser to support this logical organization.

Change-Id: I34ae1523202f8770fe3dcac010fb6226dd28b9ec
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Reduce number of file reads

This changes focuses on reducing the number of Parser() constructions to
limit the number of duplicate file reads.

Change-Id: I05df943844c70dc6aa729ab744d

config_parser: Reduce number of file reads

This changes focuses on reducing the number of Parser() constructions to
limit the number of duplicate file reads.

Change-Id: I05df943844c70dc6aa729ab744d2d405cbfe2c76
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Add common boolean parser

This more accurately parses systemd values instead of just comparing to
"false" or "true".

Change-Id: I0d70ef418075d555bf6f090fefa0b34332491ed0
Signed-off-b

config_parser: Add common boolean parser

This more accurately parses systemd values instead of just comparing to
"false" or "true".

Change-Id: I0d70ef418075d555bf6f090fefa0b34332491ed0
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Add parser warnings

This makes it possible to determine if the file had formatting issues
and should be rewritten.

Change-Id: I1a1fd683b5733bff1841703dcd7be99688b66c54
Signed-off-by:

config_parser: Add parser warnings

This makes it possible to determine if the file had formatting issues
and should be rewritten.

Change-Id: I1a1fd683b5733bff1841703dcd7be99688b66c54
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...