ethernet_interface: Reduce error logspam

Change-Id: I53c78556c576f60a6fc1ae74e90d50873f042c35
Signed-off-by: William A. Kennington III <wak@google.com>

system_queries: Migrate system queries into a single place

This provides better separation of the DBus interface and the underlying
system interactions.

Change-Id: I8bf7a44c679ab065f959af19a00c2989

system_queries: Migrate system queries into a single place

This provides better separation of the DBus interface and the underlying
system interactions.

Change-Id: I8bf7a44c679ab065f959af19a00c29897c1d5c48
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

util: Remove unused strings

Change-Id: Id784ea375f3e76bad02db24ecab0e37665183d6d
Signed-off-by: William A. Kennington III <wak@google.com>

vlan_interface: Remove interface name usage

This makes it possible to remove from the dbus interface completely.

Change-Id: I7e572306e75b8494a72a9a2b8bf2ceece6ab168c
Signed-off-by: William A. Kenni

vlan_interface: Remove interface name usage

This makes it possible to remove from the dbus interface completely.

Change-Id: I7e572306e75b8494a72a9a2b8bf2ceece6ab168c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

treewide: Remove redundant inline

Change-Id: Ibfc3d9cad1ae31c46bf432c90e406007e84df4d0
Signed-off-by: William A. Kennington III <wak@google.com>

Move dbus method call into try-catch block

This change is to avoid networkd core dumping in systems
where resolved service is not active. Moving the dbus
call into try block will throw the exception

Move dbus method call into try-catch block

This change is to avoid networkd core dumping in systems
where resolved service is not active. Moving the dbus
call into try block will throw the exception instead of
networkd core dump.

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I547fcb910628fa20312099caa97fa0f76b6d140f

show more ...

Set static & dhcp sent ntp server ip on ethernet obj

Currently there is no way to differentiate between the Static
and DHCP assigned NTP servers at dbus

This commit adds StaticNTPServers peroperty

Set static & dhcp sent ntp server ip on ethernet obj

Currently there is no way to differentiate between the Static
and DHCP assigned NTP servers at dbus

This commit adds StaticNTPServers peroperty to hold the static
configuration of NTP servers. This is a read-write property.
The existing NTPServer propery will hold both static and DHCP
assigned NTP servers. This is a read-only property.

The static and dhcp sent ntp server details are present in the
dbus object hosted by systemd-timesyncd service (mentioned in
Tested By section).

In this change, networkd fetches the ntp server details from the
timesyncd dbus object and set the "NTPServers" property with dhcp sent
ip and "StaticNTPServers" will be set from the configuration file.

Tested By:

* Change the ntp server ips in dhcp config file & restart dhcpd
* timesyncd dbus object contains the new list of ips as below:

busctl introspect org.freedesktop.timesync1 /org/freedesktop/timesync1
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
org.freedesktop.timesync1.Manager interface - - -
.FallbackNTPServers property as 4 "time1.google.com" "time2.google.com"… const
.Frequency property x 0 -
.LinkNTPServers property as 1 "1.1.1.1" -
.NTPMessage property (uuuuittayttttbtt) 0 0 0 0 0 0 0 4 0 0 0 0 0 1844453508490… emits-change
.PollIntervalMaxUSec property t 2048000000 const
.PollIntervalMinUSec property t 32000000 const
.PollIntervalUSec property t 2048000000 -
.RootDistanceMaxUSec property t 5000000 const
.ServerAddress property (iay) 2 4 1 1 1 1 -
.ServerName property s "1.1.1.1" -
.SystemNTPServers property as 0 const

* Since network configuration has changed, the service restarts and
ntp server details are loaded from timesyncd dbus object & config file,
and are set in dbus objects hosted by networkd.

command: busctl introspect xyz.openbmc_project.Network /xyz/openbmc_project/network/eth0
busctl introspect xyz.openbmc_project.Network /xyz/openbmc_project/network/eth1

* Ethernet interface network config files will be updated with NTP=<ip addresses> under [Network]

command: cat /etc/systemd/network/00-bmc-eth0.network
cat /etc/systemd/network/00-bmc-eth1.network

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: If8b1b3ed2afb531f179e00da173f6f86a1bf0c18

show more ...

Treat link-local addresses as static when link
local autoconfig is disabled.

Although a link-local IP can be set via ipmitool (e.g.,
`ipmitool lan set 1 ipaddr 169.254.x.x`), it cannot be read back:

Treat link-local addresses as static when link
local autoconfig is disabled.

Although a link-local IP can be set via ipmitool (e.g.,
`ipmitool lan set 1 ipaddr 169.254.x.x`), it cannot be read back:
`ipmitool lan print 1` reports "IP Address : 0.0.0.0". That's because
phosphor-host-ipmid only considers static and DHCP addresses:

https://github.com/openbmc/phosphor-host-ipmid/blob/master/transporthandler.cpp#L52

Treating a link-local IP as static when autoconfiguration is disabled
allows it to be reported back by "ipmitool lan print".

TESTED: Built with `default-link-local-autoconf=false`. Set a link-local
ip via `ipmitool lan set 1 ipaddr` and verified it is correctly reported
back via `ipmitool lan print 1`.

Signed-off-by: Ali El-Haj-Mahmoud <aaelhaj@google.com>
Change-Id: I4f9871095b8b99dd7e7957babda39d89c5856be2

show more ...

test/ethernet_interface: Improve syscall test coverage

Change-Id: Ia71a030f2e2e19f2cc191992929ef08d0fa917c2
Signed-off-by: William A. Kennington III <wak@google.com>

ethernet_interface: Refactor ethtool querying

This simplifies the amount of parameters pulled and unpacking procedure.

Change-Id: I2991534aeb0fbdda20d4c9b262c1f1a80bf518f8
Signed-off-by: William A.

ethernet_interface: Refactor ethtool querying

This simplifies the amount of parameters pulled and unpacking procedure.

Change-Id: I2991534aeb0fbdda20d4c9b262c1f1a80bf518f8
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Add error logging for ethtool queries

Change-Id: I385476e24bcef61f05350d89433ac2f9e5ce2225
Signed-off-by: William A. Kennington III <wak@google.com>

ethernet_interface: Always try ethtool as we handle unsupported

Change-Id: I5f2e5964f309094b81c1541ba47d4bf9743fa252
Signed-off-by: William A. Kennington III <wak@google.com>

ethernet_interface: Remove unused resolvconf file

Change-Id: Ia3fdaa82c8d456569c1f0909bf9a7a42225523c9
Signed-off-by: William A. Kennington III <wak@google.com>

ethernet_interface: Refactor object hashing

Change-Id: Ic1022410fea18be5508c8fa08a27e4ae1a2d51e0
Signed-off-by: William A. Kennington III <wak@google.com>

ipaddress: Remove obsolete gateway parameter

Change-Id: I0eb7c84951c2277a5c69fb35eb989e7e19bd897d
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Clean up string parameters

Change-Id: I0d3ea6a83465181d3edec1587ff824103489072e
Signed-off-by: William A. Kennington III <wak@google.com>

build: Cleanup subprojects and gitignore

Change-Id: I4bb3d962214084127013adf6eb9012675a614bca
Signed-off-by: William A. Kennington III <wak@google.com>

ethernet_interface: Use string_umaps where sensible

Change-Id: Id30efb0d86e85828b5cd92d401b5bf6002f179ac
Signed-off-by: William A. Kennington III <wak@google.com>

network_manager: Allow direct access to interfaces

Change-Id: I3dc2bb944b8d3a7873e26ce2958a2cb1d9be95af
Signed-off-by: William A. Kennington III <wak@google.com>

network_manager: Inline trivial functions

Change-Id: Id8af08a2d0f64a40899250b33cb5b415c49afaee
Signed-off-by: William A. Kennington III <wak@google.com>

network_manager: Cleanup map type

We want the map type to be a unique_map that allows and type of strings
for comparsion.

Change-Id: I22158e85d90256fe827a0a2fb389acb68bc909a1
Signed-off-by: William

network_manager: Cleanup map type

We want the map type to be a unique_map that allows and type of strings
for comparsion.

Change-Id: I22158e85d90256fe827a0a2fb389acb68bc909a1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

network_manager: Cleanup VLAN creation

This adds proper error handling to the path so that we don't segfault.

Change-Id: I65f39844bd36d9f5f97df33a64f5d07e767dd48c
Signed-off-by: William A. Kenningt

network_manager: Cleanup VLAN creation

This adds proper error handling to the path so that we don't segfault.

Change-Id: I65f39844bd36d9f5f97df33a64f5d07e767dd48c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Simplify hwaddr string

Change-Id: I881f7e53712ebad4762ae34bf55cda8959a0fc97
Signed-off-by: William A. Kennington III <wak@google.com>

util: Add non-family isValidIP

Change-Id: Ib039658d466c0b10b6bc3d1dde9bf5926a124c65
Signed-off-by: William A. Kennington III <wak@google.com>

util: Refactor IP toString

Change-Id: I9aea159e95e5b66d6a02809c3d5832c8697df2e1
Signed-off-by: William A. Kennington III <wak@google.com>