mboxd_flash: strerror() requires errno for argument

Change-Id: I68381ed74ab8b75dac195b53d61fd8ccabcf6fb1
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mboxd_flash: Initialise flash size if necessary

Change-Id: I0587088f72df0664e03977c704da042314580f8a
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

test: Add temporary file helper

Change-Id: Ib102d87232f897ef4c5e7267a56892d22f368f7f
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mboxd_lpc: Split init_lpc_dev() to accomodate custom paths

This enables "dependency injection" of the device path, allowing tests
to supply their own.

Change-Id: Ieffdcc75c26ff5b43782ce5884dd6510b0

mboxd_lpc: Split init_lpc_dev() to accomodate custom paths

This enables "dependency injection" of the device path, allowing tests
to supply their own.

Change-Id: Ieffdcc75c26ff5b43782ce5884dd6510b056d985
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

common: Move get_dev_mtd() to mtd.c

Allows tests to link in alternative implementations of get_dev_mtd()
without losing other functions available in common.c.

Change-Id: I606a83aa9bc59b5fbab1fb11ee

common: Move get_dev_mtd() to mtd.c

Allows tests to link in alternative implementations of get_dev_mtd()
without losing other functions available in common.c.

Change-Id: I606a83aa9bc59b5fbab1fb11ee1e2574c7f6d127
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

gitignore: Update to cover test output

Change-Id: I1cff96b64a4bef13a829b1f5898e18a739275b6c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mboxd_windows: Include mbox.h to make header self-contained

Change-Id: I48ff8175a1e9f6f012e5bed4f7268c5e9b0745e0
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mboxd_flash: Include mbox.h to make header self-contained

Change-Id: Ia8b1c514c2a102db462b376e5dc90c656655420c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mbox: Add includes to header for used types

mbox.h makes use of struct pollfd and bool types, so lets include the
appropriate headers to make the mbox header self-contained.

Change-Id: Ia9e1ce4477a

mbox: Add includes to header for used types

mbox.h makes use of struct pollfd and bool types, so lets include the
appropriate headers to make the mbox header self-contained.

Change-Id: Ia9e1ce4477a510fb9a0fa841f6542327930e02bb
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

common: Add includes for used types

common.h makes use of va_list, stdbool and stdint types, so lets include
them to make the header self-contained.

Change-Id: I3a62bfd80d4f138edee749587330c498e723

common: Add includes for used types

common.h makes use of va_list, stdbool and stdint types, so lets include
them to make the header self-contained.

Change-Id: I3a62bfd80d4f138edee749587330c498e7232f38
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mboxd_flash: Fix infinite loop on EOF

Change-Id: If3684d8c386dd41ce7f7a40353e55267e13d5b07
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mboxd_msg: Remove unreachable break statement

Change-Id: Iaa73c1c02286f9f706e45eda8c1e45f3aa346675
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mboxd_msg: Split init function to enable testing

Allows passing a dev node path through.

Change-Id: Ice3fd8157366b4687fd7f3aac72619a1f0a67fff
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mbox: Clarify sequence number constraints

And implement the specified behaviour.

Change-Id: I268d5896aa8dda3875cd79f4ff18929c8e3aea49
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mbox_msg: Cleanup error strings and whitespace

Change-Id: I6f432ef1b8c6b490c368cccc52044bef300bde84
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mbox: 'regsiter' typo in protocol documentation

Change-Id: Ic78359102aae580dadb4de782f7ea025aaa3f4ad
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mbox: Clarify protocol version negotion

The specification intended that the mbox daemon return its highest
supported protocol version less-than-or-equal to the version requested
by the host. This wa

mbox: Clarify protocol version negotion

The specification intended that the mbox daemon return its highest
supported protocol version less-than-or-equal to the version requested
by the host. This was not clear in the documentation and was not the
behaviour implemented by the daemon.

Fix both the documentation and the daemon to perform to this
expectation.

Change-Id: I6f9cf0b16d2b9319d69656eb26defb46dccd4ddf
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

configure.ac: Update repository URL

Point it to the OpenBMC repository rather than Cyril's personal copy.

Change-Id: I70ead8e871e9f75d0a0f11c3cb4c4ee10b1e79fb
Signed-off-by: Andrew Jeffery <andrew@

configure.ac: Update repository URL

Point it to the OpenBMC repository rather than Cyril's personal copy.

Change-Id: I70ead8e871e9f75d0a0f11c3cb4c4ee10b1e79fb
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mboxd_dbus: Handle errors in reply path

We were seeing some odd errors in the journal, for example:

dbus[736]: [system] Rejected send message, 0 matched rules; type="error", sender=":1.14" (uid=0

mboxd_dbus: Handle errors in reply path

We were seeing some odd errors in the journal, for example:

dbus[736]: [system] Rejected send message, 0 matched rules; type="error", sender=":1.14" (uid=0 pid=773 comm="/usr/sbin/mboxd --flash 64M --verbose --window-siz") interface="(unset)" member="(unset)" error name="org.freedesktop.DBus.Error.UnknownMethod" requested_reply="0" destination=":1.123" (uid=0 pid=2157 comm="/usr/sbin/mboxctl --reset ")

However, coinciding with the deployment of the patched mboxd the errors
went away. This patch shouldn't fix whatever was going on, but at
least we might see some report of problems in the reply codepath if it
occurs again in the future.

Change-Id: I90dc4dd8e69e3fc998ab7f04cbeec37c20c92bcf
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mboxd: Check that window size is indeed a power of 2

The window size can be specified on the command line however we restrict
this to being a power of 2 due to the internal working of the daemon.

C

mboxd: Check that window size is indeed a power of 2

The window size can be specified on the command line however we restrict
this to being a power of 2 due to the internal working of the daemon.

Currently we specify that this is the case in the help message but don't
explicitly verify this when parsing the command line.

Check that if the window size parameter is provided that the value is
indeed a power of 2 and error out if this is not the case.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: I0cb36222d53830996380702802373d862010f503

show more ...

mboxd: Make window size and number optional command line parameters

The window size and number command line parameters are used to control
the number of windows and the size of each of the windows i

mboxd: Make window size and number optional command line parameters

The window size and number command line parameters are used to control
the number of windows and the size of each of the windows in the window
cache which the reserved memory region is divided between.

Most people won't care about tuning these or just won't know what they
refer to. Additionally in the event we change how the window cache
works or allow a non-constant window size then the meaning of these
becomes unclear.

Daemon implementations may also choose to just not implement a cache so
making these required parameters may hurt portability.

Make the window size and number command line parameters optional rather
than required so that they can be largly ignored while people who really
care about tuning them can still do so.

The default for now is to have windows of size 1MB and to map the entire
reserved memory region. That is:
number of windows = size of memory region / size of windows

This means that the size of the reserved memory region can be reduced
and the daemon will adapt to this.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: I7c7bbef6e5d31d1372ec3a755877cacc6c135cce

show more ...

docs: Create Documentation folder and add mboxd and mboxctl documentation

Create a separate folder for documentation called Documentation.

Move the protocol definition into a file in this folder ca

docs: Create Documentation folder and add mboxd and mboxctl documentation

Create a separate folder for documentation called Documentation.

Move the protocol definition into a file in this folder called
mbox_protocol.md and update the README.md to explain the files in the
docs folder.

Also add two other files to the folder called mboxd.md and mboxctl.md
which document the operation of the reference implementations of the
mailbox daemon and the mailbox control program respectively.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: I9f818700ad1e36a396a828f0f085b42cc106b550

show more ...

README: Change open window commands to return actual flash offset

The open window commands now return in part of the response the
acutal flash offset which the window maps. That is the actual
flash

README: Change open window commands to return actual flash offset

The open window commands now return in part of the response the
acutal flash offset which the window maps. That is the actual
flash offset returned is the flash offset of the data which will
be presented at the lpc bus address returned.

Additionally deprecate the window size fields in get_mbox_info as
the window size is no longer fixed or required to be consistent
between windows.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: Ib170d96e66a5f6eb8bc070e56dfe78f1a6b26e57

show more ...

gitignore: Update .gitignore to include mboxctl

Update .gitignore to include the new output file mboxctl.

While we're here add cscope.out since this is often in the project repo.

Signed-off-by: Su

gitignore: Update .gitignore to include mboxctl

Update .gitignore to include the new output file mboxctl.

While we're here add cscope.out since this is often in the project repo.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: I0dd2d8b23bf28a68a740fab7c3fd8c82544975ae

show more ...

mboxctl: Implement mboxctl to facilitate dbus control of the daemon

The daemon can now be controlled by issuing commands over dbus.
Implement a mailbox control program to facilitate communication
wi

mboxctl: Implement mboxctl to facilitate dbus control of the daemon

The daemon can now be controlled by issuing commands over dbus.
Implement a mailbox control program to facilitate communication
with the daemon over dbus.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: I2a11f187268d28ce92d3c2592e0021e1ba5588b4

show more ...