bootstrap: Use strict behaviour

Change-Id: I3fc6819ce7c1dfc63ea1f14e4f23097b48b8a115
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

ax_code_coverage: Ubuntu Zesty: Enable use of lcov 1.13

This works around the bug where Ubuntu Zesty's autoconf-archive package
at version 20160916-1 doesn't support Zesty's lcov package, which is
1

ax_code_coverage: Ubuntu Zesty: Enable use of lcov 1.13

This works around the bug where Ubuntu Zesty's autoconf-archive package
at version 20160916-1 doesn't support Zesty's lcov package, which is
1.13. This leads to a non-zero exit by ./configure when enabling
code-coverage support on Zesty.

Revert when Zesty isn't broken.

Change-Id: I4050abdf9ea1b0ce7e131f334847f8f57a7281cc
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

bootstrap: Set CXXFLAGS as well as CFLAGS in dev mode

Change-Id: I2fe0974182c2f207232b8e9b1f2d0acb7b57512c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

bootstrap: Allow ./configure options on the commandline for dev mode

Change-Id: I11812d5aa19d4a293282ab776663bdfe6154069a
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

ax_code_coverage: Ubuntu Zesty: Enable use of lcov 1.13

This works around the bug where Ubuntu Zesty's autoconf-archive package
at version 20160916-1 doesn't support Zesty's lcov package, which is
1

ax_code_coverage: Ubuntu Zesty: Enable use of lcov 1.13

This works around the bug where Ubuntu Zesty's autoconf-archive package
at version 20160916-1 doesn't support Zesty's lcov package, which is
1.13. This leads to a non-zero exit by ./configure when enabling
code-coverage support on Zesty.

Revert when Zesty isn't broken.

Change-Id: I4050abdf9ea1b0ce7e131f334847f8f57a7281cc
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

bootstrap: Set CXXFLAGS as well as CFLAGS in dev mode

Change-Id: I2fe0974182c2f207232b8e9b1f2d0acb7b57512c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

bootstrap: Use strict behaviour

Change-Id: I3fc6819ce7c1dfc63ea1f14e4f23097b48b8a115
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

bootstrap: Allow ./configure options on the commandline for dev mode

Change-Id: I11812d5aa19d4a293282ab776663bdfe6154069a
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Documentation: Point to canonical protocol documentation

Avoid conflicts in the protocol documentation by pointing back to the
reference implementation.

Change-Id: I380f32dab2e9b8bbeec25b9abffe9c54

Documentation: Point to canonical protocol documentation

Avoid conflicts in the protocol documentation by pointing back to the
reference implementation.

Change-Id: I380f32dab2e9b8bbeec25b9abffe9c5427b76bd3
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

version: Update to version 2.1.0

Update to package version V2.1.0 to reflect that a backwards compatible
API change was made. This API change was the introduction of the timeout
to the GET_MBOX_INFO

version: Update to version 2.1.0

Update to package version V2.1.0 to reflect that a backwards compatible
API change was made. This API change was the introduction of the timeout
to the GET_MBOX_INFO command.

This version update also encompasses previous bug fixes.

The versioning scheme is now aligned to semver.

Use the version from config.h for both mboxd and mboxctl instead of an
independant value for the daemon and control programs.

Change-Id: I12d7fe8e40697801594b1727054342613923a784
Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>

show more ...

test: Set mbox_vlog in tests so we don't segfault

mbox_vlog contains the function pointer for the logging function called in
MSG_<ERR/INFO/DEBUG>. Currently we don't set it in the
<write/copy/erase>

test: Set mbox_vlog in tests so we don't segfault

mbox_vlog contains the function pointer for the logging function called in
MSG_<ERR/INFO/DEBUG>. Currently we don't set it in the
<write/copy/erase>_flash tests meaning if there is any test output that we
try to dereference a null pointer and thus segfault.

Set it in these tests so that we can get test output which can be useful
for debugging and most importantly so that we don't segfault which is
annoying...

Change-Id: If91725ded0ee5d6c3ab0a8925126065ec43b0cc3
Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>

show more ...

tests: Add test for timeout argument in GET_MBOX_INFO

Add a test to check the value returned in the suggested timeout
field in the response of GET_MBOX_INFO for a window size >= 1MB.

It is worth no

tests: Add test for timeout argument in GET_MBOX_INFO

Add a test to check the value returned in the suggested timeout
field in the response of GET_MBOX_INFO for a window size >= 1MB.

It is worth noting that existing test cases will continue to pass
since a window size < 1MB will have zero for the suggested timeout
which is what is expected in this field for all existing tests.

Change-Id: I4fb4903817b63a8c201af4142d429b7b21881848
Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>

show more ...

mboxd: Introduce a new DEBUG log level

Currently there is no output on the console unless -v is specified on
the command line which enables error output. A second -v will provide
info output.

We pr

mboxd: Introduce a new DEBUG log level

Currently there is no output on the console unless -v is specified on
the command line which enables error output. A second -v will provide
info output.

We probably want error output irrespective of whether a -v was given
on the command line because people generally want to know why their
program stopped working.

Make error output unconditional.

A single -v will give minimal informational output which is a good
level to see what the daemon is doing without barfing all over the
console.

A second -v will enable debug output which will print highly verbose
information which will be useful for debugging. Probably don't enable
this under normal circumstances.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: I3da25f7e4e9e976c17389fcceb1d85ef98de7e0a

show more ...

mboxd: Implement timeout return value in GET_MBOX_INFO

The previous patch added a new return field in GET_MBOX_INFO called
"suggested timeout" to be used to provide a suggested maximum timeout
value

mboxd: Implement timeout return value in GET_MBOX_INFO

The previous patch added a new return field in GET_MBOX_INFO called
"suggested timeout" to be used to provide a suggested maximum timeout
value to the host.

Add this to the return arguments of GET_MBOX_INFO.

Note that the host is free to ignore the value and the daemon can
leave this blank if it doesn't want to provide a timeout.

We hard code a milliseconds per megabyte value which was determined
to be approximately 8000 based on testing and is close to linear
as the access size changes. Testing was conducted on an Aspeed ast2500
on a Witherspoon with the dev-4.7 OpenBMC branch.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: If24e41ebb1d9f03c2bdcca84819f9430fd3eeff6

show more ...

docs: Add suggested timeout response argument to GET_MBOX_INFO

It would be nice to suggest to the host how long it should wait for a
response to a command before assuming that the BMC is not going t

docs: Add suggested timeout response argument to GET_MBOX_INFO

It would be nice to suggest to the host how long it should wait for a
response to a command before assuming that the BMC is not going to
respond and timing out.

Add a response argument for this to the GET_MBOX_INFO command. We don't want
to require a BMC to set this so we allow it to be zero to indicate that no
suggestion has been given.

This doesn't require us to bump the protocol number since the current daemon
just sets this to zero (which is allowed) and the host is free to ignore this,
which it currently does.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: Idd65a5660e0092b9abd98829403b981fd26f8bbe

show more ...

docs: Stipulate register 13 must be written last when writing a response

Writes to register 13 (Response Code) are what is used to generate an
interrupt to the host. On receiving this interrupt the

docs: Stipulate register 13 must be written last when writing a response

Writes to register 13 (Response Code) are what is used to generate an
interrupt to the host. On receiving this interrupt the host can start
processing the entire response message. Thus to ensure that the host
is processing the correct mbox response register 13 must be the last
to be written.

Stipulate in the protocol documentation that the last register to be
written by the BMC when writing a response must be the response code
into register 13.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: I2b4e14a81d7bbffc990cfb83321ab219e3df1d82

show more ...

docs: Stipulate that block size must be >= 4K and a power-of-2

Arguments and responses to most commands are given in block size which
is decided on during the version negotiation process when GET_MB

docs: Stipulate that block size must be >= 4K and a power-of-2

Arguments and responses to most commands are given in block size which
is decided on during the version negotiation process when GET_MBOX_INFO
is called.

We require that block size is greater than 4K (12 bit). The lpc bus
address space is 28 bit and commands which return an lpc bus address have
a 16 bit variable space, this means we can correctly specify anywhere in
the lpc address space.

This also allows us to support flash sizes up to 256MB where we can
correctly specify any flash offset in the command arguments.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: Ia08979017a3c0ff229ce412948dc4c67d357e82b

show more ...

docs: Reword create_{read/write}_window command spec

Reword the create_{read/write}_window command specification to make it
easier to understand and remove sentences which add no value or are
unnece

docs: Reword create_{read/write}_window command spec

Reword the create_{read/write}_window command specification to make it
easier to understand and remove sentences which add no value or are
unnecessarily verbose.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: Idb1ac8da82d4a1ab379c55ff650ef410de86e715

show more ...

configure: Download aspeed-lpc-ctrl.h if not present

However, don't download it if the file is already present in the local
directory. The AC_CHECK_HEADER macro can't test this case, so the
conditio

configure: Download aspeed-lpc-ctrl.h if not present

However, don't download it if the file is already present in the local
directory. The AC_CHECK_HEADER macro can't test this case, so the
condition will always trigger if the header isn't installed on the
system.

Change-Id: I7de8ff24823fe2ce54add9a33125cee5ad0b53f0
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

test: Add sequence_numbers

Change-Id: Ida6123bf27445f0fb65099fbf6d9520344d33f10
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

test: Add read_window_cycle

Change-Id: Iaa967b7e0732ebc0322ea89e74861a5bedb34867
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

test: Add invalid_command

Change-Id: I42bc056e5c6b6fdd078bc622e40db39583b53c64
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

test: Add write_window_dirty_erase

Change-Id: I16d2488e75dde619da39d755e00666bc24778217
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

test: Add read_window_mark_write_erased

Change-Id: I40e3e29e8064f7ec156cdfd579071563d1cc35c3
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

test: Add read_window_write_flush

Change-Id: I17b237f66e57a40df136d47e2e963eae4c3de535
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>