PEL: Add OVERTMP symbolic FRU callout

This commit adds the OVERTMP symbolic FRU as a high callout to the
perfloss, warning, and critical high temperature PELs. It uses the
newly introduced Callouts

PEL: Add OVERTMP symbolic FRU callout

This commit adds the OVERTMP symbolic FRU as a high callout to the
perfloss, warning, and critical high temperature PELs. It uses the
newly introduced CalloutsWhenNoADMatch message registry field to handle
doing it for all sensors that aren't the ambient one.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I9775daefbf67063dc5bcde2a0ad763eef3e437a5

show more ...

PEL: Add CalloutsWhenNoADMatch msg reg support

There is a new use case where we need to do one callout in the message
registry based on the value of an AdditionalData field value, and
another callou

PEL: Add CalloutsWhenNoADMatch msg reg support

There is a new use case where we need to do one callout in the message
registry based on the value of an AdditionalData field value, and
another callout in all other cases.

To support this, this commit is adding a new 'CalloutsWhenNoADMatch'
field in the PEL message registry that allows one to add callouts when
there is no match on the 'ADValue' field. This behaves like an 'else'
leg to the 'if AdValue == X' structure in the message registry.

Example:
{
"ADName": "PROC_NUM",
"CalloutsWithTheirADValues":
[
{
"ADValue": "0",
"Callouts":
[
// callouts when PROC_NUM == 0
]
},
{
"ADValue": "1",
"Callouts":
[
// callouts when PROC_NUM == 1
]
}
],
"CalloutsWhenNoADMatch": [
{
// callouts when PROC_NUM != 0 or 1
}
]
}

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ib8e208ff950a643302e856c7dd2b7474fec61b26

show more ...

PEL: Add missing gtest dependency

Fixes a compile failure when building the PEL tests in standalone mode
(using subprojects).

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ida0abbd824

PEL: Add missing gtest dependency

Fixes a compile failure when building the PEL tests in standalone mode
(using subprojects).

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ida0abbd824b6573129a3b1262b7b490270ce7787

show more ...

PEL: Fix more cppcheck warnings

This is the second of two commits to fix most of the cppcheck warnings
in the PEL code. It doesn't fix all of them because some are false
positives and some are just

PEL: Fix more cppcheck warnings

This is the second of two commits to fix most of the cppcheck warnings
in the PEL code. It doesn't fix all of them because some are false
positives and some are just suggestions.

It's broken up into two commits to make them smaller.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Id9f462386df85fd25d09529d6b410115ff4ccba8

show more ...

PEL: Fix some cppcheck warnings

This is the first of two commits to fix most of the cppcheck warnings in
the PEL code. It doesn't fix all of them because some are false
positives and some are just

PEL: Fix some cppcheck warnings

This is the first of two commits to fix most of the cppcheck warnings in
the PEL code. It doesn't fix all of them because some are false
positives and some are just suggestions.

It's broken up into two commits to make them smaller.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I75937797a6920611b136d600e9efd6c694e4209c

show more ...

Fix some cppcheck warnings

Fix some of the warnings in the base phosphor-logging code.

It doesn't fix all of them - some are false positives and some are just
suggestions, but it does bring down th

Fix some cppcheck warnings

Fix some of the warnings in the base phosphor-logging code.

It doesn't fix all of them - some are false positives and some are just
suggestions, but it does bring down the number a bit to make it easier
to spot real issues.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I8a131cbc2941ccba79ef3775151007c770207bd5

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I034a2d07644b60dd8b5938dcad800c5d157997ad

format: reformat with black

CI seems to be failing due to a new version of pycodestyle
with errors such as:

```
./tools/elog-gen.py:26:11: E275 missing whitespace after keyword
if(i_parents

format: reformat with black

CI seems to be failing due to a new version of pycodestyle
with errors such as:

```
./tools/elog-gen.py:26:11: E275 missing whitespace after keyword
if(i_parents[error] is not None):
```

Attempt to reformat the whole codebase with `black`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2fb63670cf4828d4dee19a9c7f247e9ffecdb398

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibc25db433a6926f7ee43ea83312c3ac14f480c33

show more ...

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I678f51cab15411717bf94e979317a91af31fea0a

show more ...

PEL: Add BMC uptime to PELs in UserData section

A UserData section has been added to each PEL with additional debug
information, now there is a need to add the output of the uptime
command to UserDa

PEL: Add BMC uptime to PELs in UserData section

A UserData section has been added to each PEL with additional debug
information, now there is a need to add the output of the uptime
command to UserData and display it, but for Hostboot doesn't care
about this property, so skip adding it here it.

Tested: unit test passed
"User Data 0": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
...
"Uptime": "3y 332d 21h 33m 9s",
"Load": "1.47 0.94 0.61",
},

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I3d4c78bb1650da9a91804fc83de60597992ffc8a

show more ...

PEL: Update D-Bus event sev based on PEL severity

Put in checks to ensure the D-Bus event log severity agrees with the
final PEL severity for PELs created by the BMC. The D-bus property is
what is

PEL: Update D-Bus event sev based on PEL severity

Put in checks to ensure the D-Bus event log severity agrees with the
final PEL severity for PELs created by the BMC. The D-bus property is
what is used in the Redfish event log, and we want to avoid cases like
having a Critical event log for an informational PEL.

This could happen in the case where the PEL message registry entry for
the event has a hardcoded or manufacturing specific severity value that
is different than the severity the D-Bus event log is first created
with.

This commit ensures that:
* If the PEL is nonError/recovered, the D-Bus severity is one of the
non error ones.
* If the PEL isn't nonError/recovered, then the D-Bus severity also
isn't.
* If the PEL is critical, the D-Bus severity is also critical.

It doesn't try to update the D-Bus severity for every PEL severity
because there isn't a one to one mapping - e.g. Notice, Debug, and
Informational D-Bus severities all map to a PEL severity of
nonError(informational).

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I6b0006034090e6d8e33e9f8b136ae50cce489f6e

show more ...

PEL: Move down quiesce check

Move the check where the host quiesce target may get started based on
the PEL severity to the last thing that happens when either a PEL is
created by BMC code or receive

PEL: Move down quiesce check

Move the check where the host quiesce target may get started based on
the PEL severity to the last thing that happens when either a PEL is
created by BMC code or received by the host. It just seems more
straight forward to not start systemd targets before even filling in all
of the PEL related D-Bus properties.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I689d9947ebeabfdd914b43d32b49c7f1b6cbcdd7

show more ...

PEL: Fix in getting processor position from SRC6

The value in the SRC6 is stored in the decimal form so
that string needs to be converted to integer first to get the
processor position from 0:15 bit

PEL: Fix in getting processor position from SRC6

The value in the SRC6 is stored in the decimal form so
that string needs to be converted to integer first to get the
processor position from 0:15 bits.

TESTS:
Executed the test to create PEL with SBE FFDC, there was
no crash.

Jun 23 06:30:46 p10bmc phosphor-log-manager[7794]: Created PEL 0x500010c9 (BMC ID 282) with SRC BD123500
Jun 23 06:30:46 p10bmc openpower-proc-control[17085]: exception raised
Jun 23 06:30:46 p10bmc openpower-proc-control[17085]: Enter: mpiplEnter(/proc2)
Jun 23 06:30:46 p10bmc openpower-proc-control[17085]: /proc2 CFAM(0x2986) : 0x2
Jun 23 06:30:46 p10bmc openpower-proc-control[17085]: /proc2 CFAM(0x2809) : 0x8366018F
Jun 23 06:30:46 p10bmc openpower-proc-control[17085]: /proc2 CFAM(0x282A) : 0x9A609A6
Jun 23 06:30:46 p10bmc openpower-proc-control[17085]: /proc2 CFAM(0x2829) : 0x99209A6
Jun 23 06:30:46 p10bmc openpower-proc-control[17085]: /proc2 CFAM(0x1007) : 0xC02083F8
Jun 23 06:30:46 p10bmc phosphor-log-manager[7794]: Created PEL 0x500010ca (BMC ID 283) with SRC BD123500
Jun 23 06:30:46 p10bmc openpower-proc-control[17086]: exception raised
Jun 23 06:30:46 p10bmc openpower-proc-control[17086]: Enter: mpiplEnter(/proc3)
Jun 23 06:30:46 p10bmc openpower-proc-control[17086]: /proc3 CFAM(0x2986) : 0x2
Jun 23 06:30:46 p10bmc openpower-proc-control[17086]: /proc3 CFAM(0x2809) : 0x8366018F
Jun 23 06:30:46 p10bmc openpower-proc-control[17086]: /proc3 CFAM(0x282A) : 0x9740960
Jun 23 06:30:46 p10bmc openpower-proc-control[17086]: /proc3 CFAM(0x2829) : 0x9560974
Jun 23 06:30:46 p10bmc openpower-proc-control[17086]: /proc3 CFAM(0x1007) : 0xC02083F8
Jun 23 06:30:46 p10bmc phosphor-log-manager[7794]: Created PEL 0x500010cb (BMC ID 284) with SRC BD123500
Jun 23 06:30:46 p10bmc openpower-proc-control[17083]: exception raised
Jun 23 06:30:46 p10bmc openpower-proc-control[17083]: Enter: mpiplEnter(/proc0)
Jun 23 06:30:46 p10bmc openpower-proc-control[17083]: /proc0 CFAM(0x2986) : 0x1
Jun 23 06:30:46 p10bmc openpower-proc-control[17083]: /proc0 CFAM(0x2809) : 0x8366018F
Jun 23 06:30:46 p10bmc openpower-proc-control[17083]: /proc0 CFAM(0x282A) : 0x9560942
Jun 23 06:30:46 p10bmc openpower-proc-control[17083]: /proc0 CFAM(0x2829) : 0x92E0974
Jun 23 06:30:46 p10bmc openpower-proc-control[17083]: /proc0 CFAM(0x1007) : 0xC02083F8
Jun 23 06:30:46 p10bmc openpower-proc-control[17070]: Memory preserving reboot failed
Jun 23 06:30:46 p10bmc phosphor-log-manager[7794]: Created PEL 0x500010cc (BMC ID 285) with SRC BD123500
Jun 23 06:30:46 p10bmc openpower-proc-control[17084]: exception raised
Jun 23 06:30:46 p10bmc openpower-proc-control[17084]: Enter: mpiplEnter(/proc1)
Jun 23 06:30:46 p10bmc openpower-proc-control[17084]: /proc1 CFAM(0x2986) : 0x2
Jun 23 06:30:46 p10bmc openpower-proc-control[17084]: /proc1 CFAM(0x2809) : 0x8366018F
Jun 23 06:30:46 p10bmc openpower-proc-control[17084]: /proc1 CFAM(0x282A) : 0x9B00988
Jun 23 06:30:46 p10bmc openpower-proc-control[17084]: /proc1 CFAM(0x2829) : 0x9880992
Jun 23 06:30:46 p10bmc openpower-proc-control[17084]: /proc1 CFAM(0x1007) : 0xC02083F8
Jun 23 06:30:46 p10bmc openpower-proc-control[17070]: Memory preserving reboot failed
Jun 23 06:30:46 p10bmc openpower-proc-control[17070]: Memory preserving reboot failed
Jun 23 06:30:46 p10bmc openpower-proc-control[17070]: Memory preserving reboot failed
Jun 23 06:30:46 p10bmc systemd[1]: op-enter-mpreboot@0.service: Main process exited, code=exited, status=1/FAILURE
Jun 23 06:30:46 p10bmc systemd[1]: op-enter-mpreboot@0.service: Failed with result 'exit-code'.
Jun 23 06:30:46 p10bmc systemd[1]: Failed to start Start memory preserving reboot host0.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I2a1f6f7daebe9a01e00241c9f3587dd09f8668fb

show more ...

PEL: Log spare clock failures as informational

This commit enables to log spare clock failure log as
informational.

For any sbe boot failures, application call pel api with
severity information. P

PEL: Log spare clock failures as informational

This commit enables to log spare clock failure log as
informational.

For any sbe boot failures, application call pel api with
severity information. PEL process the SBE FFDC information
and servicable information. For the spare clock failure
there is request from RAS team to log error as informational.

Tested: forced clock error on primary processor after bmc
clock isteps.

"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "0x2000",
"Subsystem": "Processor Chip Cache",
"Event Scope": "Entire Platform",
"Event Severity": "Informational Event",
"Event Type": "Miscellaneous, Informational Only",
"Action Flags": [
"Service Action Required",
"Report Externally",
"HMC Call Home"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Not Sent"
},
"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x3500",
"SRC Version": "0x02",
"SRC Format": "0x55",
"Virtual Progress SRC": "False",
"I5/OS Service Event Bit": "False",
"Hypervisor Dump Initiated":"False",
"Backplane CCIN": "2E33",
"Terminate FW Error": "False",
"Deconfigured": "False",
"Guarded": "False",
"Error Details": {
"Message": "Boot failure reported by SBE",
"SRC6": [
"0x0",
"[0:15] chip position"
]
},
"Valid Word Count": "0x09",
"Reference Code": "BD123503",
"Hex Word 2": "00080055",
"Hex Word 3": "2E330010",
"Hex Word 4": "00000000",
"Hex Word 5": "00000000",
"Hex Word 6": "00000000",
"Hex Word 7": "00000000",
"Hex Word 8": "00000000",
"Hex Word 9": "00000000",
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Symbolic FRU",
"Priority": "Mandatory, replace all with
this type as a unit",
"Part Number": "REFCLK0"
}]
}
},
"User Data 3": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"Data": [
{
"Deconfigured": true,
"EntityPath": [
35,
1,
0,
2,
0,
26,
1,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0
],
"Priority": "H",
"SymbolicFRU": "REFCLK0"
}
]
},
"User Data 4": {
"Section Version": "1",
"Sub-section type": "3",
"Created by": "0x2000",
"Data": [
"HWP_RC = RC_RCS_CLOCK_TEST_OUT_ERR",
"HWP_RC_DESC = xxxxxxx"
"HWP_FFDC_CLOCK_POS = 00",
"HWP_FFDC_READ_SNS1LTH = 00000000",
"HWP_FFDC_ATTR_CP_REFCLOCK_SELECT_VALUE = 02",
"HWP_FFDC_RCS_CLOCK_TEST_IN = 01",
"HWP_FFDC_CLOCK_A_OK = 00",
"HWP_FFDC_CLOCK_B_OK = 00",
"."
]
}

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I15cdd76237d4cdf52e9e6dc907528a66218354c1

show more ...

PEL: Redundant mode clock error handling support

Added additional error support to handle clock failures callout
support for the spare clock supported system. In this case only
deconfigure clock tar

PEL: Redundant mode clock error handling support

Added additional error support to handle clock failures callout
support for the spare clock supported system. In this case only
deconfigure clock target.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I426270ab909d21904a2ce198fff58991b91d00fc

show more ...

PEL: convertFAPItoPELformat function description updates

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Iec5b6e6dc567b178054eb47b1510f305698e54ff

PEL: SbeBootFailure message registry updates

Updated SbeBootFailure message registry to enable secondary
clock failure use case. Incase of spare clock initialisation
failure during sbe boot window,

PEL: SbeBootFailure message registry updates

Updated SbeBootFailure message registry to enable secondary
clock failure use case. Incase of spare clock initialisation
failure during sbe boot window, pel should be logged as
informational and service event should initiated. Updated
message registry fields to support this base infrastructure.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Ifc31530d7124c7e36a0ad4bcf075d562cb541efa

show more ...

PEL: Add message registry for spare clock failure

Added message registry for spare clock initilisation failure.
This error is logged as informational and enabled the required
fields to reports exter

PEL: Add message registry for spare clock failure

Added message registry for spare clock initilisation failure.
This error is logged as informational and enabled the required
fields to reports externally.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I56cb2adaca35de587c57d3dcf06500006c218e2b

show more ...

PEL: Add min length to 2 msg reg fields

Change the minimum length to 8 for the Message and Description fields in
the Documentation section of the message registry as just a basic check
that they con

PEL: Add min length to 2 msg reg fields

Change the minimum length to 8 for the Message and Description fields in
the Documentation section of the message registry as just a basic check
that they contain something valid.

The message registry is transformed into official documentation that
needs these fields filled in.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I0f7c247754a0460576337e61159b23fd02420cd4

show more ...

PEL: change OCC control SRCs to 0x2600

change OCC reason code to 0x2681, 0x2682, 0x2683.
Tested: error logs built.
Signed-off-by: Sheldon Bailey <baileysh@us.ibm.com>
Change-Id: Ic7748721664511dc818

PEL: change OCC control SRCs to 0x2600

change OCC reason code to 0x2681, 0x2682, 0x2683.
Tested: error logs built.
Signed-off-by: Sheldon Bailey <baileysh@us.ibm.com>
Change-Id: Ic7748721664511dc818e68894f4369efaa0aabc0

show more ...

PEL: Error interface for missing essential fru

The commit defines interface for essential fru missing case.
Essential frus are the ones which are required to be present
in the system at power on sta

PEL: Error interface for missing essential fru

The commit defines interface for essential fru missing case.
Essential frus are the ones which are required to be present
in the system at power on state.

The commit also modifies the entry related GPIO line error,
where because of the ambiguity behind GPIO line error, bmc
code will be called out.

Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: I167c45ed384e04676d66887bcecb4e7e00f16709

show more ...

PEL: phosphor-bmc-code-mgmt add HostFile

Add entries for errors that occur which are specific to
phosphor-bmc-code-mgmt. After code updates, and the system is
rebooted, there are partitions that sho

PEL: phosphor-bmc-code-mgmt add HostFile

Add entries for errors that occur which are specific to
phosphor-bmc-code-mgmt. After code updates, and the system is
rebooted, there are partitions that should be preserved and not
overwritten. There needs to be PEL that specify if any of the
partitions have been corrupted or modified in a way that
prevents the copy from happening.

Signed-off-by: Zami Seck <zimzam17@gmail.com>
Change-Id: I0e8b0d1fcb86a67f14ac380fb66a81b461fd0273

show more ...

PEL: Sanitize D-Bus fields that come from PELs

The Resolution D-Bus property is filled with values from the PEL callout
fields like the serial and part numbers. These fields usually come from
EEPRO

PEL: Sanitize D-Bus fields that come from PELs

The Resolution D-Bus property is filled with values from the PEL callout
fields like the serial and part numbers. These fields usually come from
EEPROMs, and may not necessarily be valid printable values if the code
that creates the PEL doesn't sanitize the values first. If any of the
characters were invalid, the daemon would crash when D-Bus broker
disconnects it from D-Bus since it doesn't allow invalid values on
D-Bus.

Prevent this crash by converting any non printable characters in the
Resolution property to spaces. This also sanitizes the EventId property
which contains the SRC ASCII string and hex words just to be safe.

This is really just a concern for non-BMC created PELs, since the BMC
code that reads EEPROMs already sanitizes the values when it reads them,
but PELs have come in from other subsystems that don't.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: If0e80fd9db27446f5367ed046e4bca2eb62e3fb2

show more ...

PEL: Read 'HMC Managed' BIOS attribute

Add a property watch on the base BaseBIOSTable property provided by the
BIOS config manager so that the pvm_hmc_managed BIOS attribute can be
read from it to k

PEL: Read 'HMC Managed' BIOS attribute

Add a property watch on the base BaseBIOSTable property provided by the
BIOS config manager so that the pvm_hmc_managed BIOS attribute can be
read from it to know if the HMC is managed or not.

The DataInterface class already provides an isHMCManaged() method that
is used by the host notification code, and this commit allows it to
return the correct value.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I55e8f222361e901f0b28c3d596dc3400093aba89

show more ...