Allow parsing of error yaml files without metadata yaml file

At present parser throws error if metadata yaml file is not found,
modified to not to return error.

Restruture the code to loop through

Allow parsing of error yaml files without metadata yaml file

At present parser throws error if metadata yaml file is not found,
modified to not to return error.

Restruture the code to loop through the entries in the error
yaml file rather than through the meta yaml file.

Change-Id: Iaae61690201aeffd8d9caa41515b29b7cc0b59a2
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

python3: iteritems does not exist

Change iteritems to items, which is slightly slower
on python2 but exists in both. None of the maps manipulated
by this program are large enough for the items vs i

python3: iteritems does not exist

Change iteritems to items, which is slightly slower
on python2 but exists in both. None of the maps manipulated
by this program are large enough for the items vs iteritems
to be a concern.

Change-Id: I63032ddde53a116431cc2cbe01828448a4d4f328
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

elog-gen.py : strip whitespaces

Strip trailing and leading whitespaces from the error description.

Resolves openbmc/openbmc#1481.

Change-Id: Ia223ab34746e64d87dacd1f23ade7e4fc63ca9df
Signed-off-by

elog-gen.py : strip whitespaces

Strip trailing and leading whitespaces from the error description.

Resolves openbmc/openbmc#1481.

Change-Id: Ia223ab34746e64d87dacd1f23ade7e4fc63ca9df
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

Add new commit API and deprecate older commit method

Added new commit method that accepts an sdbusplus exception
Deprecate commit which accepts an exception name

Change-Id: I9b5c91eb13466eb576c329e

Add new commit API and deprecate older commit method

Added new commit method that accepts an sdbusplus exception
Deprecate commit which accepts an exception name

Change-Id: I9b5c91eb13466eb576c329ebb7fd00ce33f7dd9f
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Map sdbusplus exception to phosphor exception

Errors will be created by using the sdbusplus error types, which results
in an sdbusplus exception being thrown.

Error metadata can be verified at comp

Map sdbusplus exception to phosphor exception

Errors will be created by using the sdbusplus error types, which results
in an sdbusplus exception being thrown.

Error metadata can be verified at compile-time by checking the error
against phosphor-logging error types. This commit maps the sdbusplus
error type to the phosphor type, for this purpose, via template
specializations.

Change-Id: Iee37e2a3846cc3acf3a62270a520ff0c395fd36d
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

test: add callout-test

Add test program which can create callouts based on an input device
path. It creates an error, with callouts, with name TestCallout.

Change-Id: I96b66b73ae4a9c00daff06222841a

test: add callout-test

Add test program which can create callouts based on an input device
path. It creates an error, with callouts, with name TestCallout.

Change-Id: I96b66b73ae4a9c00daff06222841a13747c07408
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

Make generated code to be const and extern

Set generated maps to be const so that they don't get
accidentally overwritten.
Use .find() to access these generated data sets as the [] operator
is not c

Make generated code to be const and extern

Set generated maps to be const so that they don't get
accidentally overwritten.
Use .find() to access these generated data sets as the [] operator
is not const.
Declare the generated maps as extern so that there's
no need to include the generated .cpp file.

Change-Id: I4efdcace099bec738e1fa9b67decbedd515d3dfa
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

elog-gen.py : consume metadata 'process' keyword

Add a new mako template to aid elog-gen.py to generate code for handling
the metadata 'process' keyword.

Change-Id: I720ac1e30cf566f5a6bfe090faec6da

elog-gen.py : consume metadata 'process' keyword

Add a new mako template to aid elog-gen.py to generate code for handling
the metadata 'process' keyword.

Change-Id: I720ac1e30cf566f5a6bfe090faec6da9742f7423
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

metadata: introduce 'process' keyword

An error metadata field that has the 'process' keyword set to true is
an indication that this metadata will have some associated action that
will take place aft

metadata: introduce 'process' keyword

An error metadata field that has the 'process' keyword set to true is
an indication that this metadata will have some associated action that
will take place after this metadata (and associated error) is logged to
the journal and before the associated error is committed.

The associated action will have to be implemented when adding the
'process' keyword.

Add 'process' keyword to an example error definition.

Change-Id: I42ab3fa230479000a88a18046548242c0043ac86
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

Error log inject tool

This tool adds an option to the logging-test
to inject an error as specified by command
line.

Change-Id: I1028bd3964db23ed5ffa50414f7a6cc2f880c40c
Signed-off-by: Michael Tritz

Error log inject tool

This tool adds an option to the logging-test
to inject an error as specified by command
line.

Change-Id: I1028bd3964db23ed5ffa50414f7a6cc2f880c40c
Signed-off-by: Michael Tritz <mtritz@us.ibm.com>

show more ...

elog-lookup: include inherited metadata

Include inherited metadata in the code generated for metadata lookup.

Change-Id: I9389eb08b0c74c94a377f7434ee358965c2fdf2b
Signed-off-by: Deepak Kodihalli <d

elog-lookup: include inherited metadata

Include inherited metadata in the code generated for metadata lookup.

Change-Id: I9389eb08b0c74c94a377f7434ee358965c2fdf2b
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

Match error full name and namespace

Remove the addition of the extra "namespace Error" while generating
error full names, as the error full name doesn't have the extra "Error".
This extra namespace

Match error full name and namespace

Remove the addition of the extra "namespace Error" while generating
error full names, as the error full name doesn't have the extra "Error".
This extra namespace addition was being done to match up sdbusplus error
binding generation, but this will have to be re-looked at.

Change-Id: Ib99ce8e3a09dd76a23b8cc6fe7e706551a1699d6
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

elog-gen.py: handle absence of metadata

An error may just want to inherit metadata from another error, without
adding metadata of it's own. In such a case, the metadata file won't
have the "meta" ke

elog-gen.py: handle absence of metadata

An error may just want to inherit metadata from another error, without
adding metadata of it's own. In such a case, the metadata file won't
have the "meta" keyword, although it will have the "inherits" keyword.

Accept metadata files that don't have the "meta" keyword.

Change-Id: I4e30e035f19d6af8e0e1f654465d109fe5284a1b
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

Include namespaces in the phosphor-logging exception name

Currently the phosphor-logging exception name is for example
Device for an error file located in xyz/openbmc_project/Error/Callout/.
It shou

Include namespaces in the phosphor-logging exception name

Currently the phosphor-logging exception name is for example
Device for an error file located in xyz/openbmc_project/Error/Callout/.
It should instead be named xyz.openbmc_project.Error.Callout.Device
following the naming structure of the sdbusplus++ tool
to differentiate it from other Device error exceptions.
With the full name, the namespaces can be determined, so there's no
need to pass the namespace parameter to the template that generates
the elog-errors.hpp. As with the name, follow the namespace
structure of the sdbusplus exception object.

Closes openbmc/phosphor-logging#2

Change-Id: I960d759d90aa18fd43211034ebd6009859113ee7
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Use configure option yaml path to generate elog-errors.hpp

Add a config variable that can be passed via a recipe to
point the parser to a directory where the error yaml files are.
Rename elog-gen.hp

Use configure option yaml path to generate elog-errors.hpp

Add a config variable that can be passed via a recipe to
point the parser to a directory where the error yaml files are.
Rename elog-gen.hpp to elog-errors.hpp, which better matches the
exception error log file names.
Include elog-gen.hpp in elog.hpp so that callers that need to
create and commit error logs only need to include one header file.

Change-Id: Ie3cd65ac761c1f7b2c99c50a2273859283a5ab4b
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

elog-gen.py: Set INFO as default error log severity level

Some error yaml files in the phosphor-dbus-interfaces repo do not
specify the error log severity. Default this value to INFO.

Change-Id: If

elog-gen.py: Set INFO as default error log severity level

Some error yaml files in the phosphor-dbus-interfaces repo do not
specify the error log severity. Default this value to INFO.

Change-Id: Ifd335ba7d5e3e8238365036a2bfa7a199e014cfc
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

elog-gen.py: Dynamically determine the namespaces

Namespaces should be determined by the directory tree where the
yaml files are located.

Change-Id: I82729728b6aebf4c48a0ec967f2d08c1cbf8b7f3
Signed

elog-gen.py: Dynamically determine the namespaces

Namespaces should be determined by the directory tree where the
yaml files are located.

Change-Id: I82729728b6aebf4c48a0ec967f2d08c1cbf8b7f3
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

elog-gen.py: Support base and test yaml directories

Add an additional argument to pass the directory where the unit
test yaml files are located. Default the base directory to None
as this argument w

elog-gen.py: Support base and test yaml directories

Add an additional argument to pass the directory where the unit
test yaml files are located. Default the base directory to None
as this argument will be passed by the recipe during build time.

Change-Id: I1276d74e383e1517595371c3f6e31fa077eac43f
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

elog-gen.py: Support subdirs

Add ability for elog-gen.py to find yaml files under subdirectories
so that yaml files found in Error/Callout/ and Error/IIC/ for
example can be found by the caller just

elog-gen.py: Support subdirs

Add ability for elog-gen.py to find yaml files under subdirectories
so that yaml files found in Error/Callout/ and Error/IIC/ for
example can be found by the caller just passing the Error/ directory.

Change-Id: I91dcd523d2a75deea6266a3ea6885b88cd788206
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Moved log.hpp and elog.hpp to a folder under phosphor-logging

Now these files are copied to a folder under phosphor-logging,
other repositories will need to be fixed. I'm leaving the files in
the ba

Moved log.hpp and elog.hpp to a folder under phosphor-logging

Now these files are copied to a folder under phosphor-logging,
other repositories will need to be fixed. I'm leaving the files in
the base dir as well until I work on fixing all projects that
utilizes log.hpp and elog.hpp

Change-Id: Ie4640852727c1572325e974548737bc70a6db7c2
Signed-off-by: Saqib Khan <khansa@us.ibm.com>

show more ...

Move inherits keyword from errors.yaml to metadata.yaml

The metadata.yaml file is the correct location for the inherits.
Update the elog-gen.py parser to support this change.

Change-Id: Iac7f67ec72

Move inherits keyword from errors.yaml to metadata.yaml

The metadata.yaml file is the correct location for the inherits.
Update the elog-gen.py parser to support this change.

Change-Id: Iac7f67ec72e761ab3dafbf89c7e4d5495b34f00d
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

elog-gen.py: python3 fixes

Change-Id: I4a96fe626c32e0c8078f8875da48eb06d63e763b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

elog-gen.py : alias inherited metadata

Alias metadata inherited from parent errors such that users don't have
to explicitly know which parent provides the metadata :

using metaName = ParentError::m

elog-gen.py : alias inherited metadata

Alias metadata inherited from parent errors such that users don't have
to explicitly know which parent provides the metadata :

using metaName = ParentError::metaName

Change-Id: Idd285766b9f831d19391f46cee1ed2ff320b2c30
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

Create a map to get the priority level for the error

Delete unused elog-lookup-template.mako.cpp file and update the
one in the tools directory.

Example of generated code for reference:
std::map<st

Create a map to get the priority level for the error

Delete unused elog-lookup-template.mako.cpp file and update the
one in the tools directory.

Example of generated code for reference:
std::map<std::string,level> g_errLevelMap = {
{"TestErrorOne",level::INFO},
{"TestErrorTwo",level::ERR},
};

Change-Id: I5dcf47cb4827f80aa7a04bbe2beb181e28d7dafc
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

logging: Commit: Use transaction id and metadata lookup

Add the lookup mako target to the makefile to get it built.
Use the lookup map to find the metadata that needs to be
added to the error log. U

logging: Commit: Use transaction id and metadata lookup

Add the lookup mako target to the makefile to get it built.
Use the lookup map to find the metadata that needs to be
added to the error log. Use the transaction id to filter
for the desired journal entries.

Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
Change-Id: Ia57dc83aab4f7ee35f8de32a799c862be28113f7

show more ...