lg2: minor size optimization in do_log

Push the calculation of the number of logging arguments into the
variadic 'do_log' function rather than calculate it at the lg2
call site. This reduces each c

lg2: minor size optimization in do_log

Push the calculation of the number of logging arguments into the
variadic 'do_log' function rather than calculate it at the lg2
call site. This reduces each call site by a few instructions.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic8fcbdf65fb34d251d8110c5bbd05c2e20c66c18

show more ...

lg2: reduce string_view for size optimize

There were a few places where string_view's were used for simplicity,
but as a result the compiler ends up instantiating temporary
string_view objects, whic

lg2: reduce string_view for size optimize

There were a few places where string_view's were used for simplicity,
but as a result the compiler ends up instantiating temporary
string_view objects, which makes the generated code larger. Switch
to 'const char*' instead and avoid needless string_view constructions.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia29470e8db0f1489bf7b5f6a18b1af0877d0ce72

show more ...

lg2: missing include for ranges::find

The lg2/header.hpp used ranges::find but didn't include the
defining header file (algorithm). This was probably missed
because in many cases algorithm is pulle

lg2: missing include for ranges::find

The lg2/header.hpp used ranges::find but didn't include the
defining header file (algorithm). This was probably missed
because in many cases algorithm is pulled in as a dependency
from other STL headers, but if you make an empty file with
nothing except 'include <phosphor-logging/lg2.hpp>' the function
definition is missing.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I64cd7edcacaccb02b15904486010c3bce5c28dba

show more ...

lg2: compile time checking for reserved header names

Add compile time checking for reserved header names like 'MESSAGE' as
these would override the meaning at a journald level.

This bug was identif

lg2: compile time checking for reserved header names

Add compile time checking for reserved header names like 'MESSAGE' as
these would override the meaning at a journald level.

This bug was identified in the review of a phosphor-virtual-sensor
commit.

Example compile failure:

../virtualSensor.cpp:198:33: in ‘constexpr’ expansion of
‘lg2::details::header_str("MESSAGE")’
../subprojects/phosphor-logging/lib/include/phosphor-logging/lg2/header.hpp:45:25:
error: call to non-‘constexpr’ function ‘static void
lg2::details::header_str::report_error(const char*)’
45 | report_error("Header name is reserved.");

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3a5c21fe25d307bf9b7fd296a71246a76d66872a

show more ...

lg2: compile time header format checking

Add support to check the format of message headers at compile
time to verify the rules imposed by journald APIs.

Signed-off-by: Patrick Williams <patrick@st

lg2: compile time header format checking

Add support to check the format of message headers at compile
time to verify the rules imposed by journald APIs.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I99fcbd8918bbf11ba839843ac8e793d8402b9055

show more ...

lg2: support exception conversion

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4b3cb55c9d03ed04b1f072bf3f5ef98ccffb0eef

lg2: support sdbusplus enum conversion

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I78cb28697631499adf5be64f7157a894c8d887ee

lg2: initial implementation of C++20 structured logging

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If37857cc3748df1ea6f767ce535b02c63cde8370

build: Refactor to separate out library

This makes it more clear what code is intended for use by the
phosphor-logging shared library. This is especially nice since it
isolates the `phosphor_logging

build: Refactor to separate out library

This makes it more clear what code is intended for use by the
phosphor-logging shared library. This is especially nice since it
isolates the `phosphor_logging_dep` to only provide the exported headers
instead of everything in the project.

Additionally, this adds an option to build only the library components
of the project when the services aren't needed.

Change-Id: Ied0858fc70e8054df4c056d91f35a6f0b3acfcb1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...