subprojects: Add phosphor-logging wrap

Change-Id: I6855c90cbfc16dbe31ee18acf9065ed83be122fc
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Moved udev rules and systemd service to repository.

Refactoring code to support the multihost physical LEDs design.
https://gerrit.openbmc.org/c/openbmc/docs/+/55230

Moved the udev rules (70-leds.r

Moved udev rules and systemd service to repository.

Refactoring code to support the multihost physical LEDs design.
https://gerrit.openbmc.org/c/openbmc/docs/+/55230

Moved the udev rules (70-leds.rules) and systemd service from
meta-phosphor to phosphor-led-sysfs repository. This daemon will
handle the udev events and service instead of copying from machine
layer.

Tested : Tested and verfied in Facebook YosemiteV2 platform.

Signed-off-by: Jayashree Dhanapal <jayashree-d@hcl.com>
Change-Id: I978a135597eaa7f715af033b31cb50867e609710

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8c2372e8caa75e8d824a933cc5b2c38a2d401c9d

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I44db990b2509a639c17765e7db10314ed858bd4d

show more ...

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib97b55f55104518672a1c23ffc5eeb81011fc9d2

show more ...

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8f609948cb7ce65f3adb611ddd6eafa0bf4f486a

show more ...

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build.

Change-Id: Id725724bb38e2e84aa788d0b39d3786bb465c1a8
Signed-off-by: Pa

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build.

Change-Id: Id725724bb38e2e84aa788d0b39d3786bb465c1a8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix some warnings by cppcheck

Warning message:
sysfs.hpp:27:5: style: Class 'SysfsLed' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
SysfsLed(std::filesystem::p

Fix some warnings by cppcheck

Warning message:
sysfs.hpp:27:5: style: Class 'SysfsLed' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
SysfsLed(std::filesystem::path&& root) : root(std::move(root))
^
test/sysfs.cpp:53:5: style: Class 'FakeSysfsLed' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
FakeSysfsLed(fs::path&& path) : SysfsLed(std::move(path))

Tested: Use cppcheck to build successfully and eliminate the above
warning message.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ib6cef5cb4eb6f44f3b8dcc0e9d2b95bd15c9818a

show more ...

Add OWNERS file

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I58229a1988398401bae4a0212bf7f1badbb4bf63

Update clang-format

refer: https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format
`Don't break long string literals`

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Id0c7176

Update clang-format

refer: https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format
`Don't break long string literals`

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Id0c7176f7c039312497b792107f9464d20cf2134

show more ...

Remove autotools support

The intent behind this commit is build phosphor-led-sysfs with meson,
So clean up the autotools support.

Tested: built phosphor-led-sysfs successfully and worked.

Signed-o

Remove autotools support

The intent behind this commit is build phosphor-led-sysfs with meson,
So clean up the autotools support.

Tested: built phosphor-led-sysfs successfully and worked.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I217c3bf8e992bd3e58008559ee7adc313821b44c

show more ...

Add meson build

This commit is to add meson.build.
And later, we will remove Autotools and replace it with meson build.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I3107491093a6b69f9

Add meson build

This commit is to add meson.build.
And later, we will remove Autotools and replace it with meson build.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I3107491093a6b69f966bab6eeb4f2d7581bfa186

show more ...

Remove config.h

The intent behind this commit is to define `BUSNAME`, `OBJPATH` and
`DEVPATH` variables in the main method, because they do not need and
absolutely have no reason to use autotools to

Remove config.h

The intent behind this commit is to define `BUSNAME`, `OBJPATH` and
`DEVPATH` variables in the main method, because they do not need and
absolutely have no reason to use autotools to configure them,
so remove config.h.

Tested: built phsphor-led-sysfs successfully and worked.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ic8a7309dc58694fef94a2a7a6b8d4e53f92df5db

show more ...

Replace std::experimental::filesystem with std::filesystem

Above c++17, std::filesystem is already supported, so replace
std::experimental::filesystem with std::filesystem.

Signed-off-by: George Li

Replace std::experimental::filesystem with std::filesystem

Above c++17, std::filesystem is already supported, so replace
std::experimental::filesystem with std::filesystem.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I864bd80905e9b61428d17b20a91b3482198d20bc

show more ...

bootstrap: fix shellcheck warnings

Shellcheck reports issues in the [mostly] common bootstrap
script found in our autotools repositories. Apply fixes
for the issues reported by this tool:

- not ha

bootstrap: fix shellcheck warnings

Shellcheck reports issues in the [mostly] common bootstrap
script found in our autotools repositories. Apply fixes
for the issues reported by this tool:

- not handling filenames with spaces.
- not using portable `find` parameters.
- squash warning for purposeful string non-evaluation in
help-text.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86ef079c9632e5563a1a56d6a2e23aad59ecbc57

show more ...

ledSysfs: Replace IRC with Discord

Discord has more users, IRC traffic has ground to a halt.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I37828cea78da99451f5a3f5c06d3859149658ab6

test: Add test cases to cover brightness and asserted values

This commit adds test cases that will validate:

┌────────────┬──────────┬────────────────────────┐
│ brightness │ asserted │ brightnes

test: Add test cases to cover brightness and asserted values

This commit adds test cases that will validate:

┌────────────┬──────────┬────────────────────────┐
│ brightness │ asserted │ brightness && asserted │
├────────────┼──────────┼────────────────────────┤
│ 0 │ 0 │ 0 │
│ 0 │ 1 │ 0 │
│ 1 │ 0 │ 0 │
│ 1 │ 1 │ 1 │
└────────────┴──────────┴────────────────────────┘

where:
getMaxBrightness() would map to asserted value
getBrightness() would map to brightness value

Change-Id: Iac2373e61614750e2f2879da46973ff1ab06213b
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

Fix an error scenario where reading the file fails

When ledcontroller starts, it looks at sysfs entries to
populate its initial D-Bus values. In the case where the
read error's out for any reason, t

Fix an error scenario where reading the file fails

When ledcontroller starts, it looks at sysfs entries to
populate its initial D-Bus values. In the case where the
read error's out for any reason, the code sets the initial
state as On

This patch fixes that scenario by putting the default to Off.
Also, this patch will enable a usecase where one wants
to have virtual physical LEDs that are not backed by file system

Tested:

/tmp/phosphor-ledcontroller -p /sys/class/leds/virtual/foo/led &

busctl get-property xyz.openbmc_project.LED.Controller.virtual_foo_led
/xyz/openbmc_project/led/physical/virtual_foo_led
xyz.openbmc_project.Led.Physical State
s "xyz.openbmc_project.Led.Physical.Action.Off"

busctl set-property xyz.openbmc_project.LED.Controller.virtual_foo_led
/xyz/openbmc_project/led/physical/virtual_foo_led
xyz.openbmc_project.Led.Physical State
s "xyz.openbmc_project.Led.Physical.Action.Blink"

busctl get-property xyz.openbmc_project.LED.Controller.virtual_foo_led
/xyz/openbmc_project/led/physical/virtual_foo_led
xyz.openbmc_project.Led.Physical State
s "xyz.openbmc_project.Led.Physical.Action.Blink"

Change-Id: If4c880902a62939197129fc3b7ce8a73f2a7d137
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

Add test cases to validate state of physical LED

This commit adds code that verifies the state of
physical LED is appropriately set in various cases

Change-Id: I9eab752f6f2b47e719934c14ef95e775d36b

Add test cases to validate state of physical LED

This commit adds code that verifies the state of
physical LED is appropriately set in various cases

Change-Id: I9eab752f6f2b47e719934c14ef95e775d36bcaa0
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

Add support for --enable-oe-sdk

This commit enables running GTEST cases via make check

Change-Id: I4b74b9f9bde41f970fc2b1b388a888c7fb629bdd
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ib

Add support for --enable-oe-sdk

This commit enables running GTEST cases via make check

Change-Id: I4b74b9f9bde41f970fc2b1b388a888c7fb629bdd
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

clang-format: update to latest from docs repo

Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, update the C++ standard to Latest.

https://github.com/

clang-format: update to latest from docs repo

Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, update the C++ standard to Latest.

https://github.com/llvm/llvm-project/commit/e5032567903de19962333c4bf7d2edceaf4f9824#diff-b49a097415dff2837d9626d422c58ba8R82
https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Id5684236b64867ba631a3a00dadababe2c36db16

show more ...

build: add correct libsystemd dependency

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I068de971f7e57a86493d5d0d0be9fc944ec1ef2f

Add vishwa as Maintainer

Change-Id: I5c8bc8852ebce21a04ae2a8e38b2c685b18ce5ba
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

autotools: Fix autoconf-archive compatibility issues

autoconf-archive 2019-01-06 changed the setup of code coverage support.
Deal with both old and new. Based on Patrick Venture's similar patch in
o

autotools: Fix autoconf-archive compatibility issues

autoconf-archive 2019-01-06 changed the setup of code coverage support.
Deal with both old and new. Based on Patrick Venture's similar patch in
other repositories[1].

[1] https://github.com/openbmc/phosphor-pid-control/commit/90e9dbcae6c1df3127dd3de41f9d1e1b5a438828

Change-Id: Ifafda526794602801e7ac1b2f01e62c64f4220d7
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

Fix an issue and read Period from D-bus

1. Change the order of setTrigger(), setDelayOn() and setDelayOff(),
because delay_on and delay_off were only displayed after the setTrigger() was excuted.

Fix an issue and read Period from D-bus

1. Change the order of setTrigger(), setDelayOn() and setDelayOff(),
because delay_on and delay_off were only displayed after the setTrigger() was excuted.

2. Read Period from D-bus instead of "periodMs = 1000" when the blinkOperation() was excuted.

Change-Id: Ia1ed328aa986be9ccc4072a4a5b48da4a07978db
Signed-off-by: tony lee <tony.lee@quantatw.com>

show more ...