fault-monitor: Add OperationalStatus Functional monitoring

Currently, the default way is to update the Asserted property of
the LedManager by monitoring the `/xyz/openbmc_project/logging`
object pat

fault-monitor: Add OperationalStatus Functional monitoring

Currently, the default way is to update the Asserted property of
the LedManager by monitoring the `/xyz/openbmc_project/logging`
object path.

The intent behind this commit is to add another way to monitor the
`xyz.openbmc_project.State.Decorator.OperationalStatus` interface
of the Inventory D-Bus object, and check whether the Inventory
D-Bus object is associated with the LED group D-Bus object, and
then update the Asserted property of the LedManager.

Since both these methods handle the faults differently,
Only ONE of these 2 methods can be enabled and NOT both.

The first way is supported by default. To turn OFF the default way
AND turn ON this second way, Enable monitor-operational-status.

Tested:
- enable `monitor-operational-status` in bbappend file, built successfully.

- Before changing the `OperationalStatus` interface:
busctl get-property xyz.openbmc_project.Inventory.Manager
/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply1
xyz.openbmc_project.State.Decorator.OperationalStatus Functional
b true

busctl get-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/powersupply1_fault
xyz.openbmc_project.Led.Group Asserted
b false

busctl get-property xyz.openbmc_project.LED.Controller.front_psu
/xyz/openbmc_project/led/physical/front_psu xyz.openbmc_project.Led.Physical State
s "xyz.openbmc_project.Led.Physical.Action.Off"

- After changing the `OperationalStatus` interface:
busctl set-property xyz.openbmc_project.Inventory.
/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply1
xyz.openbmc_project.State.Decorator.OperationalStatus Functional b false

busctl get-property xyz.openbmc_project.Inventory.Manager
/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply1
xyz.openbmc_project.State.Decorator.OperationalStatus Functional
b false

(
If we have more than 1 LED Group D-Bus object:
Like: The system/chassis/motherboard/powersupply1 path contains
two sets of LEDGroup
{
"types":
{
"rType": "fru",
"fType": "fault_led_group"
},
"paths":
[
"/xyz/openbmc_project/led/groups/powersupply0_fault",
"/xyz/openbmc_project/led/groups/powersupply1_fault"
]
}
busctl get-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/powersupply0_fault xyz.openbmc_project.Led.Group Asserted
b true
)

busctl get-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/powersupply1_fault xyz.openbmc_project.Led.Group Asserted
b true

busctl get-property xyz.openbmc_project.LED.Controller.front_psu
/xyz/openbmc_project/led/physical/front_psu xyz.openbmc_project.Led.Physical State
s "xyz.openbmc_project.Led.Physical.Action.Blink"

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I36c47198168028ea2b55804cf66d0285847afbd4

show more ...

Add meson build

This commit is to add meson build.
And later, we will remove Autotools and replace it with meson build.

In addition, fixed Layout::LedAction construct parameter error in test
file.

Add meson build

This commit is to add meson build.
And later, we will remove Autotools and replace it with meson build.

In addition, fixed Layout::LedAction construct parameter error in test
file.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I58c9a2c9de928db288e77ca2d6aa807d36e70144

show more ...

clang-format: update to latest from docs repo

Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, udpate the C++ standard to Latest.

https://github.com/

clang-format: update to latest from docs repo

Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, udpate the C++ standard to Latest.

https://github.com/llvm/llvm-project/commit/e5032567903de19962333c4bf7d2edceaf4f9824#diff-b49a097415dff2837d9626d422c58ba8R82
https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Iaac09e3c11ead581114c4b7e45ff863ec56a63f6

show more ...

string: ensure string included when used

Latest upstream yocto appears to have removed a free include of string.
This is causing compile failures for files which do not include it
properly.

Signed-

string: ensure string included when used

Latest upstream yocto appears to have removed a free include of string.
This is causing compile failures for files which do not include it
properly.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I8df4c564af2c8e8294cdcb3e74f9d7cd106d4ec8

show more ...

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7b04e16b91dbb6eb229cb2d0d528c56f6b2ea0ba

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia4b7b6bd27bdcb68cb4ef6399f97966372bf4c2e

Change to use new association interface

The phosphor-logging code moved from implementing
org.openbmc.Associations to now implementing
xyz.openbmc_project.Association.Definitions. The property name

Change to use new association interface

The phosphor-logging code moved from implementing
org.openbmc.Associations to now implementing
xyz.openbmc_project.Association.Definitions. The property name was also
changed from associations to Associations.

Tested:
Put on a system with existing error log and verified application did not
fail on start up

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I046244039dd8fe663185b981bce875691769a0d8

show more ...

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ie7747c1a6581742b2256ba2ddaf985df303ec39f

Fix std::variant usage

We need to conform to the std::variant interface for sdbusplus to
eventually switch away from mapbox. The .get() interface is only
provided by mapbox and needs to be converted

Fix std::variant usage

We need to conform to the std::variant interface for sdbusplus to
eventually switch away from mapbox. The .get() interface is only
provided by mapbox and needs to be converted.

Change-Id: Ia41808d6bab73b097fc631fd9eff549be9a22415
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Add clang-format to repo

Add clang-format to repo.

Change-Id: Ib3f81524b66414df3e6c93d8a6df6e22c43841e0
Signed-off-by: Patrick Venture <venture@google.com>

fault-monitor: Catch GetSubTree exceptions

The C++ implementation of the mapper will throw an exception
if the passed in interface was not found on any paths, which
is expected to happen when fru-f

fault-monitor: Catch GetSubTree exceptions

The C++ implementation of the mapper will throw an exception
if the passed in interface was not found on any paths, which
is expected to happen when fru-fault-monitor checks for error
logs on startup and there aren't any. Catch that exception
and just continue on the path of there being no error logs.

Note this is made slightly more complicated by the fact that the
default constructor for sdbusplus::message is deleted, so one
cannot just do:

sdbusplus::message reply;
try
{
auto method = bus.new_method_call(...);
reply = bus.call(method);
}
...
reply.read(...);

Change-Id: Ic15c7112cbfe0f3df974748f90828f12255ec29a
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Remove trailing slash on path in GetObject call

The upcoming C++ mapper implementation needs it this way.

Tested: With the new mapper and this fix, the call works.

Change-Id: I9b65cb8e12ff0369517

Remove trailing slash on path in GetObject call

The upcoming C++ mapper implementation needs it this way.

Tested: With the new mapper and this fix, the call works.

Change-Id: I9b65cb8e12ff0369517ab82dca0be0fae5ae281c
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Romulus: Handle SdBusError Exceptions

Handle exceptions from the sdbusplus method call_noreply API.

The phosphor-fru-fault-monitor app would fail with the following
message on Romulus with the late

Romulus: Handle SdBusError Exceptions

Handle exceptions from the sdbusplus method call_noreply API.

The phosphor-fru-fault-monitor app would fail with the following
message on Romulus with the latest sdbusplus changes:
sd_bus_call noreply: org.freedesktop.DBus.Error.UnknownObject:
Unknown object '/xyz/openbmc_project/led/groups/core1_fault'.
Add error handling.

Tested: The phosphor-fru-fault-monitor does not core dump on Romulus.

Change-Id: I2bec59c0e0f483e8bfc0cb20a343cb05670212b7
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Removed unused header files

Will cause symbol collisions when this repository's local
error yaml is copied out during building so phosphor-logging
includes it in its elog-errors.hpp.

Change-Id: Ic4

Removed unused header files

Will cause symbol collisions when this repository's local
error yaml is copied out during building so phosphor-logging
includes it in its elog-errors.hpp.

Change-Id: Ic467418106d45b6b49b6cabec304c4ae64a3d76b
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Fix fault-monitor interfacesAdded msg parsing

With the latest sdbusplus exception handling changes,
an exception was being thrown when trying to read a pair
out of the interfacesAdded signal message

Fix fault-monitor interfacesAdded msg parsing

With the latest sdbusplus exception handling changes,
an exception was being thrown when trying to read a pair
out of the interfacesAdded signal message.

Change the code to read the path and map separately.

Also modified the name of the data structures to match
what the message actually returned.

Tested: The exception journal entries went away and LEDs
will turn on and off again.

Change-Id: I2c72000e0da365743715da966a0c9e571efd33d5
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add error handling to message parsing

Some of the messages we try and parse are not structured in the
format we expect when parsing. When error logging is enabled in
sdbusplus this causes the phosph

Add error handling to message parsing

Some of the messages we try and parse are not structured in the
format we expect when parsing. When error logging is enabled in
sdbusplus this causes the phosphor-fru-fault-manager to crash. Fix
this crashing by logging errors and ignoring the bad signals and
message responses.

Change-Id: Ie817beaae96961b33a343aabf1dbba9f31606d4b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Move down error entry trace

It's possible that multiple services can provide the
/xyz/openbmc_project/logging paths, which means the
interfaces added handler can get multiple callbacks
for a single

Move down error entry trace

It's possible that multiple services can provide the
/xyz/openbmc_project/logging paths, which means the
interfaces added handler can get multiple callbacks
for a single error.

That being the case, move down the trace that shows
the new error log object path until after the code
checks that the association interface is present, as
that interface will only be present on one object.

Another option would have been to remove the trace
completely, but it is fairly useful for debug.

Change-Id: I98659562ef024455762110e20109bf3079b96cbe
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Use interfaces-removed for association removes

The mapper will no longer emit properties-changed signals
when the last endpoints property is removed from the fault
association object. It will only e

Use interfaces-removed for association removes

The mapper will no longer emit properties-changed signals
when the last endpoints property is removed from the fault
association object. It will only emit an interfaces-removed
signal in that case, so change the code to subscribe to the
interfaces-removed signal instead.

Change-Id: I225376e550d21b82473015324cd9a261e16fe6db
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Remove incorrect error log when no errors present.

An error was logged while starting the fru fault monitor
with no existing error logs, which is not correct.

Resolves openbmc/openbmc#2330

Change-

Remove incorrect error log when no errors present.

An error was logged while starting the fru fault monitor
with no existing error logs, which is not correct.

Resolves openbmc/openbmc#2330

Change-Id: I6b222b45dd99b653443c58d9982d6576f8af0bfa
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Assert LEDs for existing callouts while service starts

Resolves openbmc/openbmc#1631

Change-Id: I1639c84cbb180dfe7f6494b5e80ca45514a3e730
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.

Assert LEDs for existing callouts while service starts

Resolves openbmc/openbmc#1631

Change-Id: I1639c84cbb180dfe7f6494b5e80ca45514a3e730
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Fix for mapper errors during logging service restart

There was a race condition while calling mapper from led monitoring after
error logs started persisting, to avoid such errors the callout informa

Fix for mapper errors during logging service restart

There was a race condition while calling mapper from led monitoring after
error logs started persisting, to avoid such errors the callout information is
now extracted from the message received as part of interface added signal.

Resolves openbmc/openbmc#1853

Change-Id: Ie913992bdcb3b1cb93677d64331db34202f8ae72
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

use new sdbusplus match constructors

Change-Id: Id833073b9e45fae24d6bd0e7f9310ef0ba8658de
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

Implement led assert and deassert based on faults

Change-Id: I28378b155da15282b1b5bf0403075b55bda5b70d
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

Add class and stub for fru fault monitor application

This application waits for new fault entries and resolution of
exiting faults to assert or deassert LED for the corresponding FRUs,
respectively.

Add class and stub for fru fault monitor application

This application waits for new fault entries and resolution of
exiting faults to assert or deassert LED for the corresponding FRUs,
respectively.

Change-Id: I92ead0c8d3132dd7a6740b536231d6588ac42471
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...