updater: send hash file contents

Send the hash file contents to the firmware image or tarball can be
verified, for whatever verification process is used by a platform.

Tested: Verified md5sum of /t

updater: send hash file contents

Send the hash file contents to the firmware image or tarball can be
verified, for whatever verification process is used by a platform.

Tested: Verified md5sum of /tmp/bmc.sig matches the signature file's
hash on the host. Sent the contents over P2A. The implementation uses
the same data pathway for the firmware image and the signature file.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Icbc7fddc4587059004935cf51063797b25f76ad0

show more ...

pci: implement sending firmware image over p2a

Implement sending firmware image over p2a via the aspeed-p2a-ctrl
driver.

Test configuration:
# Image is static, uses the PCI bridge, and requires the

pci: implement sending firmware image over p2a

Implement sending firmware image over p2a via the aspeed-p2a-ctrl
driver.

Test configuration:
# Image is static, uses the PCI bridge, and requires the ASPEED
# PCI-to-AHB hardware implementation.
EXTRA_OECONF_append_quanta-q71l = " --enable-static-layout"
EXTRA_OECONF_append_quanta-q71l = " --enable-pci-bridge"
EXTRA_OECONF_append_quanta-q71l = " --enable-aspeed-p2a"
EXTRA_OECONF_append_quanta-q71l = " MAPPED_ADDRESS=0x47FF0000"

Tested: Verified via md5sum the image-bmc file sent from the host via
this tool matches the hash of /run/initramfs/bmc-image. This code can
be used to send any file down, but was only tested with a "static"
layout build.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I430bc7444f06f4f93a63e3bf2646bd195eaa2e52

show more ...

add exception catch-all in main

Catch all derived exceptions that may be thrown from the Updater.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I7ab1e74fc1378a3e8f73eae40295e42ef7a

add exception catch-all in main

Catch all derived exceptions that may be thrown from the Updater.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I7ab1e74fc1378a3e8f73eae40295e42ef7a2833a

show more ...

tools: main: update ipmi-blob-tool constructors

ipmi-blob-tool changed the constructors to perform explicit ownership of
the inputs. Therefore, update our constructions to obey this pattern.

Signe

tools: main: update ipmi-blob-tool constructors

ipmi-blob-tool changed the constructors to perform explicit ownership of
the inputs. Therefore, update our constructions to obey this pattern.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I8029ce2ced3d75505f918a66afdc5fd61409c69d

show more ...

tools: io: do aligned read/write mapping

Align the mmap by pagesize.

Tested: Verified alignment is correct and mmap succeeds where it would
fail on a mis-aligned call.
Signed-off-by: Patrick Ventur

tools: io: do aligned read/write mapping

Align the mmap by pagesize.

Tested: Verified alignment is correct and mmap succeeds where it would
fail on a mis-aligned call.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I76a4f94415c9337d8ca983e24a18e3e4fc701564

show more ...

tools: p2a: read the PCI configuration

Read the PCI configuration from the blob handler itself. Don't use this
yet, but read it.

Tested: Verified with a bugfix in ipmi-blob-tool that it was able t

tools: p2a: read the PCI configuration

Read the PCI configuration from the blob handler itself. Don't use this
yet, but read it.

Tested: Verified with a bugfix in ipmi-blob-tool that it was able to
read back and print the value configured into the BMC image.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I49a8c93508e64a65fd37b50ec2b437f0016272f2

show more ...

bugfix: result.bars[1] may be used uninitialized

Tools bugfix where if the result isn't assigned, it's still used.
Therefore, add a proper exit condition. This was developed on a system
with the de

bugfix: result.bars[1] may be used uninitialized

Tools bugfix where if the result isn't assigned, it's still used.
Therefore, add a proper exit condition. This was developed on a system
with the device, and interestingly, this compilation warning->error
wasn't hit during CI, only with bitbake. Therefore, different flags
must be involved between the two.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ifca7046657b65a425b0c3bf4fe05dd42bd7a8a14

show more ...

tools: p2a: check aspeed bridge

Check whether the pci-to-ahb bridge is enabled. It should be enabled
because this comes after the firmware blob is opened for writing.

Tested: Verified it reports t

tools: p2a: check aspeed bridge

Check whether the pci-to-ahb bridge is enabled. It should be enabled
because this comes after the firmware blob is opened for writing.

Tested: Verified it reports the correct state of the value.
Change-Id: I04bd21fdbf65938164f5845c0ec46e2231b17bd9
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: io: add read method

Add method for reading the host's memory to enable reading the PCI
configuration.

Tested: Verified it's able to read a memory BAR associated with the
ASPEED ast2400.

Cha

tools: io: add read method

Add method for reading the host's memory to enable reading the PCI
configuration.

Tested: Verified it's able to read a memory BAR associated with the
ASPEED ast2400.

Change-Id: Id06f30b063e69825f2dfa69786b69392657f7b1c
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

p2a: add initial p2a support (empty)

Add initial pci-to-ahb host-side support, by just listing the aspeed pci
devices.

Tested: This dumped the aspeed PCI device listed on my test platform.
Change-I

p2a: add initial p2a support (empty)

Add initial pci-to-ahb host-side support, by just listing the aspeed pci
devices.

Tested: This dumped the aspeed PCI device listed on my test platform.
Change-Id: I6dc4aeb3b38ec2f95bfd716bda2d8eb4786328ab
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: add check for pciutils: libpci

Add a check for the pciutils package that the tool relies on for
compilation.

Change-Id: Ie12ede94bc3664a3cf1194d820f9c6e078f97866
Signed-off-by: Patrick Ventu

build: add check for pciutils: libpci

Add a check for the pciutils package that the tool relies on for
compilation.

Change-Id: Ie12ede94bc3664a3cf1194d820f9c6e078f97866
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

use ipmiblob library from ipmi-blob-tool

Drop all code that is now handled by the ipmiblob library provided by
the new ipmi-blob-tool. This is a library that can be included on the
BMC if necessary

use ipmiblob library from ipmi-blob-tool

Drop all code that is now handled by the ipmiblob library provided by
the new ipmi-blob-tool. This is a library that can be included on the
BMC if necessary, but relies on nothing that is strictly meant for the
BMC.

Change-Id: Iadbf0bd89c58cafc436fba05ea43e21c49e2b669
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: enable code coverage

Enable code coverage for the project. Valgrind not enabled in this
step.

Change-Id: I519bac32acc58ba388dc3724e187255d3237c085
Signed-off-by: Patrick Venture <venture@go

build: enable code coverage

Enable code coverage for the project. Valgrind not enabled in this
step.

Change-Id: I519bac32acc58ba388dc3724e187255d3237c085
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: blob_handler: add some const ness

Many pointers cast that should be const by use-case were missing this.

Change-Id: Ib75a210d731d731ef07f59d4132f70e5cfd324bf
Signed-off-by: Patrick Venture <

tools: blob_handler: add some const ness

Many pointers cast that should be const by use-case were missing this.

Change-Id: Ib75a210d731d731ef07f59d4132f70e5cfd324bf
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: implement blob read

Implement blob read. This isn't currently used by the flash update
process however, it is useful.

Tested: Verified it read back bytes written to another blob handler.
Ch

tools: implement blob read

Implement blob read. This isn't currently used by the flash update
process however, it is useful.

Tested: Verified it read back bytes written to another blob handler.
Change-Id: Ib1590448d0bfaa3d4fde20ae8bae353c9107e5c4
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: updater: iterate via string instead of auto

Use a std::string declaration instead of auto to add backwards
compatibility and because it's clearly only ever going to be a string
and we're doin

tools: updater: iterate via string instead of auto

Use a std::string declaration instead of auto to add backwards
compatibility and because it's clearly only ever going to be a string
and we're doing a c-string check.

Change-Id: I89bf9076cdc711209a75684a984a39c058367355
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: move blobs methods to private

These mehthods are not meant to be called by other objects.

Change-Id: I4870d05585f3e069aaadb86ea67dba61c4498f6f
Signed-off-by: Patrick Venture <venture@google.

tools: move blobs methods to private

These mehthods are not meant to be called by other objects.

Change-Id: I4870d05585f3e069aaadb86ea67dba61c4498f6f
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: tie devmem io handler into lpc handler

The lpc handler requires mapping memory on the host.

Change-Id: Ic851dfa6c06d10566f66153ce7915cf5ad66992b
Signed-off-by: Patrick Venture <venture@googl

tools: tie devmem io handler into lpc handler

The lpc handler requires mapping memory on the host.

Change-Id: Ic851dfa6c06d10566f66153ce7915cf5ad66992b
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: add io interface for mmio, etc

Add an IO interface for host-side memory access. This is done as an
interface to allow platform specific implementations.

Change-Id: Id8e35d5beb21f7db544e27d6

tools: add io interface for mmio, etc

Add an IO interface for host-side memory access. This is done as an
interface to allow platform specific implementations.

Change-Id: Id8e35d5beb21f7db544e27d6592bbeac58748dcb
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: lpc configuration structure is packed

Pack the configuration structure.

Change-Id: Ib0a2ad82c0afae2a1883a492b60da286a8776dd7
Signed-off-by: Patrick Venture <venture@google.com>

tools: lpc: add internal/sys to handler

The lpc data handler will need a syscall handle. Add the syscall
interface.

Change-Id: I8a9f687e9457709e2d0f0fca3e712719fa106e80
Signed-off-by: Patrick Vent

tools: lpc: add internal/sys to handler

The lpc data handler will need a syscall handle. Add the syscall
interface.

Change-Id: I8a9f687e9457709e2d0f0fca3e712719fa106e80
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: minor cleanup, drop member return inline

Return the value from within the function instead of storing it in a
class member.

Change-Id: I8ee96d0c8bfff91fd9b14797de5a388456ef142d
Signed-off-by

tools: minor cleanup, drop member return inline

Return the value from within the function instead of storing it in a
class member.

Change-Id: I8ee96d0c8bfff91fd9b14797de5a388456ef142d
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: lpc: start implementation, send metadata

With the LPC interface, send the window information to the BMC.

Tested: Ran on test system and verified window mapped via ioctl to
driver as expected

tools: lpc: start implementation, send metadata

With the LPC interface, send the window information to the BMC.

Tested: Ran on test system and verified window mapped via ioctl to
driver as expected.

Change-Id: I7ffac6b52205b215fd698a574d098b505091c3d4
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: blob add writeMeta to interface

Add the blob write metadata command to the interface. The LPC interface
will use write meta to configure the BMC's window.

Change-Id: I0266e62174fac428bf0fb8

tools: blob add writeMeta to interface

Add the blob write metadata command to the interface. The LPC interface
will use write meta to configure the BMC's window.

Change-Id: I0266e62174fac428bf0fb84fb9d128451b69e4d8
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: specify common ipmi errors for humans

Add a check for common ipmi failure codes to the IPMI exception object
to make the messages more human readable.

Change-Id: If143a3a63748c258b2fdc4fd074

tools: specify common ipmi errors for humans

Add a check for common ipmi failure codes to the IPMI exception object
to make the messages more human readable.

Change-Id: If143a3a63748c258b2fdc4fd074cf5070c0b88d9
Signed-off-by: Patrick Venture <venture@google.com>

show more ...