| 374350d7 | 15-Mar-2019 |
William A. Kennington III <wak@google.com> |
autotools: Fix for autoconf-archive 2019.01.19
The code coverage macros from the archive changed in a backward
incompatible way. This adds a workaround to autodetect either version
and do the right
autotools: Fix for autoconf-archive 2019.01.19
The code coverage macros from the archive changed in a backward
incompatible way. This adds a workaround to autodetect either version
and do the right thing.
Change-Id: I09b88e6b4792c99140a73a4ceb11d2896ee13562
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| de8a16e2 | 07-Mar-2019 |
Patrick Venture <venture@google.com> |
use ipmiblob library from ipmi-blob-tool
Drop all code that is now handled by the ipmiblob library provided by
the new ipmi-blob-tool. This is a library that can be included on the
BMC if necessary
use ipmiblob library from ipmi-blob-tool
Drop all code that is now handled by the ipmiblob library provided by
the new ipmi-blob-tool. This is a library that can be included on the
BMC if necessary, but relies on nothing that is strictly meant for the
BMC.
Change-Id: I2b02ae0d432e84c08e598d27eef85b57c06a70fc
Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
| 48eb4029 | 08-Mar-2019 |
Patrick Venture <venture@google.com> |
use filesystem instead of experimental
Use filesystem now that it should be available instead of
experimental::filesystem.
Change-Id: Ia9b17f33ced70fe2f1f12f11d8708d15ff422bfa
Signed-off-by: Patric
use filesystem instead of experimental
Use filesystem now that it should be available instead of
experimental::filesystem.
Change-Id: Ia9b17f33ced70fe2f1f12f11d8708d15ff422bfa
Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
| fd4cdea4 | 07-Mar-2019 |
Patrick Venture <venture@google.com> |
build: enable valgrind
Enable valgrind tests.
Change-Id: Ib5ec22a19c043ef45f5274e4716e2abbae9c19da
Signed-off-by: Patrick Venture <venture@google.com> |
| a2efc76b | 06-Mar-2019 |
Patrick Venture <venture@google.com> |
build: enable code coverage
Enable code coverage for the project. Valgrind not enabled in this
step.
Change-Id: I439d58b23d2bc29d6f602600319074c8fd8c04d6
Signed-off-by: Patrick Venture <venture@go
build: enable code coverage
Enable code coverage for the project. Valgrind not enabled in this
step.
Change-Id: I439d58b23d2bc29d6f602600319074c8fd8c04d6
Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
| fb808d11 | 06-Mar-2019 |
Patrick Venture <venture@google.com> |
build: rework gtest checks
Rework gtest checks to be modeled after openbmc/gpioplus.
Change-Id: I263bf12c0323ebee5d95b569ce28da2042bd3c1d
Signed-off-by: Patrick Venture <venture@google.com> |
| 86c87f55 | 01-Feb-2019 |
Patrick Venture <venture@google.com> |
manager: add hard-coded read checks
The host-client cannot try to read back more than this number of bytes
without hitting a memory overflow in phosphor-host-ipmid. The method we
can call to dynami
manager: add hard-coded read checks
The host-client cannot try to read back more than this number of bytes
without hitting a memory overflow in phosphor-host-ipmid. The method we
can call to dynamically receive that number isn't currently linking out
of the userlayer library.
Note: Once the configure_ac can find and provide the userlayer library
from phosphor-host-ipmid, we can remove the hard-coded 64 and 0xe.
Change-Id: I08f6bb59ce44279f76a494dccaa477ae75d532c4
Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
| cd8dab49 | 15-Jan-2019 |
Patrick Venture <venture@google.com> |
stop installing manager header
Stop installing the manager header as it is no longer meant to be
exported, but rather used only internally within this repository.
Change-Id: I2ab21a31fd745e1b3e36fc
stop installing manager header
Stop installing the manager header as it is no longer meant to be
exported, but rather used only internally within this repository.
Change-Id: I2ab21a31fd745e1b3e36fc39ffea5e26d373ff51
Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
| d1c3e86f | 10-Jan-2019 |
Patrick Venture <venture@google.com> |
bugfix: process: can be only crc
The read command, if returning 0 bytes of data, does return the CRC.
Tested: Verified via a client implementation that it now behaves as
expected on returning 0 byt
bugfix: process: can be only crc
The read command, if returning 0 bytes of data, does return the CRC.
Tested: Verified via a client implementation that it now behaves as
expected on returning 0 bytes from a read (returns only the CRC).
Change-Id: I84200c0fbe8400cc9234b55991fee750cb84faa2
Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
| c18e2b64 | 21-Nov-2018 |
Patrick Venture <venture@google.com> |
add dynamic library interface to enable testing
Add interface defining the methods for dynamic linking to enable
testing.
Change-Id: If4d090d3cedc019b426435a1f651191803bfc1a9
Signed-off-by: Patrick
add dynamic library interface to enable testing
Add interface defining the methods for dynamic linking to enable
testing.
Change-Id: If4d090d3cedc019b426435a1f651191803bfc1a9
Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
| ebf7b9b6 | 13-Nov-2018 |
Patrick Venture <venture@google.com> |
bugfix: skip 0'd crc bytes on reply computation
Skip the 0'd CRC bytes on reply computation, mirroring the skipping
during request validation.
Tested: Verified via client the CRC for the reply now
bugfix: skip 0'd crc bytes on reply computation
Skip the 0'd CRC bytes on reply computation, mirroring the skipping
during request validation.
Tested: Verified via client the CRC for the reply now matches
expectations.
Change-Id: I18da28604a388fb4210c55f3e54410a067b9f10a
Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
| 41258800 | 12-Nov-2018 |
Patrick Venture <venture@google.com> |
process: add IPMI error return mechanism and update errors
The IPMI packet validation code must return specific IPMI errors
corresponding to what error has occurred instead of the invalid command
er
process: add IPMI error return mechanism and update errors
The IPMI packet validation code must return specific IPMI errors
corresponding to what error has occurred instead of the invalid command
error.
Update all IPMI handler pieces to return more specific errors.
Change-Id: I8d21e92015d84cc0880e3b83991aed7288e19eab
Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
| 5c4b17b2 | 04-Oct-2018 |
Patrick Venture <venture@google.com> |
new command: BmcBlobWriteMeta
Implement new command BmcBlobWriteMeta.
Change-Id: I2e148f4bde4ef5d24db7e30bb02bdde024d9166a
Signed-off-by: Patrick Venture <venture@google.com> |
| 7210b310 | 03-Oct-2018 |
Patrick Venture <venture@google.com> |
header: install test mock headers
IPMI Blob handlers will need to include these mocks when building
unit-tests. Therefore, they must be installed.
Change-Id: I4c8ed0fa1a4a8912853c024206ef5e61f8770
header: install test mock headers
IPMI Blob handlers will need to include these mocks when building
unit-tests. Therefore, they must be installed.
Change-Id: I4c8ed0fa1a4a8912853c024206ef5e61f87707d8
Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
| aceb4baa | 27-Sep-2018 |
Patrick Venture <venture@google.com> |
move blobs and manager header into installation dir
The blobs and manager header will be used by handlers once we've
transitioned to dynamic loading.
Change-Id: Ieae8fcfe383007731cb4f8b2619612c3bfa
move blobs and manager header into installation dir
The blobs and manager header will be used by handlers once we've
transitioned to dynamic loading.
Change-Id: Ieae8fcfe383007731cb4f8b2619612c3bfa47f50
Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
| ef3aeadc | 12-Sep-2018 |
Patrick Venture <venture@google.com> |
initial drop of phosphor-ipmi-blobs
This implements a majority of the OEM IPMI BLOBS protocol. The only
piece missing from this is the timed expiration of sessions.
Change-Id: I82c9d17b625c94fc334
initial drop of phosphor-ipmi-blobs
This implements a majority of the OEM IPMI BLOBS protocol. The only
piece missing from this is the timed expiration of sessions.
Change-Id: I82c9d17b625c94fc3340edcfabbbf1ffeb5ad7ac
Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|