mainloop: Make HwmonIO injectable dependency

HwmonIO was make into a interface object implementation. This patch
transitions mainloop to receive a pointer to this interface to allow for
injection t

mainloop: Make HwmonIO injectable dependency

HwmonIO was make into a interface object implementation. This patch
transitions mainloop to receive a pointer to this interface to allow for
injection testing.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Iaa470fafccb42c4d7fbabac0dc92f96c8075faf2

show more ...

mainloop: add helper methods for sensor removal

Add a helper method that will remove from dbus sensors that are marked
for removal and another helper method that will attempt to add sensors
marked f

mainloop: add helper methods for sensor removal

Add a helper method that will remove from dbus sensors that are marked
for removal and another helper method that will attempt to add sensors
marked for removal back.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Iecb96045cc63d93f2896af9f6a8c2672ca8fcbb2

show more ...

sensor: remove redundant condition

[sensor.cpp:147]: (style) Redundant condition: statusIface.
'!statusIface || (statusIface && statusIface->functional())' is
equivalent to '!statusIface || statusIf

sensor: remove redundant condition

[sensor.cpp:147]: (style) Redundant condition: statusIface.
'!statusIface || (statusIface && statusIface->functional())' is
equivalent to '!statusIface || statusIface->functional()'

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I4f3c3f6e2e009dfaffc5671dc94b2f553f7029ef

show more ...

rename Object type to InterfaceMap

Rename the Object type to InterfaceMap to give it a less opaque name.
The word object is somewhat overloaded.

Signed-off-by: Patrick Venture <venture@google.com>

rename Object type to InterfaceMap

Rename the Object type to InterfaceMap to give it a less opaque name.
The word object is somewhat overloaded.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ie1862450c15c8a8cecf7fcbec3552608d6a20cce

show more ...

types: add missing headers

Add missing explicit headers to avoid indirect header inclusion
dependencies.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I889fb1b7e62dbac1a9347421e97a

types: add missing headers

Add missing explicit headers to avoid indirect header inclusion
dependencies.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I889fb1b7e62dbac1a9347421e97a41716f02b20d

show more ...

sensor: Implement RAII object for GPIO unlock and lock

There is a bug where GPIO lock may not be called if there is an
exception after GPIO unlock. Adding an RAII object for GPIO lock
and replacing

sensor: Implement RAII object for GPIO unlock and lock

There is a bug where GPIO lock may not be called if there is an
exception after GPIO unlock. Adding an RAII object for GPIO lock
and replacing the current usage of gpioUnlock, gpioLock in
sensor.cpp and mainloop.cpp.

Bug: openbmc/phosphor-hwmon#11
Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: Ica094e716a6ff9dc99165651f83fc496d5ed5a17

show more ...

Emit signal and remove sensors from dbus

When a sensor is configured to be removed upon certain return codes
being returned when read, that sensor object should emit the proper
signals and be remove

Emit signal and remove sensors from dbus

When a sensor is configured to be removed upon certain return codes
being returned when read, that sensor object should emit the proper
signals and be removed from dbus. This may have previously been
occurring but recently it was noticed that is not the case, so emit an
object removed signal so the sensor object is removed from dbus and any
applications subscribed to that sensor will be notified.

Tested:
For a sensor configured to be removed upon a rc, triggered that bad
sensor read rc and used `busctl monitor` to see signals.

Change-Id: Ia9557ea548bd5a00a9bd6fdf91d4aa91d8458225
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Use std::filesystem::path::relative_path()

Use that function instead of making a relative path manually.

Change-Id: I64908353295a10af09baa91bab5d1c3a0152e994
Signed-off-by: Matt Spinler <spinler@us

Use std::filesystem::path::relative_path()

Use that function instead of making a relative path manually.

Change-Id: I64908353295a10af09baa91bab5d1c3a0152e994
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Change-Id: I298c17fb2bf6fcb6a949624f8bb2475f3878545f
Signed-off-by: Patrick Venture <venture@google.com>

build: enable valgrind

Enable valgrind to check memory usage.

Change-Id: I73ec2ee1a92e797ea9b78d6ea440f9ccdd2f49f3
Signed-off-by: Patrick Venture <venture@google.com>

flip error and help message on failure

Flip the error and help message on failure.

Change-Id: Ib75d6df87a37411edd7283fdf7785e8d56e417ea
Signed-off-by: Patrick Venture <venture@google.com>

swap out getopts for cli11

Swap out getopt for cli11 for parsing parameters.

Tested: Verified on quanta-q71l-variant that phosphor-hwmon started as
before.
Change-Id: Ic0137432afd254b77133842b5d73a

swap out getopts for cli11

Swap out getopt for cli11 for parsing parameters.

Tested: Verified on quanta-q71l-variant that phosphor-hwmon started as
before.
Change-Id: Ic0137432afd254b77133842b5d73a5bab1e415aa
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: enable code coverage

Enable code coverage for the project. Valgrind not enabled in this
step.

Tested: Verified code coverage step now running.
Change-Id: Ieb3606e5ad741fb0dd181f8da594c18258

build: enable code coverage

Enable code coverage for the project. Valgrind not enabled in this
step.

Tested: Verified code coverage step now running.
Change-Id: Ieb3606e5ad741fb0dd181f8da594c18258efa6bc
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Don't std::filesystem::path::/= an absolute path

Unlike std::experimental::filesystem::path, with
std::filesystem::path, the /= operator will turn an append
of an absolute path (starts with a '/') i

Don't std::filesystem::path::/= an absolute path

Unlike std::experimental::filesystem::path, with
std::filesystem::path, the /= operator will turn an append
of an absolute path (starts with a '/') into a '='.

So, ensure the paths aren't absolute.

Change-Id: Ie8fb9d056042e277415e8ea0eb29d094a2665611
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

use filesystem instead of experimental

Use filesystem now that it should be available instead of
experimental::filesystem.

Change-Id: I62838b343ce34f85a47661f1eaaff3c7e6338bbf
Signed-off-by: Patric

use filesystem instead of experimental

Use filesystem now that it should be available instead of
experimental::filesystem.

Change-Id: I62838b343ce34f85a47661f1eaaff3c7e6338bbf
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

test: rework gtest/gmock lookup

Rework the gtest/gmock lookup based on openbmc/gpioplus.

Change-Id: Ic53928e6f8b7a30e801976d62c910fe31bd4cc49
Signed-off-by: Patrick Venture <venture@google.com>

test: rework to use Pair-wise comparison

Use Pair-wise comparison instead of straight equality check.

Change-Id: I3aa567015bfbd81578275fc0edf1ef785fde7678
Signed-off-by: Patrick Venture <venture@go

test: rework to use Pair-wise comparison

Use Pair-wise comparison instead of straight equality check.

Change-Id: I3aa567015bfbd81578275fc0edf1ef785fde7678
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Cleanup _gitignore

Cleanup the .gitignore file, and add some new pieces for code coverage.

Change-Id: I26c961956b07b51018c7edc50459bf2fe09541fc
Signed-off-by: Patrick Venture <venture@google.com>

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: Iad7753b8e6a80307ad57a9a6dd2d4

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: Iad7753b8e6a80307ad57a9a6dd2d442ec7fe0e67
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

test: add adjustvalue test

Add a test that calls adjust value on a sensor value to verify it's
processed as expected.

Change-Id: Iff299efced680c730d7ba5bdeff71617446db042
Signed-off-by: Patrick Ven

test: add adjustvalue test

Add a test that calls adjust value on a sensor value to verify it's
processed as expected.

Change-Id: Iff299efced680c730d7ba5bdeff71617446db042
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

sensor: set scale to 0 in constructor

The _scale member will not be used without ::addValue() being called
first, however, initialize it regardless to 0.

Change-Id: I712e9192500a8a58db03bcbbaf0f0d7

sensor: set scale to 0 in constructor

The _scale member will not be used without ::addValue() being called
first, however, initialize it regardless to 0.

Change-Id: I712e9192500a8a58db03bcbbaf0f0d736f1dfd23
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: cleanup configure script PKG_CHECK_MODULES

Cleanup the configure script package include lines. There isn't a set
style for this yet, but this is an attempt to improve readability
whereas it'

build: cleanup configure script PKG_CHECK_MODULES

Cleanup the configure script package include lines. There isn't a set
style for this yet, but this is an attempt to improve readability
whereas it's often one long line per library.

Change-Id: I9df8c9384b54bba30bb49193ee2dd6e532f99249
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

sensor: add gpio handle test variation

Add a sensor constructor test where the gpio handle is required.

Change-Id: I05050fb71a6287183ca94f974e965e3f58de9499
Signed-off-by: Patrick Venture <venture@

sensor: add gpio handle test variation

Add a sensor constructor test where the gpio handle is required.

Change-Id: I05050fb71a6287183ca94f974e965e3f58de9499
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

sensor: add underscore prefix to members

Add underscore prefix to members for sensor object.

Change-Id: I5b59f9f45cc20bd700940bc3b0e5d2d4127b333d
Signed-off-by: Patrick Venture <venture@google.com>

test: add gpiohandle mock impl

Add gpio handle mock implementation for use in testing.

Change-Id: I0fb2d1af4739ad700f62a4e7cbbe62db528bb93e
Signed-off-by: Patrick Venture <venture@google.com>