sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86dfa77a53a306b0e868eeb82de30b270704c455

show more ...

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I661217b08dcbc7a2e498dc71b0097ac5123efc70

show more ...

Use proper path in service file

Using '/usr/bin/env' is now an antipattern.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I1e37bf97f16b74eab2e4d40892e042f03dd5023b

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit` or `action::emit_no_signals` as appropriate.

- Value: defer_emit (primary object)
- Others: emit_no_signals (secondary objects)

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I892a1c953231123aa5407b388ff9133882d80feb

show more ...

MAINTAINERS/OWNERS: Removal of `msbarth`

Change-Id: I1faaaf72edf925a3be99d1ad6c93f98ff485ca45
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

phosphor-hwmon: Remove venture from reviewer

Change-Id: I8d1241d6296f1ee9515679a5d0f4f4d75318fbfc
Signed-off-by: Willy Tu <wltu@google.com>

clang-format with latest clang

New clang, new format

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I822c00ec321bdcbfd20adbb050c02b994da179a7

Add OWNERS file

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I702c2eda94d453938c525e5808c97b17b2dbc3f9

build: switch to C++20

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4699bde837bcad3b9d9123bbafe0dd8bffcb97f6

sensor: accept single sensor threshold

Currently, sensors require a couple of LC/UC and/or LNC/UNC. However, in
real hardware design, there might be only one of LC, UC, LNC or UNC
available.
This ch

sensor: accept single sensor threshold

Currently, sensors require a couple of LC/UC and/or LNC/UNC. However, in
real hardware design, there might be only one of LC, UC, LNC or UNC
available.
This change allows to specify only single sensor threshold.

Tested:
1. Specify only UC threshold for PSU0_Temp sensor
2. root@mtjade:~# ipmitool sensor get PSU0_TEMP
Locating sensor record...
Sensor ID : PSU0_TEMP (0xf3)
Entity ID : 30.58
Sensor Type (Threshold) : Temperature
Sensor Reading : 26 (+/- 0) degrees C
Status : ok
Lower Non-Recoverable : na
Lower Critical : na
Lower Non-Critical : na
Upper Non-Critical : na
Upper Critical : 64.000
Upper Non-Recoverable : na
Positive Hysteresis : Unspecified
Negative Hysteresis : Unspecified

Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
Change-Id: I70fa136c6d96a6edc2ed1a6a65eee85b6ff62e39

show more ...

build: test: Fix invalid variable

We don't define the build_tests variable, reference the option directly
instead.

Change-Id: Ic190c083c2c4ebd4c1b3715cea39b563e0294b6d
Signed-off-by: William A. Ken

build: test: Fix invalid variable

We don't define the build_tests variable, reference the option directly
instead.

Change-Id: Ic190c083c2c4ebd4c1b3715cea39b563e0294b6d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Hardcode SensorValueType to double

A newer version of the compiler does not like how the sensor value type
was being determined from the D-Bus interface class, so just hardcode it
to double. This w

Hardcode SensorValueType to double

A newer version of the compiler does not like how the sensor value type
was being determined from the D-Bus interface class, so just hardcode it
to double. This was originally put in when the project was
transitioning from using an int64_t to a double for the type, but that's
been done for awhile now.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: If6a41e3ca43cf12cdebfb2137389b47a0d9dd947

show more ...

sensor: Implement sensor "ASYNC_READ_TIMEOUT"

This change will prevent sensors from blocking all other sensor reads
and D-Bus if they do not report failures quickly enough.

If "ASYNC_READ_TIMEOUT"

sensor: Implement sensor "ASYNC_READ_TIMEOUT"

This change will prevent sensors from blocking all other sensor reads
and D-Bus if they do not report failures quickly enough.

If "ASYNC_READ_TIMEOUT" environment variable is defined in the
sensor's config file for a key_type, the sensor read will be
asynchronous with timeout set in milliseconds.

For example for "sensor1":
ASYNC_READ_TIMEOUT_sensor1="1000" // Timeout will be set to 1 sec

If the read times out, the sensor read will be skipped and the
sensor's functional property will be set to 'false'. Timed out futures
will be placed in a map to prevent their destructor from running and
blocking until the read completes (limitation of std::async).

Tested: This patch has been running downstream for over a year to
solve a slow I2C sensor reads causing IPMI slowdown.

Change-Id: I3d9ed4d5c9cc87d3196fc281451834f3001d0b48
Signed-off-by: Brandon Kim <brandonkim@google.com>

show more ...

Add sensor instance id command line argument.

Introduce `-i|--sensor-id` flag to explicitly set sensor
suffix for dbus name.

Sample usage:

phosphor-hwmon-readd -i test_sensor_id -o /apb/...

Wi

Add sensor instance id command line argument.

Introduce `-i|--sensor-id` flag to explicitly set sensor
suffix for dbus name.

Sample usage:

phosphor-hwmon-readd -i test_sensor_id -o /apb/...

Will register the service with the following busname:

xyz.openbmc_project.Hwmon-test_sensor_id.Hwmon1

This change required as a part of privilege separation work:
https://github.com/openbmc/openbmc/issues/3383

Signed-off-by: Anton D. Kachalov <gmouse@google.com>
Change-Id: I48ff9c3efe0edb84718ff8f695e7e932af5445de

show more ...

Install service unit files, busconfig and udev rules from the package.

This change required as a part of privilege separation work:
https://github.com/openbmc/openbmc/issues/3383

The dependant ch

Install service unit files, busconfig and udev rules from the package.

This change required as a part of privilege separation work:
https://github.com/openbmc/openbmc/issues/3383

The dependant change in openbmc repo:
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/40359

Signed-off-by: Anton D. Kachalov <gmouse@google.com>
Change-Id: I89aec71b446e0b7be40a10e1cd94ea16d891a277

show more ...

meson: Cleanup tests and make them execute again

The tests were previously building but not executing. Fix the build so
they execute and pass again.

Change-Id: I6e29eadd4f51cf47d05f7172f37c76688955

meson: Cleanup tests and make them execute again

The tests were previously building but not executing. Fix the build so
they execute and pass again.

Change-Id: I6e29eadd4f51cf47d05f7172f37c76688955ac61
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

meson: Explicitly check for CLI11 dependency

Change-Id: Ifaf6e5aba783285c16e8aae278e34dde6aa9d52c
Signed-off-by: William A. Kennington III <wak@google.com>

meson: Cleanup library linking

Change-Id: Ie1fa47ec3c6f2d2a88f8487f3a533c5ebd801612
Signed-off-by: William A. Kennington III <wak@google.com>

gitignore: Ignore all build directories

Change-Id: I09d9323467cb90431f6ef3974a080d31292432e9
Signed-off-by: William A. Kennington III <wak@google.com>

Remove autotools files

Now that meson is enabled in the bitbake build, remove support for
building with autotools.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I49d66ca766d7d3475f454

Remove autotools files

Now that meson is enabled in the bitbake build, remove support for
building with autotools.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I49d66ca766d7d3475f454675124b3008f70bde4f

show more ...

Change #ifdef to #if after move to meson

Unlike with autotools, meson options negative-errno-on-fail and
update-functional-on-fail are written to the generated config.h file
regardless of if they ar

Change #ifdef to #if after move to meson

Unlike with autotools, meson options negative-errno-on-fail and
update-functional-on-fail are written to the generated config.h file
regardless of if they are enabled are not, such as

#define NEGATIVE_ERRNO_ON_FAIL 1
and
#define NEGATIVE_ERRNO_ON_FAIL 0

That means the code that checks the values needs to be an #if and not an

The bitbake recipe has now switched over to building with meson, so
right now openbmc master may not be building with the correct options
depending on how these are set in the various bbappends.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I9db63c3b66c1e02175528b224cc9f0d997d31272

show more ...

MAINTAINERS: Handoff from Venture to Kim

Handoff maintainer from Patrick to Brandon.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I538992dbdcdba5c9b7caea9bbe3c06c6194c5d15

Send high/low alarm signal when sensor reading exceeds threshold

The change to the xyz.openbmc_project.Sensor.Threshold.Warning and
xyz.openbmc_project.Sensor.Threshold.Critical interface that add
t

Send high/low alarm signal when sensor reading exceeds threshold

The change to the xyz.openbmc_project.Sensor.Threshold.Warning and
xyz.openbmc_project.Sensor.Threshold.Critical interface that add
the new signals WarningHighAlarmAsserted, WarningHighAlarmDeasserted,
WarningLowAlarmAsserted, WarningLowAlarmDeasserted,
CriticalHighAlarmAsserted, CriticalHighAlarmDeasserted,
CriticalLowAlarmAsserted and CriticalLowAlarmDeasserted.

When sensor reading exceeds the threshold, hwmon would send the signal
with the sensor reading value at that time.

Tested:
Use dbus-monitor command to check the signal is captured, when hwmon
send signals.

Signed-off-by: Duke Du <Duke.Du@quantatw.com>
Change-Id: Ibf050b8bcff128cf77fd103c6d2bd1f30700b27b

show more ...

enable shellcheck

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I16d09efd983f2379e2340fac08bc0ccba495fb81

bootstrap: fix shellcheck warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86ef079c9632e5563a1a56d6a2e23aad59ecbc57